-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2019-03-14, Version 11.12.0 (Current) #26644
Commits on Mar 12, 2019
-
tools: update ESLint to 5.15.0
Update ESLint to 5.15.0 PR-URL: #26391 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 5bdf71c - Browse repository at this point
Copy the full SHA 5bdf71cView commit details -
tools: update node-lint-md-cli-rollup lockfile
This includes an update for chownr from 1.0.1 to 1.1.1, which means a fix for the issue described in isaacs/chownr#14. While not a user-facing issue, it seems like a good idea to patch promptly anyway. PR-URL: #26393 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c2d1251 - Browse repository at this point
Copy the full SHA c2d1251View commit details -
Update lint-md.js from updated rollup modules. PR-URL: #26393 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c57510e - Browse repository at this point
Copy the full SHA c57510eView commit details -
win,build: add arbitrary and binlog options
This change adds a 'msbuild_arg' option to vcbuild.bat that can be used to pass arbitrary flags to MSBuild. It also adds a 'binlog' flag as a shortcut 'msbuild_arg' option to enable binary logging to `%config%\node.binlog`. This is especially convenient when debugging changes to the build system. In the process of developing this change, the idea of adding 'setlocal' to the beginning of the script was rejected since other scripts in this repo rely on the exported environment variables. This change adds a note describing this. PR-URL: #25994 Reviewed-By: João Reis <reis@janeasystems.com>
Configuration menu - View commit details
-
Copy full SHA for d75cb91 - Browse repository at this point
Copy the full SHA d75cb91View commit details -
win,build: add ARM64 support to vcbuild.bat
PR-URL: #25995 Reviewed-By: João Reis <reis@janeasystems.com>
Configuration menu - View commit details
-
Copy full SHA for 8e60193 - Browse repository at this point
Copy the full SHA 8e60193View commit details -
win,build: add ARM64 sections to common.gypi
PR-URL: #25995 Reviewed-By: João Reis <reis@janeasystems.com>
Configuration menu - View commit details
-
Copy full SHA for 7e4592e - Browse repository at this point
Copy the full SHA 7e4592eView commit details -
win,build: scope NASM warning to only x64 and x86
PR-URL: #25995 Reviewed-By: João Reis <reis@janeasystems.com>
Configuration menu - View commit details
-
Copy full SHA for e8f4096 - Browse repository at this point
Copy the full SHA e8f4096View commit details -
win,build: update Windows build documentation
PR-URL: #25995 Reviewed-By: João Reis <reis@janeasystems.com>
Configuration menu - View commit details
-
Copy full SHA for 3ad58f3 - Browse repository at this point
Copy the full SHA 3ad58f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d841a89 - Browse repository at this point
Copy the full SHA d841a89View commit details -
src: document DoWrite() usage expectations
Clarify how it must behave for both synchronous and asynchronous completion. PR-URL: #26339 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 61baa45 - Browse repository at this point
Copy the full SHA 61baa45View commit details -
* standardize on arrow functions for callbacks * standaradize on trailing commas for multiline arrays PR-URL: #26394 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 580ae56 - Browse repository at this point
Copy the full SHA 580ae56View commit details -
tools: apply stricter linting to tools directory
Enable ESLint rules for trailing commas and arrow callbacks in tools directory. These rules are also in place in the benchmark directory. PR-URL: #26394 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for dc4258a - Browse repository at this point
Copy the full SHA dc4258aView commit details -
test: remove flaky designation for test_threadsafe_function
The test_threadsafe_function doesn't seem to be flaky anymore on Windows. Optimistically removing the flaky designation in the relevant status file. Refs: #23621 (comment) PR-URL: #26403 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for e1aa510 - Browse repository at this point
Copy the full SHA e1aa510View commit details -
Configuration menu - View commit details
-
Copy full SHA for e79f0c2 - Browse repository at this point
Copy the full SHA e79f0c2View commit details -
src: use object to pass
Environment
to functionsUse a `v8::Object` with an internal field, rather than a `v8::External`. On a `GetReturnValue().Set(Environment::GetCurrent(args) == nullptr)` noop function, this benchmarks as a ~60 % speedup, as calls to `obj->GetAlignedPointerFromInternalField()` can be inlined and the field is stored with one level of indirection less. This also makes breaking up some pieces of the `Environment` class into per-native-binding data easier, if we want to pursue that path in the future. PR-URL: #26382 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for b45c22b - Browse repository at this point
Copy the full SHA b45c22bView commit details -
benchmark: refactor path benchmarks
So far the benchmarks created a highly specialized function which would inline exactly to the input. This changes it to provide a more realistic view to actual input by changing the input on each iteration. That prevents the function to be to specific. It also reduces the number of iterations the benchmarks are run to reduce the overall runtime. A microbenchmark should already show a significant difference with lower iterations, otherwise the significance for real world applications is only limited. PR-URL: #26359 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 142a92f - Browse repository at this point
Copy the full SHA 142a92fView commit details -
PR-URL: #26318 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for da457a5 - Browse repository at this point
Copy the full SHA da457a5View commit details -
test: improve code coverage in timers
PR-URL: #26310 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for dbb7a02 - Browse repository at this point
Copy the full SHA dbb7a02View commit details -
src: remove unused struct in test_inspector_socket.cc
PR-URL: #26284 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for b8abb81 - Browse repository at this point
Copy the full SHA b8abb81View commit details -
http2: refactor deprecated method in core.js
PR-URL: #26275 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 529b0c0 - Browse repository at this point
Copy the full SHA 529b0c0View commit details -
events: onceWrapper returns target value
PR-URL: #25818 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 83fba1e - Browse repository at this point
Copy the full SHA 83fba1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b6c653 - Browse repository at this point
Copy the full SHA 4b6c653View commit details -
src: fix if indent in node_http2.cc
PR-URL: #26396 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for f99349d - Browse repository at this point
Copy the full SHA f99349dView commit details -
crypto: don't call SSL_CTX_set_ciphersuites on boringssl
PR-URL: #26365 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 7155aaf - Browse repository at this point
Copy the full SHA 7155aafView commit details -
PR-URL: #26354 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 8b0164a - Browse repository at this point
Copy the full SHA 8b0164aView commit details -
PR-URL: #26336 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2a3cca7 - Browse repository at this point
Copy the full SHA 2a3cca7View commit details -
report: support RUSAGE_SELF stats on Windows
This commit adds support for the resourceUsage report section on Windows by using uv_getrusage() instead of getrusage(). PR-URL: #26406 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 0abb724 - Browse repository at this point
Copy the full SHA 0abb724View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd95d07 - Browse repository at this point
Copy the full SHA dd95d07View commit details -
deps: upgrade openssl sources to 1.1.1b
This updates all sources in deps/openssl/openssl with openssl-1.1.1b. PR-URL: #26327 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 71c4d75 - Browse repository at this point
Copy the full SHA 71c4d75View commit details -
deps: update archs files for OpenSSL-1.1.1b
`cd deps/openssl/config; make` updates all archs dependant files. PR-URL: #26327 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 88079ca - Browse repository at this point
Copy the full SHA 88079caView commit details -
deps: openssl-1.1.1b no longer packages .gitignore
Since its not packaged, we don't have to delete it, and the Makefile and update can become a (tiny) bit simpler. PR-URL: #26327 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 5895726 - Browse repository at this point
Copy the full SHA 5895726View commit details -
deps: update OpenSSL upgrade process
Particularly, ensure that the commit messages are self-explanatory so that reviewers can understand that the large commits are the result of a simple repeatable process. This should make them easier to review. See: #26327 (comment) PR-URL: #26378 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 28dc54b - Browse repository at this point
Copy the full SHA 28dc54bView commit details -
Original commit message: [coverage] Extend SourceRangeAstVisitor for throw statements The SourceRangeAstVisitor has custom logic for blocks ending with a statement that has a continuation range. In these cases, the trailing continuation is removed which makes the reported coverage ranges a bit nicer. throw Error('foo') consists of an ExpressionStatement, with a Throw expression stored within the statement. The source range itself is stored with the Throw, not the statement. We now properly extract the correct AST node for trailing throw statements. R=jgruber@chromium.org, neis@chromium.org, yangguo@chromium.org Bug: v8:8691 Change-Id: Ibcbab79fbe54719a8993045040349c863b139011 Reviewed-on: https://chromium-review.googlesource.com/c/1480632 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#59936} Refs: v8/v8@2d08967 PR-URL: #26413 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 01e69f9 - Browse repository at this point
Copy the full SHA 01e69f9View commit details -
report: refactor configuration management
This commit removes process.report.setOptions(). Instead of using complex configuration synchronization between C++ and JS, this commit introduces individual getters and setters. PR-URL: #26414 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9f446a1 - Browse repository at this point
Copy the full SHA 9f446a1View commit details -
report: warn on process.report object access
Reduce the number of emitExperimentalWarning() call sites by making process.report emit a warning on access instead of each individual report function. PR-URL: #26414 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2be9e80 - Browse repository at this point
Copy the full SHA 2be9e80View commit details -
src: refactor
Environment::GetCurrent(isolate)
usageDo not require an explicit `HandleScope`, or the ability to create one, when using `Environment::GetCurrent()`. `isolate->InContext()` is used as an indicator that it is probably okay to create a `HandleScope`, see also the short discussion in #25775 (review). PR-URL: #26376 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 716ec00 - Browse repository at this point
Copy the full SHA 716ec00View commit details -
src: prefer to get
Environment
fromContext
We explicitly store the context anyway, and can skip the extra steps introduced in `Environment::GetCurrent()`. PR-URL: #26376 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 622048d - Browse repository at this point
Copy the full SHA 622048dView commit details -
src: allow running tasks without
Environment
There is no real reason to assume that V8 tasks would have to run in a Node.js `Context`. PR-URL: #26376 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9c277c0 - Browse repository at this point
Copy the full SHA 9c277c0View commit details -
src: forbid handle allocations from Platform tasks
Platform tasks should have their own handle scopes, rather than leak into outer ones. PR-URL: #26376 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 170e196 - Browse repository at this point
Copy the full SHA 170e196View commit details -
benchmark,lib: add process.hrtime.bigint benchmark
Add a benchmark, and amend the relevant source code comment to state that currently, switching to directly returning a BigInt is not stopped by technical obstacles but rather the fact that using a typed array is actually a bit faster (about 2.5 %, measured locally). PR-URL: #26381 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for f79cf70 - Browse repository at this point
Copy the full SHA f79cf70View commit details -
* Fix heading levels. * Fix section sorting. * Add quotes around string values. * Remove quotes around property names. PR-URL: #26461 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7e40ce1 - Browse repository at this point
Copy the full SHA 7e40ce1View commit details -
stream: ensure writable.destroy() emits error once
Prevent the `'error'` event from being emitted multiple times if `writable.destroy()` is called with an error before the `_destroy()` callback is called. Emit the first error, discard all others. PR-URL: #26057 Fixes: #26015 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 82a68ce - Browse repository at this point
Copy the full SHA 82a68ceView commit details -
doc: hello addon example should return "world"
The N-API version of the hello example, returned "hello" instead of "world". PR-URL: #26328 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for d2e9e52 - Browse repository at this point
Copy the full SHA d2e9e52View commit details -
src: fix more extra-semi warnings
PR-URL: #26340 Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for dc2119a - Browse repository at this point
Copy the full SHA dc2119aView commit details -
tools: add mailmap support for Co-authored-by tags
Support `.mailmap` for manually added `Author:` and `Co-authored-by:` tags. PR-URL: #26383 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 55b8304 - Browse repository at this point
Copy the full SHA 55b8304View commit details -
PR-URL: #26383 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9299fb8 - Browse repository at this point
Copy the full SHA 9299fb8View commit details -
src: remove unused variable in node_native_module.cc
PR-URL: #26411 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 1d279ac - Browse repository at this point
Copy the full SHA 1d279acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b8297d - Browse repository at this point
Copy the full SHA 8b8297dView commit details -
build,deps: less warnings from V8
PR-URL: #26405 Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 02faa1a - Browse repository at this point
Copy the full SHA 02faa1aView commit details
Commits on Mar 14, 2019
-
src: remove unused variable in node_http2.cc
PR-URL: #26395 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 654f4d4 - Browse repository at this point
Copy the full SHA 654f4d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4886fbf - Browse repository at this point
Copy the full SHA 4886fbfView commit details -
src: fix build when NODE_USE_V8_PLATFORM is not defined
PR-URL: #26380 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 88fb771 - Browse repository at this point
Copy the full SHA 88fb771View commit details -
doc: fix the example implementation of MemoryRetainer
We need to be careful not to include the size of non-pointer fields in the parent's self size if we want to track them separately as a different node. Refs: https://github.com/nodejs/node/pull/26161/files#r259170771 PR-URL: #26262 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 05b92c9 - Browse repository at this point
Copy the full SHA 05b92c9View commit details -
doc: edit deprecation section of Collaborator Guide
Edit the last few paragraphs of the Collaborator Guide section on deprecations. PR-URL: #26419 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ca2328d - Browse repository at this point
Copy the full SHA ca2328dView commit details -
test: relax timer check in test-report-uv-handles.js
The underlying JavaScript runtime may schedule tasks at its discretion so there may be more timer handles than the one created by the test. PR-URL: #26434 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for a67fea5 - Browse repository at this point
Copy the full SHA a67fea5View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe6c419 - Browse repository at this point
Copy the full SHA fe6c419View commit details -
src: use the config binding to carry --no-browser-globals
Instead of setting it in the process object, since this is a configure-time option. Also added a shim that can be deprecated and removed some time later. PR-URL: #26228 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 0d810b7 - Browse repository at this point
Copy the full SHA 0d810b7View commit details -
src: fix wrong enum reference in node.cc
PR-URL: #26430 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for e21fa83 - Browse repository at this point
Copy the full SHA e21fa83View commit details -
src: remove unused function in cares_wrap.cc
PR-URL: #26429 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2a2a4e6 - Browse repository at this point
Copy the full SHA 2a2a4e6View commit details -
src: remove redundant cast in string_search.h
PR-URL: #26426 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 81c5382 - Browse repository at this point
Copy the full SHA 81c5382View commit details -
tools: replace var to let/const
PR-URL: #26398 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 57198f2 - Browse repository at this point
Copy the full SHA 57198f2View commit details -
tools: add no-var lint rule for tools directory
PR-URL: #26398 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 0a1537e - Browse repository at this point
Copy the full SHA 0a1537eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c247153 - Browse repository at this point
Copy the full SHA c247153View commit details -
build: indicate that configure has done something
If run without `--verbose` configure exits silently with no indication that it has done anything. Print a message on completion to indicate that the script has worked. Refs: #23111 PR-URL: #26436 Refs: #23111 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 240de93 - Browse repository at this point
Copy the full SHA 240de93View commit details -
buffer: do not affect memory after target for utf16 write
Do not write one character too much before shifting the whole result to the left when using UTF16-LE, possibly overwriting already-used memory while doing so. Fixes: #26422 PR-URL: #26432 Fixes: #26422 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Configuration menu - View commit details
-
Copy full SHA for 68bb1e9 - Browse repository at this point
Copy the full SHA 68bb1e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cc559f - Browse repository at this point
Copy the full SHA 6cc559fView commit details -
doc: standardize on End-of-Life capitalization
Use "End-of-Life" everywhere and not "End-of-life" or "End-Of-Life". PR-URL: #26442 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9945c28 - Browse repository at this point
Copy the full SHA 9945c28View commit details -
tools: update remark-preset-lint-node to 1.5.0
This update includes an additional check for `End-of-life`. For consistency, we use `End-of-Life` everywhere. PR-URL: #26442 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3b19cbf - Browse repository at this point
Copy the full SHA 3b19cbfView commit details -
src: remove redundant call in inspector_io.cc
PR-URL: #26427 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for bb374d4 - Browse repository at this point
Copy the full SHA bb374d4View commit details -
src: make parameter name const reference in method TriggerNodeReport
PR-URL: #26397 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for c7bd21c - Browse repository at this point
Copy the full SHA c7bd21cView commit details -
http: remove unused variable in _http_server.js
PR-URL: #26407 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c661d8c - Browse repository at this point
Copy the full SHA c661d8cView commit details -
test: fix tests so they work in worker threads
Use the `cwd` option for child_process instead of `process.chdir()` to allow tests to work with worker threads. PR-URL: #26453 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 2b2471b - Browse repository at this point
Copy the full SHA 2b2471bView commit details -
child_process: fire close event from stdio
PR-URL: #22892 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 8c864de - Browse repository at this point
Copy the full SHA 8c864deView commit details -
test: remove usage of
process.binding()
Prefer `internalBinding` or other equivalents over `process.binding()` (except in tests checking `process.binding()` itself). PR-URL: #26304 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 71a4b24 - Browse repository at this point
Copy the full SHA 71a4b24View commit details -
crypto: simplify GetPublicOrPrivateKeyFromJs
PR-URL: #26454 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 991ea8a - Browse repository at this point
Copy the full SHA 991ea8aView commit details -
test: refactor test/report/test-report-signal.js
PR-URL: #26446 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 153a29c - Browse repository at this point
Copy the full SHA 153a29cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b2e27a0 - Browse repository at this point
Copy the full SHA b2e27a0View commit details -
This fixes the necessary plumbing to make the --shell argument have its intended effect. PR-URL: #26449 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b879c1e - Browse repository at this point
Copy the full SHA b879c1eView commit details -
src: remove redundant cast in util-inl.h
PR-URL: #26410 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 203fa63 - Browse repository at this point
Copy the full SHA 203fa63View commit details -
repl: add replDefaults to customize the writer
So far it was not possible to modify the inspection defaults used by the REPL from the running instance itself. This introduces a new property on `util.inspect` which is only used inside the REPL and which allows to modify the used inspection defaults at any point of time. PR-URL: #26375 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a0b1191 - Browse repository at this point
Copy the full SHA a0b1191View commit details -
tools: update dmn to 2.2.1 in update scripts
dmn 2.2.1 cleans more files than earlier versions. PR-URL: #26462 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Configuration menu - View commit details
-
Copy full SHA for 9f1cc73 - Browse repository at this point
Copy the full SHA 9f1cc73View commit details -
tools: use dmn@2.2.1 to remove unneeded files
PR-URL: #26462 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Configuration menu - View commit details
-
Copy full SHA for 972a0f9 - Browse repository at this point
Copy the full SHA 972a0f9View commit details -
src: remove templating from StreamBase
PR-URL: #25142 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d688b8a - Browse repository at this point
Copy the full SHA d688b8aView commit details -
src: cleanup in all return paths in node::Start
`node::Start` creates a number of artifacts in its scope which are cleaned up in the exit path, but there is at least one path where the cleanups are bypassed. Force all paths follow the exit sequence. Refs: #21283 PR-URL: #26471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 12fb739 - Browse repository at this point
Copy the full SHA 12fb739View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ee9a96 - Browse repository at this point
Copy the full SHA 2ee9a96View commit details -
doc: add guidance on console output in tests
PR-URL: #26456 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for e3d7955 - Browse repository at this point
Copy the full SHA e3d7955View commit details -
test: bump test-bootstrap-modules.js limit
PR-URL: #26520 Fixes: #26528 Refs: #25594 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 78c4dbd - Browse repository at this point
Copy the full SHA 78c4dbdView commit details -
Edit the "Involving the TSC" section of the Collaborator Guide to reduce passive voice, make things concise, etc. PR-URL: #26481 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5897bf4 - Browse repository at this point
Copy the full SHA 5897bf4View commit details -
http: improve for-loop readability in _http_outgoing.js
PR-URL: #26408 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bf7a52b - Browse repository at this point
Copy the full SHA bf7a52bView commit details -
n-api: improve performance creating strings
Improve performance creating strings using N-API by ensuring that the strings are not internalized. Added test cases for latin-1 and utf-16 strings. PR-URL: #26439 Fixes: #26437 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8e7204e - Browse repository at this point
Copy the full SHA 8e7204eView commit details -
src: merge debug-only
SealHandleScope
sInstead of repeating the same `#ifdef DEBUG` + `SealHandleScope` pattern over and over, create an utility that does this for us. PR-URL: #26459 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for edc4af0 - Browse repository at this point
Copy the full SHA edc4af0View commit details -
src: delete unused variable in env.h
PR-URL: #26451 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for a11cf30 - Browse repository at this point
Copy the full SHA a11cf30View commit details -
src: delete unused method SetTemplateMethodNoSideEffect
PR-URL: #26451 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for efadb10 - Browse repository at this point
Copy the full SHA efadb10View commit details -
src: delete unused method SetTemplateMethod
PR-URL: #26451 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 989fcef - Browse repository at this point
Copy the full SHA 989fcefView commit details -
tools: update
node-lint-md-cli-rollup
version 2PR-URL: #26441 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4835504 - Browse repository at this point
Copy the full SHA 4835504View commit details -
tools: update generated lint-md.js
PR-URL: #26441 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dcfdef5 - Browse repository at this point
Copy the full SHA dcfdef5View commit details -
src: guard against calling
Init()
multiple timesThis function should only be called once. Calling it multiple times would currently break Node.js (e.g. re-registering builtin modules would break the linked list for them). PR-URL: #26458 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1d4fd21 - Browse repository at this point
Copy the full SHA 1d4fd21View commit details -
doc: fix nits in writing-tests.md
* Correct a typo. * Normalize spaces. * Split a paragraph with different topics. PR-URL: #26543 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 693505b - Browse repository at this point
Copy the full SHA 693505bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 476dc7e - Browse repository at this point
Copy the full SHA 476dc7eView commit details -
doc: update partner communities link in releases.md
PR-URL: #26475 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1242037 - Browse repository at this point
Copy the full SHA 1242037View commit details -
benchmark,doc,lib,test: capitalize comments
PR-URL: #26483 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 52a0d76 - Browse repository at this point
Copy the full SHA 52a0d76View commit details -
tools: update capitalized-comments rule
This strictens to rule to validate comments from 30 characters on. PR-URL: #26483 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3e2e779 - Browse repository at this point
Copy the full SHA 3e2e779View commit details -
test: rewrite ocsp test to run in parallel
Run tests in parallel and use common.mustCall() and mustNotCall() instead of process.exit() to ensure test assertions are run. PR-URL: #26460 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d590a45 - Browse repository at this point
Copy the full SHA d590a45View commit details -
src: apply clang-tidy various improvement
* rewrite to default label in method ConvertUVErrorCode * improve if condition in method PeekWritable * remove redundant cast in node_file.cc PR-URL: #26470 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a99fb54 - Browse repository at this point
Copy the full SHA a99fb54View commit details -
The tsc-review label is ineffective. It almost always gets ignored. Remove it. When requiring TSC attention, people should @-mention the TSC GitHub team. PR-URL: #26506 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 931174f - Browse repository at this point
Copy the full SHA 931174fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf78365 - Browse repository at this point
Copy the full SHA bf78365View commit details -
tools: update to mdast-util-to-hast v3.0.2
See syntax-tree/mdast-util-to-hast#21 Note: I updated all of the tools/doc dependencies, not just this one, and removed the previous workaround that was in place until this change landed. PR-URL: #22140 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 9d92887 - Browse repository at this point
Copy the full SHA 9d92887View commit details -
doc: add decode() & encode() methods into querystring.md
PR-URL: #23889 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 7323ffb - Browse repository at this point
Copy the full SHA 7323ffbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 414ad11 - Browse repository at this point
Copy the full SHA 414ad11View commit details -
report: fix stdout/stderr output formatting
This commit prevents the report and "report complete" message from being printed on the same line. PR-URL: #26522 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ac81fd2 - Browse repository at this point
Copy the full SHA ac81fd2View commit details -
test: cover stdout/stderr usage in triggerReport()
This commit adds coverage for the cases where process.report.filename is 'stdout' or 'stderr'. PR-URL: #26522 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5a0ed0b - Browse repository at this point
Copy the full SHA 5a0ed0bView commit details -
test: cover triggerReport() failure case
PR-URL: #26524 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0f8d8d6 - Browse repository at this point
Copy the full SHA 0f8d8d6View commit details -
report: rename triggerReport() to writeReport()
writeReport() is more descriptive of what the function does. PR-URL: #26527 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 74ab1aa - Browse repository at this point
Copy the full SHA 74ab1aaView commit details -
tools: update ESLint to 5.15.1
Update ESLint to 5.15.1 PR-URL: #26447 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for a32c749 - Browse repository at this point
Copy the full SHA a32c749View commit details -
doc: edit Landing Pull Requests
Edit the Landing Pull Requests section of the Collaborators Guide for brevity and clarity. PR-URL: #26536 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 76c22f8 - Browse repository at this point
Copy the full SHA 76c22f8View commit details -
doc: add inspector API example for heapdump
PR-URL: #26498 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5ad9929 - Browse repository at this point
Copy the full SHA 5ad9929View commit details -
lib,src: remove usage of _externalStream
Since 4697e1b, it is no longer necessary to use `v8::External`s to pass `StreamBase` instances to native functions. PR-URL: #26510 Refs: #25142 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9398d84 - Browse repository at this point
Copy the full SHA 9398d84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73370b4 - Browse repository at this point
Copy the full SHA 73370b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdad4d2 - Browse repository at this point
Copy the full SHA fdad4d2View commit details -
process: add --pending-deprecation to
process.binding()
Print a deprecation warning for `process.binding()` when using `--pending-deprecation`. PR-URL: #26500 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ceebbfb - Browse repository at this point
Copy the full SHA ceebbfbView commit details -
doc: add version for http.createServer() options addition
8.12 Changelog https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V8.md#8.12.0 Specifically [01dc646] - http: add options to http.createServer() #15752 PR-URL: #25001 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 667a402 - Browse repository at this point
Copy the full SHA 667a402View commit details -
crypto: check for invalid chacha20-poly1305 IVs
IV lengths of 13, 14, 15, and 16 are invalid, but are not checked by OpenSSL. IV lengths of 17 or greater are also invalid, but they were already checked by OpenSSL. See: - openssl/openssl@f426625b6a - https://www.openssl.org/news/secadv/20190306.txt PR-URL: #26537 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for b9787fd - Browse repository at this point
Copy the full SHA b9787fdView commit details -
doc: edit "Using git-node" section of Guide
Edit the "Using git-node" section of the Collaborator Guide. Make sentences concise and clear, reduce use of passive voice, etc. PR-URL: #26580 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for e2aaee0 - Browse repository at this point
Copy the full SHA e2aaee0View commit details -
src: rename Init and Start overloads to something more distinctive
In addition, move the `--help` and `--v8-help` processing out of `StartNodeWithLoopAndArgs()` and process them earlier - right after `InitializeNodeWithArgs()`, similar to how they are handled in the legacy `Init()`. PR-URL: #26499 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8822df8 - Browse repository at this point
Copy the full SHA 8822df8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c55282 - Browse repository at this point
Copy the full SHA 2c55282View commit details -
build: enable v8's siphash for hash seed creation
Triggers the V8_USE_SIPHASH to switch from the internal custom V8 hash seed generation function to an implementation of SipHash. Final step needed to clear up HashWick. PR-URL: #26367 Refs: #23259 Refs: https://darksi.de/12.hashwick-v8-vulnerability/ Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9b1cb9d - Browse repository at this point
Copy the full SHA 9b1cb9dView commit details -
deps,tools: include SipHash in LICENSE
PR-URL: #26367 Refs: #23259 Refs: https://darksi.de/12.hashwick-v8-vulnerability/ Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0fc975d - Browse repository at this point
Copy the full SHA 0fc975dView commit details -
test: fix compiler warning in test_string.c
Currently, the following compiler warnings is generated: ../test_string.c:235:50: warning: incompatible pointer types passing 'char [1]' to parameter of type 'const char16_t *' (aka 'const unsigned short *') [-Wincompatible-pointer-types] NAPI_CALL(env, napi_create_string_utf16(env, "", ((size_t)INT_MAX) + 1, &output)); ^~ ../../common.h:50:23: note: expanded from macro 'NAPI_CALL' NAPI_CALL_BASE(env, the_call, NULL) ^~~~~~~~ ../../common.h:42:10: note: expanded from macro 'NAPI_CALL_BASE' if ((the_call) != napi_ok) { \ ^~~~~~~~ /node/src/js_native_api.h:80:66: note: passing argument to parameter 'str' here const char16_t* str, ^ 1 warning generated. This commit adds a cast to silence this warning. PR-URL: #26539 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cccd3a3 - Browse repository at this point
Copy the full SHA cccd3a3View commit details -
These were causing compilation warnings. PR-URL: #26590 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9768ec4 - Browse repository at this point
Copy the full SHA 9768ec4View commit details -
worker: release native Worker object earlier
Destroy the `Worker` class earlier, because we don’t need access to it once the thread has stopped and all resources have been cleaned up. PR-URL: #26542 Fixes: #26535 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 62801b9 - Browse repository at this point
Copy the full SHA 62801b9View commit details -
url: require encodeStr from internal/querystring
PR-URL: #26538 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1de9e13 - Browse repository at this point
Copy the full SHA 1de9e13View commit details -
lib: import TextEncoder and TextDecoder from
internal/encoding
Configuration menu - View commit details
-
Copy full SHA for f128008 - Browse repository at this point
Copy the full SHA f128008View commit details -
test: fix syntax error in test-dns-idna2008.js when failing
Fixes a bug I introduced in 9613221 PR-URL: #26570 Refs: #25870 Refs: #26473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for e1a55e7 - Browse repository at this point
Copy the full SHA e1a55e7View commit details -
process: make Symbol.toStringTag writable
The ecosystem broke by making it non-writable, so this is a good intermediate fix. PR-URL: #26488 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 275a8f9 - Browse repository at this point
Copy the full SHA 275a8f9View commit details -
http2:
Http2ServerResponse.end()
should always return selfPR-URL: #24346 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6adcc6f - Browse repository at this point
Copy the full SHA 6adcc6fView commit details -
test: fix test by removing node-inspect/lib/_inspect
If this file is loaded with Node.js build without ssl, it will load 'node-inspect/lib/internal/inspect_client' as well. Due to that two deprecation warnings will be emitted instead of one and the test fails. It should be safe to just test all other cases and to ignore this specific file. PR-URL: #26619 Fixes: #26480 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for adfbfc9 - Browse repository at this point
Copy the full SHA adfbfc9View commit details -
http: send connection: close when closing conn
HTTP/1.1 mandates connections which do not support keep-alive and close the connection send the connection: close header, see https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.10 This page also provides more information: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Connection I understand that HTTP/1.1 defaults to keep-alive - and that the Connection: close header is required when closing a connection. This adds the Connection: close header in the 400 responses sent on client errors. PR-URL: #26467 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 16d9089 - Browse repository at this point
Copy the full SHA 16d9089View commit details -
PR-URL: #26306 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 5cbd112 - Browse repository at this point
Copy the full SHA 5cbd112View commit details -
tools: fix cpplint.py header rules
THIS COMMIT SHOULD GO WITH THE NEXT. IT WILL FIND NEW LINT. PR-URL: #26306 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 1c8076e - Browse repository at this point
Copy the full SHA 1c8076eView commit details -
bootstrap: experimental --frozen-intrinsics flag
PR-URL: #25685 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 3e54f90 - Browse repository at this point
Copy the full SHA 3e54f90View commit details -
net: use kHandle symbol for accessing native handle
Use a common `kHandle` for all `StreamBase`-based streams. PR-URL: #26491 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for c14aa07 - Browse repository at this point
Copy the full SHA c14aa07View commit details -
sendTrilers => sendTrailers. PR-URL: #26616 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6f68570 - Browse repository at this point
Copy the full SHA 6f68570View commit details -
domain: set
.domain
non-enumerable on resourcesIn particular, this comes into play in the node repl, which apparently enables domains by default. Whenever any Promise gets inspected, a `.domain` property is displayed, which is *very confusing*, especially since it has some kind of WeakReference attached to it, which is not yet a language feature. This change will prevent it from showing up in casual inspection, but will leave it available for use. PR-URL: #26210 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 56adebf - Browse repository at this point
Copy the full SHA 56adebfView commit details -
test: use semicolon for clarity
PR-URL: #26566 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 13253a3 - Browse repository at this point
Copy the full SHA 13253a3View commit details -
test: fix test case in test-http2-respond-file-304.js
PR-URL: #26565 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 9e82ee9 - Browse repository at this point
Copy the full SHA 9e82ee9View commit details -
cluster: refactor empty for in round_robin_handle.js
PR-URL: #26560 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cba23ed - Browse repository at this point
Copy the full SHA cba23edView commit details -
src: fix SplitString to ignore white spaces
PR-URL: #26545 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe>
Configuration menu - View commit details
-
Copy full SHA for bc09d2f - Browse repository at this point
Copy the full SHA bc09d2fView commit details -
timers: remove dead code and simplify args check
The `setUnrefTimeout` function is never called with more arguments than two. So quite some code was dead and never used. This removes that code and simplifies the args check not to coerce objects to booleans. PR-URL: #26555 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 143dbb3 - Browse repository at this point
Copy the full SHA 143dbb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9cfaa3 - Browse repository at this point
Copy the full SHA b9cfaa3View commit details -
lib: refactor deprecated function in readline.js
PR-URL: #26494 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6b004e0 - Browse repository at this point
Copy the full SHA 6b004e0View commit details -
PR-URL: #26496 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 2101371 - Browse repository at this point
Copy the full SHA 2101371View commit details -
repl: simplify regex expression
PR-URL: #26496 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 788c57b - Browse repository at this point
Copy the full SHA 788c57bView commit details -
repl: eliminate var in function _memory
PR-URL: #26496 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 1a0004d - Browse repository at this point
Copy the full SHA 1a0004dView commit details -
lib,test: improve faulty assert usage detection
This improves our custom eslint rules to detect assertions to detect assertions with only a single argument and fixes false negatives in case unary expressions are used. Some rules were extended to also lint our docs and tools and the lib rule was simplified to prohibit most assertion calls. PR-URL: #26569 Refs: #26565 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 1fa5004 - Browse repository at this point
Copy the full SHA 1fa5004View commit details
Commits on Mar 15, 2019
-
2019-03-15, Version 11.12.0 (Current)
Notable Changes * bootstrap: * Add experimental `--frozen-intrinsics` flag (Guy Bedford) #25685 * build: * Enable v8's siphash for hash seed creation (Rod Vagg) #26367 * deps: * Upgrade openssl to 1.1.1b (Sam Roberts) #26327 * process: * Make `process[Symbol.toStringTag]` writable again (Ruben Bridgewater) #26488 * repl: * Add `util.inspect.replDefaults` to customize the writer (Ruben Bridgewater) #26375 * report: * Rename `triggerReport()` to `writeReport()` (Colin Ihrig) #26527
Configuration menu - View commit details
-
Copy full SHA for a4ff9df - Browse repository at this point
Copy the full SHA a4ff9dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 51d874c - Browse repository at this point
Copy the full SHA 51d874cView commit details