Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues #20099: Add Korean language support to OpenMetadata UI #20104

Open
wants to merge 217 commits into
base: main
Choose a base branch
from

Conversation

dasomel
Copy link

@dasomel dasomel commented Mar 6, 2025

Describe your changes:

Fixes #20099

I worked on adding Korean language support to the OpenMetadata UI by creating a ko-kr.json file and modifying i18nextUtil.ts. This change will improve accessibility for Korean-speaking users and potentially increase adoption within the Korean tech community.

Changes made:

  • Created ko-kr.json file in openmetadata-ui/src/locale directory
  • Translated all UI elements, messages, and documentation to Korean
  • Modified i18nextUtil.ts to include Korean language option
  • Tested the Korean language interface to ensure proper functionality and linguistic accuracy

Type of change:

  • New feature

Checklist:

  • I have read the [CONTRIBUTING](https://docs.open-metadata.org/developers/contribute) document.
  • My PR title is Issues #20099: Add Korean language support to OpenMetadata UI
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

New feature

  • The issue properly describes why the new feature is needed, what's the goal, and how we are building it. Any discussion or decision-making process is reflected in the issue.
  • I have updated the documentation.
  • I have added tests around the new logic.

github-actions bot and others added 30 commits December 10, 2024 09:56
* Revert "feat: persona based customisation for glossary and glossary term pages (open-metadata#18454)"

This reverts commit 6fa76ec.

* Revert "chore(ui): move persona as top level settings (open-metadata#18171)"

This reverts commit 737c076.

* fix tests

* fix playwright
* Fix ES Tag Index failing

* add tags loading test

---------

Co-authored-by: karanh37 <karanh37@gmail.com>
(cherry picked from commit 08cdc69)
* MINOR - Add APIs to Ref Map

* MINOR - Add APIs to Ref Map

* MINOR - Add APIs to Ref Map

* format
…ndling (open-metadata#19062)

* fix: Resolve NullPointerException in MS Teams DQ template handling

* fix: Update DQ template logic to handle test case changes and results

Details:
Ensures a general template is created for any changes in the test case.
Generates a DQ template when the test case result is updated.

* refactor: Make testCaseResult as constant named TEST_CASE_RESULT
…n-metadata#19004)

* fix: Filter activity feed events for test cases and suites.

* minor fix around the button label after save task tab

---------

Co-authored-by: Ashish Gupta <ashish@getcollate.io>
* Fix Login Configuration Issue

* Fix Tests

(cherry picked from commit 4b9948d)
…a#18987)

* supported editUser permission in user tab for team page

* remove edit all permission check in teams add/remove user api

* added playwright test for the editUser permission

* Added playwright test for data consumer user and remove no used field from the advance api call

---------

Co-authored-by: sonikashah <sonikashah94@gmail.com>
Co-authored-by: sonika-shah <58761340+sonika-shah@users.noreply.github.com>
(cherry picked from commit 9e6078f)
…nel (open-metadata#19132)

* fix the spacing around the input in custom properties right panel

* remove unwanted css

(cherry picked from commit a0c33cc)
open-metadata#19110)

* feat: highlight search term

* refactor: use stringToHTML instead of parse

* test: highlightSearchText method

* fix: test for schema table

* fix: mock implemetation of stringToHTML

* test: highlightSearchText function with null or falsy parameters

(cherry picked from commit 31b1132)
)

* fix(ui): sync search value with url and state value

* fix flaky for user spec

(cherry picked from commit 4d30c83)
…8968)

* fix(ui): expand invalid state upon glossary term add
invalid expand state for glossary term update

* fix tests

* update glossary store upon changes in tree

* fix tests

(cherry picked from commit 254fce4)
* fix lineage flaky tests

* fix glossary flakiness

(cherry picked from commit 9a76b07)
* Add algorithm option in authentication

* ENtity Repository code remove

* Keep Default Value

* Fix Test

---------

Co-authored-by: Siddhant <86899184+Siddhanttimeline@users.noreply.github.com>
(cherry picked from commit 50ae01e)
* fix tag page flaky playwright failures

* removed commented code

(cherry picked from commit ceeba2a)
karanh37 and others added 17 commits January 29, 2025 18:10
* fix: wrong attribute name in SampleConfig model

* fix: test attribute

* fix: failing tests

* fix: trino filter error + adjust test to take into account null value

* fix: mssql and azuresql tablesample on views

(cherry picked from commit ef131d7)
@dasomel dasomel requested review from akash-jain-10, harshach, tutte and a team as code owners March 6, 2025 06:21
@dasomel dasomel changed the title Issues 20099 Issues 20099: Add support for another language: Korean Mar 6, 2025
@dasomel dasomel changed the title Issues 20099: Add support for another language: Korean Issues #20099: Add Korean language support to OpenMetadata UI Mar 6, 2025
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Korean Language Support to OpenMetadata UI