Pull v5.11.0 #1
Merged
Pull v5.11.0 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(node:16148) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. allocUnsafe should be fine because in both cases, the buffer is immediately filled and thrown out.
…3935) * Implemented fixer for member-ordering and added corresponding tests. * Improved node boundary calculation so trivia remains attached to the correct nodes. * minor comment fixes.
….Number.parseInt() (#3901)
* add fileNameCasing rule * use camel case name for tslintCli * refactor casing check into helper function * use stylized name for casing in failure message
…dev" option set (#3875)
…3979) * feature - no-implicit-dependencies - add whitelist (#3839) This allows you to specify a whitelist of modules that will not be part of package.json such as project-relative aliases * feature - no-implicit-dependencies - add whitelist (#3839) Use Set for whitelist package name comparison instead of Array.
* Prepare release 5.11.0 * Fix changelog
* codeExample support init implementation * dedent/markdown errors need revisting * updates to new code example scheme as per ajafff * reverts prettier style updates in curly * curly docs he -> they * ICodeExample config type any -> string * Code example blocks now color-coded according to pass/fail (grn/red) * added code-examples to no-sparse-arrays, no-unnecessary-callback-wrapper and object-literal-sort-keys * Update noUnnecessaryCallbackWrapperRule.ts Accidentally committed formatting that VSCode did, has nothing to do with the commit * added code-examples to only-arrow-functions, prefer-template and typedef * more examples fixed vscode's formatting * updates to buildDocs * Improve code-example descriptions * gemfile.lock??; removes unnecessary html/scss * removes site dist * moving code examples to dedicated dir to avoid bloat in rule files * removing _site dir * move codeExamples into new directory * changed year in code-examples copyrights * Merge branch 'master' into docs/code-examples The GitHub GUI is a bit confusing * wrong import
Sometimes you may want to run linting but ignore any warnings produced, such as in a CI environment where you only want lint failures to fail the build (many runners will check both the exit code and STDERR to see if the program has passed). This mimics the `quiet` flag available in ESLint, which hides errors from output when passed.
* Add new tests to workflows * Add RC instead of 3.0
Don't flag unmatched ${ in a regular string
Also flag the entire expression, not just the opening brace
This lets users enforce only backtick "`" strings for everywhere that it's permissible. This also simplifies some logic in the preferred quote determination, combining some disparate logic into the nice self-packaged functions. > See #539 > The corresponding option in eslint is called "backtick": http://eslint.org/docs/rules/quotes > See https://ponyfoo.com/articles/template-literals-strictly-better-strings
* Changed npm run to yarn in docs * Added ignore line for intellij specific settings * Added prettier * Added prettier config file * Added tslint-config-prettier * Added pre-commit hook prettier * Added prettier ignore file * Changed tab width for package.json, to see the changes better * Pinned exact version in package.json * Merged yarn.lock * Changed printWidth to 100
I created some basic issue templates. We may want to change them/fix up the text as its pretty basic right now - but its a start!
… rule. (#4066) * Add test to show the current fix of multiline signature is incomplete. * Correct the replace function of prefer-method-signature rule.
* Added tests for singleline comment * Optional new line in JsDoc
* Add snake_case option for file-name-casing rule * Add tests
#1738 added support rule severity but forgot to update the example for the stylish formatter.
jsRules can now be a boolean. If it is set to true then parseConfig file, will copy over all active rules that can be applied to js to the jsRules configuration.
* Enforce Blank Line after File Header * Fix linter errors * Remove extraneous part of enforce argument statement * Extract regex into a constant, use test() over match(), return results directly rather than variable assignment * - update fixer for newline, tests
* Added increment-decrement rule Bans ++/-- unary expressions in favor of the += equivalents. Allows an `"allow-post"` option for the i++ scenario. * Used tsutils' expresion checkers * Added increment-decrement to all.ts I always forget to do this... * Added test fix checks and parenthesis for binary expression children * A new lint fix in src * Test commit: hello * Added extra tests; undid repo changes * Undid husky changes * Undid whitespace changes to tslint.json * Also test/utils.ts * There's always room for a quick typo edit :)
* Add ban-ts-ignore rule. * Update license dates. * Use the same code snippet for pass/fail exampls. * undo copyright change
* Add ability to configure formatter from config file * Add test case * Fix lint issues
#### PR checklist - [ ] Addresses an existing issue: #0000 - [ ] New feature, bugfix, or enhancement - [ ] Includes tests - [x] Documentation update #### Overview of change: Fixes a minor typo. Thought I should contribute to TSLint before I start at Palantir in Jan! #### Is there anything you'd like reviewers to focus on? <!-- optional --> #### CHANGELOG.md entry: <!-- optional (example: "[new-rule] `arrow-return-shorthand`") --> <!-- suggested tags: [new-rule], [new-rule-option], [new-fixer], [bugfix], [enhancement], [api], [rule-change], [no-log] -->
* Upgrade prettier and run over all files This: * Upgrades Prettier to 1.14 whic adds yml support. * Turns on `trailing commas = all` as that seems to be what most of the code is doing. * Runs prettier over everything This also has the bonus of making future PRs much smaller. * Removed ts@next-breaking unquoted "bye-bye"
* Re-ran Prettier on source files again, with some more ignores Continues on #4214 - I either merged incorrectly or missed some file exclusions that were needed. * Fixed up introduced linting errors
It turns out this isn't expanding the `**` properly. Tested by touching `src/rules/orderedImportsRule.ts` and checking that it does not fix it (it didn't before).
* Fix typo in launch.json * Fix typo in launch.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features