-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from nodejs:master #14
Commits on Jan 9, 2021
-
http2: refactor to use primordials instead of <string>.indexOf
PR-URL: #36679 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3af175f - Browse repository at this point
Copy the full SHA 3af175fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96c3498 - Browse repository at this point
Copy the full SHA 96c3498View commit details -
Configuration menu - View commit details
-
Copy full SHA for 421279b - Browse repository at this point
Copy the full SHA 421279bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 83b428a - Browse repository at this point
Copy the full SHA 83b428aView commit details -
docs: add references to punycode.md
Add references to related `url` functions in punycode.md. These provide guidance to users who may be investigating the punycode module for URL encoding. PR-URL: #36761 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yash Ladha <yash@yashladha.in> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7dea99b - Browse repository at this point
Copy the full SHA 7dea99bView commit details -
async_hooks: add thisArg to AsyncResource.bind
Semver-major Support setting the `thisArg` for AsyncResource.bind and AsyncResource.prototype.bind. If `thisArg` is not set, then `this` will be set to the `AsyncResource` instance. Fixes: #36051 Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36782 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Configuration menu - View commit details
-
Copy full SHA for 324a6c2 - Browse repository at this point
Copy the full SHA 324a6c2View commit details -
crypto: introduce X509Certificate API
Introduces the `crypto.X509Certificate` object. ```js const { X509Certificate } = require('crypto'); const x509 = new X509Certificate('{pem encoded cert}'); console.log(x509.subject); ``` Fixes: #29181 Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36804 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f5287a4 - Browse repository at this point
Copy the full SHA f5287a4View commit details -
doc: clarify child_process.exec inherits cwd
PR-URL: #36809 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Yash Ladha <yash@yashladha.in> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6498e05 - Browse repository at this point
Copy the full SHA 6498e05View commit details -
net: throw ERR_OUT_OF_RANGE if blockList.addSubnet prefix is NaN
Configuration menu - View commit details
-
Copy full SHA for 9574e5b - Browse repository at this point
Copy the full SHA 9574e5bView commit details -
timers: refactor to use optional chaining
PR-URL: #36767 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d8f535b - Browse repository at this point
Copy the full SHA d8f535bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ae5ca9 - Browse repository at this point
Copy the full SHA 5ae5ca9View commit details -
doc: update release key for Danielle Adams
PR-URL: #36793 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 971bbb7 - Browse repository at this point
Copy the full SHA 971bbb7View commit details -
doc: os.uptime() temporary bug notice
Makes it clear that os.uptime() is unreliable in some virtualization cases. PR-URL: #36503 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b9ffb82 - Browse repository at this point
Copy the full SHA b9ffb82View commit details
Commits on Jan 10, 2021
-
src: fix typo in crypto_aes.cc
concatentated -> concatenated PR-URL: #36717 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for a3606f2 - Browse repository at this point
Copy the full SHA a3606f2View commit details -
zlib: refactor to use primordial instead of <string>.startsWith
PR-URL: #36718 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 7a6af02 - Browse repository at this point
Copy the full SHA 7a6af02View commit details -
doc: fix module syncBuiltinESMExports example
Fix failing code and add explanations of each assert. PR-URL: #34284 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 28e9c10 - Browse repository at this point
Copy the full SHA 28e9c10View commit details -
lib: refactor to use mapping in cluster master
Cluster master message handler is basically doing the same thing for different message actions which can be avoided. Thus move to method mapping object and doing a single lookup to find the function to execute and it doesnot exists, skip the execution chain. PR-URL: #36250 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 88d8dde - Browse repository at this point
Copy the full SHA 88d8ddeView commit details -
console: refactor to avoid unsafe array iteration
PR-URL: #36753 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7397c7e - Browse repository at this point
Copy the full SHA 7397c7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 053abac - Browse repository at this point
Copy the full SHA 053abacView commit details
Commits on Jan 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1c4fa9a - Browse repository at this point
Copy the full SHA 1c4fa9aView commit details -
tools: update doc tool dependencies
PR-URL: #36844 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9883fe0 - Browse repository at this point
Copy the full SHA 9883fe0View commit details -
deps: update nghttp2 to 1.42.0
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.42.0 PR-URL: #36842 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6b18987 - Browse repository at this point
Copy the full SHA 6b18987View commit details -
cluster: fix edge cases that throw ERR_INTERNAL_ASSERTION
Some cases use both `cluster` and `net`/`cluser` will throw ERR_INTERNAL_ASSERTION when `listen`/`bind` to the port of `0`. This PR maitains a separate map of the index to fix the issue. See the new tests added for the detail cases. PR-URL: #36764 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8e3f606 - Browse repository at this point
Copy the full SHA 8e3f606View commit details -
* add character classes * replace echo -n with printf Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #36759 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 44cf49e - Browse repository at this point
Copy the full SHA 44cf49eView commit details -
events: refactor to use optional chaining
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #36763 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for eb8422c - Browse repository at this point
Copy the full SHA eb8422cView commit details -
tools: update all lint-md rollup dependencies
PR-URL: #36843 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6520a87 - Browse repository at this point
Copy the full SHA 6520a87View commit details -
tls: refactor to avoid unsafe array iteration
PR-URL: #36772 Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 307b79d - Browse repository at this point
Copy the full SHA 307b79dView commit details -
PR-URL: #36829 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 7809c4f - Browse repository at this point
Copy the full SHA 7809c4fView commit details -
stream: fix .end() error propagation
PR-URL: #36817 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a4fce32 - Browse repository at this point
Copy the full SHA a4fce32View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4378aa - Browse repository at this point
Copy the full SHA b4378aaView commit details -
crypto: implement basic secure heap support
Adds two new command line arguments: * `--secure-heap=n`, which causes node.js to initialize an openssl secure heap of `n` bytes on openssl initialization. * `--secure-heap-min=n`, which specifies the minimum allocation from the secure heap. * A new method `crypto.secureHeapUsed()` that returns details about the total and used secure heap allocation. The secure heap is an openssl feature that allows certain kinds of potentially sensitive information (such as private key BigNums) to be allocated from a dedicated memory area that is protected against pointer over- and underruns. The secure heap is a fixed size, so it's important that users pick a large enough size to cover the crypto operations they intend to utilize. The secure heap is disabled by default. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36779 Refs: #36729 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 03c0564 - Browse repository at this point
Copy the full SHA 03c0564View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ceb441 - Browse repository at this point
Copy the full SHA 2ceb441View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4ef517 - Browse repository at this point
Copy the full SHA f4ef517View commit details -
stream: finished waits for 'close' on OutgoingMessage
Don't invoke finished callback until OutgoingMessagehas emitted 'close'. PR-URL: #36648 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 52546c0 - Browse repository at this point
Copy the full SHA 52546c0View commit details -
doc: clarify event.isTrusted text
PR-URL: #36827 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2af43f6 - Browse repository at this point
Copy the full SHA 2af43f6View commit details
Commits on Jan 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1b669b2 - Browse repository at this point
Copy the full SHA 1b669b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec794f9 - Browse repository at this point
Copy the full SHA ec794f9View commit details -
module: fix Windows folder exports deprecation warning
PR-URL: #36859 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2e909c4 - Browse repository at this point
Copy the full SHA 2e909c4View commit details -
lib: simplify
primordials.uncurryThis
PR-URL: #36866 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 1a0c5d5 - Browse repository at this point
Copy the full SHA 1a0c5d5View commit details -
doc: define "browser", "production", "development"
Defines the above exports conditions by convention as well as some guidance for further conditions definitions in future PR-URL: #36856 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Configuration menu - View commit details
-
Copy full SHA for 088a7e5 - Browse repository at this point
Copy the full SHA 088a7e5View commit details -
test: disable test-crypto-secure-heap with asan
The asan checks don't play well currently with persistent secure heap allocations. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36900 Refs: #36881 Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6e3a832 - Browse repository at this point
Copy the full SHA 6e3a832View commit details
Commits on Jan 13, 2021
-
doc: fix indentation on http2 doc entry
PR-URL: #36869 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 99580bd - Browse repository at this point
Copy the full SHA 99580bdView commit details -
fs: allow
position
parameter to be aBigInt
in read and readSyncFixes: #36185 PR-URL: #36190 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 72b678a - Browse repository at this point
Copy the full SHA 72b678aView commit details -
crypto: fix WebCrypto import of RSA-PSS keys
This patch changes GetRsaKeyDetail to work in older supported versions of OpenSSL. Refs: openssl/openssl#10217 PR-URL: #36877 Refs: #36188 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6a7eb32 - Browse repository at this point
Copy the full SHA 6a7eb32View commit details -
worker: refactor to avoid unsafe array iteration
PR-URL: #36735 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7c37e04 - Browse repository at this point
Copy the full SHA 7c37e04View commit details -
vm: refactor to avoid unsafe array iteration
PR-URL: #36752 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e70e793 - Browse repository at this point
Copy the full SHA e70e793View commit details -
lib: refactor source_map to avoid unsafe array iteration
PR-URL: #36734 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 3a44f37 - Browse repository at this point
Copy the full SHA 3a44f37View commit details -
zlib: refactor to avoid unsafe array iteration
PR-URL: #36722 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 251a0ff - Browse repository at this point
Copy the full SHA 251a0ffView commit details -
lib: refactor source_map to use more primordials
PR-URL: #36733 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e2b954b - Browse repository at this point
Copy the full SHA e2b954bView commit details -
doc: change "it's" to "its" where necessary
PR-URL: #36913 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 302060a - Browse repository at this point
Copy the full SHA 302060aView commit details
Commits on Jan 14, 2021
-
doc: update fs.l/statSync API history for throwIfNoEntry
PR-URL: #36882 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8f32733 - Browse repository at this point
Copy the full SHA 8f32733View commit details -
crypto: add keyObject.asymmetricKeyDetails for asymmetric keys
This API exposes key details. It is conceptually different from the previously discussed keyObject.fields property since it does not give access to information that could compromise the security of the key, and the obtained information cannot be used to uniquely identify a key. The intended purpose is to determine "security properties" of keys, e.g. to generate a new key pair with the same parameters, or to decide whether a key is secure enough. closes #30045 PR-URL: #36188 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1772ae7 - Browse repository at this point
Copy the full SHA 1772ae7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ba8728 - Browse repository at this point
Copy the full SHA 2ba8728View commit details -
doc: remove unnecessary contributing.md section
Remove "How to Contribute in Issues". This is not Node.js-specific and is likely to cause many readers to tune out. If we want to include this kind of how-all-issue-trackers-are-intended-to-work information, let's link to an external source. But I think it's OK to simply remove it. Refs: nodejs/TSC#864 (comment) PR-URL: #36891 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 9886d5e - Browse repository at this point
Copy the full SHA 9886d5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4db9854 - Browse repository at this point
Copy the full SHA 4db9854View commit details -
doc: update tls test to use better terminology
Given the effort to change the master branch to main, this may make sense as part of removing other references to the offending wording as well. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #36851 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 00cc39e - Browse repository at this point
Copy the full SHA 00cc39eView commit details
Commits on Jan 15, 2021
-
2021-01-14, Version 15.6.0 (Current)
PR-URL: #36889 Notable changes: * child_process: * add 'overlapped' stdio flag (Thiago Padilha) (#29412) * support AbortSignal in fork (Benjamin Gruenbaum) (#36603) * crypto: * implement basic secure heap support (James M Snell) (#36779) * fixup bug in keygen error handling (James M Snell) (#36779) * introduce X509Certificate API (James M Snell) (#36804) * implement randomuuid (James M Snell) (#36729) * doc: * update release key for Danielle Adams (Danielle Adams) (#36793) * add dnlup to collaborators (Daniele Belardi) (#36849) * add panva to collaborators (Filip Skokan) (#36802) * add yashLadha to collaborator (Yash Ladha) (#36666) * http: * set lifo as the default scheduling strategy in Agent (Matteo Collina) (#36685) * net: * support abortSignal in server.listen (Nitzan Uziely) (#36623) * process: * add direct access to rss without iterating pages (Adrien Maret) (#34291) * v8: * fix native constructors (ExE Boss) (#36549)
Configuration menu - View commit details
-
Copy full SHA for 0f78948 - Browse repository at this point
Copy the full SHA 0f78948View commit details -
tls: use recently added matching SecureContext in default SNICallback
Configuration menu - View commit details
-
Copy full SHA for 8cf5281 - Browse repository at this point
Copy the full SHA 8cf5281View commit details -
doc: add miladfarca to collaborators
PR-URL: #36934 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Configuration menu - View commit details
-
Copy full SHA for d22f16d - Browse repository at this point
Copy the full SHA d22f16dView commit details -
doc: add alternative version links to the packages page
PR-URL: #36915 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0f57902 - Browse repository at this point
Copy the full SHA 0f57902View commit details -
test: fix variable name for non-RSA keys
PR-URL: #36912 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ccc6776 - Browse repository at this point
Copy the full SHA ccc6776View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7b1866 - Browse repository at this point
Copy the full SHA d7b1866View commit details -
http2: refactor to avoid unsafe array iteration
PR-URL: #36700 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0fd9bbb - Browse repository at this point
Copy the full SHA 0fd9bbbView commit details -
doc: fixup typo in metadata entry
PR-URL: #36947 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cd37535 - Browse repository at this point
Copy the full SHA cd37535View commit details -
doc: add iansu to collaborators
PR-URL: #36951 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9237280 - Browse repository at this point
Copy the full SHA 9237280View commit details -
tools: add support for top-level await syntax in linter
PR-URL: #36911 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 49f900e - Browse repository at this point
Copy the full SHA 49f900eView commit details -
doc: use ESM syntax for WASI example
PR-URL: #36848 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 88a5426 - Browse repository at this point
Copy the full SHA 88a5426View commit details
Commits on Jan 16, 2021
-
doc: remove resolving-a-bug-report from contributing docs
This section isn't particularly useful in this context and contributes to making the document longer and less effective. This is part of a larger effort to make the contributing docs brief, informative, and friendly. Refs: nodejs/TSC#864 (comment) PR-URL: #36905 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 2afbfb0 - Browse repository at this point
Copy the full SHA 2afbfb0View commit details -
doc: remove issue template duplication from contributing docs
The replicated issue template is out of date. There isn't much reason to replicate it here anyway, so let's remove it and describe what the user should do briefly. PR-URL: #36908 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f64ad30 - Browse repository at this point
Copy the full SHA f64ad30View commit details -
http: cleanup ClientRequest oncreate
PR-URL: #36862 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniele Belardi <dwon.dnl@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 963dec3 - Browse repository at this point
Copy the full SHA 963dec3View commit details -
http: refactor ClientRequest destroy
PR-URL: #36863 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e39a3f8 - Browse repository at this point
Copy the full SHA e39a3f8View commit details -
test: fixup flaky test-crypto-x509 on windows
PR-URL: #36966 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 433afd9 - Browse repository at this point
Copy the full SHA 433afd9View commit details
Commits on Jan 17, 2021
-
doc: fix invalid HTML in doc template
Move the script tag for dark mode support inside the body tag. PR-URL: #36930 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f658bd1 - Browse repository at this point
Copy the full SHA f658bd1View commit details -
url: expose urlToHttpOptions utility
PR-URL: #35960 Fixes: #34349 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
zhangyongsheng committedJan 17, 2021 Configuration menu - View commit details
-
Copy full SHA for 7efada6 - Browse repository at this point
Copy the full SHA 7efada6View commit details
Commits on Jan 18, 2021
-
lib: refactor
primordials.makeSafe
to use more primordialsPR-URL: #36865 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 78ca54c - Browse repository at this point
Copy the full SHA 78ca54cView commit details -
lib: expose primordials object
Expose the internal `primordials` object to help with Node.js core development. ```console $ node --expose-internals -r internal/test/binding lib/fs.js (node:5299) internal/test/binding: These APIs are for internal testing only. Do not use them. (Use `node --trace-warnings ...` to show where the warning was created) ``` PR-URL: #36872 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 983e922 - Browse repository at this point
Copy the full SHA 983e922View commit details -
Revert "test: mark test-cluster-bind-privileged-port flaky on arm"
This reverts commit a45a404. Solved by marking ports <1024 as privileged on Docker containers. Ref: #36850 Ref: #36847 Ref: nodejs/build#2521 PR-URL: #36884 Refs: #36850 Refs: #36847 Refs: nodejs/build#2521 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 5716130 - Browse repository at this point
Copy the full SHA 5716130View commit details -
test: improve coverage at
lib/internal/vm/module.js
PR-URL: #36898 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 146f0fc - Browse repository at this point
Copy the full SHA 146f0fcView commit details -
url: align url format behavior with browsers
Fixes: #36887 PR-URL: #36903 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9566083 - Browse repository at this point
Copy the full SHA 9566083View commit details -
PR-URL: #36909 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d58b83d - Browse repository at this point
Copy the full SHA d58b83dView commit details -
test: improve coverage on worker threads
PR-URL: #36910 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 068efba - Browse repository at this point
Copy the full SHA 068efbaView commit details -
doc: fixup http.IncomingMessage deprecation code
PR-URL: #36917 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for ac2c8c5 - Browse repository at this point
Copy the full SHA ac2c8c5View commit details -
test: skip internet for test-npm-install
Disabling any internet-required features (namely audit and update-notifer) in order for the test to work without an internet connection. - Fixes: #36895 PR-URL: #36933 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 887f199 - Browse repository at this point
Copy the full SHA 887f199View commit details -
doc: fix percentile range in perf_hooks.md
The value accepted by histogram.percentile may be below 1 too. PR-URL: #36938 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b003643 - Browse repository at this point
Copy the full SHA b003643View commit details -
test: improve coverage for
Module
gettersPR-URL: #36950 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9e7d1a1 - Browse repository at this point
Copy the full SHA 9e7d1a1View commit details -
buffer: add base64url encoding option
PR-URL: #36952 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for f8ab632 - Browse repository at this point
Copy the full SHA f8ab632View commit details -
PR-URL: #36953 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1f287b0 - Browse repository at this point
Copy the full SHA 1f287b0View commit details -
tools: update ESLint to 7.18.0
Update ESLint to 7.18.0 PR-URL: #36955 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 568b26a - Browse repository at this point
Copy the full SHA 568b26aView commit details -
doc: fix grammar and link to QUIC in changelog
PR-URL: #36959 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 75a73c4 - Browse repository at this point
Copy the full SHA 75a73c4View commit details -
doc: fix crypto.generateKeySync aes allowed length list
PR-URL: #36928 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 51e77b3 - Browse repository at this point
Copy the full SHA 51e77b3View commit details -
crypto: experimental (Ed/X)25519/(Ed/X)448 support
Implements initial experimental support for Curve25519 and Curve448 support for both ECDH and sign/verify in Web Crypto. Introduced as a Node.js-specific extension to Web Crypto. Signed-off-by: James M Snell <jasnell@gmail.com> Fixes: #36076 PR-URL: #36879 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bd899bc - Browse repository at this point
Copy the full SHA bd899bcView commit details -
deps: V8: cherry-pick fe191e8d05cc
Original commit message: [coverage] optional chaining coverage Implement coverage tracking for optional chains. Bug: v8:10060 Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Gus Caplan <snek@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Benjamin Coe <bencoe@google.com> Cr-Commit-Position: refs/heads/master@{#72075} Refs: v8/v8@fe191e8 PR-URL: #36956 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for afd911c - Browse repository at this point
Copy the full SHA afd911cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d7fb22 - Browse repository at this point
Copy the full SHA 9d7fb22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06c4693 - Browse repository at this point
Copy the full SHA 06c4693View commit details -
doc: remove pull-requests.md preamble
Refs: nodejs/TSC#864 (comment) PR-URL: #36960 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for a8d8ca3 - Browse repository at this point
Copy the full SHA a8d8ca3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 090f0cd - Browse repository at this point
Copy the full SHA 090f0cdView commit details -
module: simplify tryStatSync with throwIfNoEntry option
PR-URL: #36971 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 88153dc - Browse repository at this point
Copy the full SHA 88153dcView commit details -
doc: add performance notes for fs.readFile
Issue #25741 discusses a number of performance considerations for fs.readFile, which was changed in Node.js 10.x to split discreet chunk reads over multiple event loop turns. While the fs.readFile() operation is certainly slower than it was pre 10.x, it's unlikely to be faster. Document the performance consideration and link back to the issue for more in depth analysis. Signed-off-by: James M Snell <jasnell@gmail.com> Fixes: #25741 PR-URL: #36880 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 408e9d3 - Browse repository at this point
Copy the full SHA 408e9d3View commit details -
repl: refactor to avoid unsafe array iteration
PR-URL: #36663 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9a18bf2 - Browse repository at this point
Copy the full SHA 9a18bf2View commit details -
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
Configuration menu - View commit details
-
Copy full SHA for 59af4e6 - Browse repository at this point
Copy the full SHA 59af4e6View commit details -
test: remove unused ecdhPeerKey
This commit removed ecdhPeerKey from test-webcrypto-wrap-unwrap.js which seems to be unsued. PR-URL: #36942 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c880965 - Browse repository at this point
Copy the full SHA c880965View commit details -
test: fix warning in test_environment.cc
``` warning log: ../test/cctest/test_environment.cc: In constructor \ ‘RedirectStdErr::RedirectStdErr(const char*)’: ../test/cctest/test_environment.cc:77:12: warning: \ ignoring return value of ‘FILE* freopen(const char*, \ const char*, FILE*)’, declared with attribute warn_unused_result [-Wunused-result] freopen(filename_, "w", stderr); ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ ``` PR-URL: #36846 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 341bbd3 - Browse repository at this point
Copy the full SHA 341bbd3View commit details -
os: performance improvement in vector allocation
We were using the result vector with an object which is not a primitive data type, and going with the constructor allocation pattern it creates a size of that vector and also initializes the spaces with the data type as well which is in our case is `Local<Value>`. It leads to waste of some CPU cycles and instead we just wanted to have some reserved space in our vector. We can use `reserve` method on vector to reserve some space for the vector but doesn't initialize the value since we are anyways doing it in the following loop. PR-URL: #36748 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cb2535e - Browse repository at this point
Copy the full SHA cb2535eView commit details -
test: increase buffer list coverage
1. test consuming BufferList which has strings with > 1 items Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L116 2. test consuming BufferList with > 1 items Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L152 PR-URL: #36688 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0aef78e - Browse repository at this point
Copy the full SHA 0aef78eView commit details -
test,benchmark: stop requiring URL and URLSearchParams
Since the URL and URLSearchParams classes are available in the global object, there is no need to require them from 'url'. PR-URL: #36927 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3dce4fb - Browse repository at this point
Copy the full SHA 3dce4fbView commit details -
The `Blob` object is an immutable data buffer. This is a first step towards alignment with the `Blob` Web API. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36811 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d4bea09 - Browse repository at this point
Copy the full SHA d4bea09View commit details -
PR-URL: #36811 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7be7285 - Browse repository at this point
Copy the full SHA 7be7285View commit details -
http: abortIncoming only on socket close
Don't call abortIncombin twice for same socket, i.e. both during 'end' and 'close'. PR-URL: #36821 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 708728d - Browse repository at this point
Copy the full SHA 708728dView commit details -
src: use BaseObject::kInternalFieldCount in X509Certificate constructor
Use defined constant instead of hard-coding the field count PR-URL: #36892 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3ede3c2 - Browse repository at this point
Copy the full SHA 3ede3c2View commit details -
doc: fix typo in http.server.requestTimout docs
PR-URL: #36987 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8354ca5 - Browse repository at this point
Copy the full SHA 8354ca5View commit details -
src: replace push_back with emplace_back in debug_utils
This prevents potential temporary object constructions. PR-URL: #36897 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4ae3135 - Browse repository at this point
Copy the full SHA 4ae3135View commit details -
http: attach request as res.req
This change makes it possible for userland http-related modules to pave over edge cases that require referencing the original request when handling a response--making a "Lodash for HTTP" library possible. More information and research in #28673 Fixes: #28673 PR-URL: #36505 Reviewed-By: Robert Nagy <ronagy@icloud.com>
Configuration menu - View commit details
-
Copy full SHA for fc3f1c3 - Browse repository at this point
Copy the full SHA fc3f1c3View commit details -
build: fix compiling against openssl with no-psk
Node 15 prior to this commit will not compile if openssl is built with no-psk. Compiling emits an error like this: ``` crypto_tls.cc:(.text+0x4c27): undefined reference to `node::crypto::TLSWrap::SetCACerts(node::crypto::SecureContext*)' ``` Blame on crypto_tls.cc shows the file was created in a refactor. Before that refactor SetCACerts was defined outside OPENSSL_NO_PSK ifndef. PR-URL: #36881 Fixes: #36464 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for fef2128 - Browse repository at this point
Copy the full SHA fef2128View commit details
Commits on Jan 19, 2021
-
lib: remove non used getter in
lib/perf_hooks.js
PR-URL: #36907 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for acbd3a4 - Browse repository at this point
Copy the full SHA acbd3a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 863ec7d - Browse repository at this point
Copy the full SHA 863ec7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b58fe52 - Browse repository at this point
Copy the full SHA b58fe52View commit details
Commits on Jan 20, 2021
-
tools,doc: list the stability status of each API
Fixes: #23723 PR-URL: #36223 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2bb42bf - Browse repository at this point
Copy the full SHA 2bb42bfView commit details -
util: prefer
Reflect.ownKeys(…)
PR-URL: #36740 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e9944e9 - Browse repository at this point
Copy the full SHA e9944e9View commit details -
src: use BaseObject::kInteralFieldCount in Blob
Instead of hard-coding the field count. PR-URL: #36991 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e3e054d - Browse repository at this point
Copy the full SHA e3e054dView commit details -
Refs: https://github.com/unicode-org/icu/releases/tag/release-68-2 PR-URL: #36980 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5faffd8 - Browse repository at this point
Copy the full SHA 5faffd8View commit details -
doc: fix maintaining ICU guide
PR-URL: #36980 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 37e0a0d - Browse repository at this point
Copy the full SHA 37e0a0dView commit details -
tools: cleanup old ICU version-specific fixes
Our current minimum ICU is 67, so we don't need to support those anymore PR-URL: #36980 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 900c9f5 - Browse repository at this point
Copy the full SHA 900c9f5View commit details -
lib: refactor to use validateArray
PR-URL: #36982 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e279304 - Browse repository at this point
Copy the full SHA e279304View commit details
Commits on Jan 22, 2021
-
PR-URL: #37018 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a35b32e - Browse repository at this point
Copy the full SHA a35b32eView commit details -
process: runtime deprecate changing process.config
The fact that `process.config` is mutable has long made it unreliable when it really should just work. Start the process of deprecating the ability to change it. Fixes: #7803 Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36902 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 96f3977 - Browse repository at this point
Copy the full SHA 96f3977View commit details
Commits on Jan 23, 2021
-
lib: refactor to use validateBoolean
PR-URL: #36983 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cb5668b - Browse repository at this point
Copy the full SHA cb5668bView commit details -
benchmark: improve explanations in R script
PR-URL: #36995 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ea2e2df - Browse repository at this point
Copy the full SHA ea2e2dfView commit details -
fs: add explicit note about undefined path when recursive
PR-URL: #37010 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 432a571 - Browse repository at this point
Copy the full SHA 432a571View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ec7114 - Browse repository at this point
Copy the full SHA 3ec7114View commit details -
fs: refactor to remove redundant validation
The function makeCallback already calls validateCallback, so the call inside copyFile can be removed. PR-URL: #36984 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ae5e95f - Browse repository at this point
Copy the full SHA ae5e95fView commit details -
lib: refactor to use validateNumber
PR-URL: #36993 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e884fd7 - Browse repository at this point
Copy the full SHA e884fd7View commit details -
lib: refactor to use validateString
PR-URL: #37006 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 08dd4b1 - Browse repository at this point
Copy the full SHA 08dd4b1View commit details -
child_process: allow promisified exec to be cancel
Using new AbortController, add support for promisified exec to be cancelled. PR-URL: #34249 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2242cbb - Browse repository at this point
Copy the full SHA 2242cbbView commit details -
readline: add support for the AbortController to the question method
In some cases a question asked needs to be canceled. For instance it might be desirable to cancel a question when a user presses ctrl+c and triggers the SIGINT event. Also an initial empty string was set for this.line since the cursor methods fail if line is not initialized. Added custom promisify support to the question method. PR-URL: #33676 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 19981ed - Browse repository at this point
Copy the full SHA 19981edView commit details -
PR-URL: #37017 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0e7e91f - Browse repository at this point
Copy the full SHA 0e7e91fView commit details -
crypto: throw error on invalid object in diffieHellman()
PR-URL: #37016 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dbdc14b - Browse repository at this point
Copy the full SHA dbdc14bView commit details -
test: test mode passed as an options object in mkdir/mkdirSync
Add tests for mode passed as an options object in fs.mkdir() and fs.mkdirSync(). This also adds coverage for mkdirSync() inside the conditional where options.mode is not undefined. PR-URL: #37008 Refs: https://coverage.nodejs.org/coverage-e3e054d020ee5ef6/lib/fs.js.html#L1023 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3f4bfef - Browse repository at this point
Copy the full SHA 3f4bfefView commit details
Commits on Jan 24, 2021
-
test: log error in test-fs-realpath-pipe
Show more information when the test fails. PR-URL: #36996 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8aea886 - Browse repository at this point
Copy the full SHA 8aea886View commit details -
doc: add missing ARIA label for button
The button for toggling light mode and dark mode has no text display. Screen readers will read it as simply "button", making it not useful. Add an aria-label attribute so it gets a better description. PR-URL: #37031 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 835b85d - Browse repository at this point
Copy the full SHA 835b85dView commit details -
test: improve coverage of
SourceTextModule
gettersPR-URL: #37013 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6b62f70 - Browse repository at this point
Copy the full SHA 6b62f70View commit details -
lib: refactor to use optional chaining in internal/options.js
PR-URL: #36939 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 85e6089 - Browse repository at this point
Copy the full SHA 85e6089View commit details -
fs: use throwIfNoEntry option on statSync calls
PR-URL: #36975 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a87190b - Browse repository at this point
Copy the full SHA a87190bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fe571a - Browse repository at this point
Copy the full SHA 1fe571aView commit details -
src: mark internally exported functions as explicitly internal
Configuration menu - View commit details
-
Copy full SHA for bf79987 - Browse repository at this point
Copy the full SHA bf79987View commit details -
test: increase timeout on ASAN Action
Setting the timeout to 300s (or 5 minutes) instead of the default 120s per test to limit the number of false negative on GH Action CI results. PR-URL: #37007 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 90cae3a - Browse repository at this point
Copy the full SHA 90cae3aView commit details
Commits on Jan 25, 2021
-
doc: list Unsupported Directory Import resolve err
PR-URL: #37032 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for efa6e1d - Browse repository at this point
Copy the full SHA efa6e1dView commit details -
readline: add history event and option to set initial history
Add a history event which is emitted when the history has been changed. This enables persisting of the history in some way but also to allows a listener to alter the history. One use-case could be to prevent passwords from ending up in the history. A constructor option is also added to allow for setting an initial history list when creating a Readline interface. PR-URL: #33662 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d7640a3 - Browse repository at this point
Copy the full SHA d7640a3View commit details -
PR-URL: #37039 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 61f3b71 - Browse repository at this point
Copy the full SHA 61f3b71View commit details -
test: process.nextTick for before exit
PR-URL: #37012 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1377163 - Browse repository at this point
Copy the full SHA 1377163View commit details -
test: increase fs promise coverage
1. Signal aborted while writing file Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L278 2. Signal aborted on first tick Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L301 3. Validate file size is withing range for reading Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L312 4. Signal aborted right before buffer read Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L321 5. Use fallback buffer allocation when input not buffer Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L374 6. Specify symlink type Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L539 7. Set modification times with lutimes Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L635 8. Use fallback encoding when input is null Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L665 9. Use fallback flag when input is null Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L681 PR-URL: #36813 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 211cd04 - Browse repository at this point
Copy the full SHA 211cd04View commit details -
doc:
EventTarget
andEvent
are available to user code since v15.0.0PR-URL: #37059 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cd1e73a - Browse repository at this point
Copy the full SHA cd1e73aView commit details -
benchmark: make output RFC 4180 compliant
PR-URL: #37038 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9da3f21 - Browse repository at this point
Copy the full SHA 9da3f21View commit details -
src: rename crypto_ecdh.(h|cc) to crypto_ec.(h|cc)
PR-URL: #37048 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7394311 - Browse repository at this point
Copy the full SHA 7394311View commit details -
doc: improve AsyncLocalStorage introduction
PR-URL: #36946 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 63d978c - Browse repository at this point
Copy the full SHA 63d978cView commit details -
dgram: support AbortSignal in createSocket
PR-URL: #37026 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 21c8c7e - Browse repository at this point
Copy the full SHA 21c8c7eView commit details -
test: improve assertion message for test-vm-memleak
The test is unreliable in CI. It might be helpful to get an exact read of `rss` so this adds that to the assertion message. PR-URL: #37034 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 13ac5fb - Browse repository at this point
Copy the full SHA 13ac5fbView commit details
Commits on Jan 26, 2021
-
doc: add tooltip for light/dark mode toggle
PR-URL: #37044 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 258d77a - Browse repository at this point
Copy the full SHA 258d77aView commit details -
doc: add Zijian Liu to collaborators
PR-URL: #37075 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ecb7818 - Browse repository at this point
Copy the full SHA ecb7818View commit details -
crypto: add generatePrime/checkPrime
APIs for generating and checking pseudo-random primes Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36997 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for bb13469 - Browse repository at this point
Copy the full SHA bb13469View commit details -
2021-01-26, Version 15.7.0 (Current)
PR-URL: #37020 Notable changes: * buffer: * introduce Blob (James M Snell) [#36811](#36811) * add base64url encoding option (Filip Skokan) [#36952](#36952) * doc: * add @iansu to collaborators (Ian Sutherland) [#36951](#36951) * add @RaisinTen to collaborators (Darshan Sen) [#36998](#36998) * add @miladfarca to collaborators (Milad Fa) [#36934](#36934) * fs: * allow position parameter to be a BigInt in read and readSync (raisinten) [#36190](#36190) * http: * attach request as res.req (Ian Storm Taylor) [#36505](#36505) * expose urlToHttpOptions utility (Yongsheng Zhang) [#35960](#35960)
Configuration menu - View commit details
-
Copy full SHA for cef00ad - Browse repository at this point
Copy the full SHA cef00adView commit details -
Configuration menu - View commit details
-
Copy full SHA for c5f3565 - Browse repository at this point
Copy the full SHA c5f3565View commit details
Commits on Jan 27, 2021
-
test,doc,lib: adjust object literal newlines for lint rule
Before enabling object-curly-newline for our ESLint rules, adjust files to comply with it. Refs: https://eslint.org/docs/rules/object-curly-newline PR-URL: #37040 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 996b85b - Browse repository at this point
Copy the full SHA 996b85bView commit details -
tools: enable object-curly-newline in ESLint rules
I saw a PR review comment about newlines in desructured assignments, and this would be the rule to enforce these kinds of nits. Start by just enabling the rule. We can incrementally adjust it to be more strict. Refs: https://eslint.org/docs/rules/object-curly-newline Refs: #37028 (review) PR-URL: #37040 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3e54870 - Browse repository at this point
Copy the full SHA 3e54870View commit details -
test: increase coverage for assert/calltracker
1. test calls fn parameter is number Refs: https://coverage.nodejs.org/coverage-51b43675067fafaa/lib/internal/assert/calltracker.js.html#L30 2. test calls fn parameter is undefined Refs: https://coverage.nodejs.org/coverage-51b43675067fafaa/lib/internal/assert/calltracker.js.html#L33 PR-URL: #36728 Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7016c61 - Browse repository at this point
Copy the full SHA 7016c61View commit details -
test: update to improve terminology
Update common section in wpt to incorporate improved terminology fixed upstream in web-platform-tests/wpt#27152 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #37011 Reviewed-By: Milad Fa <mfarazma@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9603e4a - Browse repository at this point
Copy the full SHA 9603e4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for da3a948 - Browse repository at this point
Copy the full SHA da3a948View commit details -
lib: refactor to avoid unsafe array iteration
PR-URL: #37029 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2e1e02a - Browse repository at this point
Copy the full SHA 2e1e02aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e833b6 - Browse repository at this point
Copy the full SHA 4e833b6View commit details -
doc: mention adding Fixes to collaborator onboarding PR
Also update the example to include the Fixes url. PR-URL: #37097 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 35fe310 - Browse repository at this point
Copy the full SHA 35fe310View commit details -
crypto: generateKeyPair('ec') should not support NODE-ED* and NODE-X*
Configuration menu - View commit details
-
Copy full SHA for 8b65004 - Browse repository at this point
Copy the full SHA 8b65004View commit details -
crypto: fix encrypted private -> public import
PR-URL: #37056 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c9992a0 - Browse repository at this point
Copy the full SHA c9992a0View commit details -
test: increase read file abort coverage
PR-URL: #36716 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8c3cdce - Browse repository at this point
Copy the full SHA 8c3cdceView commit details -
lib: refactor to use validateFunction
add validateFunction and refactor to use validateFunction PR-URL: #37045 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 064a707 - Browse repository at this point
Copy the full SHA 064a707View commit details -
test: skip tests consistently in parallel.status
Some tests are marked SKIP,FLAKY (resulting in yellow/unstable CI when they fail) and others are marked SKIP (which means the results don't affect CI at all). There doesn't seem to be any reason for the difference. Mark them all as SKIP as IBM i for consistency and to have the luxury of a green daily CI. We'll want these to be at least SKIP,FLAKY (and preferably not skipped at all) before IBM i is supported. PR-URL: #37035 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e331046 - Browse repository at this point
Copy the full SHA e331046View commit details -
test: increase inspect coverage
1. Truncate output for Primitives with 1 character left Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/util/inspect.js.html#L1359 2. Truncate output for ArrayBuffers using plural or singular bytes Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/util/inspect.js.html#L1465 PR-URL: #36755 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4abe50c - Browse repository at this point
Copy the full SHA 4abe50cView commit details -
fs: add validatePosition and use in read and readSync
PR-URL: #37051 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0aaa804 - Browse repository at this point
Copy the full SHA 0aaa804View commit details -
benchmark: add benchmark for NODE_V8_COVERAGE
PR-URL: #36972 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 8c9dc4e - Browse repository at this point
Copy the full SHA 8c9dc4eView commit details
Commits on Jan 28, 2021
-
lib: refactor to use validateObject
Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #37028 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 029d1fd - Browse repository at this point
Copy the full SHA 029d1fdView commit details -
lib: add
bound apply
variants of varargsprimordials
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #37005 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 728fee2 - Browse repository at this point
Copy the full SHA 728fee2View commit details -
test: add tests for
bound apply
variants of varargsprimordials
PR-URL: #37005 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 742342f - Browse repository at this point
Copy the full SHA 742342fView commit details -
doc: update BUILDING.md previous versions links
Remove links to End-of-Life versions of the BUILDING.md document. Add a link to the version for Node.js 14.x. PR-URL: #37082 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b9dfda9 - Browse repository at this point
Copy the full SHA b9dfda9View commit details
Commits on Jan 29, 2021
-
tools: remove commented code from stability.js
PR-URL: #37092 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1b222f9 - Browse repository at this point
Copy the full SHA 1b222f9View commit details -
readline: check for null input in question()
question() checks for objects passed as the recently added options argument. This commit improves that logic to also check for null. PR-URL: #37089 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b02030d - Browse repository at this point
Copy the full SHA b02030dView commit details -
readline: replace _questionCancel with a symbol
This commit avoids exposing a new underscored property on readline Interface instances. PR-URL: #37094 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fec093b - Browse repository at this point
Copy the full SHA fec093bView commit details -
util: add internal createDeferredPromise()
The pattern of resolving/rejecting a Promise from outside of its executor happens numerous times throughout the codebase (more than what is updated here in fact). This commit abstracts that logic into an internal utility function. PR-URL: #37095 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 17467d1 - Browse repository at this point
Copy the full SHA 17467d1View commit details -
src: fix dead code in RandomPrimeTraits
PR-URL: #37083 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0a993e1 - Browse repository at this point
Copy the full SHA 0a993e1View commit details
Commits on Jan 30, 2021
-
PR-URL: #37117 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d3906ae - Browse repository at this point
Copy the full SHA d3906aeView commit details -
doc: update Buffer encoding option count
#36952 added the `base64url` encoding option. Easier to just remove the count of options so it doesn’t need to be updated to four, five, etc. in the future. PR-URL: #37102 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fd02dac - Browse repository at this point
Copy the full SHA fd02dacView commit details -
esm: deprecate legacy main lookup for modules
PR-URL: #36918 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 255d633 - Browse repository at this point
Copy the full SHA 255d633View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c52ce8 - Browse repository at this point
Copy the full SHA 1c52ce8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e63035c - Browse repository at this point
Copy the full SHA e63035cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f763a80 - Browse repository at this point
Copy the full SHA f763a80View commit details -
PR-URL: #37067 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c3d6d50 - Browse repository at this point
Copy the full SHA c3d6d50View commit details -
PR-URL: #37067 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 290ecb3 - Browse repository at this point
Copy the full SHA 290ecb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71cb829 - Browse repository at this point
Copy the full SHA 71cb829View commit details -
esm: update to correct deprecation code
#36918 landed with references to DEP0150, which is already used for a different deprecation. This commit updates the code to use DEP0151. PR-URL: #37147 Refs: #36918 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d0a92e2 - Browse repository at this point
Copy the full SHA d0a92e2View commit details
Commits on Jan 31, 2021
-
doc: remove TOC summary for pages with no TOC
Remove the table of contents summary for pages with no table of contents. Currently, this affects at least index.html. PR-URL: #37043 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 683754c - Browse repository at this point
Copy the full SHA 683754cView commit details
Commits on Feb 1, 2021
-
doc: add example for test structure
PR-URL: #35046 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c746c40 - Browse repository at this point
Copy the full SHA c746c40View commit details -
doc: clarify repl exception conditions
The sample code demonstrating ERR_INVALID_REPL_INPUT is confusing, I think. This simplifies and clarifies it a bit, I hope. PR-URL: #37142 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e30e035 - Browse repository at this point
Copy the full SHA e30e035View commit details -
http: refactor to avoid unsafe array iteration
PR-URL: #37124 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4a113be - Browse repository at this point
Copy the full SHA 4a113beView commit details -
doc: clarify ERR_INVALID_REPL_INPUT usage
The REPL documentation does not list prohibited inputs, but it does explain the conditions under which ERR_INVALID_REPL_INPUT is used. Update the error doc to indicate that. PR-URL: #37143 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 06d7495 - Browse repository at this point
Copy the full SHA 06d7495View commit details -
doc: fix markup and alphabetization in errors.md
Change `<a id"...` to `<a id="...` (missing equal sign) and move entry to correct location in alphabetical order. PR-URL: #37144 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for e6fbe48 - Browse repository at this point
Copy the full SHA e6fbe48View commit details -
stream: refactor to use more primordials
PR-URL: #36346 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 419686c - Browse repository at this point
Copy the full SHA 419686cView commit details -
stream: refactor to avoid unsafe array iteration
PR-URL: #37126 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4ad46e2 - Browse repository at this point
Copy the full SHA 4ad46e2View commit details -
fs: only use Buffer.concat in promises.readFile when necessary
PR-URL: #37127 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 186feb4 - Browse repository at this point
Copy the full SHA 186feb4View commit details -
fs: read full size if known in promises.readFile
If we have an estimate of the file size available from the previous stat call, use that for the size of the first chunk to be read. This increases performance by reading more data (and, most likely, all data) at once without incurring memory overhead in most situations. PR-URL: #37127 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a126cb5 - Browse repository at this point
Copy the full SHA a126cb5View commit details -
doc,test: fix prime generation description
The previous description incorrectly explained the behavior of options.add and options.rem for primes that are not safe. PR-URL: #37085 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 814f971 - Browse repository at this point
Copy the full SHA 814f971View commit details -
async_hooks: refactor to avoid unsafe array iteration
PR-URL: #37125 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f8853dd - Browse repository at this point
Copy the full SHA f8853ddView commit details -
doc: fix list format in Developer's Certificate of Origin
This corresponds to the format at https://developercertificate.org/. PR-URL: #37138 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b5f5c46 - Browse repository at this point
Copy the full SHA b5f5c46View commit details -
src: expose BaseObject::kInternalFieldCount in post-mortem metadata
Configuration menu - View commit details
-
Copy full SHA for 638fb48 - Browse repository at this point
Copy the full SHA 638fb48View commit details
Commits on Feb 2, 2021
-
PR-URL: #37177 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 3c0672e - Browse repository at this point
Copy the full SHA 3c0672eView commit details -
The flag is going to be removed upstream in V8 9.0. Refs: v8/v8@0a480c3 PR-URL: #37151 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 501ae0e - Browse repository at this point
Copy the full SHA 501ae0eView commit details -
doc: improve promise terminology
PR-URL: #37181 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 271e04f - Browse repository at this point
Copy the full SHA 271e04fView commit details -
src: read exactly two tokens from Linux THP sysfs config
There was an unexpected and hard-to-spot issue here: the /sys/kernel/mm/transparent_hugepage/enabled file contains three entries, and the std::ifstream reader was reading two values on each loop iteration, resulting in incorrect behaviour. Fixes: #37064 PR-URL: #37065 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a0c0875 - Browse repository at this point
Copy the full SHA a0c0875View commit details -
doc: fix color contrast on <kbd> elements
PR-URL: #37185 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b750f74 - Browse repository at this point
Copy the full SHA b750f74View commit details -
test: split heap snapshot limit tests
test/parallel/test-heapsnapshot-near-heap-limit.js is timing out in CI on low-memory and slow-CPU devices. Split off the worker test to its own test file to allow the test to finish in time. Refs: #36961 PR-URL: #37189 Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 84e41d2 - Browse repository at this point
Copy the full SHA 84e41d2View commit details -
tls: add ability to get cert/peer cert as X509Certificate object
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37070 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c973d50 - Browse repository at this point
Copy the full SHA c973d50View commit details -
2021-02-02, Version 15.8.0 (Current)
Notable changes: crypto: * (SEMVER-MINOR) add generatePrime/checkPrime (James M Snell) #36997 * (SEMVER-MINOR) experimental (Ed/X)25519/(Ed/X)448 support (James M Snell) #36879 deps: * upgrade npm to 7.5.0 (Ruy Adorno) #37117 dgram: * (SEMVER-MINOR) support AbortSignal in createSocket (Nitzan Uziely) #37026 doc: * add Zijian Liu to collaborators (ZiJian Liu) #37075 esm: * deprecate legacy main lookup for modules (Guy Bedford) #36918 readline: * (SEMVER-MINOR) add history event and option to set initial history (Mattias Runge-Broberg) #33662 * (SEMVER-MINOR) add support for the AbortController to the question method (Mattias Runge-Broberg) #33676 PR-URL: #37183
Configuration menu - View commit details
-
Copy full SHA for 211574b - Browse repository at this point
Copy the full SHA 211574bView commit details -
crypto: add keyObject.export() 'jwk' format option
Adds [JWK](https://tools.ietf.org/html/rfc7517) keyObject.export format option. Supported key types: `ec`, `rsa`, `ed25519`, `ed448`, `x25519`, `x448`, and symmetric keys, resulting in JWK `kty` (Key Type) values `EC`, `RSA`, `OKP`, and `oct`. `rsa-pss` is not supported since the JWK format does not support PSS Parameters. `EC` JWK curves supported are `P-256`, `secp256k1`, `P-384`, and `P-521` PR-URL: #37081 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for a8d7de1 - Browse repository at this point
Copy the full SHA a8d7de1View commit details
Commits on Feb 3, 2021
-
PR-URL: #37191 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 861a396 - Browse repository at this point
Copy the full SHA 861a396View commit details -
stream: improve Readable.from error handling
PR-URL: #37158 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 03380bc - Browse repository at this point
Copy the full SHA 03380bcView commit details -
doc: fix 404 links in module.md
PR-URL: #37202 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3b40893 - Browse repository at this point
Copy the full SHA 3b40893View commit details -
PR-URL: #37205 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b586c6a - Browse repository at this point
Copy the full SHA b586c6aView commit details -
tools: update ESLint to 7.19.0
Update ESLint to 7.19.0 PR-URL: #37159 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bc396c8 - Browse repository at this point
Copy the full SHA bc396c8View commit details -
src: simplify calls to BN_bin2bn in prime gen
PR-URL: #37169 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8b14046 - Browse repository at this point
Copy the full SHA 8b14046View commit details -
timers: introduce setInterval async iterator
Added setInterval async generator to timers\promises. Utilises async generators to provide an iterator compatible with `for await`. Co-Authored-By: Fabian Cook <hello@fabiancook.dev> fix message PR-URL: #37153 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fefc639 - Browse repository at this point
Copy the full SHA fefc639View commit details -
test: remove flaky designation for test-http2-large-file
This seems to have stopped happening, possibly because it only ever happened on win2008 and that went eol last year. Closes: #22327 PR-URL: #37156 Fixes: #22327 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4f44cad - Browse repository at this point
Copy the full SHA 4f44cadView commit details -
PR-URL: #37214 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bc89048 - Browse repository at this point
Copy the full SHA bc89048View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe43bd8 - Browse repository at this point
Copy the full SHA fe43bd8View commit details
Commits on Feb 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c148c3a - Browse repository at this point
Copy the full SHA c148c3aView commit details -
PR-URL: #37228 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3b36320 - Browse repository at this point
Copy the full SHA 3b36320View commit details -
timers: remove flaky setInterval test
PR-URL: #37227 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cfb2e06 - Browse repository at this point
Copy the full SHA cfb2e06View commit details -
repl: refactor to avoid unsafe array iteration
PR-URL: #37188 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 703e566 - Browse repository at this point
Copy the full SHA 703e566View commit details
Commits on Feb 5, 2021
-
doc: fix CHANGELOG_ARCHIVE table of contents
PR-URL: #37232 Refs: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_ARCHIVE.md#0.8.0 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 62cd0eb - Browse repository at this point
Copy the full SHA 62cd0ebView commit details -
doc: fix version number for DEP006
PR-URL: #37231 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6385340 - Browse repository at this point
Copy the full SHA 6385340View commit details -
Configuration menu - View commit details
-
Copy full SHA for 664cce9 - Browse repository at this point
Copy the full SHA 664cce9View commit details -
src: refactor bookkeeping of bootstrap status
This patch 1. Refactors the bootstrap routine of the main instance so that when --no-node-snapshot is used, Environment::InitializeMainContext() will only be called once (previously it would be called twice, which was harmless for now but not ideal). 2. Mark the number of BaseObjects in RunBootstrapping() when creating the Environment from scratch and in InitializeMainContext() when the Environment is deserialized. Previously the marking was done in the Environment constructor and InitializeMainContext() respectively for the cctest which was incorrect because the cctest never uses an Environment that's not bootstrapped. Also renames the mark to base_object_created_after_bootstrap to reflect what it's intended for. PR-URL: #37113 Refs: #36943 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9aeb836 - Browse repository at this point
Copy the full SHA 9aeb836View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e769a9 - Browse repository at this point
Copy the full SHA 2e769a9View commit details -
PR-URL: #37229 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a6de951 - Browse repository at this point
Copy the full SHA a6de951View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf2f2b7 - Browse repository at this point
Copy the full SHA bf2f2b7View commit details -
fs: use a default callback for fs.close()
The `fs.close()` function requires a callback. Most often the only thing that callback does is check and rethrow the error if one occurs. To eliminate common boilerplate, make the callback optional with a default that checks and rethrows the error as an uncaught exception. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37174 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7d0f680 - Browse repository at this point
Copy the full SHA 7d0f680View commit details -
doc: fix webcrypto HMAC generateKey example
PR-URL: #37197 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 29789f7 - Browse repository at this point
Copy the full SHA 29789f7View commit details -
doc: mention CryptoKey in port.postMessage()
PR-URL: #37196 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 88be944 - Browse repository at this point
Copy the full SHA 88be944View commit details -
doc: consistent webcrypto
node.keyObject
formatPR-URL: #37200 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 931c2d1 - Browse repository at this point
Copy the full SHA 931c2d1View commit details -
doc: mark Certificate methods as static, add missing KeyObject.from
PR-URL: #37198 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for e8286bb - Browse repository at this point
Copy the full SHA e8286bbView commit details -
crypto: remove webcrypto "DSA" JWK Key Type operations
"DSA" is not a registered JWK key type. https://www.iana.org/assignments/jose/jose.xhtml#web-key-types PR-URL: #37203 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 2ff1c83 - Browse repository at this point
Copy the full SHA 2ff1c83View commit details
Commits on Feb 6, 2021
-
test: rename n-api to node-api
This renames the macros used in the tests from `NAPI_*` to `NODE_API_*`. PR-URL: #37217 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4b7f23f - Browse repository at this point
Copy the full SHA 4b7f23fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b8b165 - Browse repository at this point
Copy the full SHA 6b8b165View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3aba6fe - Browse repository at this point
Copy the full SHA 3aba6feView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0e66e3 - Browse repository at this point
Copy the full SHA c0e66e3View commit details