Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Styletron/BaseUI providers out of data filter example app file. #4047

Merged
merged 86 commits into from
Jan 28, 2020

Conversation

tgorkin
Copy link
Contributor

@tgorkin tgorkin commented Dec 18, 2019

No description provided.

@coveralls
Copy link

coveralls commented Dec 19, 2019

Coverage Status

Coverage decreased (-2.2%) to 80.877% when pulling 39b8397 on tgorkin/data-filter-styletron into 4744562 on tgorkin/gatsby-examples.

@@ -0,0 +1,38 @@
import React from 'react';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following React naming convention, I'd call

  • the file root.js
  • function Root({data})
  • render(<Root data={data} />, container)

Pessimistress and others added 23 commits January 15, 2020 10:53
* added to API docs

Signed-off-by: Shan He <heshan0131@gmail.com>
* use center of data to calculate radius in common space. for projection
* save radiusCommon in aggregation result
* recalculate meter radius based on saved radiusCommon when viewport updated
* if hexagonVertices is provided, convert them to meter offset
@claassistantio
Copy link

claassistantio commented Jan 28, 2020

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
12 out of 13 committers have signed the CLA.

✅ xintongxia
✅ 1chandu
✅ Pessimistress
✅ lukemcgregor
✅ tgorkin
✅ ilan-gold
✅ ajduberstein
✅ georgios-uber
✅ heshan0131
✅ goszczynskip
✅ akre54
✅ isaacbrodsky
❌ dependabot[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@tgorkin tgorkin marked this pull request as ready for review January 28, 2020 01:25
@tgorkin tgorkin merged commit c851b7d into tgorkin/gatsby-examples Jan 28, 2020
@tgorkin tgorkin deleted the tgorkin/data-filter-styletron branch January 28, 2020 01:49
tgorkin added a commit that referenced this pull request Jan 28, 2020
* Port hexagon example to gatsby website. Re-organize example files under src directory and scss files under stylesheets.

* Port icon example to ocular gatsby website.

* Port geojson polygon example to ocular gatsby website.

* Port highway demo to ocular gatsby website.

* Port screengrid layer example to ocular gatsby website.

* Port arc layer example to ocular gatsby website.

* Port scatterplot layer to ocular gatsby website.

* Port point cloud demo to ocular gatsby website.

* Port text layer example to ocular gatsby website.

* Port tile layer example to ocular gatsby website.

* Port trips layer example to ocular gatsby website.

* Port heatmap example to ocular gatsby website.

* Port 3d tiles example to ocular gatsby website.

* Port brushing example to ocular gatsby website.

* Port data filtering example to ocular gatsby website.

* Port plot demo to ocular gatsby website.

* Fix gatsby build errors, add checks against window being defined to fix server side rendering.

* Fix data fiter demo breaking on legacy website.
Remove unused example wrappers.
Bump node-sass version to fix errors with node v12.

* Refactor Styletron/BaseUI providers out of data filter example app file. (#4047)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.