Prebid upgrade 2 2 0 20190213112513 #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rivr thin adapter (#5) * RVR-2049 - change impression event * RVR-2049 - fix user id value returned on creation of the cookie * RVR-2049 - remove blockedCategories and browser properties from Auction object * RVR-2060 - rewrite rendering detection for impression and click events * RVR-2060 - rewrite tests for rendering detection for impression and click events * RVR-2049 - send ad unit code in click event * RVR-2049 - adapt tests for click event * RVR-2072 - split impression detection depending on the ad server - DFP/none * RVR-2056 - set creativeId in Auction -> received bids * RVR-2056 - set bid.clearPrice to cmp * RVR-2087 - extract trackAuctionInit implementation to rivraddon * RVR-2087 - extract implementation to rivraddon WIP * RVR-2087 - extract implementation to rivraddon * RVR-2087 - extract implementation to rivraddon * RVR-2087 - Update package-lock * RVR-2087 - Add addons check * Rivr Thin Adapter - part 2 (#6) * RVR-2087 - Remove sendAuction call from ExpiringQueue * RVR-2147 - Fix test failing on IE 11.0.0 * RVR-2087 - Remove ExpiringQueue
* Fix multi-bid adId in Criteo bid adapter A single bid request can generate multiple bids if it has multiple sizes. However, by default 'adId' will be filled with the bid request's 'bidId' field, so if we create two bids from the same bid request, they will share the same 'adId'. Because of this, Prebid will not know which bid to use once DFP makes either of those bids win, always taking the first one (see 'auctionManager.findBidByAdId' used in 'pbjs.renderAd'). * Increment Criteo adapter version * Add test for Criteo multi-bid fix
…ze instead of bid.sizes (prebid#3377) * Added telaria bid adapter * more documentation * Added more test cases. And improved some code in the adapter * Removed the check for optional params, they are handled in the server. Also updated certain param names used in the test spec. * added some spaces to fix CircleCI tests * added some spaces to fix CircleCI tests * fixed code indentation in /spec/AnalyticsAdapter_spec.js which causing the CircleCI tests to fail. * Reverted the changes * merged with prebid master. * creative Id is required when we build a response but our server doesn't always have the crid, so using a sentinel value when we don't have the crid. * - removed an un used method - Removed the package-lock file. * merging to master * updated telaria bid adapter to use player size provided by the bid.mediaTypes.video.playerSize instead of bid.sizes. prebid#3331 * - removed the requirement for having player size - updated the test spec to reflect the above change - removed changes to the package-lock.json file. * added a param to the ad call url to let us know that the request is coming via hb. * to lower casing the bidder code.
* New adapter "Coinzilla" added * Solved required modifications related to bidderRequest.referrerInfo.referer
* Changing to requestId in order to align with prebid cores mapping of bidId to responseId * Need to update in other events as well * Catching and logging no bid found * Lint error fix
* * check if consent hook is already set * * removed debug code * * formatting
* inprogress * add support for s2sConfig bidderOptions * merged missing updates from origin * changed arrow function in spec mocha tests to standard functions * fixed missing closing bracket and paren * updated incorrect spec expected values for s2sConfig tests * removed rubicon specific s2s configuration default value for sra * deleted unnecessary test and revised a test description since the rubicon specific defaults were removed * removed jsdoc for deprecated cookieSetUrl
prebid#3380) * Backward compatible update & reduced TTL * replaced deprecated getWindowTopLocation with referer detection module
* RAD-2356 Upgrade Mocha karma-webpack karma * RAD-2356 update readme to support node v6 or more * Remove webpack output logs while testing * move from gulp-webserver to gulp-connect * remove karma-require and redundant watch task
* Fix prebid#3265 - pbs cookie sync race condition * add/update jsdoc comments
* * make eslint fix formatting * * remove double semi-column
* update IE version in readme * tweak IE message
…bid#3401) * Adding GDPR support * Always drop user syncs when available * Set dealID based on buying type * Native ads, single request option
…bid#3387) * Adding remaining missing parameters from AppNexus Native response * Removed native video, renamed sale and clickLabel to RTB spec names * drop video from tests
* 3413-Insert Iframes for user sync in body * Append Iframe as the last child * Add unit test for insertElement * utls insert element at the top by default * add unit tests for utls insert element * Insert iframe as html last child * revert package.lock changes
* changing default currency file * using defaultRate in the case of rate file not returning * Adding date macro * added unit tests for date macro support in currency file url, and small fix to date macro in currency.js * replaced string concatenations with string literals * removed unnecessary parens
* added suppor for grabbing digitrust id off the window * added digitrust support
* Update the Gamoshi Gambid adapter to simply the Gamoshi adapter This is a minor branding change to highlight the Gamoshi brand name. The biddercode "gambid" is still retained in the adapter aliases array. * update whitelabel * Add test that checks support for outstream renderers * Update testing and page ref * Modify bidder's url resolving * Fix lint issue with bidder's url resolving
* otm * ALF-95 * otm: modify adapter to support migration to a new ssp * otm: fixed spec
* - pubnx new bidder adapter created - pubnx doc file created * - Spec file added. * - Vertoz removed from response text * removed pubnx from serverbid since there will be a standalone adapter, the pubnx alias needs to removed from here * - pubnx response parameters updated * - build request params updated
* adding playback and hb=1 * export-updateSelectedFilters
* add adpod to mediaTypes * add new typedef
* Livewrapped bid and analytics adapter * Fixed some tests for browser compatibility * Fixed some tests for browser compatibility * Changed analytics adapter code name * Fix double quote in debug message * modified how gdpr is being passed * Added support for Publisher Common ID Module
* Fix requestId field after the commit (https://github.com/prebid/Prebid.js/pull/3411/files), Rubicon is no more seeing event for Server side requests. This is due to the requestId not correctly set up as it should be the associatedBidRequest bidid not the bid response bid id. * Update index.js * Update prebidServerBidAdapter_spec.js
* add support to pass custom key in PBC request * update logic to allow individual custom keys per bid
…3440) * generate bid.adId uniquely * remove stray debugger * update adId reference in currency file
* create hooks and modify adservermanager function * remove comment * modify the import path for hook file * move checkAdUnitSetup and refactor video.js hook * update hook code to use new API * change hooks to use sync type * add adpod mediatype and rename native variable * remove unused import from test file * remove adpod reference in utils to avoid merge conflict
* Add support for multiple media types. Add test coverage. * Add support for multiple media types. Add test coverage. * Modify multi-format ads handler. Modify tests. * Rename yieldnexus bid adapter to fix download issue
* Rich Audience Bidder Adapter * Rich Audience Bidder Adapter * Rich Audience Bidder Adapter * Changes in UserSyncs * Changes in package-lock.json
* initial commit * updated contact and tag details * changes ti support the renderers * changes to pass dimId * fixed names of internal mapping * added comment * added gdpr param to request and other fixes * modified api url * fix * fixed the secure api call * rolled back video event callback till we support it * updated doc with video details * added bid won and timeout pixel * added testcase for bid events * modified testcase * fixed the url logged * tag param values passed ot renderer * added a conditioal check * changes to support new param to adserver for purpose of tracking * passed param to renderer * missing variable defined
* Admedia adapter * Removed a commented line
* use unit id being sent instead of hard coded auid * make multiple requests * removes commented out code. adds aus param back * hardcodes vht, vwd, aus * arrays should have commas * adds aus check to test * updates md file with new sizes syntax * updates md file with new sizes syntax * adds note on md about size option * size updates
* added universal id support * fixed universal id for oRTB section only * added unit test for universal id support in bid adapter * added universal id support * fixed universal id for oRTB section only * added unit test for universal id support in bid adapter * renamed universalID to userId * reverted merge error
Added "len" param to show we support it.
Prebid upgarde automate- test pull request created through git api please ignore it
…ver side enabled partners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information