Merge main into features/list-patterns #55072

Revert "Ensure we don't try and build an empty table when modifying entries"

…elease/dev17.0-to-main

…ith no values (dotnet#54639)

…elease/dev17.0-to-release/dev17.0-vs-deps

…-release/dev17.0-vs-deps Merge release/dev17.0 to release/dev17.0-vs-deps

… into merges/main-to-features/FileScopedNamespaces

Merge main into features/interpolated-string and condense errors

Fix diagnostics with locations in mapped files displaying at an incorrect location

…-main Merge release/dev17.0 to main

…7.0p2 Update PublishData.json after M2 snap

Fixes AB#1347599

Merge features/interpolated-string into main

Fix failure to handle missing source after a configuration change

Increase timeout for macOS debug

Add F# content type to always active server to support pull diagnostics

* Unescape interpolated string literal components Fixes dotnet#54703. Spec change is at dotnet/csharplang#4910. Note that there is an interesting wrinkle here in that, for an interpolated string used as a string, the change in constant value makes the lowering mechanism an observable side effect. While doing this step during lowering instead of initial binding is technically feasible, it would be quite complex as there are several different ways an AppendLiteral call could get to lowering (dynamic, conversion to object, regular literal, passed by in, etc). For now, I'm opting for simple strategy of accepting this observable side-effect, and if we want to try and make that side effect invisble we can look at doing so at a later point. Co-authored-by: Jared Parsons <jaredpparsons@gmail.com>

… into merges/main-to-features/FileScopedNamespaces

* Document IListCalls and related types * Clarify comments in code * Clear ImmutableSegmentedList<T>.ValueBuilder._list when initializing _mutableList

Address FileScopedNamespaces test plan review

…o-release/dev17.0 Merge release/dev16.11 to release/dev17.0

…o-release/dev16.11-vs-deps Merge release/dev16.11 to release/dev16.11-vs-deps

Adornment manager and related file changes

🐇 Use ImmutableSegmentedDictionary to optimize storage and lookup

…aces Merge FileScopedNamespaces to main

…-main Merge release/dev17.0 to main

…-release/dev17.0-vs-deps Merge release/dev17.0 to release/dev17.0-vs-deps

…s-deps-to-release/dev17.0-vs-deps Merge release/dev16.11-vs-deps to release/dev17.0-vs-deps

Fix navigation to file-scoped namespaces

…otnet#50058)

Fix FAR for constructors in file-scoped namespaces

Ensure equivalence key is not null

…Roslyn into records-xml-doc-ide

Switch progression search over to navto search by default.

Add records support to XmlDocCommentCompletion and ChangeSignature

[main] Update dependencies from dotnet/roslyn

See also microsoft/vs-threading#556

…tbulb" This reverts commit 0d317a4, reversing changes made to 5336a84.

…tnet#51679)

Revert "Merge pull request dotnet#53117 from CyrusNajmabadi/asyncLightbulb"

…tnet#54726) * Prefer Concat on interpolated strings with 4 or less string parts Fixes dotnet#54702. This does not implement any changes to prefer concat for ReadOnlySpan<char>: doing so will require a deeper change of the local rewriter's handling of string concatenation that we can revisit at a later date if we so choose.

Enable CA2012 (Use ValueTasks correctly)

…#54790) * Simplify condition that must always be true * Name parameter more clearly * Make private and name properly

…4797)

* Reduce allocations in CSharp command line parsing Context dotnet#53570 The C# parser is used by the project system in scenarios like solution open. That means the allocations in command line parsing can contribute significantly to Visual Studio performance. This PR reduces the allocations significantly. Note: in the below explanations when I refer to the "99% case" I am referring to how command lines are structured when created by MSBuild based builds. That is the **overwhelming** case for the compiler and is advantageous because it normalizes many items like lower casing all option names, having one reference per option, etc ... The remaining 1% are hand authored build files and these should not impact Visual Studio scenarios. The first fix is to simply avoid iterators in the parse hot paths. Most of the iterators in the parser return a single element in the 99% case hence the iterator is wasted allocations. These were switched to take pooled builder arguments. The next, and more siginificant fix, is to use `ReadOnlyMemory<char>` instead of `string` on our hot parsing paths. This allows us to parse the command line arguments without actually allocating memory for the values until actually needed by lower level APIs. This allowed for APIs like `RemoveQuotesAndSlashes` to become allocation free in the 99% case (it's just a slicing operation now, not a string allocation). The hot paths in our parsing were updated to employ these techniques. The one downside of the change is that I had to touch virtually every `case "someOption"` where the option value was used. The value is now held in a `ReadOnlyMemory<char>` until it's actually needed as a `string`. Hence every one of these cases either needed to use the new `ReadOnlyMemory<char>` APIs or force the allocation of the `string`. That made the change longer than I would've liked but it's also fairly mechanical. To test out the changes I created a benchmark which parsed a couple of command lines: - Command line for building Microsoft.CodeAnalysis.CSharp - Command line for a simple razor app The results are below and represent a significant win in both allocations and in simple performance. There are a few more places we could get some wins but getting into the realm of diminishing returns at this point. Before | Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |-------------------------------- |-----------:|---------:|---------:|---------:|---------:|------:|----------:| | ParseCSharpCompilerCommandLine | 1,101.9 us | 16.05 us | 14.23 us | 242.1875 | 80.0781 | - | 876 KB | | ParseCSharpCompilerResponseFile | 1,916.7 us | 18.26 us | 14.26 us | 353.5156 | 175.7813 | - | 2,082 KB | | ParseRazorCompilerCommandLine | 467.3 us | 2.27 us | 2.02 us | 350.5859 | 53.7109 | - | 571 KB | | ParseRazorCompilerResponseFile | 850.6 us | 8.09 us | 7.17 us | 327.1484 | 102.5391 | - | 953 KB | After | Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |-------------------------------- |-----------:|---------:|---------:|---------:|--------:|------:|----------:| | ParseCSharpCompilerCommandLine | 771.7 us | 15.09 us | 19.62 us | 109.3750 | 20.5078 | - | 200 KB | | ParseCSharpCompilerResponseFile | 2,094.4 us | 20.04 us | 18.74 us | 105.4688 | 39.0625 | - | 551 KB | | ParseRazorCompilerCommandLine | 249.5 us | 2.49 us | 2.33 us | 77.6367 | 14.6484 | - | 136 KB | | ParseRazorCompilerResponseFile | 710.1 us | 5.97 us | 5.29 us | 88.8672 | 24.4141 | - | 251 KB | closses dotnet#53570 * Progress * Response file parsing * Fix build error * PR feedback * Linux test failure * Fix test crash * PR feedback * Parse response file wins * Update src/Compilers/Core/Portable/CommandLine/CommandLineParser.cs Co-authored-by: Fred Silberberg <fred@silberberg.xyz> * Fixed build correctness issue Co-authored-by: Fred Silberberg <fred@silberberg.xyz>

…54320)

Test argument completion triggers with non-empty arguments

* Details pane no longer showing on click * Did not support dark theme * Switching themes does not update the highlight brush * Selection highlight wasn't working for single character items

…hemes Update value tracking to fix a number of UI issues. Details pane no longer showing on click Did not support dark theme Switching themes does not update the highlight brush Selection highlight wasn't working for single character items

Update FAR engine to be able to work without having access to all projects at the same time.

Fixes AB#1353715

Bump Roslyn version for VS 16.11 preview 4 release

…e/dev17.0

Avoid computing unused values in lsif

Change feature flag title

…o-release/dev17.0 Merge release/dev16.11 to release/dev17.0

…o-release/dev16.11-vs-deps Merge release/dev16.11 to release/dev16.11-vs-deps

…-main Merge release/dev17.0 to main

…-release/dev17.0-vs-deps Merge release/dev17.0 to release/dev17.0-vs-deps

Ensure option persisters are available before taking a lock

[main] Update dependencies from dotnet/source-build

… merges/release/dev16.11-vs-deps-to-release/dev17.0-vs-deps

…s-deps-to-release/dev17.0-vs-deps Merge release/dev16.11-vs-deps to release/dev17.0-vs-deps

Add async modifier on await completion

dotnet#54874) This reverts commit debd668, reversing changes made to 9087236.

… 20210716.1 (dotnet#54895) [main] Update dependencies from dotnet/source-build

…t#54910)

…issue 48291 (dotnet#54911)

…719.1 (dotnet#54917) [main] Update dependencies from dotnet/roslyn

dotnet#54761) Co-authored-by: Jason Malinowski <jason@jason-m.com>

…cesAddUsings Fix 'add using' with file scoped namespaces

…ceUseAutoProp Fix 'use auto property' with file scoped namespaces

* Expose output kinds - Make output kinds public - Take a parameter during construction - Don't run outputs passed in as disabled to the generator

…cesSuggestionCompletion Fix 'completion suggestion mode' with file scoped namespaces

…cesKeywordRecommenders Fix 'keyword recommenders' with file scoped namespaces

…cesConvertAnonymousType Fix 'convert anonymous type' with file scoped namespaces

…cesConvertTupleToStruct Fix 'convert tuple to struct' with file scoped namespaces

…cesSimplifyTypeNames Fix 'simplify type names' with file scoped namespaces

…cesLineSeparators Fix 'line separators' with file scoped namespaces

Fix NuGet warnings with VS17 preview 2 packages

Small refactor of BoundBinaryOperator to put uncommon fields in a separate data holder ahead of adding support for interpolated strings. There is no functional change in this PR.

Remove 'kind' from being part of a checksum

…cesClassification Fix 'syntactic classification' with file scoped namespaces

…ceSyntaxGenerator Fix 'syntax generator' with file scoped namespaces

…ginZoomLevelFix Make Inheritance Margin Zoom Level is divided by 100

…ceNameCompletion Fix 'name completion' with file scoped namespaces

…ation Remove dependency on Type.IsSerializable from OptionSet serialization

Don't combine 'this.' with underscore named fields

…eSortUsings Fix 'group usings' with file scoped namespaces

…eAddUsing Fix 'add extern alias' with file scoped namespaces

[main] Update dependencies from dotnet/source-build

* Pull Members Up adds Usings/Imports Add symbol annotations so that members pulled up will also include correct usings/imports. Add 12 new C# tests regarding pulling members up and import adding. * Change way to add symbol annotations, add test importing System.Linq and non-declared type * Working on adding using statements, tests failing * converted to language service to filter syntaxnode types, added more tests * Removed VB as there is no refactoring provider, passing tests * Remove add line to first member as elastic trivia already adds those lines * Re-added space for first member, only in case of no imports remaining in destination file * Fixed first member leading trivia and added a few comment tests, should just keep all leading trivia now. * Fixed line spacing issue * Updated to use syntax factory equivalence instead of just name equivalence, removed Distinct call, and refactored some language-agnostic code into abstract class as a private method * Remove unneccessary import * Refactored more functionality into abstract provider, added context node for namespace imports and added namespace & alias tests. * Update src/Features/Core/Portable/PullMemberUp/IMembersPullerService.cs Remove extra angle bracket. I thought I had done this, it must have been reverted somehow. Co-authored-by: Youssef Victor <youssefvictor00@gmail.com> * WIP * More refactoring, now adds imports for all containing namespaces, add more tests too for namespaces, aliases, and extensions. * Added documentation, changed namespace import generation, added nested namespace import test. * Reverted some line change tests, failing now because the formatter deleted a line that should probably stay there. * Replaced all trivia from source imports with elastic line trivia. Fixed an error with duplicating first member trivia. Fixed tests that expected duplicate first member trivia. * Removed initial whitespace line on moved imports as it forced extra newlines when they weren't necessary. * Refactor import getting into syntax facts, revert names/services back to before + refactor service usages * Rename in syntaxfacts to handle file scoped namespaces, add test to make sure we find those namespaces. Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>

…release/dev16.11-to-release/dev17.0

…o-release/dev17.0 Merge release/dev16.11 to release/dev17.0

…-release/dev17.0-vs-deps Merge release/dev17.0 to release/dev17.0-vs-deps

…-main Merge release/dev17.0 to main

…eMoveType

Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>

…ceMatchFolder Fix 'match folder and namespace' with file scoped namespaces

Remove file count limitation in server build

Merge `main` into `features/struct-ctors`

… EnC (dotnet#55012)

Merge `features/struct-ctors` into `main` branch

Notify Pythia when item is being committed

…ceMoveType Fix 'move type' with file scoped namespaces

…et#55049)

✨ Implement ImmutableSegmentedList<T>

…documents (dotnet#55054)

…o-main-p2 Merge release/dev17.0-vs-deps to main

…ceCodeModel Fix 'code model' with file scoped namespaces

# Conflicts: # src/Compilers/CSharp/Portable/Binder/Binder_Expressions.cs # src/Compilers/CSharp/Portable/Binder/Binder_Patterns.cs # src/Compilers/CSharp/Portable/Errors/MessageID.cs # src/Compilers/CSharp/Portable/FlowAnalysis/DefiniteAssignment.cs # src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter.cs # src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_AssignmentOperator.cs # src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_Call.cs # src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_FunctionPointerInvocation.cs # src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_IndexerAccess.cs # src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_ObjectOrCollectionInitializerExpression.cs # src/Compilers/CSharp/Portable/PublicAPI.Unshipped.txt # src/Compilers/CSharp/Portable/xlf/CSharpResources.cs.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.de.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.es.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.fr.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.it.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.ja.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.ko.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.pl.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.pt-BR.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.ru.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.tr.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.zh-Hans.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.zh-Hant.xlf # src/Compilers/Test/Utilities/CSharp/TestOptions.cs

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge main into features/list-patterns #55072

Merge main into features/list-patterns #55072

Commits on Jul 8, 2021

Commits on Jul 9, 2021

Commits on Jul 10, 2021

Commits on Jul 11, 2021

Commits on Jul 12, 2021

Commits on Jul 13, 2021

Commits on Jul 14, 2021

Commits on Jul 15, 2021

Commits on Jul 16, 2021

Commits on Jul 17, 2021

Commits on Jul 19, 2021

Commits on Jul 20, 2021

Commits on Jul 21, 2021

Commits on Jul 22, 2021

Commits on Jul 23, 2021