-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting up some lightweight automation for publishing docker images #1
base: master
Are you sure you want to change the base?
Commits on May 10, 2022
-
Fill domainID for backwards compatibility (uber#4819)
* Fill domainID for backwards compatibility * Added unit test
Configuration menu - View commit details
-
Copy full SHA for eede466 - Browse repository at this point
Copy the full SHA eede466View commit details
Commits on May 11, 2022
-
Log error fields as tags (uber#4801)
* Log error fields as tags * Update common/log/loggerimpl/logger.go Co-authored-by: Steven L <stevenl@uber.com> * Fix syntax error * Use zap ObjectMarshaler for nested fields Co-authored-by: Steven L <stevenl@uber.com>
Configuration menu - View commit details
-
Copy full SHA for a51b613 - Browse repository at this point
Copy the full SHA a51b613View commit details -
Configuration menu - View commit details
-
Copy full SHA for 400bbe4 - Browse repository at this point
Copy the full SHA 400bbe4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45770c2 - Browse repository at this point
Copy the full SHA 45770c2View commit details
Commits on May 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4194b29 - Browse repository at this point
Copy the full SHA 4194b29View commit details
Commits on May 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ee5461b - Browse repository at this point
Copy the full SHA ee5461bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a37a8b - Browse repository at this point
Copy the full SHA 0a37a8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d21162d - Browse repository at this point
Copy the full SHA d21162dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94fd0a6 - Browse repository at this point
Copy the full SHA 94fd0a6View commit details
Commits on May 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b03d03e - Browse repository at this point
Copy the full SHA b03d03eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fbfafb9 - Browse repository at this point
Copy the full SHA fbfafb9View commit details
Commits on May 19, 2022
-
Forward activity responses and heartbeats on failover as well (uber#4823
) We have a user desiring this, and in general it seems like a good idea. Activities are generally assumed to be "high cost" to lose, or at least potentially. Longer term, we should probably consider making this a per-domain config, rather than something that is hardcoded for a whole cluster. Nothing about this seems like it would be cluster-bound.
Configuration menu - View commit details
-
Copy full SHA for 20329a2 - Browse repository at this point
Copy the full SHA 20329a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a575908 - Browse repository at this point
Copy the full SHA a575908View commit details -
Removing target-domain-not-active special-case handling (uber#4835)
The suspicion is that this is not actually a transient and retriable error, so this should be handled differently
Configuration menu - View commit details
-
Copy full SHA for beab75c - Browse repository at this point
Copy the full SHA beab75cView commit details
Commits on May 20, 2022
-
Simplify history builder (uber#4837)
* Simplify history builder * Removed unused methods
Configuration menu - View commit details
-
Copy full SHA for 915a777 - Browse repository at this point
Copy the full SHA 915a777View commit details -
Configuration menu - View commit details
-
Copy full SHA for 535cda8 - Browse repository at this point
Copy the full SHA 535cda8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48a157e - Browse repository at this point
Copy the full SHA 48a157eView commit details
Commits on May 23, 2022
-
Bugfix/correct failover issue target domain not active ii (uber#4840)
* Removing target-domain-not-active special-case handling The suspicion is that this is not actually a transient and retriable error, so this should be handled differently * Fixing remaining non-retriable error * Fix test
Configuration menu - View commit details
-
Copy full SHA for a727049 - Browse repository at this point
Copy the full SHA a727049View commit details
Commits on May 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 856d33f - Browse repository at this point
Copy the full SHA 856d33fView commit details
Commits on May 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3cfcaea - Browse repository at this point
Copy the full SHA 3cfcaeaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 471e6d1 - Browse repository at this point
Copy the full SHA 471e6d1View commit details
Commits on May 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3a813e8 - Browse repository at this point
Copy the full SHA 3a813e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6ce732 - Browse repository at this point
Copy the full SHA c6ce732View commit details
Commits on May 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0582a58 - Browse repository at this point
Copy the full SHA 0582a58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15267b9 - Browse repository at this point
Copy the full SHA 15267b9View commit details -
Decouple domain cache entry from cluster metadata (uber#4847)
* Decouple domain cache entry from cluster metadata * Addressing comments * Fixing test
Configuration menu - View commit details
-
Copy full SHA for d6ae278 - Browse repository at this point
Copy the full SHA d6ae278View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12d8c54 - Browse repository at this point
Copy the full SHA 12d8c54View commit details
Commits on May 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b457b55 - Browse repository at this point
Copy the full SHA b457b55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2408f9d - Browse repository at this point
Copy the full SHA 2408f9dView commit details
Commits on Jun 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for af932bd - Browse repository at this point
Copy the full SHA af932bdView commit details
Commits on Jun 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7854f81 - Browse repository at this point
Copy the full SHA 7854f81View commit details -
Configuration menu - View commit details
-
Copy full SHA for bafdf15 - Browse repository at this point
Copy the full SHA bafdf15View commit details
Commits on Jun 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ae14412 - Browse repository at this point
Copy the full SHA ae14412View commit details
Commits on Jun 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 494f202 - Browse repository at this point
Copy the full SHA 494f202View commit details
Commits on Jun 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0930305 - Browse repository at this point
Copy the full SHA 0930305View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e6d122 - Browse repository at this point
Copy the full SHA 9e6d122View commit details
Commits on Jun 15, 2022
-
\adence-history does not emit continue-as-new metrics (uber#4866)
* CDNC-1746: cadence-history does not emit continue-as-new metrics - Emit metric when completing via ContinueAsNew - Emit metric and logs when completing via unknown type, so that we'll know in the future if there are more types we should emit metrics for * PR requests * Revert "PR requests" This reverts commit 832bcfe. * PR requests try2
Configuration menu - View commit details
-
Copy full SHA for 93bda8f - Browse repository at this point
Copy the full SHA 93bda8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50d331a - Browse repository at this point
Copy the full SHA 50d331aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e8a06cc - Browse repository at this point
Copy the full SHA e8a06ccView commit details
Commits on Jun 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 68fb2e6 - Browse repository at this point
Copy the full SHA 68fb2e6View commit details
Commits on Jun 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for dc5230f - Browse repository at this point
Copy the full SHA dc5230fView commit details
Commits on Jun 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 608bcb5 - Browse repository at this point
Copy the full SHA 608bcb5View commit details
Commits on Jun 22, 2022
-
Feature/adding canary for cross cluster -> readme patch (uber#4870)
* Adds cross-cluster canary * updating readme
Configuration menu - View commit details
-
Copy full SHA for e5ed7f7 - Browse repository at this point
Copy the full SHA e5ed7f7View commit details
Commits on Jun 24, 2022
-
Add support for changing the gocql connect timeout (uber#4874)
* Add support for changing the gocql connect timout * Fix comment typo
Configuration menu - View commit details
-
Copy full SHA for f133d3c - Browse repository at this point
Copy the full SHA f133d3cView commit details
Commits on Jun 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 83aa193 - Browse repository at this point
Copy the full SHA 83aa193View commit details
Commits on Jun 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6009044 - Browse repository at this point
Copy the full SHA 6009044View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f21900 - Browse repository at this point
Copy the full SHA 9f21900View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cfb741 - Browse repository at this point
Copy the full SHA 4cfb741View commit details
Commits on Jun 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for aff5ecf - Browse repository at this point
Copy the full SHA aff5ecfView commit details -
Refactor dynamic config (uber#4863)
* Refactor dynamic config * Change dynamic client interface
Configuration menu - View commit details
-
Copy full SHA for 650cf8a - Browse repository at this point
Copy the full SHA 650cf8aView commit details
Commits on Jun 30, 2022
-
Rename dockers default cluster name to match the other config files. (u…
…ber#4885) This allows an easy workflow for building/running a custom cadence server: docker-compose up, docker stop cadence, cadence-server start. Also add documentation of this workflow.
Configuration menu - View commit details
-
Copy full SHA for e9915ae - Browse repository at this point
Copy the full SHA e9915aeView commit details
Commits on Jul 2, 2022
-
Magically speed up integration tests by nearly 10x (uber#4892)
Delete 3 lines -> cut test suite time significantly! I feel productive. At this point, the biggest time cost seems to be coming from installing cqlsh, which is a bit longer than other portions of "build stuff so we can run stuff".
Configuration menu - View commit details
-
Copy full SHA for 691bf3f - Browse repository at this point
Copy the full SHA 691bf3fView commit details
Commits on Jul 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ac10760 - Browse repository at this point
Copy the full SHA ac10760View commit details
Commits on Jul 5, 2022
-
Removed replication mocks (uber#4883)
* Removed replication mocks * Ensure fakeTaskExecutor was called
Configuration menu - View commit details
-
Copy full SHA for 354e6b0 - Browse repository at this point
Copy the full SHA 354e6b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 663a041 - Browse repository at this point
Copy the full SHA 663a041View commit details -
Add helper function to list all dynamic config keys used in production (
uber#4891) Co-authored-by: David Porter <david.porter@uber.com>
Configuration menu - View commit details
-
Copy full SHA for 9d45241 - Browse repository at this point
Copy the full SHA 9d45241View commit details -
upgrade go version to 1.17 in go mod and Buildkite dockerfile (uber#4889
Configuration menu - View commit details
-
Copy full SHA for 6f9e2d9 - Browse repository at this point
Copy the full SHA 6f9e2d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfd637e - Browse repository at this point
Copy the full SHA cfd637eView commit details
Commits on Jul 6, 2022
-
Minor makefile cleanup, verbose CI, fmt with a recent Go version (ube…
…r#4896) * Minor makefile cleanup, verbose CI, fmt with a recent Go version Due to some unnecessary complexity troubleshooting a buildkite failure recently, I'm declaring "no more @ use", period. Knowing the full command that has failed is extremely useful, and this is an easy way to achieve it. Also: - made some vars slightly more readable? - make the Makefile verbose in all buildkite jobs - `make fmt` with Go 1.18 because it apparently changes goimports' behavior. older Go versions do not undo this, so it should be stable.
Configuration menu - View commit details
-
Copy full SHA for de09926 - Browse repository at this point
Copy the full SHA de09926View commit details -
Separating tools dependencies from main dependencies (uber#4895)
Adding gowrap in uber#4879 pulled in an additional *30MB* of dependencies, which is pretty ridiculous. It's happening because, while gowrap uses a tools-tagged `tools.go`, it's in the same module as everything else, so its dependencies are pulled in too, because Go has no way to tell that it's not needed by callers (it needs to consider ALL tags). We're doing the same thing. Granted, we're an application and not a library, but it still seems kinda unnecessary. And it forces upgrades we may not want to force (yet). So this moves tools.go to a new package, sets up a new go.mod file just for it, and adds a bit of automation to prevent it from drifting too far from the main module. With this, `go mod tidy` in the top level does not consider tools-dependencies any more, so we actually *remove* some, and do not add tons more for gowrap/etc in the future. --- internal/tools is just because it needs to be in a separate package, and "tools" was taken. plus nobody should ever import it, so it should be a clear "dependency dead-end" for tools.
Configuration menu - View commit details
-
Copy full SHA for ed2beb2 - Browse repository at this point
Copy the full SHA ed2beb2View commit details -
[codegen] introduce gowrap for generating retryableClient (uber#4879)
* introduce gowrap for decorator generation * go mod tidy -go=1.16 && go mod tidy -go=1.17
Configuration menu - View commit details
-
Copy full SHA for 7da6bc0 - Browse repository at this point
Copy the full SHA 7da6bc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f8c93a - Browse repository at this point
Copy the full SHA 1f8c93aView commit details
Commits on Jul 16, 2022
-
Add JitterDelay option when creating workflows. (uber#4886)
* Add JitterDelay option when creating workflows. * Update idls * getting jitter to work with cron * Update IDL Co-authored-by: David Porter <david.porter@uber.com>
Configuration menu - View commit details
-
Copy full SHA for 8c449b3 - Browse repository at this point
Copy the full SHA 8c449b3View commit details -
Add new es record for uninitialized workflow execution (uber#4899)
* Add new es record for uninitialized workflow (uber#2386) * Add nil check for visibility manager when adding uninitialized wf execution record (uber#2386) * Update TestProcessRecordWorkflowStartedTask to include unit test for record wf execution uninitialized method * Fix the test add method of es processor (uber#2386) * Disable the feature by default (uber#2386) * Fix the unit test when feature is disabled * Fix the unit test when feature is disabled (uber#2386)
Configuration menu - View commit details
-
Copy full SHA for 64cb46f - Browse repository at this point
Copy the full SHA 64cb46fView commit details
Commits on Jul 18, 2022
-
Capture CassandraLWT error and log/bump metrics for it. (uber#4888)
Capture DB Unavailable errors and log/bump metrics for it.
Configuration menu - View commit details
-
Copy full SHA for b0d1f06 - Browse repository at this point
Copy the full SHA b0d1f06View commit details -
Add new CI step for lint validation (uber#4903)
* fix lint error * add new CI step for lint * commit change after lint * add missing dependency of makefile rule * address comments: remove excessive artifact paths
Configuration menu - View commit details
-
Copy full SHA for 25e221b - Browse repository at this point
Copy the full SHA 25e221bView commit details -
Fix flaky retrypolicy tests. (uber#4905)
* Fix flaky retry tests. - Use random seed in test suite to hit the flakiness easier. - Adjust 2 tests to use the correct remaining times (which I found by instrumenting the code to print out the actual remaining time for the expiration interval.)
Configuration menu - View commit details
-
Copy full SHA for d2f72d8 - Browse repository at this point
Copy the full SHA d2f72d8View commit details -
Update EnableRecordWorkflowExecutionUninitialized flag to filter by d…
Configuration menu - View commit details
-
Copy full SHA for 8845d97 - Browse repository at this point
Copy the full SHA 8845d97View commit details
Commits on Jul 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 52203ab - Browse repository at this point
Copy the full SHA 52203abView commit details -
Standardizing cancellation behavior: a canceled workflow never starts…
… a new run (uber#4898) # Summary for busy people Workflow cancellation was kinda weird and confusing, and left some awful, unrecoverable, and un-*preventable* edge cases (particularly with child workflows). It also left users with no way to reliably stop work, aside from termination. Termination is inherently "unclean" and risky, so it should not be required to achieve something outside exceptional circumstances where recovery is not possible. This commit changes that: cancellation is now "sticky", and a canceled workflow does not ever trigger a new run after it completes, regardless of how it completes, so it can be used as a reliable "stop processing after cleanup" tool. The final state of a canceled workflow's run is now *always* a successful completion with a value, canceled, or timed out. (termination remains always "terminated") A canceled workflow can still start and abandon child workflows, so all current behavior with retries / continue as new / etc can be replicated with child workflows if desired. A fair bit of (not very complex) additional work here and in nearly all other repos is required to truly complete this, but it is *functional* and non-optional with this commit alone. In particular, adding a dynamic config to (temporarily!) restore old behavior should be fairly easy if it proves to be needed. # More details and motivation Part 1 of [many, tbd, in multiple repos] involved in changing workflow cancellation to reliably end workflows. Tests will be coming soon, for now I'm using a fairly simple set of workflows and checking the resulting histories exhaustively by hand. The primary motivation for these changes is to address some impossible-to-recover-from scenarios when canceling child workflows. After further exploration and discussion we've realized that, without these changes, there is *no reliable way* to stop a sequence of workflows without relying on termination, which we consistently treat as a fallback / impure-but-necessary ultimate hammer. Workflows should not *need* to rely on termination to achieve a desired behavior. With these changes, cancellation becomes capable of *guaranteeing* that workflows end within some finite time, which is a unique ability and makes it much more consistent and reliable. Turning this into a "complete" change will require quite a few tests, documentation changes, client-side changes (to allow recording more info, and likely changing test suites), and some smallish database and maybe RPC changes (to hold/return more data in cancellation errors). We are also not currently planning on making this configurable. It's seen as a correction of an under-specified and somewhat flawed chunk of behavior, more than "a change". Existing workflows will not experience replay errors, but it is still a substantial *semantic* change, though from what we have seen cancellation is relatively rarely used (partly due to its complex behavior). If issues are encountered / if users end up needing it, it should be fairly easy to add a per-domain/tasklist/workflow type configuration value, but it will be opt-*out*, not opt-*in*. # What was happening Previously, workflow behavior on cancellation was pretty frequently surprising to our users, arguably inconsistent, and not very well documented: | **PREVIOUS** | **simple** | **retry** | **cron** | **retry+cron** | |--------------:|--------------------------|-------------------------------------------|-----------------------------------------|---------------------------------------------------| | **success** | success | success | success<br>continue cron<br>cron | success<br>continue cron<br>cron<br>retry | | **cancel** | canceled | canceled | canceled | canceled | | **retryable** | (n/a, fatal) | continue retry<br>retry<br>recorded error | (n/a, fatal) | continue retry<br>cron<br>retry<br>recorded error | | **fatal** | failed<br>recorded error | failed<br>recorded error | continue cron<br>cron<br>recorded error | continue cron<br>cron<br>retry<br>recorded error | | **continue** | continue immediately | continue immediately<br>retry | continue immediately | continue immediately<br>retry | | **timeout** | timeout | continue retry<br>retry<br>recorded error | continue cron<br>cron<br>recorded error | continue retry<br>cron<br>retry<br>recorded error | A legend is: - success / etc shows the final state of the canceled run (success = completed with a value that can be retrieved) - "continue X" covers what source is used to compute the next run's starting delay (cron, retry, or no delay) - "cron" / "retry" shows whether or not cron/retry configuration is carried over to the new run - note that cron is lost by default with continue-as-new - and "recorded error" is whether or not the returned error is saved in its entirety (type + reason + details) This largely summarizes as "cancellation works when you end with the canceled-context error", say from `ctx.Err()`, otherwise it behaves like normal (or nearly) and many scenarios will start a new run. That's somewhat reasonable, but it's fairly "fragile" (it depends on what you return, and there are *many* ways for code to return some other error), and most importantly it means *there is no reliable way to stop a workflow* except to terminate it. That has severe consequences in at least two scenarios: 1. When termination is *unsafe* 2. When a parent workflow cancels a child by canceling its context For 1, for manual cancellations it's potentially reasonable to just terminate a run that begins after a successful cancel... but in principle if you're using cancellation it implies that termination is *not* desired, and potentially not safe to do. Canceling may result in a brand new run that immediately starts new behavior, leaving you with no safe window to terminate and not leave bad state lingering. So users wanting a safe way to stop a sequence of workflows have no reliable way to do so. For 2, it puts parent+child workflows in an extremely awkward, and essentially unrecoverable scenario. Cancellation is a *one time event*, and as far as the parent is concerned, if the child/its context is canceled, the child is canceled... ...but if the child then starts a new run for *any* reason (retry, cron, reset, etc), that new run is no longer canceled. The parent has no way to know this has happened, and has no way to *re*-cancel the new child, so it can easily lead to the collection of workflows getting into an impossible state that it never recovers from. Both cases are able to lead to unreliable behavior which can only use termination to stop, and for which no "safe" option exists. After reviewing some customer issues and desires and thinking about things, we've settled on "cancel should guarantee that things stop". Not necessarily in a timely manner, but that's fine. And if a workflow wants to run behavior longer or larger than its current run can achieve, it has a workaround: start a new (likely child) workflow to do the cleanup. # What happens now So that's what this PR does, in a minimal / to-be-polished way so we can start running it for our stuck users while we flesh out tests and change other behaviors. Currently that means our cancellation behavior is now: | **CURRENT** | **simple** | **retry** | **cron** | **retry+cron** | |--------------:|-------------------------------------------|-------------------------------------------|-------------------------------------------|-------------------------------------------| | **success** | success | success | success | success | | **cancel** | canceled | canceled | canceled | canceled | | **retryable** | (n/a, fatal) | canceled<br>recorded error (details only) | (n/a, fatal) | canceled<br>recorded error (details only) | | **fatal** | canceled<br>recorded error (details only) | canceled<br>recorded error (details only) | canceled<br>recorded error (details only) | canceled<br>recorded error (details only) | | **continue** | canceled<br>(no details) | canceled<br>(no details) | canceled<br>(no details) | canceled<br>(no details) | | **timeout** | timeout | timeout | timeout | timeout | And the new "details" entries cover whether or not an error's "details" (the custom encoded data, not reason or type) are saved. Unfortunately the current cancellation event (and clients' API) does not allow recording all data, or any in some cases, so the original reason/message and error type are lost and are replaced with a canceled error. Now, cancellation *always* ends workflows with the current run. Returning a value will return that value, including in cron scenarios, timeouts are still timeouts (and they imply a possibly un-clean termination), and _all_ errors or attempts to continue-as-new will instead result in a canceled state. # Future changes to make to finish this effort With further changes to the clients and RPC/storage models, canceled errors will store more details about what was returned. E.g. continue-as-new does not record what was *attempted* to be started, and other error types lose their "reason" (i.e. the message) and type but not details. Pretty clearly this is sub-par, and we should be capable of reporting the actual return in full so it can be retrieved if needed. This is also why returning a value now always ends in a completed state, so successful completions do not lose those values. Prior to merging into master / a release, we may end up making this configurable (likely with a default of opt-out), to address both the sub-par information recording and the semantically-breaking behavior change. Docs changes are also due, as well as some integration tests, client library changes (e.g. to make sure the test suite reflects the new behavior), etc. Another gap to plug is that resetting a workflow does not "forward" the canceled state to the new run. We should probably be treating cancellation like we do signals: cancel the new run if the current run is canceled. This will ensure that you can reset a child and retain the parent's cancellation, so it'll very likely become the default behavior, but we'll allow overriding it. Resets are manual actions, they can break the rules if desired. And they can just manually cancel later if they decide they do want it. And last and perhaps least: it's quite strange that continue-as-new does not retain cron config. At least from the Go client. I suspect it's just not adding to / pulling from the context correctly.
Configuration menu - View commit details
-
Copy full SHA for add4b39 - Browse repository at this point
Copy the full SHA add4b39View commit details -
Start fixing server lint warnings (uber#4909)
* Fix minor lint issue: [indent-error-flow] if block ends with a return statement, so drop this else and outdent its block * Fix lint warning: [var-naming] struct field WorkflowId should be WorkflowID * Fix lint warning: [receiver-naming] receiver name m should be consistent with previous receiver name n for noopClientImpl * Fix lint warning: [range-val-address] suspicious assignment of 't'. range-loop variables always have the same address For this one, I created a Go playground test to ensure the right values are being appended. Because we're appending the address of t.TransferTask (instead of just t), this is safe. * Make it an error to disable a revive warning without specifying a reason * Ignore '[defer] recover must be called inside a deferred function': callers are being called using defer and I don't see a better way to do it.
Configuration menu - View commit details
-
Copy full SHA for 8b42a6d - Browse repository at this point
Copy the full SHA 8b42a6dView commit details
Commits on Jul 23, 2022
-
Addition of DomainTag to required functions for the creation of metri…
…cs required for Domain Cost Attribution (uber#4908) * Update RecordWorkflowExecutionStarted method to create a metrics by adding a domain tag * add domaing tag to the metrics file recordworkflowexecutionstarted method * Updated all functions in esVisibilityMetricClients.go with additon of domainId to create metrics * Added DomainId changes in the functions of esVisibilityMetricClient.go file * Added DomainId changes in the functions of esVisibilityMetricClient.go file * Added DomainId changes in the functions of esVisibilityMetricClient.go file * Added DomainId changes in the functions of esVisibilityMetricClient.go file * Added the change to map domainName to domainID in DeleteWorkflowExecution in esVisibilityMetricClients.go file * Added the change to map domainName to domainID in DeleteWorkflowExecution in esVisibilityMetricClients.go file * Added the change to map domainName to domainID in DeleteWorkflowExecution in esVisibilityMetricClients.go file * Added domain to the VisibilityDeleteWorkflowExecutionRequest to all the implementing and in definition * Added domain to the VisibilityDeleteWorkflowExecutionRequest to all the implementing and in definition * Added domain to the VisibilityDeleteWorkflowExecutionRequest to all the implementing and in definition * Removed Domain field from serialization file : empty data field * Removed Domain field from thrift_mapper_test.go : added unknown field,not used * Remove Domain tag from newTimerTaskFromInfo : extra field,not used * Added mock behaviour to match with real behaviour in time_task_executor_base_test.go * Ran linter and removed a comment
Configuration menu - View commit details
-
Copy full SHA for c3f7bd3 - Browse repository at this point
Copy the full SHA c3f7bd3View commit details -
Fix remaining server lint warnings and make lint error by default. (u…
…ber#4911) * Minor text changes while reading this file * Ignore lint warning: [defer] recover must be called inside a deferred function * Fix lint warning: [var-naming] func parameter startedShardId should be startedShardID * Fix lint warnings: [context-as-argument] context.Context should be the first parameter of a function * Fix lint warning: [receiver-naming] receiver name mdb should be consistent with previous receiver name pdb for db * Fix lint warning: [indent-error-flow] if block ends with a return statement, so drop this else and outdent its block * Fix lint warning: [context-as-argument] context.Context should be the first parameter of a function * Fix lint warning: [unexported-return] exported func NewDNSPeerChooserFactory returns unexported type *rpc.dnsPeerChooserFactory, which can be annoying to use - Return interface instead of impl - Remove small piece of test that was testing impl. * Make lint (revive) error by default. - Use stylish formatter which looks cool (let me know if this is going to break something in CI) - Don't exclude canary because there doesn't seem to be a good reason to. - Don't sort at the end, because we shouldn't have a huge list and we need the error code. * Fix build error - move ctx to new position
Configuration menu - View commit details
-
Copy full SHA for c06649e - Browse repository at this point
Copy the full SHA c06649eView commit details
Commits on Jul 26, 2022
-
Replace unsafe usage of recover() in helper functions (uber#4913)
We decided that our usage of helper functions when using defer/recover was too brittle, since one too many functions causes recover() not to do the right thing in Go. Switching to this idiom, where the defer caller also calls recover() ensures that we will get the right result from recover(), but also lets us continue to use the helper functions to deduplicate the code that runs after recover().
Configuration menu - View commit details
-
Copy full SHA for 82544de - Browse repository at this point
Copy the full SHA 82544deView commit details -
Update revive to catch more defer/recover badness (uber#4917)
* Update to latest version of revive that includes Steven's change to find more defer/recover badness. mgechev/revive#719 * Ignore 158 new warnings about package-comments. * Add Steven's new immediate-recover linter. - Verified this would have caught the previous mistakes I made (woohoo!)
Configuration menu - View commit details
-
Copy full SHA for ef8d11e - Browse repository at this point
Copy the full SHA ef8d11eView commit details
Commits on Jul 27, 2022
-
downgrade testify to fix monorepo (uber#4918)
downgrade testify to fix monorepo
Configuration menu - View commit details
-
Copy full SHA for 43a17d2 - Browse repository at this point
Copy the full SHA 43a17d2View commit details
Commits on Jul 28, 2022
-
Fix query workflow high latency after a long inactive time (uber#4871)
* Fix query workflow high latency after a long inactive time * Add new client integration test
Configuration menu - View commit details
-
Copy full SHA for a4d77f5 - Browse repository at this point
Copy the full SHA a4d77f5View commit details
Commits on Aug 2, 2022
-
CDNC-1781 Add restart command/api (uber#4900)
CDNC-1781 restart cli command
Configuration menu - View commit details
-
Copy full SHA for e5036ed - Browse repository at this point
Copy the full SHA e5036edView commit details
Commits on Aug 3, 2022
-
Adding DomainTag to the Persistence metrics client (uber#4922)
* Update RecordWorkflowExecutionStarted method to create a metrics by adding a domain tag * added domain tag to the metrics file recordworkflowexecutionstarted method * Updated all functions in esVisibilityMetricClients.go with addition of domainId to create metrics * Added DomainId changes in the functions of esVisibilityMetricClient.go file * Added DomainId changes in the functions of esVisibilityMetricClient.go file * Added DomainId changes in the functions of esVisibilityMetricClient.go file * Added DomainId changes in the functions of esVisibilityMetricClient.go file * Added the change to map domainName to domainID in DeleteWorkflowExecution in esVisibilityMetricClients.go file * Added the change to map domainName to domainID in DeleteWorkflowExecution in esVisibilityMetricClients.go file * Added the change to map domainName to domainID in DeleteWorkflowExecution in esVisibilityMetricClients.go file * Added domain to the VisibilityDeleteWorkflowExecutionRequest to all the implementing and in definition * Added domain to the VisibilityDeleteWorkflowExecutionRequest to all the implementing and in definition * Added domain to the VisibilityDeleteWorkflowExecutionRequest to all the implementing and in definition * Removed Domain field from serialization file : empty data field * Removed Domain field from thrift_mapper_test.go : added unknown field: not used * Remove Domain tag from newTimerTaskFromInfo : extra field :not used * Added mock behavior to match with real behavior in time_task_executor_base_test.go * Ran linter and removed a comment * Changed ReadHistoryBranch,AppendHistoryNodes,call and the previous flows from persistenceMetricClients.go w/o mocks change * Removed else statement as there was an return statement in if * removed unnecessary comments * Removed extra spaces * removed space * Changes in persistenceMetricClients.go * Added Domain Name in Mock * Added DomainName to testing file changes * Changes after review : before mocks * After linting * linter change * Added mock for domainCache in historyExist_test * Added metrics.Tag type to call instead of generic string type * return 0 instead of -1 as per suggestion in context.go * Changed call, and added mocks correct implementation * Changed call, and added mocks correct implementation: With linter * Added mock to task_ac_manager_test.go * Added mock to task_ac_manager_test.go: with linter * Remove redundant mocks from adminHandler_test.go
Configuration menu - View commit details
-
Copy full SHA for 6cf4252 - Browse repository at this point
Copy the full SHA 6cf4252View commit details -
Adding DomainTag to the ForkHistoryBranch, ReadRawHistoryBranch and R…
…eadHistoryBranchByBatch (uber#4926) * ada * Update RecordWorkflowExecutionStarted method to create a metrics by adding a domain tag * add domaing tag to the metrics file recordworkflowexecutionstarted method * Updated all functions in esVisibilityMetricClients.go with additon of domainId to create metrics * Added DomainId changes in the functions of esVisibilityMetricClient.go file * Added DomainId changes in the functions of esVisibilityMetricClient.go file * Added DomainId changes in the functions of esVisibilityMetricClient.go file * Added DomainId changes in the functions of esVisibilityMetricClient.go file * Added the change to map domainName to domainID in DeleteWorkflowExecution in esVisibilityMetricClients.go file * Added the change to map domainName to domainID in DeleteWorkflowExecution in esVisibilityMetricClients.go file * Added the change to map domainName to domainID in DeleteWorkflowExecution in esVisibilityMetricClients.go file * Added domain to the VisibilityDeleteWorkflowExecutionRequest to all the implementing and in definition * Added domain to the VisibilityDeleteWorkflowExecutionRequest to all the implementing and in definition * Added domain to the VisibilityDeleteWorkflowExecutionRequest to all the implementing and in definition * Removed Domain field from serialization file : empty data field * Removed Domain field from thrift_mapper_test.go : added unknown field,not used * Remove Domain tag from newTimerTaskFromInfo : extra field,not used * Added mock behaviour to match with real behaviour in time_task_executor_base_test.go * Ran linter and removed a comment * Changed ReadHistoryBranch,AppendHistoryNodes,call and the previous flows from persistenceMetricClients.go w/o mocks change * Removed else statement as there was an return statement in if * removed unnecessary comments * Removed extra spaces * removed space * Changes in persistenceMetricClients.go * Added Domain Name in Mock * Added DomainName to testing file changes * Changes after review : before mocks * After linting * linter change * Added mock for domainCache in historyExist_test * Added metrics.Tag type to call instead of generic string type * return 0 instead of -1 as per suggestion in context.go * Changed call, and added mocks correct implementation * Changed call, and added mocks correct implementation: With linter * Added mock to task_ac_manager_test.go * Added mock to task_ac_manager_test.go: with linter * Remove redundant mocks from adminHandler_test.go * Changes from central master * Changed call method in ReadHistoryBranchByBatch and ReadRawHistoryBranch * Added changes to forkHistory mocks and backtracked methods * Added changes to forkHistory mocks and backtracked methods * Module files update automatic
Configuration menu - View commit details
-
Copy full SHA for b34f4e4 - Browse repository at this point
Copy the full SHA b34f4e4View commit details
Commits on Aug 5, 2022
-
Changed DeleteHistoryBranch and GetHistoryTree by adding Domain Tag w…
…ith mocks (uber#4928) * ada * Update RecordWorkflowExecutionStarted method to create a metrics by adding a domain tag * add domaing tag to the metrics file recordworkflowexecutionstarted method * Updated all functions in esVisibilityMetricClients.go with additon of domainId to create metrics * Added DomainId changes in the functions of esVisibilityMetricClient.go file * Added DomainId changes in the functions of esVisibilityMetricClient.go file * Added DomainId changes in the functions of esVisibilityMetricClient.go file * Added DomainId changes in the functions of esVisibilityMetricClient.go file * Added the change to map domainName to domainID in DeleteWorkflowExecution in esVisibilityMetricClients.go file * Added the change to map domainName to domainID in DeleteWorkflowExecution in esVisibilityMetricClients.go file * Added the change to map domainName to domainID in DeleteWorkflowExecution in esVisibilityMetricClients.go file * Added domain to the VisibilityDeleteWorkflowExecutionRequest to all the implementing and in definition * Added domain to the VisibilityDeleteWorkflowExecutionRequest to all the implementing and in definition * Added domain to the VisibilityDeleteWorkflowExecutionRequest to all the implementing and in definition * Removed Domain field from serialization file : empty data field * Removed Domain field from thrift_mapper_test.go : added unknown field,not used * Remove Domain tag from newTimerTaskFromInfo : extra field,not used * Added mock behaviour to match with real behaviour in time_task_executor_base_test.go * Ran linter and removed a comment * Changed ReadHistoryBranch,AppendHistoryNodes,call and the previous flows from persistenceMetricClients.go w/o mocks change * Removed else statement as there was an return statement in if * removed unnecessary comments * Removed extra spaces * removed space * Changes in persistenceMetricClients.go * Added Domain Name in Mock * Added DomainName to testing file changes * Changes after review : before mocks * After linting * linter change * Added mock for domainCache in historyExist_test * Added metrics.Tag type to call instead of generic string type * return 0 instead of -1 as per suggestion in context.go * Changed call, and added mocks correct implementation * Changed call, and added mocks correct implementation: With linter * Added mock to task_ac_manager_test.go * Added mock to task_ac_manager_test.go: with linter * Remove redundant mocks from adminHandler_test.go * Changes from central master * Changed call method in ReadHistoryBranchByBatch and ReadRawHistoryBranch * Added changes to forkHistory mocks and backtracked methods * Added changes to forkHistory mocks and backtracked methods * Module files update automatic * Changed DeleteHistoryBranch by adding Domain Tag with mocks * Added anyTimes to mock of timer_task_executor_base_test.go * Added changes to GetHistoryTree * Added changes to GetHistoryTree
Configuration menu - View commit details
-
Copy full SHA for c091a49 - Browse repository at this point
Copy the full SHA c091a49View commit details
Commits on Aug 9, 2022
-
Improve decode_thrift output (uber#4929)
The current output is not particularly useful for some types: ``` ❯ cadence admin db decode_thrift -i '590f000a0c000000010a000a00000000000000560a00141704bf217393afac08001e000000030a002300000000000000010a0024000000000dd674990c004608000a00000000000000' =======Decode into type shared.History ======== {Events:[len=1]} ``` Now it's much better: ``` ❯ cadence admin db decode_thrift -i '590f000a0c000000010a000a00000000000000560a00141708a948a26a263f08001e000000030a002300000000000000010a0024000000000d985dab0c004608000a00000000000000' ======= Decode into type shared.History ======== (*shared.History)(0xc0003fc588)(History{Events: [HistoryEvent{EventId: 86, Timestamp: 1659762592113632831, EventType: WorkflowExecutionTimedOut, Version: 1, TaskId: 228089259, WorkflowExecutionTimedOutEventAttributes: WorkflowExecutionTimedOutEventAttributes{TimeoutType: START_TO_CLOSE}}]}) ======= As JSON ======== {"events":[{"eventId":86,"timestamp":1659762592113632831,"eventType":"WorkflowExecutionTimedOut","version":1,"taskId":228089259,"workflowExecutionTimedOutEventAttributes":{"timeoutType":"START_TO_CLOSE"}}]} ```
Configuration menu - View commit details
-
Copy full SHA for 341d9f0 - Browse repository at this point
Copy the full SHA 341d9f0View commit details
Commits on Aug 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 85e0fee - Browse repository at this point
Copy the full SHA 85e0feeView commit details -
Added DomainTag changes to ReadHistory branch for readHistoryRequest,…
… CreateWorkflowRequest + added DomainCacheNoOp file (uber#4930) Why this change? - To add domain tag to persistenceMetricClients.go methods: ReadHistoryBranch, CreateWorkflowExecution What are the changes? - Added domainCacheNoOp file for no implementation of domainCache. Reason: Needed for tools/cli/adminDBCleanCommand.go and adminDBScanCommand.go and cli commands are not required for Cadence UI - Added mock in data_corruption_test - Added DomainName tag to readHistoryRequest - Added domainCache to ExecutionFixerActivity as it was needed for InvariantFactory Other alternatives: - Why not added cache to persistence.Retryer without adding another parameter for cache explicitly? Reason: There were so many calls for persistence.Retryer and and multiple assignments as well. Hence, it will increase the load on the system to have one more parameter added to the call and hence, might reduce speed. And, will increase time as well to make the change.
Configuration menu - View commit details
-
Copy full SHA for 2bb13a1 - Browse repository at this point
Copy the full SHA 2bb13a1View commit details -
Add List*Execution (ElasticSearch) API ratelimiters (uber#4925)
This is a re-implementation of uber#4916 that's compatible with the new dynamic config refactor, as there are enough changes that it wasn't worth trying to merge or cherry-pick. I've also made some minor improvements, e.g. added some more descriptions and used private types, but there is no behavior change from that PR. --- ES (and in general any kind of "bulk query" API) is a different resource and has quite different ratelimiting needs than other kinds of requests, so this separates the APIs and adds a new ratelimiter dynamic config. Since it kinda looked like we had something for this before, but it wasn't working, I dug around in the code and discovered that the existing limits are pretty wildly incorrectly used, or were actually completely unused. Those variables are now marked as deprecated for visibility, future changes should probably just remove them entirely (and/or correct them).
Configuration menu - View commit details
-
Copy full SHA for e3496a3 - Browse repository at this point
Copy the full SHA e3496a3View commit details
Commits on Aug 11, 2022
-
Refactor task ack manager (uber#4894)
* Simplified FindFirstVersionHistoryByItem * Refactored unit tests for TaskAckManager * Set SourceTaskID within each replication type * Remove getVersionHistoryItems helper function * Removed processReplication helper * Stop using getters * Minor renames and styling * Moved out hydration logic to separate task_hydrator.go * Moved hydrator tests out * Minor constructor changes * Simple Ptr() usage * Added timeToUnixNano helper * Simplify setting of time fieds * Added comments for exported names * Drop pointer for persistence.ReplicationTaskInfo * Added protection against nil mutable state * No need for copies within HydrateSyncActivityTask * Release workflow lock early when hydrating history * Minor code rearrangement * Move out logging without version histories * Separated HistoryLoader for loading history event blobs from db * Drop ReplicationTaskProcessorReadHistoryBatchSize config. We only page size of 2 ot most * Added MutableStateProvider * Do not expose internal interfaces * Remove toReplicationTask helper * No need for readTasksWithBatchSize helper and useless conversion to task.Info * Added fakeHistoryProvider * Added unit tests for history loader * Added unit tests for mutable state loader * Added TaskHydrator struct * Added DynamicTaskReader * Use DynamicTaskReader in TaskAckManager * Initialize metrics scope once in constructor * Move out domainCache to struct * Minor renaming * Added ackLevelStore interface * Stop accepting shard.Context in TaskAckManager * New unit tests for TaskAckManager * Minor styling * Fix test * Removed TaskAckManager interface * Moved variable * Removed unused struct field * Update licence years * Unit test for unknown replication task * Move out GetTask function to historyEngine itself * More test coverage * Regenerate mocks * Removed ReplicationTaskProcessorReadHistoryBatchSize from constants.go * Make sure workflow context is always released * Pass domainName
Configuration menu - View commit details
-
Copy full SHA for fe3bf0b - Browse repository at this point
Copy the full SHA fe3bf0bView commit details -
Adds more pertinent information about replication (uber#4931)
Debugging timeout failures in replication is presently quite annoying. Let's get more visibliity here. Co-authored-by: Steven L <stevenl@uber.com>
Configuration menu - View commit details
-
Copy full SHA for 385c1c3 - Browse repository at this point
Copy the full SHA 385c1c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b21f34f - Browse repository at this point
Copy the full SHA b21f34fView commit details
Commits on Aug 12, 2022
-
Added changes to GetWorkflowExecution and UpdateWorkflowExecution (ub…
…er#4938) What Changes? - Added changes to GetWorkflowExecution and UpdateWorkflowExecution - Removed DomainName from persistenceTestBase.go as it is not required : when did the changes it was showing error: over usage of Cassandra service error
Configuration menu - View commit details
-
Copy full SHA for 13a130b - Browse repository at this point
Copy the full SHA 13a130bView commit details -
adding reason to cancel workflow. (uber#4934)
* adding reason to cancel workflow.
Configuration menu - View commit details
-
Copy full SHA for f1c5578 - Browse repository at this point
Copy the full SHA f1c5578View commit details -
Added changes to ConflictWorkflowExecution and DeleteWorkflowExecution (
uber#4943) What changes? - Added changes to ConflictWorkflowExecution and DeleteWorkflowExecution present in persistenceMetricsClients.go - Changed domainName references: previously pointing to nil. (Reason: error coming in integration NDC tests)
Configuration menu - View commit details
-
Copy full SHA for 8c5f2ff - Browse repository at this point
Copy the full SHA 8c5f2ffView commit details
Commits on Aug 15, 2022
-
Added changes to DeleteCurrentWorkflowExecution and GetCurrentExecuti…
…on (uber#4944) What Changes? - Added changes to DeleteCurrentWorkflowExecution and GetCurrentExecution
Configuration menu - View commit details
-
Copy full SHA for b9b8b42 - Browse repository at this point
Copy the full SHA b9b8b42View commit details -
Added changes to PutReplicationTaskToDLQ and IsWorkflowExecutionExists (
uber#4946) What Changes? - Added changes to PutReplicationTaskToDLQ and IsWorkflowExecutionExists
Configuration menu - View commit details
-
Copy full SHA for e88a9c7 - Browse repository at this point
Copy the full SHA e88a9c7View commit details
Commits on Aug 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4c8013d - Browse repository at this point
Copy the full SHA 4c8013dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d739bf5 - Browse repository at this point
Copy the full SHA d739bf5View commit details -
Partial response of GetReplicationMessages on history service (uber#4935
Configuration menu - View commit details
-
Copy full SHA for 457c35e - Browse repository at this point
Copy the full SHA 457c35eView commit details -
Added domain Tag to UpdateTaskList,DeleteTaskList,LeaseTaskList,Compl…
…eteTask and CompleteTaskLessThan (uber#4950) What Changes? - Added domain Tag to UpdateTaskList, DeleteTaskList, LeaseTaskList, CompleteTask and CompleteTaskLessThan
Configuration menu - View commit details
-
Copy full SHA for d1965b1 - Browse repository at this point
Copy the full SHA d1965b1View commit details -
fix funcorder linter (uber#4942)
* fix funcorder linter * lint Co-authored-by: David Porter <david.porter@uber.com>
Configuration menu - View commit details
-
Copy full SHA for 7566018 - Browse repository at this point
Copy the full SHA 7566018View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9949a22 - Browse repository at this point
Copy the full SHA 9949a22View commit details
Commits on Aug 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0f59042 - Browse repository at this point
Copy the full SHA 0f59042View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2b2108 - Browse repository at this point
Copy the full SHA f2b2108View commit details
Commits on Aug 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d8cb61e - Browse repository at this point
Copy the full SHA d8cb61eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ecd1e4 - Browse repository at this point
Copy the full SHA 6ecd1e4View commit details
Commits on Aug 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 177f087 - Browse repository at this point
Copy the full SHA 177f087View commit details
Commits on Aug 23, 2022
-
Added domainName change to remaining functions of appendHistoryNodeRe…
…quest and RecordWorkflowExecutionUninitializedRequest (uber#4968) * Added domainName to context (one remaining change)
Configuration menu - View commit details
-
Copy full SHA for 76a025a - Browse repository at this point
Copy the full SHA 76a025aView commit details -
Adding limit for amount of pending activties in mutable state. (uber#…
…4959) * Adding limit for amount of pending activties in mutable state.
Configuration menu - View commit details
-
Copy full SHA for 701fb70 - Browse repository at this point
Copy the full SHA 701fb70View commit details -
Configuration menu - View commit details
-
Copy full SHA for e597b87 - Browse repository at this point
Copy the full SHA e597b87View commit details
Commits on Aug 24, 2022
-
Replication cache for sharing hydrated messages (uber#4952)
* Replication cache for sharing hydrated messages * Export ErrUnknownCluster * Tag shardID for TaskStore Co-authored-by: David Porter <david.porter@uber.com>
Configuration menu - View commit details
-
Copy full SHA for 1be9b6d - Browse repository at this point
Copy the full SHA 1be9b6dView commit details
Commits on Aug 25, 2022
-
Added changes to readHistoryBranchRequest (uber#4972)
-- Added changes to readHistoryBranchRequest by adding to the persistence-utils
Configuration menu - View commit details
-
Copy full SHA for e69dbd6 - Browse repository at this point
Copy the full SHA e69dbd6View commit details -
Return persisted history events blob (uber#4953)
* Return persisted history events blob * Fix after merge
Configuration menu - View commit details
-
Copy full SHA for 93a6f23 - Browse repository at this point
Copy the full SHA 93a6f23View commit details -
Adding first scheduled time metadata field for cron workflows. (uber#…
…4969) * Adding first scheduled time metadata field for cron workflows.
Configuration menu - View commit details
-
Copy full SHA for a91a250 - Browse repository at this point
Copy the full SHA a91a250View commit details -
Addition of domain tag for Replication task metric (uber#4974)
What Changed? -- Added changes to task_processor.go -- Added new metrics ReplicationTasksAppliedPerDomain
Configuration menu - View commit details
-
Copy full SHA for 88991f2 - Browse repository at this point
Copy the full SHA 88991f2View commit details
Commits on Aug 26, 2022
-
Addition of domainName tag to Replication task (uber#4975)
What changes? -- Added domain tag to replication task -- Added new metrics for replication task : replication_task_applied_per_domain
Configuration menu - View commit details
-
Copy full SHA for c8783f0 - Browse repository at this point
Copy the full SHA c8783f0View commit details
Commits on Aug 27, 2022
-
Fix docker image build, which has been broken since July 5th. Tested by building normally & via docker - both locally and in buildkite. - tcheck wasn't being found, but David and I agree that it seems unnecessary and doesn't seem to be used any more. - Bash wasn't found in the image, but is needed to run scripts/check-gomod-version.sh, so I added it to the alpine image. - During docker image build, the protoc binary had 644 permissions but needed to be executed so I added +x - During docker image build, the PROTO_OUT/uber/cadence directory doesn't exist, so we skip the cp/rm commands that fail otherwise.
Configuration menu - View commit details
-
Copy full SHA for 172abd6 - Browse repository at this point
Copy the full SHA 172abd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 854fc59 - Browse repository at this point
Copy the full SHA 854fc59View commit details
Commits on Aug 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2bca516 - Browse repository at this point
Copy the full SHA 2bca516View commit details
Commits on Aug 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 86f645d - Browse repository at this point
Copy the full SHA 86f645dView commit details -
Add Metric Emitter, which emits a metric once a minute for true repli…
…cation lag in nanoseconds. (uber#4979)
Configuration menu - View commit details
-
Copy full SHA for 5202eb3 - Browse repository at this point
Copy the full SHA 5202eb3View commit details -
Allow docker compose to work with docker-compose-mysql.yml on M1 (ube…
…r#4983) Trying to run this failed: docker-compose -f docker-compose-mysql.yml up Pulling mysql (mysql:5.7)... 5.7: Pulling from library/mysql ERROR: no matching manifest for linux/arm64/v8 in the manifest list entries Solution found here: https://stackoverflow.com/questions/65456814/docker-apple-silicon-m1-preview-mysql-no-matching-manifest-for-linux-arm64-v8
Configuration menu - View commit details
-
Copy full SHA for 22b87eb - Browse repository at this point
Copy the full SHA 22b87ebView commit details
Commits on Sep 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e4b0a83 - Browse repository at this point
Copy the full SHA e4b0a83View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8e9e96 - Browse repository at this point
Copy the full SHA a8e9e96View commit details -
Added logs for domainName empty situation (uber#4987)
What changes? -- Added logs for domainName if function returns an error while fetching domainName
Configuration menu - View commit details
-
Copy full SHA for d8624b2 - Browse repository at this point
Copy the full SHA d8624b2View commit details
Commits on Sep 2, 2022
-
Make test now passes locally (uber#4915)
Add test flags (controlled by environment variables) that are used to skip tests that have external dependencies. Tests call RequiresX() functions to mark that they depend on X to run. When tests cannot run because they require a dependency, they will be skipped and print out a message describing how to run that test (after starting your dependency.) In order to run tests marked with a dependency, you use the following environment variables: CASSANDRA, MYSQL, MONGODB, POSTGRES. So for example, to run tests that depend on Cassandra: CASSANDRA=1 make test
Configuration menu - View commit details
-
Copy full SHA for ae1e0a0 - Browse repository at this point
Copy the full SHA ae1e0a0View commit details -
Immediate replication task hydration after successful transaction (ub…
…er#4980) * Immediate replication task hydration after successful transaction * Regenerate mocks * Fixing tests * More test fixes * Test fixes * More comments and unit tests * Minor * Clean commit * Pass isRunning field to immediateMutableState * Addressing review comments
Configuration menu - View commit details
-
Copy full SHA for 3362f85 - Browse repository at this point
Copy the full SHA 3362f85View commit details
Commits on Sep 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c3beb64 - Browse repository at this point
Copy the full SHA c3beb64View commit details
Commits on Sep 8, 2022
-
Add domain_type and cluster_groups tags (uber#4990)
* Add domain_type tag * Add cluster_group tag
Configuration menu - View commit details
-
Copy full SHA for 5fd0127 - Browse repository at this point
Copy the full SHA 5fd0127View commit details
Commits on Sep 9, 2022
-
Add support of update time for Cassandra, Mysql and Postgres (uber#4971)
* Add support of update time for Cassandra, Mysql and Postgres (uber#2567) * Fix integration test * Fix one persistence test method * Fix mysql syntax error * Fix cassandra unit test * Add comment to explain unit of update timestamp
Configuration menu - View commit details
-
Copy full SHA for 60f7b13 - Browse repository at this point
Copy the full SHA 60f7b13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bb3bd7 - Browse repository at this point
Copy the full SHA 5bb3bd7View commit details
Commits on Sep 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for cdbcd02 - Browse repository at this point
Copy the full SHA cdbcd02View commit details
Commits on Sep 22, 2022
-
Revert "Fix error conversion for WorkflowExecutionAlreadyStartedError (…
…uber#4838)" (uber#4999) This reverts commit 48a157e.
Configuration menu - View commit details
-
Copy full SHA for 5edc675 - Browse repository at this point
Copy the full SHA 5edc675View commit details
Commits on Sep 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d9296f6 - Browse repository at this point
Copy the full SHA d9296f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6952083 - Browse repository at this point
Copy the full SHA 6952083View commit details -
Adds fix for domain ack level issue (uber#5001)
Adds fix for domain replication by ensuring (non-transactionally) that replication messages are higher then ack levels
Configuration menu - View commit details
-
Copy full SHA for 2a0afef - Browse repository at this point
Copy the full SHA 2a0afefView commit details
Commits on Sep 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 23abf96 - Browse repository at this point
Copy the full SHA 23abf96View commit details
Commits on Sep 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 832f71a - Browse repository at this point
Copy the full SHA 832f71aView commit details
Commits on Sep 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ea49977 - Browse repository at this point
Copy the full SHA ea49977View commit details
Commits on Oct 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0d35f18 - Browse repository at this point
Copy the full SHA 0d35f18View commit details
Commits on Oct 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4e67d91 - Browse repository at this point
Copy the full SHA 4e67d91View commit details
Commits on Oct 31, 2022
-
Fix ndc flush buffered events (uber#5009)
Co-authored-by: David Porter <david.porter@uber.com>
Configuration menu - View commit details
-
Copy full SHA for 9b3f0de - Browse repository at this point
Copy the full SHA 9b3f0deView commit details
Commits on Nov 2, 2022
-
Reformatting most things for go 1.19, rebuilding go.mod tools after c…
…lean, warning about different go versions (uber#5019) The .bin folder isn't cleaned and doesn't version itself based on all possible influences... ... so it's kinda just turning into too much of a headache when it misbehaves. In particular, Go versions sometimes change formatting, and that tends to be baked into formatting tools, rather than executing `go` externally. So when e.g. `goimports` is built with a different version of Go than you are currently using, things can get confusing. These are now in the .build folder, so `make clean` will force a rebuild. Downloaded bins like `buf` and `protoc` are pre-built and should generally be resistant to this kind of leakage... and forcing a re-download on every `make clean` seems like definitely a bad idea in some scenarios. So the .bin folder remains, but its use is now much smaller. --- For gofmt purposes, formatting with the latest go version _tends_ to be stable... but unfortunately 1.19 and 1.17 disagree on protoc's code block indentation in comments. As CI currently runs 1.17, we need to be stable with 1.17's output. So this commit does a 1.19 format, then a 1.17 format. This appears stable with our hand-crafted comments, and is likely an improvement over just 1.17. It does, unfortunately, mean that you truly must use <1.19 or your commits may not be stable. We will likely be upgrading to 1.19 soon, but that involves a number of changes, so it's not done here. Stability first, upgrades second. --- The warning is printed immediately for all commands, but does not stop you from using that version: ``` ❯ make Makefile:41: Caution: you are not using CI's go version. Expected: go1.17, current: go version go1.18 darwin/amd64 help Prints a help message showing any specially-commented targets ... ```
Configuration menu - View commit details
-
Copy full SHA for 897dd9c - Browse repository at this point
Copy the full SHA 897dd9cView commit details -
Emitting version metrics also adding a githook that runs a script the…
… automatically updates the version unless the user manually skips (uber#4994) Emitting version metrics also adding a githook that runs a script the automatically updates the version unless the user manually skips
Configuration menu - View commit details
-
Copy full SHA for d6c48e9 - Browse repository at this point
Copy the full SHA d6c48e9View commit details
Commits on Nov 3, 2022
-
Enhance workflowDeletionTaskJitterRange to handle deletes piling up w…
…hen many workflows have finished at the same time. (uber#5020) * Enhance workflowDeletionTaskJitterRange to handle deletes piling up when many workflows have finished at the same time. * Fix panics when values < 1 are provided * Randomize the timestamp on a second granularity so that deletes are more spread out than before. * Default to 60 minutes. * Enhance workflowDeletionTaskJitterRange to handle deletes piling up when many workflows have finished at the same time. * Fix panics when values < 1 are provided * Randomize the timestamp on a second granularity so that deletes are more spread out than before. * Default to 60 minutes.
Configuration menu - View commit details
-
Copy full SHA for a668ce1 - Browse repository at this point
Copy the full SHA a668ce1View commit details -
Feature/min initial failover version (uber#5015)
Adds a migration feature for failover version
Configuration menu - View commit details
-
Copy full SHA for 56d2028 - Browse repository at this point
Copy the full SHA 56d2028View commit details
Commits on Nov 7, 2022
-
Fix Makefile OpenSearch rule name in CONTRIBUTING.md install guide, F…
…ix OpenSearch version in dev Docker config (uber#5004) * Fix Makefile rule name in Schema Install instructions of CONTRIBUTING.md * Opportunistic fix of Dependency software names surrounding Makefile rule name being fixed * Fix OpenSearch version pulled by Docker
Configuration menu - View commit details
-
Copy full SHA for 18e8bad - Browse repository at this point
Copy the full SHA 18e8badView commit details
Commits on Nov 9, 2022
-
Decouple StateBuilder from TaskGenerator (uber#4991)
* Decouple StateBuilder from TaskGenerator * Address comments
Configuration menu - View commit details
-
Copy full SHA for 946f677 - Browse repository at this point
Copy the full SHA 946f677View commit details
Commits on Nov 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0c8e16c - Browse repository at this point
Copy the full SHA 0c8e16cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 197bd16 - Browse repository at this point
Copy the full SHA 197bd16View commit details
Commits on Nov 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3eb3254 - Browse repository at this point
Copy the full SHA 3eb3254View commit details
Commits on Nov 16, 2022
-
Add UpdateTime to uninitialized workflow execution record and update …
…logic to set the update time (uber#5014) * Add updateTime to uninitialized wf execution record * Update updateTime field to use shard time source now to make the logic consistent
Configuration menu - View commit details
-
Copy full SHA for ea21d8a - Browse repository at this point
Copy the full SHA ea21d8aView commit details -
Update DSL query to allow filtering by missing start time (uber#5017)
* Update DSL query to allow filtering by missing start time and get count of uninitialized wf execution records
Configuration menu - View commit details
-
Copy full SHA for 0703b40 - Browse repository at this point
Copy the full SHA 0703b40View commit details
Commits on Nov 17, 2022
-
Revert version to simple hardcode to match release branch. Auto updat…
…e moved to closed source (uber#5026) Revert to a simple hard coded server version metric emission
Configuration menu - View commit details
-
Copy full SHA for 8a1ddbd - Browse repository at this point
Copy the full SHA 8a1ddbdView commit details -
test: use
T.TempDir
to create temporary test directory (uber#5013)This commit replaces `os.MkdirTemp` with `t.TempDir` in tests. The directory created by `t.TempDir` is automatically removed when the test and all its subtests complete. Prior to this commit, temporary directory created using `os.MkdirTemp` needs to be removed manually by calling `os.RemoveAll`, which is omitted in some tests. The error handling boilerplate e.g. defer func() { if err := os.RemoveAll(dir); err != nil { t.Fatal(err) } } is also tedious, but `t.TempDir` handles this for us nicely. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: David Porter <david.porter@uber.com> Co-authored-by: Mantas Šidlauskas <mantass@uber.com>
Configuration menu - View commit details
-
Copy full SHA for 9472846 - Browse repository at this point
Copy the full SHA 9472846View commit details
Commits on Nov 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1a50671 - Browse repository at this point
Copy the full SHA 1a50671View commit details
Commits on Nov 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4b06e3f - Browse repository at this point
Copy the full SHA 4b06e3fView commit details
Commits on Nov 22, 2022
-
Add TLS ServerName as CLI option for Cadence Cassandra Tool (uber#5011)
* Add TLS ServerName as CLI option for Cadence Cassandra Tool * Format with make fmt
Configuration menu - View commit details
-
Copy full SHA for 1a52714 - Browse repository at this point
Copy the full SHA 1a52714View commit details
Commits on Nov 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d249434 - Browse repository at this point
Copy the full SHA d249434View commit details
Commits on Nov 28, 2022
-
Update parent close policy to terminate/cancel child workflows even a…
…fter continue as new (uber#5032)
Configuration menu - View commit details
-
Copy full SHA for 477c65b - Browse repository at this point
Copy the full SHA 477c65bView commit details
Commits on Nov 29, 2022
-
Add cli tls support (uber#5027)
* introduce tls cert flag to CLI frontend, add logic for building tls CLIoutbound * remove explicit default value for cert flag for style consistency Co-authored-by: Shijie Sheng <shengs@uber.com> Co-authored-by: David Porter <david.porter@uber.com>
Configuration menu - View commit details
-
Copy full SHA for d934bf1 - Browse repository at this point
Copy the full SHA d934bf1View commit details
Commits on Dec 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 653ab49 - Browse repository at this point
Copy the full SHA 653ab49View commit details
Commits on Dec 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c20a4fb - Browse repository at this point
Copy the full SHA c20a4fbView commit details
Commits on Dec 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0726498 - Browse repository at this point
Copy the full SHA 0726498View commit details
Commits on Dec 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8e9d827 - Browse repository at this point
Copy the full SHA 8e9d827View commit details
Commits on Dec 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3e568fc - Browse repository at this point
Copy the full SHA 3e568fcView commit details -
Making a schema tooling concrete -> interface (uber#5046)
* Making a concrete implementation of schema tool into an interface
Configuration menu - View commit details
-
Copy full SHA for 2060667 - Browse repository at this point
Copy the full SHA 2060667View commit details -
Improve logs for transfer task validator (uber#5044)
Co-authored-by: David Porter <david.porter@uber.com>
Configuration menu - View commit details
-
Copy full SHA for d5f3f4f - Browse repository at this point
Copy the full SHA d5f3f4fView commit details
Commits on Dec 13, 2022
-
Exposing the ability to pull CQL changesets (uber#5047)
* Exposing the ability to pull CQL changesets
Configuration menu - View commit details
-
Copy full SHA for 4a2c9af - Browse repository at this point
Copy the full SHA 4a2c9afView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6b4aa9 - Browse repository at this point
Copy the full SHA a6b4aa9View commit details
Commits on Dec 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2d4ad08 - Browse repository at this point
Copy the full SHA 2d4ad08View commit details
Commits on Dec 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 29398d8 - Browse repository at this point
Copy the full SHA 29398d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ded66f0 - Browse repository at this point
Copy the full SHA ded66f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d0926e3 - Browse repository at this point
Copy the full SHA d0926e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a06075 - Browse repository at this point
Copy the full SHA 4a06075View commit details -
Wf version metrics (uber#5041)
Add workflow version metrics into a workflow that runs every 10m as a part of cadence-workers
Configuration menu - View commit details
-
Copy full SHA for 57565b8 - Browse repository at this point
Copy the full SHA 57565b8View commit details
Commits on Dec 29, 2022
-
Search attribute validation toggling (uber#5033)
* Introduce dyn. config flag for toggling attr. validation, implement flag check before performing validation * Toggle validation on attaching attr. in WF start, toggle indexProcessor level validation * Update construction of validation tests * Add new dynamic config property to unit test * Handle nil case for new config property in validation Co-authored-by: David Porter <david.porter@uber.com> Co-authored-by: Zack Kirsch <zackk@uber.com>
Configuration menu - View commit details
-
Copy full SHA for d618e32 - Browse repository at this point
Copy the full SHA d618e32View commit details
Commits on Jan 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 747b58e - Browse repository at this point
Copy the full SHA 747b58eView commit details
Commits on Jan 6, 2023
-
Delete uninitialized workflow execution record if workflow failed to …
…start (uber#5059) * Add method to verify uninitialized workflow execution record then delete from ES * Delete uninitialized workflow execution record if workflow failed to add start event
Configuration menu - View commit details
-
Copy full SHA for 933fb08 - Browse repository at this point
Copy the full SHA 933fb08View commit details
Commits on Jan 9, 2023
-
Fix make install-schema-es-v6 and install-schema-es-v7 (uber#5063)
Update to use static path to the template for es v6 and v7
Configuration menu - View commit details
-
Copy full SHA for 84ccb72 - Browse repository at this point
Copy the full SHA 84ccb72View commit details
Commits on Jan 10, 2023
-
change to emit wf version (uber#5066)
Add workflow type tag to workflow version metrics.
Configuration menu - View commit details
-
Copy full SHA for 60a6746 - Browse repository at this point
Copy the full SHA 60a6746View commit details
Commits on Jan 11, 2023
-
Update dependencies (uber#5065)
Updating some cadence dependencies.
Configuration menu - View commit details
-
Copy full SHA for f2a58e2 - Browse repository at this point
Copy the full SHA f2a58e2View commit details
Commits on Feb 1, 2023
-
Add domain tag to unregistered field error (uber#5070)
* Add domain tag to unregistered field error to track which domain got that problem
Configuration menu - View commit details
-
Copy full SHA for 7657275 - Browse repository at this point
Copy the full SHA 7657275View commit details -
Fix docker image builds with an actually-reliable dependency skip (ub…
…er#5071) * Fix docker image builds with an actually-reliable dependency skip Honestly this is so obvious in retrospect that I don't know why I tried to do the fake-codegen thing. The easiest way to skip dependencies is... to not declare that dependency in the first place.
Configuration menu - View commit details
-
Copy full SHA for 361a107 - Browse repository at this point
Copy the full SHA 361a107View commit details
Commits on Feb 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7670ab2 - Browse repository at this point
Copy the full SHA 7670ab2View commit details
Commits on Feb 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 40c9028 - Browse repository at this point
Copy the full SHA 40c9028View commit details
Commits on Feb 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 14142e0 - Browse repository at this point
Copy the full SHA 14142e0View commit details -
UpdateWorkflow ShardId based metrics (uber#5080)
Add shardId metrics to updateworkflow execution in persistence. Also created a reusable and explicitly named function if other operations require shardId metrics
Configuration menu - View commit details
-
Copy full SHA for f5efe3a - Browse repository at this point
Copy the full SHA f5efe3aView commit details
Commits on Feb 9, 2023
-
Emit workflow counts per workflow type metrics (uber#5082)
Added new workflow to emit workflow count by workflow type metrics
Configuration menu - View commit details
-
Copy full SHA for 3b5c2b6 - Browse repository at this point
Copy the full SHA 3b5c2b6View commit details
Commits on Feb 10, 2023
-
Update supported decoding types of CLI (uber#5069)
Co-authored-by: Steven L <imgroxx@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1c4f6c8 - Browse repository at this point
Copy the full SHA 1c4f6c8View commit details -
Add iWF link in README (uber#5084)
* Add iWF link * Update README.md
Configuration menu - View commit details
-
Copy full SHA for 9f91cd2 - Browse repository at this point
Copy the full SHA 9f91cd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4752da4 - Browse repository at this point
Copy the full SHA 4752da4View commit details
Commits on Feb 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dd95446 - Browse repository at this point
Copy the full SHA dd95446View commit details
Commits on Feb 14, 2023
-
CDNC-2088 (uber#5094) Add attempt-count to task processing logs
* CDNC-2088 Add attempt-count to task processing logs in file service/history/task/task.go Also changed AttemptCount in tags.go to be type int. * delete comments that was used for self reminder * add attemptCount to log in file service/history/task/cross_cluster_task.go
Configuration menu - View commit details
-
Copy full SHA for fbe72b3 - Browse repository at this point
Copy the full SHA fbe72b3View commit details
Commits on Feb 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 68a7614 - Browse repository at this point
Copy the full SHA 68a7614View commit details
Commits on Feb 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fe9c3ab - Browse repository at this point
Copy the full SHA fe9c3abView commit details -
Resolve an infinite loop around impossible cron schedules (uber#5097)
We got some infinite (or near enough to infinite) hot loops in cron-schedule-Next-ing code today. While we don't yet have any concrete examples to investigate, I'm going to claim it's due to being 2 weeks away from the end of February, and February is weird. People are probably accidentally scheduling things for Feb 30 or 31. There does seem to be some invalid cron schedule parsing happening in robfig/cron, e.g. for `0 0 0 , 0`, but the bulk of the blame for this rests on our code: `.Next` returns a zero-valued time if there is no next time, and that's `.Before` other dates... by a very large margin. There's a decent chance the next `.Next` will return another zero value too, leading to a truly infinite loop. Since a lot of this code was kinda ridiculous about not returning errors, I've just changed that and all callers. In most cases there was a simple place "nearby" that already returned errors, so it just now returns another kind of error. --- Because these invalid schedules are likely *always* invalid (robfig/cron checks 5 years of values, e.g. to work around leap years), and this would *always* infinite loop on those values, I believe it's safe to assume that these invalid cron schedules have never been written to databases.
Configuration menu - View commit details
-
Copy full SHA for caeeec1 - Browse repository at this point
Copy the full SHA caeeec1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ff8c89 - Browse repository at this point
Copy the full SHA 3ff8c89View commit details
Commits on Feb 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 04a6c92 - Browse repository at this point
Copy the full SHA 04a6c92View commit details
Commits on Feb 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 937e436 - Browse repository at this point
Copy the full SHA 937e436View commit details
Commits on Feb 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f4f8a85 - Browse repository at this point
Copy the full SHA f4f8a85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35e2212 - Browse repository at this point
Copy the full SHA 35e2212View commit details
Commits on Feb 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f9d04ea - Browse repository at this point
Copy the full SHA f9d04eaView commit details
Commits on Feb 22, 2023
-
add 3 tags to support adding logs for every manual access (uber#5112)
* add 3 tags to support adding logs for every manual access * more comment explaining * correct a naming * correct a variable name * change caller tag function name to avoid conflict
Configuration menu - View commit details
-
Copy full SHA for 471cf77 - Browse repository at this point
Copy the full SHA 471cf77View commit details
Commits on Feb 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e32116d - Browse repository at this point
Copy the full SHA e32116dView commit details -
CLI: print all available dynamic config keys (uber#5090)
* CLI: print all available dynamic config keys * rename from describe to listall
Configuration menu - View commit details
-
Copy full SHA for 011932e - Browse repository at this point
Copy the full SHA 011932eView commit details
Commits on Feb 24, 2023
-
Flexible / sane header forwarding (uber#5103)
Blindly forwarding all inbound headers to outbound requests is unambiguously wrong, and causing problems. This adds a semi-flexible system to allow controlling what headers are forwarded, via static and dynamic config. Dynamic config is currently only loaded at startup, but at least internally it's still quicker than changing static config. We should consider making this truly dynamic. As this has historically been copying ?? to outbounds, leading to ?? total headers: the current version does not change anything. We'll likely experiment internally to make sure our new sets of headers are safe with our setup, and will make a separate PR to tighten down the list somewhat when we've confirmed that it works + is likely to work in other clusters. --- Why this kind of add/remove/regex list structure? No strong reason, I've just used it in previous projects pretty happily. Only-inclusive or only-exclusive has been insufficient every time, but I've had this in a couple services for years without needing more. Longer-term we probably want this to be truly dynamically updatable and/or fully pluggable. If we're lucky we might not need more than this though, and driving it via config is pretty convenient and easily understood.
Configuration menu - View commit details
-
Copy full SHA for 4fd55ca - Browse repository at this point
Copy the full SHA 4fd55caView commit details
Commits on Feb 27, 2023
-
Add sample log and dynamic config for updateworkflowexecution hot sha…
…rd detection (uber#5120) Add sample logging infra and sample logging for updateworkflowexecution hotshard detection
Configuration menu - View commit details
-
Copy full SHA for d079c9a - Browse repository at this point
Copy the full SHA d079c9aView commit details
Commits on Feb 28, 2023
-
Add attempt-count to task processing logs, and update unit test so th…
…at it will cover deadlock (uber#5122) * change both getAttempt function to a variale called attempt to avoid deadlock * lead the unit test go into the function where caused deadlock. The unit test will stuck if there is a deadlock * remove a mock in setup that will cause an error for GetTaskType function * update comments for more explaination
Configuration menu - View commit details
-
Copy full SHA for 412efa7 - Browse repository at this point
Copy the full SHA 412efa7View commit details -
Visiblity shard id to open source stuff (uber#5123)
Add shard_Id into open source visibility solutions
Configuration menu - View commit details
-
Copy full SHA for 5619c98 - Browse repository at this point
Copy the full SHA 5619c98View commit details
Commits on Mar 1, 2023
-
add metrics for delete workflow execution on a shard level (uber#5126)
add metrics for delete workflow execution on a shard level
Configuration menu - View commit details
-
Copy full SHA for 15f18f5 - Browse repository at this point
Copy the full SHA 15f18f5View commit details
Commits on Mar 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0ffecc3 - Browse repository at this point
Copy the full SHA 0ffecc3View commit details
Commits on Mar 6, 2023
-
Indexer: refactor ES processor (uber#5100)
* Indexer: refactor ES processor * fix kafka key variable, pass processor name
Configuration menu - View commit details
-
Copy full SHA for 87c91bd - Browse repository at this point
Copy the full SHA 87c91bdView commit details -
create RequestBody struct, implement it using requests, add requestbo…
…dy into Attribute for auditing (uber#5124) * Revert "CDNC-2088 (uber#5094) Add attempt-count to task processing logs" This reverts commit fbe72b3. * experiment on adding audit info (has errorsgit status) * move AuditInfo into Attr * implement requestBody Struct, implement it using requests, add it into Attribute to use this field for auditing manual accesses * change struct name to be ManualRequestBody to avoid conflict * change any to interface to solve a compiling error * rerun make go-generate && make fmt && make lint && make copyright for auto generated code * change the PII-filtered request to still be a requset instead of a map * add a utility function to check if access is manual, add request body into Attribute * update with make go-generate && make fmt && make lint && make copyright * update comments and naming * change Sprintf to marshal * add error handling for json.marshal, pass it to the caller of SerializeForLogging function * add a new log tag for actor email address * update interface function error handling * pass in a pointer for serialization instead of a struct * delete the isManual checks when creating Attributes
Configuration menu - View commit details
-
Copy full SHA for c462ec0 - Browse repository at this point
Copy the full SHA c462ec0View commit details -
move sample logger into persistence metric client for cleaness (uber#…
…5129) move sample logger into persistence metric client for cleaness
Configuration menu - View commit details
-
Copy full SHA for 2f9dde5 - Browse repository at this point
Copy the full SHA 2f9dde5View commit details
Commits on Mar 7, 2023
-
add overall persistence count for shardid (uber#5134)
add overall persistence count for shardid
Configuration menu - View commit details
-
Copy full SHA for 29b706d - Browse repository at this point
Copy the full SHA 29b706dView commit details
Commits on Mar 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 56c6941 - Browse repository at this point
Copy the full SHA 56c6941View commit details
Commits on Mar 9, 2023
-
Scanner to purge deprecated domain workflows (uber#5125)
* Added checks to look for deprecated flag in the domains and putting workflows up for deletion * code cleaning and minnor changes * Added the domain check to open executions * Cleaned up some code and added a new check for domain * Removed unused constants * updated documentation * Isolated the domain status check in a separate invariant * code cleanup
Configuration menu - View commit details
-
Copy full SHA for d04521d - Browse repository at this point
Copy the full SHA d04521dView commit details -
Fix prometheus frontend label inconsistencies (uber#5087)
Fix prometheus frontend label inconsistencies (uber#5087)
Configuration menu - View commit details
-
Copy full SHA for 9643242 - Browse repository at this point
Copy the full SHA 9643242View commit details -
[history] add domain status check in taskfilter (uber#5140)
What changed? add domain status check in taskAllocator verification Why? tasks in queues should drop for deprecated or deleted domains
Configuration menu - View commit details
-
Copy full SHA for 4b5e888 - Browse repository at this point
Copy the full SHA 4b5e888View commit details
Commits on Mar 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 434bcee - Browse repository at this point
Copy the full SHA 434bceeView commit details -
ES: do not set _type when using Bulk API for v7 client (uber#5104)
* ES: do not set type for v7 * add buildkite job * disable os2 security
Configuration menu - View commit details
-
Copy full SHA for 45c3cee - Browse repository at this point
Copy the full SHA 45c3ceeView commit details
Commits on Mar 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b0cbe1c - Browse repository at this point
Copy the full SHA b0cbe1cView commit details -
Service name should be `worker` not `workers` Co-authored-by: Zijian <Shaddoll@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for bb7cb10 - Browse repository at this point
Copy the full SHA bb7cb10View commit details -
Adding request body into Attributes for auditing purpose with PII fie…
…lds are filtered (uber#5151) * add unit test for filter PII functions to check bugs and error when cloning * handles when pointers are nil to avoid bugs and errors * resume the changes from previous reverted branch * use json tags to filter PII instead of hard copies * Create a new struct in unit test that only contains PII. Would be much more clearer to see filtered result. * some clean up
Configuration menu - View commit details
-
Copy full SHA for 5e5895a - Browse repository at this point
Copy the full SHA 5e5895aView commit details -
add remaining persistence stuff that goes to a shard (uber#5142)
add remaining persistence stuff that goes to a shard
Configuration menu - View commit details
-
Copy full SHA for 61c64c3 - Browse repository at this point
Copy the full SHA 61c64c3View commit details -
Consistent query pershard metric (uber#5143)
* added and update consistent query per shard metric * testing pershard metric * move sample logger into persistence metric client for cleaness * fix test * fix lint * fix test again * fix lint * sample logging with workflowid tag * added domain tag to logger * metric completed * addressing comments * fix lint * Revert "fix lint" This reverts commit 1e96944. * fix lint second attempt --------- Co-authored-by: Allen Chen <allenchen2244@uber.com>
Configuration menu - View commit details
-
Copy full SHA for 9581488 - Browse repository at this point
Copy the full SHA 9581488View commit details
Commits on Mar 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e3ac246 - Browse repository at this point
Copy the full SHA e3ac246View commit details
Commits on Mar 15, 2023
-
ES: single interface for different ES/OpenSearch versions (uber#5158)
* ES: single interface for different ES/OpenSearch versions * make fmt
Configuration menu - View commit details
-
Copy full SHA for a25cba8 - Browse repository at this point
Copy the full SHA a25cba8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba19a29 - Browse repository at this point
Copy the full SHA ba19a29View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbf0d14 - Browse repository at this point
Copy the full SHA cbf0d14View commit details
Commits on Mar 16, 2023
-
Elasticsearch: reduce code duplication (uber#5137)
* Elasticsearch: reduce code duplication * address comments --------- Co-authored-by: Zijian <Shaddoll@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 42a14b1 - Browse repository at this point
Copy the full SHA 42a14b1View commit details -
Set poll interval for filebased dynamic config if not set (uber#5160)
* Set poll interval for filebased dynamic config if not set * update unit test
Configuration menu - View commit details
-
Copy full SHA for 1304570 - Browse repository at this point
Copy the full SHA 1304570View commit details -
Add Pinot docker files, table config and schema (uber#5163)
* Initial checkin for pinot config files
Configuration menu - View commit details
-
Copy full SHA for 55a8d93 - Browse repository at this point
Copy the full SHA 55a8d93View commit details
Commits on Mar 17, 2023
-
[history] more cautious in deciding domain state to make decisions on…
… dropping queued tasks (uber#5164) What changed? When domain cache returned entity not found error, don't drop queued tasks to be more conservative. Why? In cases when the cache is dubious, we shouldn't drop the queued tasks.
Configuration menu - View commit details
-
Copy full SHA for ff4eab2 - Browse repository at this point
Copy the full SHA ff4eab2View commit details -
Add Canary TLS support (uber#5086)
* add support for TLS connections by Canary, add development config for Canary with TLS * update README to include new config option * remove testing config --------- Co-authored-by: David Porter <david.porter@uber.com> Co-authored-by: Shijie Sheng <shengs@uber.com> Co-authored-by: Zijian <Shaddoll@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a3e2774 - Browse repository at this point
Copy the full SHA a3e2774View commit details -
Fix type validation in configstore DC client value updating (uber#5110)
* Remove misleading type check, Add more detailed log message * removing debugging logging * Handle nil update edge case --------- Co-authored-by: allenchen2244 <102192478+allenchen2244@users.noreply.github.com> Co-authored-by: Zijian <Shaddoll@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 1519ace - Browse repository at this point
Copy the full SHA 1519aceView commit details -
Upgrade Golang base image to 1.18 to remediate CVEs (uber#5035)
Co-authored-by: David Porter <david.porter@uber.com>
Configuration menu - View commit details
-
Copy full SHA for f1e2476 - Browse repository at this point
Copy the full SHA f1e2476View commit details
Commits on Mar 27, 2023
-
Adds a small test to catch issues with deadlocks (uber#5171)
* Adds a small test to catch issues with deadlocks
Configuration menu - View commit details
-
Copy full SHA for 7b281c2 - Browse repository at this point
Copy the full SHA 7b281c2View commit details
Commits on Mar 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dd51c53 - Browse repository at this point
Copy the full SHA dd51c53View commit details -
large workflow hot shard detection (uber#5166)
Metrics for large workflows
Configuration menu - View commit details
-
Copy full SHA for 9d01035 - Browse repository at this point
Copy the full SHA 9d01035View commit details
Commits on Apr 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9a86fbc - Browse repository at this point
Copy the full SHA 9a86fbcView commit details
Commits on Apr 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d2f9ec6 - Browse repository at this point
Copy the full SHA d2f9ec6View commit details
Commits on Apr 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b2bc8bf - Browse repository at this point
Copy the full SHA b2bc8bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for d165c7b - Browse repository at this point
Copy the full SHA d165c7bView commit details -
Allow registering search attributes without Advance Visibility enabled (
uber#5185) * remove validation & test for add search attribute with no advanced config - Remove validation for Advance Visibility Store - Add Advance Visibility Config check before update ElasticSearch/OpenSearch mapping - Remove co-related test for 'no advanced config' * Update CHANGELOG.md Update CHANGELOG.md * Add warn level message if skip updating OpenSearch/ElasticSearch mapping * Add warn level message and add validSearchAttributes in development.yaml --------- Co-authored-by: Quanzheng Long <prclqz@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9fc4485 - Browse repository at this point
Copy the full SHA 9fc4485View commit details
Commits on Apr 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for eade936 - Browse repository at this point
Copy the full SHA eade936View commit details -
Fix consistent query metric (uber#5170)
* add shardid tag to log * remove counter for overall scope * fix lint
Configuration menu - View commit details
-
Copy full SHA for c5678dd - Browse repository at this point
Copy the full SHA c5678ddView commit details
Commits on Apr 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 824f0ac - Browse repository at this point
Copy the full SHA 824f0acView commit details
Commits on Apr 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b18be27 - Browse repository at this point
Copy the full SHA b18be27View commit details
Commits on Apr 21, 2023
-
Physical sharding for NoSQL-based persistence (uber#5187)
What changed? Added a sharding layer to the NoSQL persistence stack so that Cadence can use multiple Cassandra clusters at once in a physically sharded manner. Cadence is a heavily storage-bounded system, so the limits for the load per Cadence cluster is strictly limited by the underlying storage system. Given the massive adoption of Cadence at Uber, this scale limitation forces us to create more Cadence clusters than we want to operate. This capability will let us have one or two orders of magnitude larger Cadence clusters than we have today. Note that this feature only enables bootstrapping a brand-new cluster with multiple databases behind it. Resharding is designed but not implemented yet. Why? So that a Cadence cluster can be bootstrapped with multiple Cassandra clusters powering it. How did you test it? Added unit tests. Ran samples and tested bench tests in a staging environment. Potential risks Since this change significantly changes the low-level persistence logic, it can cause data loss if something goes terribly wrong. Release notes The change is backward compatible. Existing Cadence cluster configurations can be updated, if desired, to use the sharded NoSQL config format. However, they must continue having a single shard since Cadence still doesn't have the ability to reshard data. Documentation Changes There is a sample config file included in this PR that shows how to make use of the feature in a new cluster.
Configuration menu - View commit details
-
Copy full SHA for 45129f1 - Browse repository at this point
Copy the full SHA 45129f1View commit details
Commits on Apr 22, 2023
-
Add tasklist traffic metrics for non-sticky and non-forwarded tasklis…
…ts (uber#5218) * add tasklist traffic metrics for decision task * add logger, remove tasklistID * add taskListCombined * add more fields * add forward metric and source * fix nil * add tlMgr metrics * add more metrics * remove tlMgr metric * only emit metrics if not sticky and not forwarded * create new metrics name for better distinction * add new emitted info * change nil to empty string * add domain and tasklist name tags * add metrics for forwarded tasklist * new metrics for activity task, rename metrics to allow aggregation of both type of tasks * clean up logging * clean up changes in emitInfoOrDebugLog() * resolve comments * improve some logic * fix small error
Configuration menu - View commit details
-
Copy full SHA for 16cd991 - Browse repository at this point
Copy the full SHA 16cd991View commit details
Commits on Apr 24, 2023
-
Setting up some lightweight automation for publishing docker images
We have this in an internal wiki, but it's still quite manual, and there are a lot of steps. Some lightweight automation seems worth adopting.
Configuration menu - View commit details
-
Copy full SHA for bb9521f - Browse repository at this point
Copy the full SHA bb9521fView commit details