Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-source-contentful): Calculate fixed image width if only height supplied #24393

Closed
wants to merge 237 commits into from
Closed

fix(gatsby-source-contentful): Calculate fixed image width if only height supplied #24393

wants to merge 237 commits into from

Conversation

mrseanbaines
Copy link
Contributor

@mrseanbaines mrseanbaines commented May 23, 2020 •
edited
Loading

Description

Fixes an issue where gatsby-source-contentful returns empty srcSet and srcSetWebp when querying fixed images with only height argument.

Before:

image

After:

image

Related Issues

Fixes #24392

@mrseanbaines mrseanbaines requested a review from a team as a code owner May 23, 2020 18:39
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 23, 2020
@mrseanbaines mrseanbaines changed the title Calculate fixed image width if necessary fix(gatsby-source-contentful): Calculate fixed image width if only height supplied May 23, 2020
@LekoArts LekoArts added status: needs core review Currently awaiting review from Core team member and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 25, 2020
axe312ger
axe312ger previously approved these changes Jun 10, 2020
View reviewed changes
Copy link
Collaborator

@axe312ger axe312ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the work :)

@alexpyzhianov
fix(www): sidebar scrolling shouldn't move main content (#24438)
ad47c24 
* Previously scrolling or swiping inside the navigation
sidebar could result in main content moving. Fixed for
most browsers with overflow-behavior: contain

Resolves #24255

Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
@mrseanbaines
Copy link
Contributor Author

No problemo @axe312ger. Any idea why the tests are failing/hanging? They look very unrelated to these changes.

muescha and others added 18 commits June 10, 2020 12:46
@muescha
change yarn to gatsby command (#24364)
09224dc
@andrzejwp @muescha
Add Sourcing from Flotiq documentation entry (#24721)
c8228f5 
* Add Sourcing from Flotiq documentation entry

* fix whitespace

* prettier

* fix prettier, again

* add headless-cms table entry

* Update docs/docs/sourcing-from-flotiq.md

Co-authored-by: Muescha <184316+muescha@users.noreply.github.com>

* `Update docs/docs/sourcing-from-flotiq.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/sourcing-from-flotiq.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/sourcing-from-flotiq.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/sourcing-from-flotiq.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/sourcing-from-flotiq.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/sourcing-from-flotiq.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/sourcing-from-flotiq.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/sourcing-from-flotiq.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/sourcing-from-flotiq.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/sourcing-from-flotiq.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/sourcing-from-flotiq.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/sourcing-from-flotiq.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/sourcing-from-flotiq.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/sourcing-from-flotiq.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Apply suggestions from code review

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* fix improper API key reference

* Update docs/docs/sourcing-from-flotiq.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* add blogpost template

* simplify blog-post template

* add full gatsby-node.js example

* Apply suggestions from code review

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* prettier, update img alt attribute

* remove empty paragraph

* add dotenv to gatsby-config example

Co-authored-by: Andrzej WP <andrzej@codewave.pl>
Co-authored-by: Muescha <184316+muescha@users.noreply.github.com>
Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>
@Ildarik
Warning in docs before bumping master branch (#24538)
5d980e3 
* Close #24479

* chore: format

* Update docs/docs/how-gatsby-works-with-github-pages.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/how-gatsby-works-with-github-pages.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/how-gatsby-works-with-github-pages.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/how-gatsby-works-with-github-pages.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/how-gatsby-works-with-github-pages.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>
Add Deploy to Gatsby Cloud subsection to main tutorial (#24576)
e908448 
* Add Gatsby Cloud subsection

* 'Gatsby.js' → 'Gatsby'

* Add more benefits of Gatsby Cloud

* Use straight quotes instead of curly

* Address requested changes

Github → GitHub, add 'shell' to code blocks, relative URLs, make Gatsby Cloud H3 level

* Make Gatsby Cloud H3 level

Co-authored-by: Aisha Blake <aisha.g.blake@gmail.com>

Co-authored-by: Aisha Blake <aisha.g.blake@gmail.com>
@muescha
fix language, add title (#24579)
a0cd2b9
@jbampton
chore(docs): Standardize word website (#24728)
6eafab3
@puzzledbytheweb @muescha
feat(recipes): add gitlab-ci-cd recipe to cli list (#24501)
99da774 
* feat(recipes): add gitlab-ci-cd recipe to cli list

* Update packages/gatsby-recipes/src/cli.js

Co-authored-by: Muescha <184316+muescha@users.noreply.github.com>

Co-authored-by: Muescha <184316+muescha@users.noreply.github.com>
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
@Slashgear @KyleAMathews
feat(recipes): add github pages deployement with travis (#23669)
9b2a804 
* feat(recipes): add github pages deployement with travis

* Update travis-deploy-github-pages.mdx

* review

* Tweak wording

* Update cli.js

Co-authored-by: Kyle Mathews <mathews.kyle@gmail.com>
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
@muescha
fix link, remove local links, code block for example url (#24649)
aa9aa96
@visualfanatic
chore(docs): mention async/await syntax in Gatsby Node APIs docs (#24752
130d5b7 
)
@jbampton
chore(gatsby): Fix all Netlify app links for subdomains. Change .com …
c31ef6f 
…to .app (#24722)
@jsjoeio
Update index.md (#24657)
f0cb87b
@shanejones
Docs - Lighthouse audits (#24783)
7f38822 
* updating content and screenshots

* Fix linting

Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>
@muescha
remove local domain, brand names, typos (#24824)
3858990
@muescha
remove local domain, brand name, escape \$ (#24803)
d2f5099
@muescha
fix brand names, files in code blocks (#24800)
d95033c
@iamdarshshah
fix(docs): next.js github links (zeit to vercel) (#24785)
773f8cc
@iamdarshshah
fix: links zeit to vercel (#24786)
f14c99b
abhishekjakhar and others added 24 commits June 24, 2020 23:13
@abhishekjakhar
chore(www): convert ImagePlaceholder used in guidelines to theme-ui (#…
ff83475 
…25078)

* convert ImagePlaceholder used in guidelines to theme-ui

* update

* update

* combining imports
@tesseralis
Fix a prettier formatting issue in blog post (#25285)
d9ad8e5
Add usage instructions for images
2b45c0e
@mgienow
Blog gatsby WebAIM Million (#25273)
9903506 
* Add WebAIM Million announcement Gatsby is most accessible framework

* create frontmatter for WebAIM blog post

* Update index.md

* Update index.md

* chore: format

* fix typo

* Update index.md

Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
Adjust language slightly (#25299)
898461f 
Co-authored-by: Laurie Barth <laurie@LauriesrkLaptop.fios-router.home>
Change official plugins testing condition (#25300)
d41526f 
Co-authored-by: Laurie Barth <laurie@LauriesrkLaptop.fios-router.home>
@TylerBarnes
feat(docs): Add explanation of Site.siteMetadata field (#25208)
e59b4a9 
* Add explanation of Site.siteMetadata field

* chore: format

Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
@kakchan
chore(showcase): Add erp.laputan.com.au (#25227)
b75ffc3 
* chore(showcase): Add erp.laputan.com.au

* fix category for dangerbot

* update title for dangerbot

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>
@jina
chore(docs): Correct capitalization for Sass (#25311)
35744ac 
I know it's nitpicky, but just wanted to make it follow the Sass brand guidelines. 😄
@MichaelDeBoey
chore(test): Test on Node 14 (#23354)
1cf0c27 
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
update author.yaml for Marcy Sutton (#25306)
32c186f 
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
@pieh
refactor(develop): expose APIs to suspend/resume webpack watching to …
b73cc5d 
…gatsby internals (#25236)
@tesseralis
maintenance(www): use gatsby-plugin-react-svg for icons (#25282)
67b3ca9 
* use gatsby-plugin-react-svg for icons

* use elements instead of component names

* update asset imports

* v2 icon

* featured-sites

* add thingy

* svg
@tesseralis
fix(gatsby-plugin-mdx): set childOf extension for Mdx type definition (…
49c0929 
…#25112)

* set mimeTypes extension for Mdx type definition

* whoops
@tesseralis
fix(gatsby-transformer-documentationjs): Add childOf, mimeTypes and f…
48f7878 
…ill in other schema typings (#25113)

* Add mimeTypes and other directives to fill in files

* add placeholder type
@abhishekjakhar
chore(www): convert BoxWithBorder to theme-ui (#25144)
6013206 
* convert BoxWithBorder to theme-ui

* update the border css rules
@fk
chore(www): Tidy sx prop space usage (#25333)
7b0de96 
* chore(www): Tidy `space`, `color`, fix `:hover`

* chore(www): Tidy `space` token value usage

* chore(www): Tidy `space` token value usage

* chore(www): Tidy `space` token value usage

* chore(www): Tidy `space` token value usage

* chore(www): Tidy `space` token value usage

* chore(www): Tidy `space` token value usage

* chore(www): Tidy `space` token value usage

* chore(www): Tidy `space` token value usage

* chore(www): Tidy `space` token value usage

* chore(www): Use `sidebarItemMinHeight` token

* fix(www): `TitleButton` indention, padding-right

This is currently not in use so will leave it alone, but this thing's height and `hover`, `active` states are also off a little.

* chore(www): Tidy `space` token value usage

* chore(www): Tidy `space` token value usage

Not really in use either, but let's fix the "pull in page margin" thing.
chore(starters): add gatsby-starter-capacitor (#24755)
219e01e
@tesseralis
Remove fake styled components from banner (#25352)
9e68ac3
@tesseralis
refactor(www): Convert Pullquote to use theme-ui (#25351)
aa8c300 
* refactor pullquote component

* Fix sizes

* Simplify styles for cross axis

* Add some documentation on the pullquote
@fk
chore(www): Refactor homepage-logo-banner (#25348)
c1368c0 
* chore(www): Refactor to `sx`

* rm `@emotion/styled`

* newlines, more concise, fix a d'oh

not bored enough for responsive array things tho ;)

* OK, bored enough

🤔

* lol

* time for breakfast

* inline styles 😛 null, null, null, null
@fk
chore(www): Refactor ecosystem-section (#25349)
c9c3d68 
* chore(www): Refactor to `sx`

* newlines

* 🙄

* 🙃

* 💩

* combine imports

* rm className, spread love

* 🙀

* mv inline

* 🤡
@mrseanbaines
Calculate fixed image width if necessary
8b50135
@mrseanbaines
Merge branch 'fix-gatsby-source-contentful-srcSet' of github.com:gats…
653281a 
…byjs/gatsby into fix-gatsby-source-contentful-srcSet
@axe312ger
Copy link
Collaborator

@mrseanbaines Hey Sean, why did you close this? Did you have issues rebasing on master?

@mrseanbaines
Copy link
Contributor Author

@axe312ger I'm not sure what happened but I somehow ended up with hundreds of commits worth of changes 😄. I'll fix this and reopen when I get a sec.

@mrseanbaines mrseanbaines mentioned this pull request Jul 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axe312ger axe312ger axe312ger left review comments

Assignees
No one assigned
Labels
status: needs core review Currently awaiting review from Core team member topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Milestone
No milestone