Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore update container oscal cli js 20241113 #901

Closed

Commits on Sep 24, 2024

  1. Initial commit of awesome cloud example. This example is notional and…

    … will likely change over time to become better and more complete as an example.
    david-waltermire authored and aj-stein-gsa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e6e8037 View commit details
    Browse the repository at this point in the history
  2. Update obsolete actions/checkout actions for #643

    Not all, but many, actions were pinned to old versions by tag and to an
    explicit SHA1 hash from the repo that are old enough to cause GHA
    error notices. Upgraded from these to current SHA1 hash for the most
    (692973e3d937129bcbf40652eb9f2f61becf3332) for recent v4.1.7 release.
    
    > The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
    
    > The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
    
    Source: https://github.com/GSA/fedramp-automation/actions/runs/10783353551
    aj-stein-gsa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b4ad4f7 View commit details
    Browse the repository at this point in the history
  3. Remove version from compose files for #643

    This directive is now obsolete, causes more noise in the GHA workflow
    run logs.
    
    https://forums.docker.com/t/docker-compose-yml-version-is-obsolete/141313
    aj-stein-gsa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3a0d415 View commit details
    Browse the repository at this point in the history
  4. Update path-regexp manually in lieu of #673

    Dependabot still stinks about switching the target branch to rebase,
    recreate, or do whatever. More details in the longstanding issue. I give
    up! I cherry-picked the #673 commit because the related docker command
    issues that fail those builds would be better fixed here, go figure.
    
    dependabot/dependabot-core#6692
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and aj-stein-gsa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    426d597 View commit details
    Browse the repository at this point in the history
  5. Bump vite from 3.2.7 to 3.2.11 in /src/web (#698)

    Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 3.2.7 to 3.2.11.
    - [Release notes](https://github.com/vitejs/vite/releases)
    - [Changelog](https://github.com/vitejs/vite/blob/v3.2.11/packages/vite/CHANGELOG.md)
    - [Commits](https://github.com/vitejs/vite/commits/v3.2.11/packages/vite)
    
    ---
    updated-dependencies:
    - dependency-name: vite
      dependency-type: direct:development
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored and aj-stein-gsa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    35b66c9 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. initial commit of OSCAL and FedRAMP-specific OSCAL external constrain…

    …ts for use with OSCAL-cli.
    david-waltermire authored and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    025ea23 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    48d48e0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    43a5421 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    df596b7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5bfeb08 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0cffdea View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a0f8c42 View commit details
    Browse the repository at this point in the history
  8. automate content generation and validation via CLI (#614)

    * Introduce cucumber testing of yaml unit tests
    * introduce content generation and validation via CLI
    * use junit
    * eslint format
    wandmagic authored and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    bfe47f0 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    809179e View commit details
    Browse the repository at this point in the history
  10. allowed value constraints (#622)

    * Draft allowed values metaschema and YAML unit test.
    * automate content generation and validation via CLI (#614)
    * Introduce cucumber testing of yaml unit tests
    * introduce content generation and validation via CLI
    * better test summary reporting
    * introduce constraint coverage checking + improve coverage
    * throw an error if we do not find the matching rule
    * store output in .sarif folder
    * update constraints & test strategy, allow for mixed results as failure test
    * pretty print sarif & correct file name output
    * add time to sarif output file
    * introduce validation-cache for performance
    
    Co-authored-by: David Waltermire <davewaltermire@gmail.com>
    Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
    Co-authored-by: DimitriZhurkin <dimitri.zhurkin@noblis.org>
    4 people authored and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    03859bd View commit details
    Browse the repository at this point in the history
  11. improve constraint coverage tests (#633)

    * Improve constraint coverage tests
    * Update features/steps/fedramp_extensions_steps.ts
    
    ---------
    Co-authored-by: David Waltermire <davewaltermire@gmail.com>
    wandmagic authored and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    600fe76 View commit details
    Browse the repository at this point in the history
  12. Add README.md to OSCAL CLI instructions (#636)

    * Add README.md to OSCAL CLI instructions
    
    * Implemented reviewers' comments
    DimitriZhurkin authored and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ab9909f View commit details
    Browse the repository at this point in the history
  13. informational and warning constraint results (#635)

    * make test runner aware of informational constraint results
    
    * Update features/steps/fedramp_extensions_steps.ts
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    
    * improve test runner to handle warn and informational tests better
    
    * Update fedramp_extensions_steps.ts
    
    ---------
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    wandmagic and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e230bd3 View commit details
    Browse the repository at this point in the history
  14. Improve test runner and make commands (#649)

    * add make update command
    
    * add make constraint
    
    * improve first run on fresh constraint
    wandmagic authored and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2ef3dd3 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    66e040f View commit details
    Browse the repository at this point in the history
  16. Implemented further comments

    DimitriZhurkin authored and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    47b5118 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    9b62223 View commit details
    Browse the repository at this point in the history
  18. Add CONTRIBUTING guide for constraints portion of codebase (#647)

    * Constraint-specific CONTRIBUTING to its own dir
    
    Add the diagram of the constraint and testing
    components specific to this area of code base here
    and outline other sections to follow.
    
    * Reference prerequisites in README for install
    
    * Reorder CONTRIBUTING sections, add Metaschema one
    
    * Add references to relevant Metaschema docs
    
    * Add docs for new constraint tests
    
    * Sigh, whitespace from code blocks break numbering
    
    * Add detailed docs on modifying existing constraint
    
    * Shorten and clean up explanatory copy
    
    * Explain purpose of oscal-external constraints
    
    * Clarify oscal file for generic constraints only
    
    * Add guidance for using which FR constraints file
    
    * [skip ci] Docs for deleting tests, links to PR docs
    
    * Add @Rene2mt's feedback about testing one constraint by ID
    
    Clearly this guy constraints!
    
    Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
    
    * [skip ci] Clean up typos, grammar, and missing info per @Rene2mt's PR feedback
    
    Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
    
    ---------
    
    Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
    aj-stein-gsa and Rene2mt committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    eef8d39 View commit details
    Browse the repository at this point in the history
  19. Add back-matter constraints resource-has-{title,rlink} (#650)

    * Added constraints and tests for resource-has-(title/rlink)
    
    * metapath cleanup
    
    * Add comment
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    
    * Add comment
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    
    * Added or base64 condition
    
    * Cleanup
    
    * Edit constraint name
    
    ---------
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    Gabeblis and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f661814 View commit details
    Browse the repository at this point in the history
  20. Update docs with docker install and other walkthrough improvements (#666

    )
    
    * [skip ci] More appropriate README title for #659
    
    * [skip ci] Context for constraints, tools for #659
    
    Be sure to talk about the constraints and their relationship to the tool,
    do not just talk about the `oscal-cli` without context. Re-order some of
    the info, talk about target audience before install instructions.
    
    * [skip ci] Remove dupe copy of 'who for?' for #659
    
    * [skip ci] Subject is FR not only FR devs in #659
    
    * [skip ci] No more header numbers, add headers #659
    
    * [skip ci] Better intro and simple diagram for #659
    
    * [skip ci] Docker install prerequisites for #659
    
    * [skip ci] More install and command docs for #659
    
    * [skip ci] Clearer wording on OCI tool for #659
    
    * [skip ci]  Feedback for #659, re manual clone step
    
    * [skip ci] Remove dangling this for #659
    
    Thanks to @david-waltermire for catching that.
    
    * [skip ci]  Align arguments docs, examples for #659
    
    Based on some more detailed feedback from @Rene2mt that matched other
    comments from Dave in the PR.
    
    * Good catch, @gabelis, fix numbering for #659
    aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    51055c2 View commit details
    Browse the repository at this point in the history
  21. Feature/data center constraints (#639)

    * introduce data center constraints
    
    * complete data center constraints
    
    * Update src/validations/constraints/content/ssp-all-INVALID.xml
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    
    * Update src/validations/constraints/content/ssp-all-VALID.xml
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    
    * Update src/validations/constraints/content/ssp-location-INVALID.xml
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    
    * remove allowed-type data center country code
    
    * Late review feedback: align country code example with constraint
    
    * Fix the correction that broke negative testing, sorry Paul
    
    ---------
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    wandmagic and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    001d5db View commit details
    Browse the repository at this point in the history
  22. Test GHCR integration with "in upstream" branch instead of fork with …

    …write perms dropping (#665)
    
    * Add initial OCI spec for container for #655
    
    * Now add FR constraint files for #655
    
    * Woops, fix typo in clone path for fd_data_dl scratch container
    
    * Constraints in /opt/fedramp sudir, make it WORKDIR
    
    * Switch to Alpine Maven scratch image not Debian
    
    * Switch to Node for final image, install oscaljs
    
    * Add checkout data to final image
    
    * Fix missed parameterization of git image
    
    * Add non-default OCI image build target for make
    
    * Verify GPG signaure of oscal-cli build
    
    * Add clean target for OCI image builds
    
    * Allow for TLS bypass and proxy in Makefile
    
    Disable cert-checking for the local version that is built on laptops for
    GSA staff who make use of a VPN/proxy solution that intercept all TLS
    communication for security monitoring. This includes not just Docker,
    but also the containers as they build an image. Since production images
    will be made in GitHub Actions without the Makefile, these directives
    will be ignored.
    
    * Do not do slow git clone, use local COPY instead
    
    For speed, ease of access, and leave commit metadata from the container
    ID linked to the commit hash itself, just copy from the outside context
    of the image build.
    
    * Add publish target to Makefile with useful tags
    
    Also try docker push to GHCR to start before moving on the "in pipeline"
    build with GitHub Actions.
    
    * Fix repeat docker commands for correct tag-n-push
    
    * Correct the org.opencontainers.image.source label
    
    * Actions: perms for writing packages (ghcr.io)
    
    * Actions: follow GH tutorial, more perms added
    
    * Actions: build, sign, push, attest and OCI image
    
    This workflow change is the first attempt at building, pushing, and
    signing the validation-tools image to push to the ghcr.io registry.
    
    * Actions: ref_name for image tags problematic
    
    For both PRs and non-PR branches, that seems to cause problems for tags
    that we ought to avoid for now.
    
    * Actions: use action correctly, no manual labels
    
    * Actions: remove metadata from Dockerfile, use GHA
    
    * Actions: woops, forgot explicit checkout path
    
    Our GHA CI/CD checks out to `./git-content`, `.` by default so the action
    directive looking for context did not find the Dockerfile.
    
    * Actions: check if least privilege perms block push
    
    See more details in this reply and the larger context from others who
    cannot push a built container to ghcr.io.
    
    https://github.com/orgs/community/discussions/57724#discussioncomment-7779731
    
    * Actions: scratch that, `write-all` blocked by org
    
    The github.com/GSA organization still blocks the write to an org-level
    package in very permissive move. Tips from the discussions posts did not
    help here.
    
    https://github.com/orgs/community/discussions/57724#discussioncomment-7779731
    
    * Actions: add metadata action SHA options
    
    We need to force SHA1 long (not seven-digit short version to avoid
    collisions), remove both `sha-` prefix and remove suffix explicitly.
    
    * Actions, sigh, really remove `sha256` prefix again
    
    It seems that didn't stick the last time, so I will try this config
    again and follow the official custom hash label strategy from the action
    example from the official README.
    
    * Support MVP platforms, arm64 and amd64
    
    If not we will only support modern Apple computers with modern M1 chips,
    not Intel environments for PC and older Macs. We need broad support for
    these top platforms.
    
    * Explicit platform option for buildx too for #656
    
    It seems this may be needed because I still get similar but different
    warnings on multi-platform docker builds when using on macOS on an Apple
    laptop with a M1 processor and amd64 processor for personal computers
    with Windows and Linux operating systems respectively.
    
    > WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v3) and no specific platform was requested
    
    * Pin metadata action and update configs for #656
    
    - Had a slightly wrong version of docker/metadata-action that could not
    use annotations properly, hence no annotations on image.
    - Use annotations instead of custom override labels with that action.
    - Update docker/build-push-registry action to retrieve those labels as
    well.
    - Change subject name for attestation to end with `-attestation` suffix
    to make the GHCR registry entries less confusing.
    
    * Woops, attestation subject === image name for #656
    
    I re-read the dogs. Attestations will be uploaded to Sigstore but I will
    not busy up the registry with them every moment as it will make it even
    more confusing for novice users and advanced developers what data they
    are looking for by content-addressable git commit hash ID.
    
    * Explanatory comments on Dockerfile lint for #656
    
    For future analysis or assessment, I am leaving information in the
    Dockerfile as comments to address warning output in docker build and
    push flagging a potential finding re secrets based on variable names.
    
    ```sh
     4 warnings found (use docker --debug to expand):
     - SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "OSCAL_CLI_GPG_KEY") (line 20)
     - SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "TEMURIN_APK_KEY_URL") (line 45)
     - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 17)
     - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 43)
    ```
    
     They are IDs to secrets, not actually secrets, now I have documented it.
    
    * Attestations need explicit reg push off for #656
    
    Just removing it may not have done the trick.
    aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5a0e799 View commit details
    Browse the repository at this point in the history
  23. Add back-matter 'has' constraints (#654)

    * Added back-matter 'has' constraints
    
    * Set levels to 'ERROR'
    Gabeblis authored and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9a636ea View commit details
    Browse the repository at this point in the history
  24. Actions: tighten when docker build runs and how (#682)

    * Actions: tighten when docker build runs and how
    
    - We do not want to fails build when staff and community make fork PRs.
    - We want to make sure the latest feature branch is tagged and deployed
    for now, stop push PR container builds before merge.
    
    * Actions: more explicit branch targeting
    
    I am not sure that syntax is air-tight with var == 'value1' || 'value2',
    so make it more explicit and have var on left side and right side of the
    boolean OR check.
    
    * Actions: even more explicit use startsWith syntax
    
    * Actions: one last attempt to force annotations
    aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8f35179 View commit details
    Browse the repository at this point in the history
  25. Trigger push on master, dev, feature branches

    I had incorrectly put it on workflow_dispatch which will not help as
    needed.
    aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6ac1829 View commit details
    Browse the repository at this point in the history
  26. Add system-owner role (#693)

    * Add system-owner role
    
    * Adjust wording to be more friendly to users with less OSCAL knowledge.
    
    ---------
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    DimitriZhurkin and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a467b96 View commit details
    Browse the repository at this point in the history
  27. introduce missing-response-components constraint (#688)

    * introduce missing-response-components constraint
    
    * Add review feedback from AJ before merge
    
    ---------
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    wandmagic and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    62b8b07 View commit details
    Browse the repository at this point in the history
  28. Update SSP metadata role constraints (#676) (#686)

    * Update SSP metadata role constraints
    
    * Adjust message text to be more approachable, per PR feedback
    
    ---------
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    DimitriZhurkin and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e3cd610 View commit details
    Browse the repository at this point in the history
  29. Add system-characteristics 'categorization-has' constraints (#671)

    * Added system-characteristics 'categorization-has constraints and tests
    
    * Adjust path style and message wording per my PR feedback
    
    ---------
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    Gabeblis and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    60e454f View commit details
    Browse the repository at this point in the history
  30. Add system-characteristics 'has-assurance-level' constraints (#701)

    * Add system-characteristics 'has-assurance-level' constraints & tests
    
    * Make uniform wording for informational findings per PR review
    
    ---------
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    Gabeblis and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3867163 View commit details
    Browse the repository at this point in the history
  31. introduce metaquery script (#699)

    * introduce metaquery script
    
    * Update CONTRIBUTING.md
    
    * Tweak header for mq explanation in CONTRIBUTING.md
    
    ---------
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    wandmagic and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    55d8300 View commit details
    Browse the repository at this point in the history
  32. Add system-characteristics 'has-network-architecture' constraints (#707)

    * Added   constraints & tests
    
    * Corrected message
    Gabeblis authored and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    28b3c42 View commit details
    Browse the repository at this point in the history
  33. Add system-characteristics 'has-authorization-boundary' constraints (#…

    …702)
    
    * Added system-characteristics 'has-authorization-boundary' constraints & tests
    
    * Style corrections
    
    * Rephrase
    
    * Fix IAL-FAL acronym typo and wrap up review.
    
    ---------
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    Gabeblis and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5817efb View commit details
    Browse the repository at this point in the history
  34. General cleanup related to 'system-characteristics' constraints (#710)

    * Fixed targets, created separate invalid files where necessary, redirected yaml fail test files where necessary, removed 2 constraints that are handled by the schema
    
    * Fixed targets, created separate invalid files where necessary, redirected yaml fail test files where necessary, removed 1 constraint that is handled by the schema
    
    * cleanup
    Gabeblis authored and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2eb5b60 View commit details
    Browse the repository at this point in the history
  35. Test data optimization ADR (#700)

    * Introduce test data optimization ADR
    
    * Correction: only scaffold invalid test data file
    
    * Provide more detail in ADR
    
    * Date correction
    
    * Add solution & consequences
    
    * Add reference to #710.
    
    ---------
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    Gabeblis and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    81151e4 View commit details
    Browse the repository at this point in the history
  36. Improve dev constraint script (#690)

    * add option to specify test content be made from template or use all invalid
    
    * improve scaffolding for negative test cases
    
    * introduce re-run script
    
    * update contributing docs for rerun info
    
    * improve scaffolding
    
    * adjust constraint script to match feedback
    
    * Update dev-constraint.js
    wandmagic authored and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b5f3965 View commit details
    Browse the repository at this point in the history
  37. ssp-all-INVALID.xml deprecation (#713)

    * Created separate invalid test data file and edited the yaml fail case file to reference the new invalid test data file for each constraint in
    
    * Created separate invalid test data file and edited the yaml fail case file to reference the new invalid test data file for each constraint in
    
    * Removed deprecated invalid test data files
    
    * Rename invalid test data files
    
    * Delete ssp-all-INVALID.xml (obviously)
    Gabeblis authored and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f0c8271 View commit details
    Browse the repository at this point in the history
  38. add parrellel 4 to npm test (#717)

    wandmagic authored and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d37356d View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    f69caee View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    a6c3665 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    7fff529 View commit details
    Browse the repository at this point in the history
  42. Add container-based debugging info for CONTRIBUTING.md (#725)

    * [skip ci] Fix Makefile menu items for #697
    
    * [skip ci] Add container debug approach for #697
    
    * [skip ci] Fix docker cmd formatting for #697
    
    * [skip ci] Fix docs, add entrypoint info for #697
    
    * [skip ci] Path important for docker mounts in #697
    aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    edc2996 View commit details
    Browse the repository at this point in the history
  43. Add virtual, public, and allows-authenticated-scan allowed values (#728)

    * Add allowed-values (virtual, public, allows-authenticated-scan)
    
    * Add YAML and ssp-virtual-INVALID..xml
    
    * Add YAML and INVALID for public and authorized-scan allowed values.
    
    * Rebase the branch and add "inventory-item" to constraints
    
    * Fix feature inventory of tests per feedback
    
    ---------
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    DimitriZhurkin and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9735921 View commit details
    Browse the repository at this point in the history
  44. Hotfix/dev constraint (#727)

    * hotfix post scaffold run
    
    * Update dev-constraint.js
    
    * remove conflicting legacy files
    wandmagic authored and aj-stein-gsa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1299cde View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    00faa6d View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Don't make dupe ADR 6, properly number ADR 8 (#733)

    * [skip ci] No dupe ADR 6, properly number ADR 8
    
    * [skip ci] Rename file from ADR 6 -> ADR 8
    
    * [skip ci] 0-pad ADR 7 filename to match others
    
    * Updated ADR #8 status
    
    ---------
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    aj-stein-gsa and Gabeblis authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e45b2d8 View commit details
    Browse the repository at this point in the history
  2. Add security level constraints (#732)

    * Add security level constraints
    
    * Reduce out-of-context data not needed by security-level
    
    ---------
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    Rene2mt and aj-stein-gsa authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    2974ae3 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. hotfix constraint script for windows (#740)

    * hotfix constraint script for windows
    
    * Update test-scripts.yml
    
    * remove debug log
    
    * Update test-scripts.yml
    
    * update dev constraint
    
    * Update dev-constraint.js
    
    * sort files listed from directories
    wandmagic authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    478908e View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Add ADR for constraint-based help documentation by URL for SARIF-base…

    …d results output (#735)
    
    * [skip ci] Start up ADR 9 from template for #720
    
    * [skip ci] Add context for decision in #720
    
    * [skip ci] Add possible solutions for #720
    
    * [skip ci] Hyperlink oscal-cli for bg in #720 PR
    
    * [skip ci] Fix Metachema->Metaschema typos for #720
    
    * [skip ci] Add consequences of decisions for #720
    
    * [skip ci] Spacing and style guide for S4 in #720
    
    * [skip ci] Recommend Solution 4 for #720
    
    * [skip ci] Reorg and improve decision rec for #720
    
    * [skip ci] Missed or required for decision in #720
    
    * [skip ci] Clarify backporting and new dev for #720
    
    * [skip ci] Clarify Metaschema data-types and structure per out-of-band PR review
    
    * [skip ci] Correct namespace per PR feedbacm.
    
    Co-authored-by: David Waltermire <davewaltermire@gmail.com>
    
    * [skip ci] Correct grammar, editing-edit per review
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    
    * [skip ci] Clarify team vetted ahead of community
    
    Per valid PR feedback, we should clarify that AJ and the team drafted
    and reviewed the PR ahead of soliciting community review and feedback.
    
    * [skip ci] Add newlines for `help-markdown` per final feedback
    
    Co-authored-by: David Waltermire <davewaltermire@gmail.com>
    
    ---------
    
    Co-authored-by: David Waltermire <davewaltermire@gmail.com>
    Co-authored-by: Kylie Hunter <kylie.hunter@gsa.gov>
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    4 people authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4cd6cec View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Some container images are not built on dev (#750)

    While working on #729, I realized we have filtered out some image builds targeting dev now that the feature branch is gone. This change will allow more pre-release evaluation of constraints as they are developed.
    
    I should have PRed this or delegated it after we merged in the long-standing feature/external-constraints branch, but this miss was an oversight on my part.
    aj-stein-gsa authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    5da9318 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8301e38 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Add system-has-id constraint (#744)

    * Add  constraint and tests
    
    * Add help-url prop
    Gabeblis authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b9513d2 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Update oscal-cli from 2.1.0->2.2.0 in Docker install (#766)

    I worked on the metaschema-framework/oscal-cli release but I was unable to finish a native OCI container build there. So, we need to update here manually again. This PR quickly addresses that.
    aj-stein-gsa authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a7309c4 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Add information-type-800-60-v2r1 (#764)

    * Add information-type-800-60-v2r1
    
    * In target, add system URL ([@System='https://doi.org/10.6028/NIST.SP.800-60v2r1'])
    
    * In ssp-information-type-id-INVALID.xml, add another invalid information-type-id
    DimitriZhurkin authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9d50039 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. [skip ci] Use team for all devs for code reviews (#783)

    We need to reviews from at least three members of the team, we should
    reconfigure the repo to use CODEOWNERS with not only admins, but the
    group that includes all the team.
    aj-stein-gsa committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5a1e56c View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Configuration menu
    Copy the full SHA
    7b7e010 View commit details
    Browse the repository at this point in the history
  2. Hotfix/info (#780)

    * fix informational constraint handling and make ssp-all valid correct
    
    * revert external constraint changes
    
    * Update fedramp-external-constraints.xml
    
    * Update fedramp_extensions_steps.ts
    
    * update info handling
    
    * Update fedramp-external-constraints.xml
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    
    * Update fedramp-external-constraints.xml
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    
    * Update fedramp-external-constraints.xml
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    
    * Update fedramp-external-constraints.xml
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    
    * Update src/validations/constraints/fedramp-external-constraints.xml
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    
    * Update src/validations/constraints/fedramp-external-constraints.xml
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    
    * Update dev-constraint.js
    
    ---------
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    wandmagic and Gabeblis authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    168e47a View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Add allowed-values metadata fedramp-version (#800)

    * Add allowed-values metadata fedramp-version
    
    * Add fedramp-external-constraints.xml, ssp-fedramp-version-INVALID.xml, fedramp-version-FAIL.yaml, fedramp-version-PASS.yaml
    
    * Implement reviewers' comments
    
    * Add remarks
    
    * Update help-url
    DimitriZhurkin authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    5478c59 View commit details
    Browse the repository at this point in the history
  2. Add security-sensitivity-level-matches-security-impact-level (#786)

    * Add security-sensitivity-level-matches-security-impact-level
    
    * Modify the message wording
    
    * In the message, change MUST to SHOULD
    DimitriZhurkin authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    41d76e9 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. 818 fix data center (#819)

    * fixed data center property arguments in ssp-all-VALID
    
    * changed data-center constraints to point to name = type, value = data-center
    
    * made unit tests much more specific to their file name, AKA only one error occurs in each file
    
    * Update src/validations/constraints/content/ssp-data-center-US-INVALID.xml
    
    Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
    
    * Update src/validations/constraints/content/ssp-data-center-alternate-INVALID.xml
    
    Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
    
    * Update src/validations/constraints/content/ssp-data-center-country-code-INVALID.xml
    
    Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
    
    * Update src/validations/constraints/content/ssp-data-center-primary-INVALID.xml
    
    Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
    
    * Update src/validations/constraints/content/ssp-data-center-primary-INVALID.xml
    
    Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
    
    * Update src/validations/constraints/content/ssp-data-center-US-INVALID.xml
    
    Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
    
    * Update src/validations/constraints/fedramp-external-constraints.xml
    
    Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
    
    * Update src/validations/constraints/fedramp-external-constraints.xml
    
    Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
    
    * Update src/validations/constraints/fedramp-external-constraints.xml
    
    Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
    
    * Update src/validations/constraints/content/ssp-data-center-count-INVALID.xml
    
    Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
    
    ---------
    
    Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
    kyhu65867 and aj-stein-gsa authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a08c9da View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Add responsible-party-is-person constraint (#652)

    * Add responsible-party-is-person constraint
    
    * Add help-url
    
    * Update constraint to only validate required roles
    
    * Make updates resolving review feedback comments
    Rene2mt authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    cd0ff59 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Add unit test metaschema conformant with ADR#6 (#826)

    * [skip ci] Metaschema module for unit test struct
    
    We are proposing changes to the structure of the JSON/YAML unit test
    file used for all constraints test suite management. This version
    documents the model of that YAML file before the proposed change in the
    comments of the #817 PR, linked below.
    
    #817 (comment)
    
    * [skip ci] Document unit test metaschema elements
    
    * [skip ci] Do not explicitly use default types
    
    * [skip ci] Add missing `@id` and `@level` to model
    
    * [skip ci] Add pipeline to pipeline, thx @wandmagic
    
    * [skip ci] Backport #219 docs into model remarks
    
    * [skip ci] Fix max-occurs re bad model cardinality
    
    This addresses changes that should be handled as determined by upstream
    guidance from metaschema-framework maintainers.
    
    metaschema-framework/metaschema-java#221
    metaschema-framework/metaschema#44
    
    * [skip ci] Is a pipeline with a ref even a pipeline at all?
    
    Thanks to @Rene2mt for PR feedback about the missing ref to the assembly definition of pipeline in the model.
    
    Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
    
    ---------
    
    Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
    aj-stein-gsa and Rene2mt authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    bc9a2a3 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Add import-profile-has-href-attribute constraint (#817)

    * Add import-profile constraints and tests
    
    * Add different valid tests
    
    * Add descriptions to test files to distinguish test cases
    
    * Add functionality to run mutliple content files. Deleted extra yaml files, and preserved 1 pass/fail yaml file per constraint structure
    
    * Constraint test & test file cleanup
    Gabeblis authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    1093dce View commit details
    Browse the repository at this point in the history
  2. 640 readme cleanup (#771)

    * fixed error in the OSCAL deprecation strategy section that implied that an oscal version 1.0.0 would not support 1.0.1 +
    
    * updated Rev 4 to Rev 5 under Dependencies
    
    * fixed broken link
    
    * Removed Rules Documentation Section
    
    * Removed Implementation Details
    
    * Enclosed manual install instructions in a drop down
    
    * Enclosed manual install instructions in a drop down
    
    * Enclosed container upgrade instructions in a drop down
    
    * Updated NIST OSCAL version in dependencies
    
    * Dual overhaul of the overview and addition of information about validation tooling
    
    * Changed the order of the sections on main readme
    
    * removed out of date information about release of rev 5 guidance
    
    * Some general cleanup
    
    * Cleaning up some things, and adding a table?
    
    * cleaning up pt 2
    
    * cleaning up pt 3
    
    * Picking up from yesterday. Cleaning up wording, adding some drop downs
    
    * added .bash_profile to path information
    
    * changed to OSCAL syntax generaly instead of just SSPs
    
    * Update README.md
    
    Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
    
    * Update README.md
    
    Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
    
    * Update README.md
    
    Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
    
    * cleaning up introduction, implementing AJ's feedback, and adding a portion about visiting the automation website for our documentation
    
    * no need to have a table with different resources if our only resource is the tooling. Correct me if I'm wrong
    
    * this information will all be deprecated soon so no need to explicitly discuss it.
    
    * deleted per AJ's advice
    
    * made this link relative
    
    * deleted per AJ's advice
    
    * fixing typos and awkward wording in the versioning and deprecation section
    
    Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
    
    * Fixing spacing
    
    Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
    
    * changed build requirements to latest version of Java, removed Python
    
    ---------
    
    Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
    Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
    3 people authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    cb9f6b4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c5fee7a View commit details
    Browse the repository at this point in the history
  4. target cleanup

    Gabeblis authored and aj-stein-gsa committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    fdf0b9c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6ebcf22 View commit details
    Browse the repository at this point in the history
  6. Add more detailed test descriptions

    Gabeblis authored and aj-stein-gsa committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    c2195bb View commit details
    Browse the repository at this point in the history
  7. add help-url props

    Gabeblis authored and aj-stein-gsa committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    fceae0e View commit details
    Browse the repository at this point in the history
  8. caps lock hello?

    Gabeblis authored and aj-stein-gsa committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    cc722bd View commit details
    Browse the repository at this point in the history
  9. fix message

    Gabeblis authored and aj-stein-gsa committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    a975542 View commit details
    Browse the repository at this point in the history
  10. add n

    Gabeblis authored and aj-stein-gsa committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    059cd23 View commit details
    Browse the repository at this point in the history
  11. fix feature order

    Gabeblis authored and aj-stein-gsa committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    d0ed82e View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    60d6731 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    9b92ba8 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    d1b3411 View commit details
    Browse the repository at this point in the history
  15. merge correction

    Gabeblis authored and aj-stein-gsa committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    20ae02c View commit details
    Browse the repository at this point in the history
  16. Add more detailed test descriptions

    Gabeblis authored and aj-stein-gsa committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    0ba66b1 View commit details
    Browse the repository at this point in the history
  17. Add help-url props

    Gabeblis authored and aj-stein-gsa committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    6ecaec5 View commit details
    Browse the repository at this point in the history
  18. What even is caps lock?

    Gabeblis authored and aj-stein-gsa committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    c99b70c View commit details
    Browse the repository at this point in the history
  19. Message correction

    Gabeblis authored and aj-stein-gsa committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    f4d75f6 View commit details
    Browse the repository at this point in the history
  20. Add n

    Gabeblis authored and aj-stein-gsa committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    8cf8e0f View commit details
    Browse the repository at this point in the history
  21. Add system-characteristics 'cia-has' and 'has-system-name-short' cons…

    …traints (#689)
    
    * Added system-characteristics 'cia-impact' and 'has-system-name-short' constraints and tests
    
    * rephrase for clarity
    
    * Create separate invalid tests
    
    * Add more detailed test descriptions
    
    * Adjust ssp-all-VALID.xml to have valid security levels
    
    * Cleanup metapath
    
    * Add help-url props
    
    * Capitalize things
    
    * add n
    Gabeblis authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    04d3591 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. introduce user constraints (#743)

    * introduce user constraints
    
    * introduce help props
    
    * adjust help uri coverage
    
    * Update src/validations/constraints/fedramp-external-constraints.xml
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    
    * Update src/validations/constraints/fedramp-external-constraints.xml
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    
    * Update src/validations/constraints/fedramp-external-constraints.xml
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    
    * Update src/validations/constraints/fedramp-external-constraints.xml
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    
    * Update src/validations/constraints/fedramp-external-constraints.xml
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    
    * see GSA/automate.fedramp.gov#98
    
    * merge same invalid samples
    
    * Update user-type-FAIL.yaml
    
    * Update user-type-FAIL.yaml
    
    * update tests
    
    * Update src/validations/constraints/fedramp-external-allowed-values.xml
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    
    * Update src/validations/constraints/content/ssp-all-VALID.xml
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    
    * update tests
    
    ---------
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    wandmagic and aj-stein-gsa authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5cb7351 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aa059aa View commit details
    Browse the repository at this point in the history
  3. Delete legacy code from repository (#841)

    * [skip ci] Delete deprecated code for #738
    
    * [skip ci] Remove oscal submodule and deps for #738
    
    * [skip ci] Remove Makefile for #738
    aj-stein-gsa authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c6c2b0c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2b0e49c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    63e6757 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b8d2925 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Configuration menu
    Copy the full SHA
    fe36bc5 View commit details
    Browse the repository at this point in the history
  2. add oscal server (#850)

    * add oscal server
    
    * content array
    
    * add docs
    wandmagic authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    f53b26f View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. added ADR-12

    Brian Ruf authored and aj-stein-gsa committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    407bc48 View commit details
    Browse the repository at this point in the history
  2. Update documents/adr/0012-constraint-strategy.md

    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    2 people authored and aj-stein-gsa committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    79c6b58 View commit details
    Browse the repository at this point in the history
  3. Update documents/adr/0012-constraint-strategy.md

    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    2 people authored and aj-stein-gsa committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a13ab63 View commit details
    Browse the repository at this point in the history
  4. Update documents/adr/0012-constraint-strategy.md

    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    2 people authored and aj-stein-gsa committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    8bdba06 View commit details
    Browse the repository at this point in the history
  5. Update documents/adr/0012-constraint-strategy.md

    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    2 people authored and aj-stein-gsa committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    ca1ddda View commit details
    Browse the repository at this point in the history
  6. Update documents/adr/0012-constraint-strategy.md

    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    2 people authored and aj-stein-gsa committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    bbf1893 View commit details
    Browse the repository at this point in the history
  7. Update documents/adr/0012-constraint-strategy.md

    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    2 people authored and aj-stein-gsa committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    857d825 View commit details
    Browse the repository at this point in the history
  8. Update documents/adr/0012-constraint-strategy.md

    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    2 people authored and aj-stein-gsa committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    4db89db View commit details
    Browse the repository at this point in the history
  9. Update documents/adr/0012-constraint-strategy.md

    Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
    brian-ruf and aj-stein-gsa committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    527d5e1 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    67734f9 View commit details
    Browse the repository at this point in the history
  11. per a PR comment, added examples for each automtion type.

    Brian Ruf authored and aj-stein-gsa committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    64e15e9 View commit details
    Browse the repository at this point in the history
  12. clarified the ADR focus statement

    Brian Ruf authored and aj-stein-gsa committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    7f31955 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    13d17aa View commit details
    Browse the repository at this point in the history
  14. Remove make target for web app for #783 post-#841

    It turns out I left an errant Makefile target that is no longer needed.
    See the removed target from the targeted Makefile module, but it was
    left in the top-level targets and referenced in the still active `clean`
    target.
    
    https://github.com/GSA/fedramp-automation/pull/841/files#diff-b0fa8ca7ead097f81107867d3e7cea11f7b622267b326985e8d7f8763031ea1a
    aj-stein-gsa committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    fcdd25e View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Fix import-profile constraints

    Gabeblis authored and aj-stein-gsa committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a01e93f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5136f25 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bdb50b0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7575314 View commit details
    Browse the repository at this point in the history
  5. Message tweak

    Gabeblis authored and aj-stein-gsa committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    247f99a View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Configuration menu
    Copy the full SHA
    a2416e1 View commit details
    Browse the repository at this point in the history
  2. Apply Style Guide To Constraints (#852)

    * Add props to each constraint that has sufficient existing documentation
    
    * Sort constraints alphabetically and sort ascending by metapath specificity
    
    * Add missing (and available) help-url
    
    * IETF BCP14 Keywords in Constraint Messages
    
    * spacing between context blocks for readability
    
    * sort alphabetically and use consistent spcaing.
    Gabeblis authored and wandmagic committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    3542c96 View commit details
    Browse the repository at this point in the history
  3. Style Guide Constraints (#856)

    * Create style guide for FedRAMP OSCAL Constraints (#760)
    
    * Remove FedRAMP namespace from 'data-center' props (#795)
    
    * Hotfix/info (#780)
    
    * fix informational constraint handling and make ssp-all valid correct
    
    * revert external constraint changes
    
    * Update fedramp-external-constraints.xml
    
    * Update fedramp_extensions_steps.ts
    
    * update info handling
    
    * Update fedramp-external-constraints.xml
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    
    * Update fedramp-external-constraints.xml
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    
    * Update fedramp-external-constraints.xml
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    
    * Update fedramp-external-constraints.xml
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    
    * Update src/validations/constraints/fedramp-external-constraints.xml
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    
    * Update src/validations/constraints/fedramp-external-constraints.xml
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    
    * Update dev-constraint.js
    
    ---------
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    
    * [skip ci] Create style guide doc for #675
    
    * [skip ci] FSCR-1 re external constraints for #675
    
    * [skip ci] FCSR-1, woops, need formal name for #675
    
    * [skip ci] Tweak FCSR-1 anchor ID in #675
    
    * [skip ci] Stop header hacks for IDs in #675
    
    I read more about these techniques than I would like, but none of them
    appear to work effectively for making anchors like `#fcsr-1` without
    adding other content to the anchor which I would like to avoid.
    
    https://gist.github.com/asabaylus/3071099?permalink_comment_id=3895584
    
    Either it never worked or something changed. Oh well!
    
    * [skip ci] Add FCSR-2 on context sorting for #675
    
    * [skip ci] Add FCSR-3 about alpha sorting for #675
    
    * [skip ci] Add FCSR-4 to require help-url for #675
    
    * [skip ci] Adjust title from style guide to dev style guide per Rene's review
    
    * [skip ci] Adjust grammar and style per Rene's review
    
    Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
    
    * [skip ci] @Rene2mt's feedback: add ID req for #675
    
    * [skip ci] @Rene2mt's feedback: level req for #675
    
    * [skip ci] @Rene2mt's review: why CRITICAL for #675
    
    * [skip ci] Woops, missed IDs for reqs for #675
    
    * [skip ci] Feedback: add message req for #675
    
    * [skip ci] Fix constraint path in examples for #675
    
    * [skip ci] Add remarks rec guidance for #675
    
    * [skip ci] Add @wandmagic's rec for FCSR-1 for #675
    
    * [skip ci] Add FCSR-10 re active voice for #675
    
    * [skip ci] Remove FCSR-10's incorrect only for #675
    
    * [skip ci] Add FCSR-11 about BCP14 words for #675
    
    * [skip ci] Add no-jargon req FCSR-12 for #675
    
    * [skip ci] Item, not sequence style req for #675
    
    * [skip ci] Add req for sequence ctx hints for #675
    
    * [skip ci] Add FCSR-15 re formal-names for #675
    
    * [skip ci] Remove anchor hack from FCSR-1 for #675
    
    * [skip ci] Wrap up kebab case IDs, reorder for #675
    
    * [skip ci] Fixes from @Rene2mt'2 review for #675
    
    * [skip ci] Add labels for rules in #675
    
    * [skip ci] Simplify rule titles for #675
    
    Follow feedback from @brian-ruf in his review.
    
    * [skip ci] Finalize table index with reqs for #645
    
    * [skip ci] Limit informational constraints for #675
    
    * [skip ci] Feedback: FRR1 about OSCAL constraints, not Metaschema constraints
    
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * [skip ci] Update FRR1 in table listing too
    
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * [skip ci] Add space in status row of table for FRR2
    
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * [skip ci] Add missing word to FRR3 title
    
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * [skip ci] Improve the prose in FRR2 guidance
    
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * [skip ci] Reorder statements in sentence of FRR2 guidance
    
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * [skip ci] Clarify ambiguous wording in FRR5
    
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * [skip ci] Correct typos in FRR6 formal name
    
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * [skip ci] Make FRR7 formal name more explicit
    
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * [skip ci] Improve FRR8 formal name
    
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * [skip ci] Fix FRR8 formal name in table index
    
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * [skip ci] Fix FRR9 formal name in table index
    
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * [skip ci] Fix FRR9 formal name in table index
    
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * [skip ci] Adjust FRR9 guidance to specify expect constraints
    
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * [skip ci] Adjust FRR9 constraint examples for correct type
    
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * [skip ci] Adjust FRR10 formal name to be more clear
    
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * [skip ci] Fix FRR10 formal name in table index
    
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * [skip ci] Make FRR11 formal name better sentence fragment
    
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * [skip ci] Fix FRR11 above requirement text
    
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * [skip ci] Adjust FedRAMP reqs prefix FCSR->FRR
    
    Given related work in the program, I want to generalize the prefix to be
    more general and global for all form of FedRAMP requirements down the
    road.
    
    * [skip ci] Add missing examples to FRR17 for #675
    
    * [skip ci] Align formal names, spacing for #675
    
    I had to fix up some of the formal names where Dave covered some of them
    in many places, but not all. Also other suggestions add some space.
    
    * [skip ci] Add level to many examples, finish #675
    
    * [skip ci] Fold longer bg info for reqs in #675
    
    * [skip ci] Clarify FRR1 bad example is bad in #645
    
    * [skip ci] Clarify context order examples for #675
    
    * [skip ci] Clarify case sorting for FRR3 in #675
    
    * [skip ci] Clean up explanation of FRR10 for #675
    
    * [skip ci] Fix typos in FRR13 and FRR15 for #675
    
    * [skip ci] FRR2 feedback from Kylie for #675
    
    * [skip ci] Reword FRR9 with Kylie's feedback in #675
    
    * [skip ci] Woops, FRR16 twice, no FRR17 for #675
    
    * [skip ci] Last call and let reqs in FRR18 for #675
    
    * [skip ci] Correct ID for FRR18 to anchor in table
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    
    * [skip ci] Offset req ID sequence
    
    Per discussion with others on a call with leads and staff from both FR
    branches, begin with an offset sequences and reserve the first 100 for
    other uses for the time being.
    
    /cc @kscarf1
    
    * [skip ci] BCP14 keywords in #675 summary text
    
    * [skip ci] Tighten up summary text more for #675
    
    * [skip ci] Add back to top anchors for #675
    
    * [skip ci] Better grammar and flow for #675 summary
    
    * [skip ci] Improve FRR102 guidance text for #675
    
    * [skip ci] Capitalize and fix FRR110 title for #675
    
    * [skip ci] Fix poor grammar in FRR117 text for #675
    
    * [skip ci] Explicit docs URL in FRR104 for #675
    
    Address missing feedback to @kyhu65867 from review that had not been
    previously addressed by yours truly.
    
    * [skip ci] Fix FRR105 with feedback for #675
    
    Address some feedback about wording and style  of the unique ID req.
    
    * [skip ci] Fix FRR103 spacing for #675
    
    Completely address feedback from @david-waltermire after checking for
    final review of style guide left in the comment below.
    
    #760 (comment)
    
    * [skip ci] Fix FRR108 conformant example for #675
    
    ---------
    
    Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
    Co-authored-by: wandmagic <156969148+wandmagic@users.noreply.github.com>
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    
    * Apply Style Guide To Constraints (#852)
    
    * Add props to each constraint that has sufficient existing documentation
    
    * Sort constraints alphabetically and sort ascending by metapath specificity
    
    * Add missing (and available) help-url
    
    * IETF BCP14 Keywords in Constraint Messages
    
    * spacing between context blocks for readability
    
    * sort alphabetically and use consistent spcaing.
    
    * Add style guide constraints
    
    Add constraints to enforce style guide
    
    Place holders for constraints to add when necessary functions for implementation are supported
    
    Add formal names
    
    space
    
    Add back constraint
    
    Delete temporary test file
    
    Point help-url to develop
    
    Clean up id and formal name
    
    Script name change to test:style
    
    * Clean up errors by adding place holder urls and change data-center-US to lowercase.  Small touch up to style guide step.
    
    * make id lowercase
    
    * remove space
    
    * inject schema
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    
    * TODO
    
    * Move style guide
    
    * TODO
    
    * add help-url
    
    ---------
    
    Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
    Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
    Co-authored-by: wandmagic <156969148+wandmagic@users.noreply.github.com>
    Co-authored-by: David Waltermire <david.waltermire@gsa.gov>
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    6 people committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    39d9983 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    24a9fc1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9831309 View commit details
    Browse the repository at this point in the history
  6. validate with sarif output

    wandmagic committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    2e85192 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f265297 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    590f13d View commit details
    Browse the repository at this point in the history
  9. Update features/steps/fedramp_extensions_steps.ts

    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    wandmagic and Gabeblis committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    e4dad88 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    14484b3 View commit details
    Browse the repository at this point in the history
  11. fix new constraints

    wandmagic committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    54b7d34 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Add system-characteristics has-cloud-model constraints (#737)

    * Added 'has-cloud-model' constraints and tests
    
    * Message/grammar corrections
    
    * Remove FedRAMP namespace and fix allowed-values constraints
    
    * cloud model constraint corrections
    
    * Add condition for 'other'
    
    * Fix all-valid value
    
    * message tweak
    Gabeblis authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    110b190 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Configuration menu
    Copy the full SHA
    821ec62 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Add constraints for fully operational date (issue #853) (#876)

    * Add constraints for fully operational date
    
    * Fix constraints and add formal names
    
    * Update to align with frr103
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    
    * Update to comply with frr112
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    
    * Move has-fully-operational-date to appropriate context
    
    ---------
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    Rene2mt and Gabeblis authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    6b10783 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d4422df View commit details
    Browse the repository at this point in the history
  3. update id and error level

    wandmagic committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    596688d View commit details
    Browse the repository at this point in the history
  4. Update src/validations/constraints/fedramp-external-constraints.xml

    Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
    wandmagic and Rene2mt committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    3ef21e7 View commit details
    Browse the repository at this point in the history
  5. Update src/validations/constraints/fedramp-external-constraints.xml

    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    wandmagic and Gabeblis committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    2848c18 View commit details
    Browse the repository at this point in the history
  6. Update src/validations/constraints/fedramp-external-constraints.xml

    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    wandmagic and Gabeblis committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    5f7428e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    db7cbcd View commit details
    Browse the repository at this point in the history
  8. update filename

    wandmagic committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9ef22e2 View commit details
    Browse the repository at this point in the history
  9. Update src/validations/constraints/fedramp-external-constraints.xml

    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    wandmagic and Gabeblis committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    de6747a View commit details
    Browse the repository at this point in the history
  10. party-has-name

    wandmagic committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    75ad4d8 View commit details
    Browse the repository at this point in the history
  11. Update src/validations/constraints/content/ssp-party-has-name-INVALID…

    ….xml
    
    Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
    wandmagic and Gabeblis committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    ee2cf0d View commit details
    Browse the repository at this point in the history
  12. re-run

    wandmagic committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    4638ecf View commit details
    Browse the repository at this point in the history
  13. Update src/validations/constraints/fedramp-external-constraints.xml

    Co-authored-by: A.J. Stein <aj@gsa.gov>
    wandmagic and aj-stein-gsa committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    1292d57 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    402065a View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    54ba39c View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    366a3fc View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Configuration menu
    Copy the full SHA
    ad57a49 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a040de7 View commit details
    Browse the repository at this point in the history
  3. Add has-marking (#875)

    * Add has-marking
    
    * Update features/fedramp_extensions.feature
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    
    * Restore after pull
    
    ---------
    
    Co-authored-by: A.J. Stein <aj@gsa.gov>
    DimitriZhurkin and aj-stein-gsa authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    66c94cd View commit details
    Browse the repository at this point in the history
  4. Add Prepared By Constraints (#870)

    * Add prepared-by constraints
    
    * Add check for embedded address assembly in party
    
    * Fix messages to be less jargony
    
    * indent
    
    * Parenthesis to cleanup test expression
    
    * Add extra negative test case
    
    * undo workaround
    
    * Suggested improvements to constraint level and ssp-all-VALID
    Gabeblis authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    8a7f909 View commit details
    Browse the repository at this point in the history
  5. New oscal-js oscal-cli versions in OCI image spec

    - Update oscal-cli to the latest stable release (2.3.1).
    - Update oscal-js to the latest stable release (2.0.6).
    aj-stein-gsa committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    6211011 View commit details
    Browse the repository at this point in the history