Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs onboarding] Add select logs step #4

Open
wants to merge 228 commits into
base: logs-onboarding-landing-page-154928
Choose a base branch
from

Commits on Apr 27, 2023

  1. Configuration menu
    Copy the full SHA
    f2ff308 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bc6a1b5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    de64ff5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    18830e7 View commit details
    Browse the repository at this point in the history
  5. Bump moment-timezone to the latest version (elastic#155832)

    ## Summary
    
    Fix elastic#155792
    
    Bump `moment-timezone` from `0.5.34` to `0.5.43` (latest version) to
    include latest timezone changes
    
    ## Release Note
    
    Fix a bug causing the latest timezone changes to not be taken into
    account for date formatting (e.g Mexico 2023)
    pgayvallet committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    2250020 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bf64874 View commit details
    Browse the repository at this point in the history
  7. [Infrastructure UI] Create MetricsExplorerViewsService and MetricsExp…

    …lorerViewsClient (elastic#155878)
    
    ## 📓 Summary
    
    Depends on elastic#154900
    Closes elastic#155112  
    
    This PR implements the `InventoryViewsService` and
    `InventoryViewsClient`, injecting an instance of the client in the
    KibanaContextForPlugin and exposing so a set of utilities to
    retrieve/update inventory views:
    - `findMetricsExplorerViews`
    - `getMetricsExplorerView`
    - `createMetricsExplorerView`
    - `updateMetricsExplorerView`
    - `deleteMetricsExplorerView`
    
    ## 👣 Next steps
    - Implement elastic#154725 to consume the service
    
    ---------
    
    Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
    Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com>
    3 people committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    5422d08 View commit details
    Browse the repository at this point in the history
  8. [UnifiedFieldList] Handle exceptions in FieldPopover better (elastic#…

    …155866)
    
    ## Summary
    
    This PR wraps rendering of FieldPopover with additional try/catch and
    error boundary so we can look into exceptions if they happen.
    jughosta committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    c571a38 View commit details
    Browse the repository at this point in the history
  9. [Defend Workflows][E2E]Endpoint e2e response console multipass (elast…

    …ic#155519)
    
    This PR adds e2e test run on real endpoint for coverage of isolate,
    processes, kill-process and suspend-process commands from respond
    console.
    
    Depends on elastic#155360
    szwarckonrad committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    d80fdd6 View commit details
    Browse the repository at this point in the history
  10. [Visualize2Lens] Transfers the custom timerange to the converted panel (

    elastic#155113)
    
    ## Summary
    
    Part of elastic#147646
    
    It passes the custom timerange to the converted Lens panel for both by
    ref and by value legacy visualizations.
    It works for all paths:
    - Edit visualization--> Edit in Lens--> Replace in dashboard
    - Convert to Lens --> Replace in dashboard
    
    
    ![2](https://user-images.githubusercontent.com/17003240/233287641-82fe190d-5b92-4368-ace8-0b576a46d32a.gif)
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
    stratoula and dej611 committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    61c82dc View commit details
    Browse the repository at this point in the history
  11. [APM] Check if metric fields exist (elastic#145348)

    Fixes the error 
    ```
    "script_stack": [
                "org.elasticsearch.server@8.5.0-SNAPSHOT/org.elasticsearch.index.fielddata.ScriptDocValues.throwIfEmpty(ScriptDocValues.java:92)",
                "org.elasticsearch.server@8.5.0-SNAPSHOT/org.elasticsearch.index.fielddata.ScriptDocValues$Longs.get(ScriptDocValues.java:110)",
                "org.elasticsearch.server@8.5.0-SNAPSHOT/org.elasticsearch.index.fielddata.ScriptDocValues$Longs.getValue(ScriptDocValues.java:105)",
                """total = useCgroupLimit ? doc[limitKey].value : doc['system.memory.total'].value;
    
        double """,
                "                                                                         ^---- HERE"
    
    
    ```
    
    connected elastic/sdh-apm#765 (internal)
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>
    3 people committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    98165d2 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    f06e55f View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    1146d03 View commit details
    Browse the repository at this point in the history
  14. [Files] Adds bulk get method (elastic#155636)

    ## Summary
    
    Closes elastic#155369
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ### For maintainers
    
    - [x] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    vadimkibana and kibanamachine committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    a0cd724 View commit details
    Browse the repository at this point in the history
  15. [Saved Objects] Compatible mappings PR check (elastic#148656)

    ## Summary
    
    This PR adds a technical control to prevent incompatible mappings
    changes. These include:
    
    1. Removing mapped fields. For the foreseeable future we require that
    teams only introduce new fields - in short: this avoids the "reindex"
    step in our migrations.
    2. Changing the type of a field. We leverage ES to determine whether a
    given set of mappings can be applied "on top" of another. Similarly,
    this avoids the "reindex" step in migrations.
    
    The above checks depend on a snapshot of the mappings from `main`, these
    are the "current" mappings and are extracted from plugin code. This PR
    will bootstrap `main` with an initial set of mappings extracted from
    plugins (bulk of new lines added).
    
    ## The new CLI
    
    See the added `README.md` for details on how the CLI works.
    
    ## How will it work?
    
    Any new PR that introduces compatible mappings changes will result in a
    new snapshot being captured, then merged to main for other PRs to merge
    and run the same checks against (currently committing new snapshots
    happens in the CI check so there is no manual step of maintaining the
    snapshot).
    
    ## Additional
    
    We should consider combining this CI check with the existing check in
    `src/core/server/integration_tests/saved_objects/migrations/check_registered_types.test.ts`.
    Hopefully we can automate the check such that no manual review is needed
    from Core, not sure how we might cover the hash of the non-mappings
    related fields. We could consider narrowing the Jest test to exclude
    mappings.
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    Co-authored-by: spalger <spencer@elastic.co>
    3 people committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    e9197ad View commit details
    Browse the repository at this point in the history
  16. [Discover] Navigating from Field statistics tab to text based languag…

    …es should return to the documents view (elastic#152572)
    
    Closes elastic#152485
    ~Would be better to override this somewhere in app state management
    logic but I could not find a right place for it.~ Done
    
    Current changes make sure that for text-based queries only grid view is
    possible (both on Discover and as embeddable) and the app state will be
    updated accordingly.
    jughosta committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    f528b34 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    863d28f View commit details
    Browse the repository at this point in the history
  18. Fix integration tests: Check for root before shutdown, bail after 1 r…

    …eported issue (elastic#155938)
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    TinaHeiligers and kibanamachine committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    ab8b7c1 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    a680828 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    7efe3d5 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    d7370f0 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    b8ca723 View commit details
    Browse the repository at this point in the history
  23. [Cases] Fixing a few more integration tests with arraysToEqual (elast…

    …ic#155942)
    
    This PR fixes a few integration tests that were failing because the
    ordering of the bulk creation of attachments isn't guaranteed. The
    solution is to compare the results ignoring ordering within the arrays.
    
    Fixes: elastic#154640
    
    Flaky test runner results:
    https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2178
    🟢
    jonathan-buttner committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    7000f0d View commit details
    Browse the repository at this point in the history
  24. [Enterprise Search] ELSER model download component (elastic#155334)

    ## Summary
    
    This PR adds a panel with 3 stages of ELSER trained model deployment:
    - Model is not deployed (with button to initiate deployment)
    - Model is deploying (polling status every 5 seconds)
    - Model has deployed
    
    Note that deploying the model does not start it; this will be
    implemented in a follow-up PR.
    
    The panel is discardable in the Pipelines screen but not discardable in
    the pipeline configuration flyout.
    demjened committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    b01d60a View commit details
    Browse the repository at this point in the history
  25. [content management / maps] Content management / Saved object schema …

    …abstraction (elastic#155342)
    
    ## Summary
    
    Abstract schema definitions for using Saved Objects with the content
    management api. For most schema types, this will reduce creation to only
    the attributes specific to a saved object. For Option types (create
    options, update options, search options) the saved object api is more
    complex and its likely that most SO types will only need to use a
    portion of it. In these cases we recommend using the provided schema
    definitions as a pattern for creating simpler schemas.
    
    Follow up to - elastic#154985 - expresses
    types in schema form
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    mattkime and kibanamachine committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    0c8f38b View commit details
    Browse the repository at this point in the history
  26. [Security Solution][Endpoint] Cleanup and improvements to `run_endpoi…

    …nt_agent.js` CLI tool (elastic#155730)
    
    ## Summary
    
    As a follow up to PR elastic#155455 : 
    
    - `run_endpoint_agent` CLI: Removed internal code that handles the
    creation of a VM and the enrollment of the agent with fleet and replaced
    it with use of methods now found in `endpoint_host_services`
    - created new service for managing agent download cache on local system
    - enhanced `run_endpoint_agent` to use cached version of agent download,
    and thus increase the performance of this tool
    paul-tavares committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    99ee941 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    454418b View commit details
    Browse the repository at this point in the history
  28. [Discover] Remove legacy field stats (elastic#155503)

    Closes elastic#154841
    
    ## Summary
    
    This PR removes legacy field stats which were shown in field popover
    before. They were based on loaded hits and were less precise than the
    current default field stats (they are based now on 5000 documents per
    shard sample).
    
    Before (opt-in option):
    <img width="500" alt="Screenshot 2023-04-21 at 14 26 57"
    src="https://user-images.githubusercontent.com/1415710/233635136-ebc4017e-71c3-499d-96ac-544e26ea4b49.png">
    
    After:
    <img width="500" alt="Screenshot 2023-04-21 at 14 26 20"
    src="https://user-images.githubusercontent.com/1415710/233635194-8c60fd05-5db6-40e0-abcd-672689932a83.png">
    jughosta committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    c6b6e28 View commit details
    Browse the repository at this point in the history
  29. [Cases ]Add getAttachmentRemovalObject to file type. (elastic#156031)

    ## Summary
    
    When deleting a file user action the message displayed should be "<user>
    removed file".
    
    before
    <img width="1059" alt="Screenshot 2023-04-27 at 17 08 14"
    src="https://user-images.githubusercontent.com/1533137/234906123-48452699-a1ee-4452-b2ed-2ec3d4422ac3.png">
    
    
    after
    <img width="1063" alt="Screenshot 2023-04-27 at 17 07 56"
    src="https://user-images.githubusercontent.com/1533137/234906310-4cc9c752-da76-441e-b3de-3d6194e821cb.png">
    adcoelho committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    3480acd View commit details
    Browse the repository at this point in the history
  30. [Security Solution][Investigations] - Add tests and handle building b…

    …lock alerts (elastic#155903)
    
    ## Summary
    
    This PR accomplishes a few things:
    
    1. Make sure eql building block alerts show up when redirecting directly
    to the alerts page (demo of this fix below)
    2. Bumps up the time window from 1 ms to 5 min, to make it easier to see
    other alerts when clearing out the filters
    3. Add unit tests for the `alert_details_redirect.tsx` component
    4. Adds a cypress test to test the presence of `kibana.alert.url` in an
    alert document and updates the config with the `publicBaseUrl` field
    which is needed for the field to be present.
    
    **Before the eql fix:**
    
    
    
    https://user-images.githubusercontent.com/17211684/234636355-507b33fc-5211-4b02-9818-d1ba78fee115.mov
    
    
    
    **After the eql fix:**
    
    
    https://user-images.githubusercontent.com/17211684/234635657-bdbdc2cf-8a3e-4e5c-a14e-04f878f09e7b.mov
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    michaelolo24 and kibanamachine committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    d447797 View commit details
    Browse the repository at this point in the history
  31. [ML] Fix retention policy date field should list destination index da…

    …te fields (elastic#155765)
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    qn895 and kibanamachine committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    dcc280b View commit details
    Browse the repository at this point in the history
  32. Update XState (main) (elastic#150263)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    afb36f3 View commit details
    Browse the repository at this point in the history
  33. [Enterprise Search] Add Production Model Name to Allowed List for ELS…

    …ER API Endpoints (elastic#156020)
    
    ## Summary
    
    Small PR to add the production model name to the `acceptableModelNames`
    list that the Enteprise Search 1-Click deploy API endpoints use to check
    to ensure we have a known, valid model name.
    
    ### Checklist
    - [ ] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    markjhoy committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    fbe3aa3 View commit details
    Browse the repository at this point in the history
  34. [Enterprise Search] Enable converting native connector to custom (ela…

    …stic#155853)
    
    ## Summary
    
    This adds the ability to convert a native connector to a customized
    connector.
    
    ---------
    
    Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
    sphilipse and leemthompo committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    e44087a View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    6c5aafb View commit details
    Browse the repository at this point in the history
  36. [Fleet][Message Signing] Rotate key pair error handling (elastic#155864)

    ## Summary
    
    Adds more info to key rotation API response in case of errors.
    Follow up of elastic/pull/155252
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    ashokaditya and kibanamachine committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    ece6805 View commit details
    Browse the repository at this point in the history
  37. [D4C] Response with no actions will now show an error + fix to null p…

    …ointer when actions deleted in yaml editor. (elastic#155952)
    
    ## Summary
    
    Fixes an issue where the user could deselect all actions in a response
    (which should not be allowed).
    
    Also fixes an issue in the yaml editor if you delete all actions
    (causing a null pointer exception).
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [x]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [x] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [x] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [x] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [x] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    mitodrummer committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    096d003 View commit details
    Browse the repository at this point in the history
  38. [ResponseOps] Enable maintenance windows (elastic#156033)

    ## Summary
    
    Enables maintenance windows by setting the feature flag to `true`
    doakalexi committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    ef99b85 View commit details
    Browse the repository at this point in the history
  39. [Search Application] Update pageTemplate header to grey and rename na…

    …v item to "Search preview" (elastic#155795)
    
    ## Summary
    * Rename nav item from "Preview" to "Search Preview"
    * Update page Header to grey
    
    
    ### Screenshots
    
    <img width="1728" alt="Search preview"
    src="https://user-images.githubusercontent.com/55930906/234397633-003e4e99-680d-4531-8d94-528152fa2799.png">
    
    <img width="1728" alt="Content"
    src="https://user-images.githubusercontent.com/55930906/234397654-fb678a29-2c55-47d7-8d96-d8ce9f5164a2.png">
    
    <img width="1728" alt="Connect"
    src="https://user-images.githubusercontent.com/55930906/234397677-57823b14-16bf-44eb-9f01-eb6adca2a3fa.png">
    saarikabhasi committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    e199282 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    f9d7655 View commit details
    Browse the repository at this point in the history
  41. [lens] split x-pack/test/functional/apps/lens/group3/config.ts into s…

    …maller groups (elastic#155860)
    
    ## Summary
    
    
    Re-grouping lens functional tests into 6 groups since 2 groups often
    cross the 35+ min runtime. Also, we have retry in place so pipeline
    might have +40 minutes run if any of test fails.
    
    <img width="1354" alt="image"
    src="https://user-images.githubusercontent.com/10977896/234843379-aec47a81-22dc-4ecf-aee5-b1d489b3b31f.png">
    
    x-pack/test/functional/apps/lens/group1/config.ts 18m 42s
    x-pack/test/functional/apps/lens/group2/config.ts 19m 26s
    x-pack/test/functional/apps/lens/group3/config.ts 18m 26s
    x-pack/test/functional/apps/lens/group4/config.ts 18m 40s
    x-pack/test/functional/apps/lens/group5/config.ts 17m 55s
    x-pack/test/functional/apps/lens/group6/config.ts 19m 24s
    
    ---------
    
    Co-authored-by: Jon <jon@budzenski.me>
    dmlemeshko and jbudz committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    483edea View commit details
    Browse the repository at this point in the history
  42. [Saved Objects] Adds managed to import options (elastic#155677)

    Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    3 people committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    0858b38 View commit details
    Browse the repository at this point in the history
  43. [KQL] Fix node builder with empty array (elastic#155901)

    ## Summary
    
    Fixes elastic#95657.
    
    Updates the logic for `nodeBuilder` when passing an empty array to
    `nodeBuilder.and`/`nodeBuilder.or` to actually return a `KueryNode`
    instead of `undefined`.
    
    ### Checklist
    
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    lukasolson committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    654287b View commit details
    Browse the repository at this point in the history
  44. Fix issue with single value for metaFields advanced setting (elastic#…

    …155811)
    
    ## Summary
    
    Resolves elastic#94356.
    
    Fixes an issue with the _fields_for_wildcard API when the value for
    `metaFields` advanced setting is set to a single value (e.g. `_source`).
    
    ### Checklist
    
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ### Release note
    
    Fixes an issue where having a single value for the advanced setting
    `metaFields` would prevent refreshing a data view.
    lukasolson committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    f1360f2 View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    1a39471 View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    9b80399 View commit details
    Browse the repository at this point in the history
  47. [SecuritySolution] Remove SavedObject UI client from EA dashboard link (

    elastic#156003)
    
    ## Summary
    
    issue: elastic#155995
    
    Clean the deprecated SO client in the UI used in the
    `useDashboardButtonHref` hook.
    This is part of Serverless improvements.
    
    This PR also changes the button to open the integrated Security
    Dashboard viewer page, instead of the external Dashboards app.
    
    ### Changes:
    
    - Changed SavedObject client direct query by the
    `findDashboardsService`.
    - Changed the link to the external Dashboards app by the Security
    Dashboards page (including urlState parameters to preserve the time
    range).
    - Added "open in new tab" icon to the button
    - Refactoring names to stay consistent
    
    ### Demo:
    
    
    
    https://user-images.githubusercontent.com/17747913/234864463-75d08cf6-58d2-4a0d-b5fb-aae4e642b534.mov
    semd committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    9e20f89 View commit details
    Browse the repository at this point in the history
  48. Visualization UI components package (elastic#155459)

    ## Summary
    
    Moves a series of Lens components to an independent plugin for reuse in
    the annotations library.
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] remove mentions of Lens
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    drewdaemon and kibanamachine committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    0832ae2 View commit details
    Browse the repository at this point in the history
  49. [D4C] Fix to unused selector badge showing when selector used as excl…

    …ude (elastic#156122)
    
    ## Summary
    
    Defend for containers (policy UI) fix:
    - Fix to unused selector badge showing when selector used as exclude
    mitodrummer committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    69755a9 View commit details
    Browse the repository at this point in the history
  50. [Search Sessions] Fix flaky partial results test in search examples (e…

    …lastic#155816)
    
    ## Summary
    
    Unskip and fix flaky partial results test in search examples plugin.
    
    Flaky test runner x100:
    https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2172.
    
    Fixes elastic#116038.
    
    ### Checklist
    
    - [ ] ~Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~
    - [ ]
    ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials~
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] ~Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard
    accessibility](https://webaim.org/techniques/keyboard/))~
    - [ ] ~Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~
    - [ ] ~If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~
    - [ ] ~This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~
    - [ ] ~This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)~
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    davismcphee committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    11a80ce View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. [SharedUx] Chrome/Navigation package (elastic#152510)

    **The API for the link definition is subject to change.** This PR
    provides linking functionality and structure that will give solution
    devs a starting point for side nav in their projects. The API uses
    simple hrefs for now, because it's the easiest thing to start with.
    Planning forward, we are thinking of a different navigation model that
    separates nav structure from presentation of each nav item - this will
    allow reuse of the structure without reusing the presentation.
    
    ## Isolated dependencies
    In order for this component to be usable in `main`, a bit further work
    is currently required in the ChromeStart service and the Serverless
    plugin. These links are examples of a usable implementation that link to
    a POC branch:
    * Light mode for the side nav container:
    tsullivan@0a32333cdf0
    * Extensions to Serverless plugin and the ChromeStart service:
    tsullivan@16b0aad610f
    
    ## Summary
    
    Introduces a component to host the side navigation in Kibana. Solution
    teams can insert their own content, and have other small options to
    customize the presentation: see the storybook demos for more.
    
    Closes elastic#154479
    Closes elastic#154484
    Closes elastic#154485
    ~~Closes elastic#154489
    Closes elastic#154481
    Closes elastic#154480
    Closes elastic#154486
    Closes elastic#154487
    
    <img width="1462" alt="image"
    src="https://user-images.githubusercontent.com/908371/233739506-7b88646e-3c19-44f0-afbf-ca1a23d32c57.png">
    
    ## Developer documentation
    
    See the Storybook demos:
    * run: `yarn storybook shared_ux`
    * Find the `Chrome > Navigation` section in the Storybook app
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    - [x] Home icon links to Project's "home" - or the customer user setting
    - [x] Home icon shows loading indicator
    - [x] All the Platform links navigate to the correct place
    - ~~Platform links are not shown if the underlying plugin is disabled~~
    - [x] Nav items define their links using `href` only
    - [x] All href links work
    - [x] Nav menu item to link to Cloud deployment
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [x] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [x] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [ ] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    tsullivan and kibanamachine committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    604a02f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    965b327 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8181b0c View commit details
    Browse the repository at this point in the history
  4. [Lens] Allow user to switch sub function when in incomplete state (el…

    …astic#155521)
    
    ## Summary
    
    Fixes elastic#152719
    
    This PR cleans up the incomplete state for the specific referenced
    column on sub function change.
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [ ] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [ ] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [ ] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [ ] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [ ] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    
    ### Risk Matrix
    
    Delete this section if it is not applicable to this PR.
    
    Before closing this PR, invite QA, stakeholders, and other developers to
    identify risks that should be tested prior to the change/feature
    release.
    
    When forming the risk matrix, consider some of the following examples
    and how they may potentially impact the change:
    
    | Risk | Probability | Severity | Mitigation/Notes |
    
    |---------------------------|-------------|----------|-------------------------|
    | Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
    | Low | High | Integration tests will verify that all features are still
    supported in non-default Kibana Space and when user switches between
    spaces. |
    | Multiple nodes&mdash;Elasticsearch polling might have race conditions
    when multiple Kibana nodes are polling for the same tasks. | High | Low
    | Tasks are idempotent, so executing them multiple times will not result
    in logical error, but will degrade performance. To test for this case we
    add plenty of unit tests around this logic and document manual testing
    procedure. |
    | Code should gracefully handle cases when feature X or plugin Y are
    disabled. | Medium | High | Unit tests will verify that any feature flag
    or plugin combination still results in our service operational. |
    | [See more potential risk
    examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    
    ---------
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    dej611 and kibanamachine committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    52d4861 View commit details
    Browse the repository at this point in the history
  5. [SecuritySolution] Fix building block alert highlighting (elastic#155497

    )
    
    ## Summary
    
    As described in elastic#152318, we
    noticed that building block alerts were not highlighted anymore after
    the migration to the new alerts table.
    
    A preferred implementation of building block alert highlighting would
    follow the [`EUIDataGrid` approach of row
    highlighting](https://eui.elastic.co/#/tabular-content/data-grid-style-display#grid-row-classes).
    The `DataGrid` allows you to pass custom CSS class names for each row
    (`gridStyle.rowClasses`). That would allow us to highlight table rows
    with building block alerts.
    
    However, without access to the underlying data, we would not be able
    generate the correct `rowClasses` for rows with building block alerts.
    So simply passing `gridStyle.rowClasses` to the `AlertsStateTable` was
    not an option.
    
    Therefore in this PR we're introducing a new prop on the `AlertsTable`,
    the `highlightedRowMapper`. It's a callback function that receives the
    alert data and when it returns true, that row will be highlighted.
    
    This allows for highlighting of rows from the outside without exposing
    too many details about the underlying data structures.
    
    **Screenshot of the alerts table with a highlightedRowMapper that
    highlights building block alerts**
    
    <img width="1259" alt="Screenshot 2023-04-21 at 13 03 54"
    src="https://user-images.githubusercontent.com/68591/233620704-a56204c0-e285-4289-897a-58481f440446.png">
    
    ### Additional notes
    
    - Since the alerts table has default grid styles, it allows to pass
    `gridStyle` and it computes its own `rowClasses` for "active row"
    highlighting, the logic for merging all those styles looks intimidating.
    I tried my best to comment that part of code to make it clear why the
    merges are necessary and how they work.
    - While working on the issue, I noticed that active rows are not
    highlighted anymore (related bug:
    elastic#155487). The changes in this PR
    fix that behaviour as well as you can see in the screenshot below:
    
    <img width="936" alt="Screenshot 2023-04-21 at 13 04 15"
    src="https://user-images.githubusercontent.com/68591/233620752-d752dada-9c97-4f00-933a-5425e19a5793.png">
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    janmonschke and kibanamachine committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    ce71264 View commit details
    Browse the repository at this point in the history
  6. Merge remote-tracking branch 'origin/logs-onboarding-landing-page-154…

    …928' into logs-onboarding-select-logs-154941
    yngrdyn committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    8f83c4c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8c87a3f View commit details
    Browse the repository at this point in the history
  8. [Enterprise Search] MongoDB Connector cypress test. (elastic#155886)

    ## Summary
    
    Add automated tests via Cypress for MongoDB and Web Crawler happy paths.
    
    Tests are quite basic and covers only adding simple one time sync paths.
    Fill in the `cypress.env.json` with the credentials before running.
    Mongo specs will run only against a local environment (via `./cypress.sh
    dev`) as connector has to be running locally as well.
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    efegurkan and kibanamachine committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    a4953ed View commit details
    Browse the repository at this point in the history
  9. Adapting to design + i18n

    yngrdyn committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    17f8f19 View commit details
    Browse the repository at this point in the history
  10. [APM] Fix query to mobile transactions main statistics (elastic#155895)

    When splitting the query to mobile transactions main statistics, the
    sessions were left in the errors query and should have been retrieved in
    the transactions events. This PR fix this issue
    MiriamAparicio committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    67b2110 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    de23f32 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    708ef73 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    064aec6 View commit details
    Browse the repository at this point in the history
  14. [Synthetics] Disable/enable status alert for viewer user permissions (e…

    …lastic#156146)
    
    ## Summary
    
    Fixes elastic#155937
    
    For viewer user tooltip will be displayed and button is disabled.
    
    Also fixed loading position for manual test run loader.
    
    <img width="1770" alt="image"
    src="https://user-images.githubusercontent.com/3505601/235106034-7e758a5d-7291-47a2-8a46-2327b367e4a8.png">
    shahzad31 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    dab1409 View commit details
    Browse the repository at this point in the history
  15. [asset_manager] Add /related endpoint (elastic#154541)

    Exposes a `/related` endpoint that can be called to retrieve any
    supported asset relationship (`ancestors|descendants|references`).
    
    Note that this is a first draft to get a functioning endpoint available.
    Further optimizations (performances, typing..) will be implemented as
    follow ups or when we get feedback from actual use cases.
    
    Follow ups:
    - We're currently doing two sequential requests to retrieve the related
    assets, one for the _directly_ referenced of the primary (in
    `assets.children|parents..`) and another for _indirectly_ referenced
    that lists the primary in `asset.children|parents...`. These two
    predicates can be packed in a single query
    - The size is difficult to enforce at the query level if a `type` filter
    is provided. If we're looking at a `depth > 1` and we apply the size
    limit to the queries at `depth < maxDistance` we may miss edges to the
    requested type. Similarly the `type` filter can't be enforced at `depth
    < maxDistance`
    
    To do:
    
    - [x] Add filtering by type
    - [ ] ~Limit by size~
    - [x] Add sample assets which use references
    - [x] Add integration tests that validate each type of relation query
    - [x] Add documentation and sample requests/responses for each relation
    type
    - [x] Handle circular references. In what situations can that happens,
    references ?
    
    Closes elastic#153471
    Closes elastic#153473
    Closes elastic#153482
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    Co-authored-by: klacabane <kevin.lacabane@elastic.co>
    Co-authored-by: Kevin Lacabane <klacabane@gmail.com>
    Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com>
    5 people committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    9b2562e View commit details
    Browse the repository at this point in the history
  16. [Discover] Fix flaky saved objects tagging functional test (elastic#1…

    …55974)
    
    This PR fixes elastic#150249, an occasional flaky test of Discover's saved search tagging
    Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2179
    kertal committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    e7a3a48 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    2dad937 View commit details
    Browse the repository at this point in the history
  18. [Enterprise Search] Fix configurable field inputs and ensure correct …

    …typing (elastic#156002)
    
    Fixes some misc bugs with the new configurable fields inputs
    
    - `EuiFieldNumber` inputs could not be `null`, but we sometimes want
    `null`. I switched these back to `EuiFieldText` and added integer
    validations.
    - Fields were still being saved as strings even if they should be
    integers, so enforced a type check to make sure the expected type is
    saved.
    
    The new function `validateConnectorConfiguration` can also easily be
    expanded to use the new validations.
    navarone-feekery committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    c3afeb0 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    b09703c View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    a524e5c View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    24927cb View commit details
    Browse the repository at this point in the history
  22. [Cases] Separate Cases SO attributes from HTTP APIs (elastic#155898)

    This PR separates the persisted SO attributes from the fields received
    in the HTTP API requests.
    
    This is to address step 2 in preparing our HTTP routes as versioned.
    
    Issue: elastic#153726
    
    This PR encompasses a few PRs here which have been reviewed individually
    by the cases team members:
    
    elastic#155325 - User actions
    elastic#155440 - Attachments
    elastic#155444 - Configure, Connector
    Mappings
    elastic#155277 - Cases
    
    The large number of files is because of renaming some types throughout
    the frontend code. There shouldn't be many functionality changes, mostly
    just type changes.
    
    ---------
    
    Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
    Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
    3 people committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    6d5e245 View commit details
    Browse the repository at this point in the history
  23. [Lens] Quote csv values when contain separator char (elastic#155905)

    ## Summary
    
    Fix a bug found by @markov00 
    
    When a cell value contains the csvSeparator char (by default `,`) the
    text was not escaped correctly. This PR fixes this by wrapping the value
    in quotes (if enabled).
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [ ] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [ ] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [ ] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [ ] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [ ] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    
    ### Risk Matrix
    
    Delete this section if it is not applicable to this PR.
    
    Before closing this PR, invite QA, stakeholders, and other developers to
    identify risks that should be tested prior to the change/feature
    release.
    
    When forming the risk matrix, consider some of the following examples
    and how they may potentially impact the change:
    
    | Risk | Probability | Severity | Mitigation/Notes |
    
    |---------------------------|-------------|----------|-------------------------|
    | Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
    | Low | High | Integration tests will verify that all features are still
    supported in non-default Kibana Space and when user switches between
    spaces. |
    | Multiple nodes&mdash;Elasticsearch polling might have race conditions
    when multiple Kibana nodes are polling for the same tasks. | High | Low
    | Tasks are idempotent, so executing them multiple times will not result
    in logical error, but will degrade performance. To test for this case we
    add plenty of unit tests around this logic and document manual testing
    procedure. |
    | Code should gracefully handle cases when feature X or plugin Y are
    disabled. | Medium | High | Unit tests will verify that any feature flag
    or plugin combination still results in our service operational. |
    | [See more potential risk
    examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    dej611 and kibanamachine committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    1ab34e1 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    e7551de View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    19f5312 View commit details
    Browse the repository at this point in the history
  26. [Dashboard] Fix flaky Dashboard create tests (elastic#156085)

    Closes elastic#155777
    
    ## Summary
    
    The `"replaces panel with incoming embeddable if id matches existing
    panel"` test was **not** the flaky one, even though it was the one that
    showed the failure; it was actually one of the previous `"pulls state
    <...>"` tests that was failing, which was pretty confusing to catch 🤦
    
    Basically, because we are [running the unsaved changes check on load
    now](elastic#155648), depending on the
    timing of the `debounce` on the `checkForUnsavedChangesSubject$`
    subscription it would sometimes run for the `"pulls state <...>"` tests
    (but not always) - so whenever it **would** run, because the mocked
    `loadDashboardStateFromSavedObject` was only returning a partial
    Dashboard input, this would result in trying to get the property of
    `undefined` when checking for filter changes, panel changes, etc.
    
    This is fixed by ensuring that the `loadDashboardStateFromSavedObject`
    returns a complete Dashboard input, with all the required keys, for all
    of the relevant tests. Note that, since you can't test Jest unit tests
    using the flaky test runner, I was able to run it multiple times by
    surrounding all the tests with the following in order to ensure that it
    was no longer flaky:
    
    ```typescript
    for (const i of Array(x)
      .fill(null)
      .map((_, i) => i)) {
      describe(`test run ${i}`, () => {
        <...> // all the tests go here
      });
    };
    ```
    
    I did this with `x = 200`, and the entire test suite passed 200 times in
    a row 👍
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    Heenawter committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    5779773 View commit details
    Browse the repository at this point in the history
  27. [Fleet] [Message Signing] Respond with a generic error when rotate ke…

    …y pair fails (elastic#156144)
    
    ## Summary
    
    Responds with a generic error message for the rotate key pair API,
    instead of a trace message of where the error was generated.
    
    We log the detailed errors and this is to avoid a chance of any
    sensitive data (key generation details) being exposed through the API
    response.
    
    follow up of elastic/pull/155864
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    ashokaditya committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    13486f5 View commit details
    Browse the repository at this point in the history
  28. [Cases] Fix lens visualization in comment and description markdown (e…

    …lastic#155897)
    
    ## Summary
    
    This PR fixes issues with lens visualization in case view page for
    comment and description.
    
    Fixes: elastic#155631
    
    **Description:**
    
    
    https://user-images.githubusercontent.com/117571355/234856964-52bc479e-73bb-48d1-9b23-9e78e3452f00.mov
    
    **Comment:**
    
    
    https://user-images.githubusercontent.com/117571355/234858215-feaac6c7-5579-4a00-bb97-00e0b23f5cfe.mov
    
    ### Checklist
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    **Flakey Test runner:**
    https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2182
    
    Next one after update:
    https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2183
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    js-jankisalvi and kibanamachine committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    0c0e022 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    af18253 View commit details
    Browse the repository at this point in the history
  30. Minor copy edit in Create Search Application Flyout (elastic#156116)

    ## Summary
    
    A minor copy edit to the Create Search Application flyout, as requested
    [here](https://github.com/elastic/kibana/pull/155649/files#r1177950465).
    
    Per the thread in the request, the popover is changed but the callout
    remains the same.
    <img width="457" alt="image"
    src="https://user-images.githubusercontent.com/63422879/235157710-6463ca4c-fa92-4d1a-af22-9e2a507f3176.png">
    <img width="631" alt="Screenshot 2023-04-28 at 8 53 55 AM"
    src="https://user-images.githubusercontent.com/63422879/235153128-e49933a8-91a5-4365-bbd5-f0a1d4b52579.png">
    kderusso committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    53e7cd9 View commit details
    Browse the repository at this point in the history
  31. [Cases] Fix attachment's renderer memoization (elastic#156179)

    ## Summary
    
    PR elastic#154436 changed the memoization
    function (my fault 🙂) and that caused the attachments to rerender each
    time a user does an action in cases. This PR fixes this issue.
    
    **Before:**
    
    
    
    https://user-images.githubusercontent.com/7871006/235171360-62be773f-8317-4762-9f14-0310d3825a1e.mov
    
    **After:**
    
    
    
    https://user-images.githubusercontent.com/7871006/235171429-5e06f9c4-9c0a-4148-8580-bde2360169af.mov
    
    
    
    ### For maintainers
    
    - [x] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    cnasikas committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    60e3d98 View commit details
    Browse the repository at this point in the history
  32. Add Advanced Analytics (UEBA) package subcategory under Security

    …category (elastic#155935)
    
    ## Summary
    
    Summarize your PR. If it involves visual changes include a screenshot or
    gif.
    
    Add `Advanced Analytics (UEBA)` subcategory under Security
    
    * elastic/package-spec#499
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [ ] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [ ] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [ ] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [ ] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [ ] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    
    ### Risk Matrix
    
    Delete this section if it is not applicable to this PR.
    
    (This PR doesn't add new features, thus deleting the table in the
    boilerplate)
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    susan-shu-c committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    bd5f330 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    c28d935 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    ec76672 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2023

  1. [drift] Changed default trial offset from 60 to 90 days per PM reques…

    …t. (elastic#156186)
    
    ## Summary
    
    Changes the default trial offset used to display the Drift chat
    integration from 60 to 90 days.
    
    
    ### Checklist
    N/A
    
    ### Risk Matrix
    N/A
    
    ### For maintainers
    N/A
    petrklapka committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    fa8096c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0d89527 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2023

  1. Configuration menu
    Copy the full SHA
    0ba78e3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fe19072 View commit details
    Browse the repository at this point in the history
  3. [Discover] [Unified Histogram] Fix reset search button not fully rese…

    …tting Unified Histogram state (elastic#155967)
    
    ## Summary
    
    This PR fixes an issue where resetting a saved search would not fully
    reset the Unified Histogram state. The issue was caused by multiple
    state values changing in quick succession which resulted in some state
    getting overwritten, so I've updated `use_discover_state` to batch state
    updates and improve diffing when state changes.
    
    Fixes elastic#151395.
    
    ### Checklist
    
    - [ ] ~Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~
    - [ ]
    ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials~
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] ~Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard
    accessibility](https://webaim.org/techniques/keyboard/))~
    - [ ] ~Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~
    - [ ] ~If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~
    - [ ] ~This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~
    - [ ] ~This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)~
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    davismcphee committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    9d023f6 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. Configuration menu
    Copy the full SHA
    29dfcd5 View commit details
    Browse the repository at this point in the history
  2. [serverless] Create Observability Serverless plugin (elastic#156118)

    > Derived from elastic#153274
    > Builds upon elastic#155582
    
    ## Summary
    
    This PR creates the Serverless Observability plugin, based on the work
    from elastic#153274:
    
    - creates the plugin,
    - adds API to hide the solution navigation from Enterprise Search,
    - calls that API if the chrome style is `project`.
    
    <img width="1610" alt="Screenshot 2023-04-27 at 5 03 44 PM"
    src="https://user-images.githubusercontent.com/297604/234990765-d6770650-41b3-4e94-ad7f-c6a22778d39a.png">
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    clintandrewhall and kibanamachine committed May 1, 2023
    Configuration menu
    Copy the full SHA
    4e88645 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e6366c0 View commit details
    Browse the repository at this point in the history
  4. [CollapsibleNav] Make CollapsibleNav Items Accessible on Small Scre…

    …ens and In Browsers with High Zoom (elastic#155817)
    
    Fixes elastic/eui#6702
    
    Pinging @elastic/eui-team for visibility
    
    ## Summary
    
    ### ✨ What's the problem?
    A user submitted an issue where they were unable to use the main
    collapsible nav when their browser was zoomed in at 400% for
    accessibility. The nav items weren't visible and could not be interacted
    with at this level.
    
    <img width="400" alt="image"
    src="https://user-images.githubusercontent.com/40739624/234444373-b9539160-a069-4e4f-9bdc-c01a9405f11c.png">
    
    ### ✨ What changed?
    When the container for the collapsible nav has a `max-height` of `15em`,
    overflow and additional flex properties are used to allow the nav groups
    to be traversed.
    
    
    https://user-images.githubusercontent.com/40739624/234444539-72e2d499-94b3-4b0b-ba08-d17b12afa15c.mov
    
    
    ### ✨ QA
    View the Kibana homepage and set the Zoom on your browser to 400%. This
    will need to be done in a relatively small window (like the one on your
    computer itself, not an external monitor). Open the main navigation menu
    on the left. You should be able to navigate all links in menu with both
    keyboard and by scrolling the sections.
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [x] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [x] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    
    ---------
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
    3 people committed May 1, 2023
    Configuration menu
    Copy the full SHA
    8cdef94 View commit details
    Browse the repository at this point in the history
  5. [Security Solutions] Fix install azure integration URL and loading st…

    …ate (elastic#155706)
    
    ## Summary
    
    * Generate Azure integration URL instead of hardcoding it 
    
    ![Apr-26-2023
    14-32-40](https://user-images.githubusercontent.com/1490444/234575705-6ff288c3-5691-4b66-af6c-cf1383f3399b.gif)
    
    * Fix flyout showing callout when loading
    
    ![Apr-26-2023
    14-25-10](https://user-images.githubusercontent.com/1490444/234574219-ed25f37b-0206-49d6-bc81-8d75cf023e64.gif)
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    machadoum committed May 1, 2023
    Configuration menu
    Copy the full SHA
    23d47b7 View commit details
    Browse the repository at this point in the history
  6. [Enterprise Search] Support for starting ELSER model deployment (elas…

    …tic#156080)
    
    ## Summary
    
    We're adding action buttons to the ELSER model deployment panel,
    specifically to the state where the trained model has been downloaded
    but not started yet. The user has two options here:
    - Start the model (synchronously) with a basic configuration using the
    "Start single-threaded" button
    - Navigate to the Trained Models page and fine-tune the model deployment
    with the "Fine-tune performance" button
    
    In addition a 4th state of the panel is being introduced: the ELSER
    model has started.
    
    
    ![ELSER_start](https://user-images.githubusercontent.com/14224983/234971172-a99917dd-ec55-4df3-acd1-a6b390262104.gif)
    
    
    ### Checklist
    - [x] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [x] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [x] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    demjened and kibanamachine committed May 1, 2023
    Configuration menu
    Copy the full SHA
    5897708 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d22825a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bdfc0d7 View commit details
    Browse the repository at this point in the history
  9. [Files] Add ability to optionally generate a File Hash during upload …

    …by allowing for custom Transforms to be used (elastic#156039)
    
    ## Summary
    
    closes elastic#154047
    
    - Exposes reusable `Transform` that will calculate a File's hash and
    store it with the file's metadata. This Transform is "opt in" and not
    the default behaviour.
    - The `File.uploadContent()` method was enhanced to optionally accept
    `options.transforms Array<Transform>`, thus allowing consumer of the
    service to defined an additional set to be included in the file's
    processing pipeline. The upload process was also altered to recognize
    the use of the new `FileHashTransform` and store the file's `hash` if it
    is used.
    - Saved Object schema was also updated to include mappings for the
    `file.hash` property. This update also impacts the creation of indexes
    when the `FileClient` is created with custom indexes and those don't yet
    exist.
    paul-tavares committed May 1, 2023
    Configuration menu
    Copy the full SHA
    6e19049 View commit details
    Browse the repository at this point in the history
  10. [Enterprise Search] Fix bug saving edited field rules (elastic#156259)

    ## Summary
    
    This fixes a bug causing edited field rules to always overwrite the
    first rule in the list when saved.
    sphilipse committed May 1, 2023
    Configuration menu
    Copy the full SHA
    83ca5a7 View commit details
    Browse the repository at this point in the history
  11. Upgrade EUI to v77.1.2 (elastic#156232)

    ## Summary
    
    `eui@77.1.1` ⏩ `eui@77.1.2`
    
    This upgrade consists of a backport release intended to fix a major bug
    where portals within `EuiFlyout`s and `EuiModal`s are not scrollable.
    fixes elastic#156161
    
    This release also adds functionality that resolves the need for a TODO
    workaround added in elastic#153227
    
    ---
    
    ## [`77.1.2`](https://github.com/elastic/eui/tree/v77.1.2)
    
    - Updated `EuiFocusTrap` to support the `gapMode` prop configuration
    (now defaults to `padding`)
    ([elastic#6744](elastic/eui#6744))
    
    **Bug fixes**
    
    - Fixed the `scrollLock` property on `EuiFocusTrap` (and other
    components using `EuiFocusTrap`, such as `EuiFlyout` and `EuiModal`) to
    no longer block scrolling on nested portalled content, such as combobox
    dropdowns ([elastic#6744](elastic/eui#6744))
    
    ---------
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    cee-chen and kibanamachine committed May 1, 2023
    Configuration menu
    Copy the full SHA
    0564e54 View commit details
    Browse the repository at this point in the history
  12. [Security Solution][Investigations] - remove flaky cypress test (elas…

    …tic#156258)
    
    This PR removes a flaky test which fails when trying to visit a url.
    Further investigation is needed to determine why the test sometimes
    visits the login screen when trying to visit the given url, but for the
    time being should be removed to unblock future PRs.
    michaelolo24 committed May 1, 2023
    Configuration menu
    Copy the full SHA
    a8269ea View commit details
    Browse the repository at this point in the history
  13. [Discover] Fix flaky Discover security functional test (elastic#156221)

    ## Summary
    
    Fixes elastic#153796.
    
    Flaky test runner x 100:
    https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2196
    
    ### Checklist
    
    - [ ] ~Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~
    - [ ]
    ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials~
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] ~Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard
    accessibility](https://webaim.org/techniques/keyboard/))~
    - [ ] ~Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~
    - [ ] ~If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~
    - [ ] ~This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~
    - [ ] ~This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)~
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    davismcphee committed May 1, 2023
    Configuration menu
    Copy the full SHA
    5035be8 View commit details
    Browse the repository at this point in the history
  14. [Security Solution] add user name and authentication to generate data…

    … script (elastic#155932)
    
    ## Summary
    
    This PR added additional fields to be populated by the generate_data
    script:
    
    - User name is added in generate alert functions 
    - Currently alert data does not contain user names, this would be
    beneficial for testing user related features on the alerts page.
    - Event outcome is specified for `event.category==='authentication'`
    
    Alerts page:
    - user names are showing
    
    ![image](https://user-images.githubusercontent.com/18648970/234691639-81d2cd05-812c-44b6-8760-193f6b72d314.png)
    
    Explore -> Host -> Pick a host -> Authentication
    - Showing successful and failed authentications
    
    ![image](https://user-images.githubusercontent.com/18648970/234692001-1d7a4ee2-c890-4ddb-b349-c4d3ed91cce7.png)
    christineweng committed May 1, 2023
    Configuration menu
    Copy the full SHA
    ba4d187 View commit details
    Browse the repository at this point in the history
  15. [Security Solution] [Timeline] Fix timeline draft collision with conc…

    …urrent users (elastic#155663)
    
    ## Summary
    
    This pr fixes an issue where two users who both have draft timelines
    open will actually be using the same underlying saved object, which
    would cause a host of issues. Adds attributes.createdBy and
    attributes.updatedBy to the savedObjectsClient.find filter used to
    retrieve drafts, so that each user has their own draft. This should
    allow the reaping of unused drafts to function as before.
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    kqualters-elastic committed May 1, 2023
    Configuration menu
    Copy the full SHA
    7a7936e View commit details
    Browse the repository at this point in the history
  16. Fix error removing Environment value in APM rules (elastic#156212)

    Fixes elastic#153085
    
    Fixes the error shown when removing selected Environment value in the
    following APM rules:
    - Latency threshold
    - Error count threshold
    - Failed transaction rate threshold
    benakansara committed May 1, 2023
    Configuration menu
    Copy the full SHA
    61dad95 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    7588a96 View commit details
    Browse the repository at this point in the history
  18. [APM] Avoid re-mounting the entire application on every url change (e…

    …lastic#156171)
    
    ## Problem
    The `ErrorBoundary` component that encapsulates the APM application uses
    the url path as the `key`, causing the application to be unmounted and
    re-mounted on every page change:
    
    ```ts
    <ErrorBoundary key={location.pathname}>{children}</ErrorBoundary>
    ```
    
    ## Solution
    
    While applying a fix to the `ErrorBoundary` component I noticed that it
    is no longer used. Errors are captured by the
    `ObservabilityPageTemplate` (introduced a few weeks back in
    elastic#154716) which makes our
    ErrorBoundary useless.
    
    The `ErrorBoundary` in `ObservabilityPageTemplate` does not have the
    same problem our had. However, it also does not reset the ErrorBoundary
    on page change (like ours did). This means that once an error is caught,
    it is not possible to remove the Error Boundary ui without manually
    performing a full page refresh. I've mentioned this to @CoenWarmer and
    created a follow-up issue:
    elastic#156172
    
    ## Before
    
    https://user-images.githubusercontent.com/209966/235135444-d691b481-5441-449b-8555-77760877c3ba.mp4
    
    ## After
    
    https://user-images.githubusercontent.com/209966/235135459-cc3d4318-d553-44ad-890b-c15bdeac9292.mp4
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    sorenlouv and kibanamachine committed May 1, 2023
    Configuration menu
    Copy the full SHA
    66ab6b7 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    7a0620f View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    5ef0df5 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    10bb8e9 View commit details
    Browse the repository at this point in the history
  22. [Security Solution] Advanced policy options for Endpoint 8.8 (elastic…

    …#156308)
    
    ## Summary
    
    Adds several more advanced options for Endpoint to Policy.
    
    
    ![image](https://user-images.githubusercontent.com/56395104/235530865-635a6427-336c-4120-9112-47fb3ea9fe5e.png)
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    kevinlog and kibanamachine committed May 1, 2023
    Configuration menu
    Copy the full SHA
    47b1ca3 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Configuration menu
    Copy the full SHA
    527ab4b View commit details
    Browse the repository at this point in the history
  2. [Synthetics] Do not re-render embeddable visualizations on detail/his…

    …tory page `onLoad` (elastic#156219)
    
    Co-authored-by: shahzad31 <shahzad31comp@gmail.com>
    justinkambic and shahzad31 committed May 2, 2023
    Configuration menu
    Copy the full SHA
    7b94718 View commit details
    Browse the repository at this point in the history
  3. [ML] Explain Log Rate Spikes: Fix key attribute for grouped analysi…

    …s results table (elastic#156038)
    
    Fixes the React dev mode warning "Warning: Each child in a list should
    have a unique "key" prop. Check the render method of EuiBasicTable" by
    putting the `key` attribute for a group item on the outer level.
    walterra committed May 2, 2023
    Configuration menu
    Copy the full SHA
    a3f5a34 View commit details
    Browse the repository at this point in the history
  4. [Lens][TSVB] Add TSDB field checks functional tests (elastic#156165)

    ## Summary
    
    Fix elastic#155830 
    
    Add basic checks for both Lens and TSVB editors.
    In Lens more advanced tests are performed to check for compatible and
    uncompatible operations for specific TSDB field types.
    In TSVB the check is only performed to verify that the editor and
    visualization doesn't crash and when unsupported the right error message
    is shown.
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [ ] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [ ] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [ ] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [ ] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [ ] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    
    ### Risk Matrix
    
    Delete this section if it is not applicable to this PR.
    
    Before closing this PR, invite QA, stakeholders, and other developers to
    identify risks that should be tested prior to the change/feature
    release.
    
    When forming the risk matrix, consider some of the following examples
    and how they may potentially impact the change:
    
    | Risk | Probability | Severity | Mitigation/Notes |
    
    |---------------------------|-------------|----------|-------------------------|
    | Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
    | Low | High | Integration tests will verify that all features are still
    supported in non-default Kibana Space and when user switches between
    spaces. |
    | Multiple nodes&mdash;Elasticsearch polling might have race conditions
    when multiple Kibana nodes are polling for the same tasks. | High | Low
    | Tasks are idempotent, so executing them multiple times will not result
    in logical error, but will degrade performance. To test for this case we
    add plenty of unit tests around this logic and document manual testing
    procedure. |
    | Code should gracefully handle cases when feature X or plugin Y are
    disabled. | Medium | High | Unit tests will verify that any feature flag
    or plugin combination still results in our service operational. |
    | [See more potential risk
    examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    dej611 committed May 2, 2023
    Configuration menu
    Copy the full SHA
    3c26123 View commit details
    Browse the repository at this point in the history
  5. [Discover] Refactor deprecated eui page content usage (elastic#156138)

    Closes elastic#139890
    
    ## Summary
    
    This PR removes usage of deprecate Eui page components.
    jughosta committed May 2, 2023
    Configuration menu
    Copy the full SHA
    df71c65 View commit details
    Browse the repository at this point in the history
  6. [Lens] New random sampling shared plugin (elastic#155068)

    ## Summary
    
    A new plugin to share the Random sampling logic across Kibana apps.
    As starting point it contains the Random Sampling Icon + the setting
    slider.
    
    <img width="788" alt="Screenshot 2023-04-18 at 11 03 36"
    src="https://user-images.githubusercontent.com/924948/232743718-9fad0308-9c21-4bd7-901f-9634ac3486ad.png">
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [ ] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [ ] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [ ] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [ ] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [ ] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    
    ### Risk Matrix
    
    Delete this section if it is not applicable to this PR.
    
    Before closing this PR, invite QA, stakeholders, and other developers to
    identify risks that should be tested prior to the change/feature
    release.
    
    When forming the risk matrix, consider some of the following examples
    and how they may potentially impact the change:
    
    | Risk | Probability | Severity | Mitigation/Notes |
    
    |---------------------------|-------------|----------|-------------------------|
    | Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
    | Low | High | Integration tests will verify that all features are still
    supported in non-default Kibana Space and when user switches between
    spaces. |
    | Multiple nodes&mdash;Elasticsearch polling might have race conditions
    when multiple Kibana nodes are polling for the same tasks. | High | Low
    | Tasks are idempotent, so executing them multiple times will not result
    in logical error, but will degrade performance. To test for this case we
    add plenty of unit tests around this logic and document manual testing
    procedure. |
    | Code should gracefully handle cases when feature X or plugin Y are
    disabled. | Medium | High | Unit tests will verify that any feature flag
    or plugin combination still results in our service operational. |
    | [See more potential risk
    examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
    3 people committed May 2, 2023
    Configuration menu
    Copy the full SHA
    ca780c5 View commit details
    Browse the repository at this point in the history
  7. [Defend Workflows][E2E]Endpoint e2e response console (elastic#155605)

    Depends on elastic#155519
    
    E2E coverage of `isolate`, `processes`, `kill-process` and
    `suspend-process` commands on mocked endpoint.
    
    E2E coverage of the above but on real endpoint is
    [here](elastic#155519).
    
    Because these tests are run against mocked data I've decided not to mock
    `kill-process` and `suspend-process` outcome (whether process is
    actually killed/suspended) because it would mean testing mocks
    themselves. What is tested is the outcome the user sees ('Action
    completed').
    
    ---------
    
    Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
    szwarckonrad and patrykkopycinski committed May 2, 2023
    Configuration menu
    Copy the full SHA
    fd5309f View commit details
    Browse the repository at this point in the history
  8. [SecuritySolution] Fix edit dashboard url (elastic#156160)

    ## Summary
    
    It lands on the wrong page after clicking on `Edit Dashboard` button.
    
    - Steps to reproduce:
    
    1. Create a dashboard, save it and add a Security Solution tag.
    2. Back to SecuritySolution > Dashboards, select the dashboard you
    added.
    3. Click the `Edit` button at the top right corner.
    4. Observe that it lands at Kibana dashboard listing page.
    
    Expect:
    It should navigate to Kibana dashboard's edit mode.
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    angorayc committed May 2, 2023
    Configuration menu
    Copy the full SHA
    eb2c8b8 View commit details
    Browse the repository at this point in the history
  9. [RAM] Slack Web API Connector Channels List Error Message Not Showing…

    … Up (elastic#155996)
    
    Fixes elastic#155722
    
    Adds an integration test that loads the ActionForm using SlackApi
    connector so we can check that the right error message is shown
    
    ---------
    
    Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
    jcger and XavierM committed May 2, 2023
    Configuration menu
    Copy the full SHA
    e62581f View commit details
    Browse the repository at this point in the history
  10. [Enterprise Search][Behavioral Analytics] Set limit on 10k results fo…

    …r explore tables (elastic#156237)
    
    - ✔️ For Explorer page set max items to 10k to prevent pagination and
    load issues
    - ✔️ Indicate limit results according guidelines
    <img width="958" alt="image"
    src="https://user-images.githubusercontent.com/17390745/235352939-0291eb86-9743-4558-b146-2e22de07e0c8.png">
    yansavitski committed May 2, 2023
    Configuration menu
    Copy the full SHA
    2ff49bf View commit details
    Browse the repository at this point in the history
  11. Adapt the ZDT migration algorithm to support v2 migrations (elastic#1…

    …55981)
    
    ## Summary
    
    Adapt the `zdt` migration algorithm to run the v2 migrations in addition
    to the model version transformations.
    
    The intent is to be able to use the current migration system in a
    zero-downtime upgrade friendly-ish way
    
    ### Technicals  
    
    elastic#148656 was a precondition, as the
    zdt algo requires that mapping changes are compatible (given we keep the
    same index).
    
    Technically, it means we're now storing the `virtualVersion` instead of
    the `modelVersion` in the index's meta (`mappingVersions` and
    `docVersions`), to allow keeping track of mixed stack and model versions
    per type.
    
    Note that switching to model versioning is still a one way,
    non-revertible action. Once using model versioning (by specifying
    `switchToModelVersionAt` on your type), there is no going back.
    pgayvallet committed May 2, 2023
    Configuration menu
    Copy the full SHA
    9cddb60 View commit details
    Browse the repository at this point in the history
  12. [Infarstructure UI] Fix hosts view functional test (elastic#155772)

    closes elastic#155429
    closes elastic#155293
    
    ## Summary
    
    
    This PR fixes the hosts view functional test, stabilizing the flaky test
    cases that started to fail after changes were made to the page
    
    
    ### How to test
    
    - `yarn test:ftr:server --config
    x-pack/test/functional/apps/infra/config.ts`
    - `yarn test:ftr:runner --config
    x-pack/test/functional/apps/infra/config.ts --include
    x-pack/test/functional/apps/infra/hosts_view.ts`
    
    ---------
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    crespocarlos and kibanamachine committed May 2, 2023
    Configuration menu
    Copy the full SHA
    c466932 View commit details
    Browse the repository at this point in the history
  13. Update cypress (main) (elastic#152647)

    [![Mend
    Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
    
    This PR contains the following updates:
    
    | Package | Change | Age | Adoption | Passing | Confidence |
    |---|---|---|---|---|---|
    | [cypress](https://togithub.com/cypress-io/cypress) | [`^12.6.0` ->
    `^12.10.0`](https://renovatebot.com/diffs/npm/cypress/12.6.0/12.10.0) |
    [![age](https://badges.renovateapi.com/packages/npm/cypress/12.10.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![adoption](https://badges.renovateapi.com/packages/npm/cypress/12.10.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![passing](https://badges.renovateapi.com/packages/npm/cypress/12.10.0/compatibility-slim/12.6.0)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![confidence](https://badges.renovateapi.com/packages/npm/cypress/12.10.0/confidence-slim/12.6.0)](https://docs.renovatebot.com/merge-confidence/)
    |
    | [cypress-axe](https://togithub.com/component-driven/cypress-axe) |
    [`^1.3.0` ->
    `^1.4.0`](https://renovatebot.com/diffs/npm/cypress-axe/1.3.0/1.4.0) |
    [![age](https://badges.renovateapi.com/packages/npm/cypress-axe/1.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![adoption](https://badges.renovateapi.com/packages/npm/cypress-axe/1.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![passing](https://badges.renovateapi.com/packages/npm/cypress-axe/1.4.0/compatibility-slim/1.3.0)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![confidence](https://badges.renovateapi.com/packages/npm/cypress-axe/1.4.0/confidence-slim/1.3.0)](https://docs.renovatebot.com/merge-confidence/)
    |
    |
    [cypress-multi-reporters](https://togithub.com/you54f/cypress-multi-reporters)
    | [`^1.6.2` ->
    `^1.6.3`](https://renovatebot.com/diffs/npm/cypress-multi-reporters/1.6.2/1.6.3)
    |
    [![age](https://badges.renovateapi.com/packages/npm/cypress-multi-reporters/1.6.3/age-slim)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![adoption](https://badges.renovateapi.com/packages/npm/cypress-multi-reporters/1.6.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![passing](https://badges.renovateapi.com/packages/npm/cypress-multi-reporters/1.6.3/compatibility-slim/1.6.2)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![confidence](https://badges.renovateapi.com/packages/npm/cypress-multi-reporters/1.6.3/confidence-slim/1.6.2)](https://docs.renovatebot.com/merge-confidence/)
    |
    | [cypress-recurse](https://togithub.com/bahmutov/cypress-recurse) |
    [`^1.27.0` ->
    `^1.31.2`](https://renovatebot.com/diffs/npm/cypress-recurse/1.27.0/1.31.2)
    |
    [![age](https://badges.renovateapi.com/packages/npm/cypress-recurse/1.31.2/age-slim)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![adoption](https://badges.renovateapi.com/packages/npm/cypress-recurse/1.31.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![passing](https://badges.renovateapi.com/packages/npm/cypress-recurse/1.31.2/compatibility-slim/1.27.0)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![confidence](https://badges.renovateapi.com/packages/npm/cypress-recurse/1.31.2/confidence-slim/1.27.0)](https://docs.renovatebot.com/merge-confidence/)
    |
    |
    [eslint-plugin-cypress](https://togithub.com/cypress-io/eslint-plugin-cypress)
    | [`^2.12.1` ->
    `^2.13.2`](https://renovatebot.com/diffs/npm/eslint-plugin-cypress/2.12.1/2.13.2)
    |
    [![age](https://badges.renovateapi.com/packages/npm/eslint-plugin-cypress/2.13.2/age-slim)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![adoption](https://badges.renovateapi.com/packages/npm/eslint-plugin-cypress/2.13.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![passing](https://badges.renovateapi.com/packages/npm/eslint-plugin-cypress/2.13.2/compatibility-slim/2.12.1)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![confidence](https://badges.renovateapi.com/packages/npm/eslint-plugin-cypress/2.13.2/confidence-slim/2.12.1)](https://docs.renovatebot.com/merge-confidence/)
    |
    
    ---
    
    ### Release Notes
    
    <details>
    <summary>cypress-io/cypress</summary>
    
    ###
    [`v12.10.0`](https://togithub.com/cypress-io/cypress/releases/tag/v12.10.0)
    
    [Compare
    Source](https://togithub.com/cypress-io/cypress/compare/v12.9.0...v12.10.0)
    
    Changelog:
    https://docs.cypress.io/guides/references/changelog#&#8203;12-10-0
    
    ###
    [`v12.9.0`](https://togithub.com/cypress-io/cypress/releases/tag/v12.9.0)
    
    [Compare
    Source](https://togithub.com/cypress-io/cypress/compare/v12.8.1...v12.9.0)
    
    Changelog:
    https://docs.cypress.io/guides/references/changelog#&#8203;12-9-0
    
    ###
    [`v12.8.1`](https://togithub.com/cypress-io/cypress/releases/tag/v12.8.1)
    
    [Compare
    Source](https://togithub.com/cypress-io/cypress/compare/v12.8.0...v12.8.1)
    
    Changelog:
    https://docs.cypress.io/guides/references/changelog#&#8203;12-8-1
    
    ###
    [`v12.8.0`](https://togithub.com/cypress-io/cypress/releases/tag/v12.8.0)
    
    [Compare
    Source](https://togithub.com/cypress-io/cypress/compare/v12.7.0...v12.8.0)
    
    Changelog:
    https://docs.cypress.io/guides/references/changelog#&#8203;12.8.0
    
    ###
    [`v12.7.0`](https://togithub.com/cypress-io/cypress/releases/tag/v12.7.0)
    
    [Compare
    Source](https://togithub.com/cypress-io/cypress/compare/v12.6.0...v12.7.0)
    
    Changelog:
    https://docs.cypress.io/guides/references/changelog#&#8203;12.7.0
    
    </details>
    
    <details>
    <summary>component-driven/cypress-axe</summary>
    
    ###
    [`v1.4.0`](https://togithub.com/component-driven/cypress-axe/releases/tag/v1.4.0)
    
    [Compare
    Source](https://togithub.com/component-driven/cypress-axe/compare/v1.3.0...v1.4.0)
    
    ##### Features
    
    - retry option
    ([#&elastic#8203;151](https://togithub.com/component-driven/cypress-axe/issues/151))
    ([682ba11](https://togithub.com/component-driven/cypress-axe/commit/682ba11d1d52a00d08a828da25f8a033b67916e0))
    
    </details>
    
    <details>
    <summary>bahmutov/cypress-recurse</summary>
    
    ###
    [`v1.31.2`](https://togithub.com/bahmutov/cypress-recurse/releases/tag/v1.31.2)
    
    [Compare
    Source](https://togithub.com/bahmutov/cypress-recurse/compare/v1.31.1...v1.31.2)
    
    ##### Bug Fixes
    
    - compute limit from timeout and delay, closes
    [#&elastic#8203;159](https://togithub.com/bahmutov/cypress-recurse/issues/159)
    ([ae325c9](https://togithub.com/bahmutov/cypress-recurse/commit/ae325c9436f7318e0cd6c34dc7e11c454b09f46e))
    
    ###
    [`v1.31.1`](https://togithub.com/bahmutov/cypress-recurse/releases/tag/v1.31.1)
    
    [Compare
    Source](https://togithub.com/bahmutov/cypress-recurse/compare/v1.31.0...v1.31.1)
    
    ##### Bug Fixes
    
    - yield value on time limit
    ([6a8af64](https://togithub.com/bahmutov/cypress-recurse/commit/6a8af6440055f89795931a9d65d4dbcae9149b26))
    
    ###
    [`v1.31.0`](https://togithub.com/bahmutov/cypress-recurse/releases/tag/v1.31.0)
    
    [Compare
    Source](https://togithub.com/bahmutov/cypress-recurse/compare/v1.30.0...v1.31.0)
    
    ##### Features
    
    - yield the last value
    ([#&elastic#8203;158](https://togithub.com/bahmutov/cypress-recurse/issues/158))
    ([2a089f4](https://togithub.com/bahmutov/cypress-recurse/commit/2a089f4543c688c0683166d3e9788936d43463c5))
    
    ###
    [`v1.30.0`](https://togithub.com/bahmutov/cypress-recurse/releases/tag/v1.30.0)
    
    [Compare
    Source](https://togithub.com/bahmutov/cypress-recurse/compare/v1.29.0...v1.30.0)
    
    ##### Bug Fixes
    
    - include commands in the list of files
    ([3ce4aad](https://togithub.com/bahmutov/cypress-recurse/commit/3ce4aad9236bc1183cbcd4a88b6ec2ba34385485))
    
    ##### Features
    
    - add optional custom command cy.recurse
    ([#&elastic#8203;156](https://togithub.com/bahmutov/cypress-recurse/issues/156))
    ([8cb1a6f](https://togithub.com/bahmutov/cypress-recurse/commit/8cb1a6fb3f42f7e58dc458be34cb267464e09b01))
    
    ###
    [`v1.29.0`](https://togithub.com/bahmutov/cypress-recurse/releases/tag/v1.29.0)
    
    [Compare
    Source](https://togithub.com/bahmutov/cypress-recurse/compare/v1.28.0...v1.29.0)
    
    ##### Features
    
    - print better error message
    ([#&elastic#8203;148](https://togithub.com/bahmutov/cypress-recurse/issues/148))
    ([6dfb97e](https://togithub.com/bahmutov/cypress-recurse/commit/6dfb97e48f6aa4bebcad16daf145e98bc63fedd4))
    
    ###
    [`v1.28.0`](https://togithub.com/bahmutov/cypress-recurse/releases/tag/v1.28.0)
    
    [Compare
    Source](https://togithub.com/bahmutov/cypress-recurse/compare/v1.27.1...v1.28.0)
    
    ##### Features
    
    - add do not fail option
    ([#&elastic#8203;146](https://togithub.com/bahmutov/cypress-recurse/issues/146))
    ([4621825](https://togithub.com/bahmutov/cypress-recurse/commit/46218259d1adefce91f2bc2c73c0276b928db7d2))
    
    ###
    [`v1.27.1`](https://togithub.com/bahmutov/cypress-recurse/releases/tag/v1.27.1)
    
    [Compare
    Source](https://togithub.com/bahmutov/cypress-recurse/compare/v1.27.0...v1.27.1)
    
    ##### Bug Fixes
    
    - put labels on the logs
    ([#&elastic#8203;145](https://togithub.com/bahmutov/cypress-recurse/issues/145))
    ([2fa4dea](https://togithub.com/bahmutov/cypress-recurse/commit/2fa4dea883129d650a4b5730ec69cc40783fae56))
    
    </details>
    
    <details>
    <summary>cypress-io/eslint-plugin-cypress</summary>
    
    ###
    [`v2.13.2`](https://togithub.com/cypress-io/eslint-plugin-cypress/releases/tag/v2.13.2)
    
    [Compare
    Source](https://togithub.com/cypress-io/eslint-plugin-cypress/compare/v2.13.1...v2.13.2)
    
    ##### Bug Fixes
    
    - Wait incorrectly reported as unsafe to chain
    ([7c20206](https://togithub.com/cypress-io/eslint-plugin-cypress/commit/7c20206))
    
    ###
    [`v2.13.1`](https://togithub.com/cypress-io/eslint-plugin-cypress/releases/tag/v2.13.1)
    
    [Compare
    Source](https://togithub.com/cypress-io/eslint-plugin-cypress/compare/v2.13.0...v2.13.1)
    
    ##### Bug Fixes
    
    - Solve unsafe to chain command does not exist
    ([#&elastic#8203;126](https://togithub.com/cypress-io/eslint-plugin-cypress/issues/126))
    ([1fdfef7](https://togithub.com/cypress-io/eslint-plugin-cypress/commit/1fdfef7))
    
    ###
    [`v2.13.0`](https://togithub.com/cypress-io/eslint-plugin-cypress/releases/tag/v2.13.0)
    
    [Compare
    Source](https://togithub.com/cypress-io/eslint-plugin-cypress/compare/v2.12.1...v2.13.0)
    
    ##### Features
    
    - Add 'unsafe-to-chain-command' rule
    ([bf6a75d](https://togithub.com/cypress-io/eslint-plugin-cypress/commit/bf6a75d))
    
    </details>
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: Branch creation - At any time (no schedule defined),
    Automerge - At any time (no schedule defined).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you
    are satisfied.
    
    ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
    rebase/retry checkbox.
    
    👻 **Immortal**: This PR will be recreated if closed unmerged. Get
    [config help](https://togithub.com/renovatebot/renovate/discussions) if
    that's undesired.
    
    ---
    
    - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
    this box
    
    ---
    
    This PR has been generated by [Mend
    Renovate](https://www.mend.io/free-developer-tools/renovate/). View
    repository job log
    [here](https://app.renovatebot.com/dashboard#github/elastic/kibana).
    
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTQuNyIsInVwZGF0ZWRJblZlciI6IjM1LjU4LjIifQ==-->
    
    ---------
    
    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
    renovate[bot] and patrykkopycinski committed May 2, 2023
    Configuration menu
    Copy the full SHA
    a16930f View commit details
    Browse the repository at this point in the history
  14. [serverless] Create Security Serverless plugin (elastic#156104)

    > Derived from elastic#153274
    > Builds upon elastic#155582
    
    ## Summary
    
    This PR creates the Serverless Security plugin, based on the work from
    elastic#153274:
    
    - creates the plugin,
    - adds API to hide the solution navigation from Security,
    - calls that API if the chrome style is `project`.
    
    <img width="1688" alt="Screenshot 2023-04-27 at 12 37 46 PM"
    src="https://user-images.githubusercontent.com/297604/234979670-425bfb12-8194-4916-8f92-efff7804b577.png">
    
    ## Next Steps
    
    - render the left nav from elastic#153274
    using an API provided by @elastic/appex-sharedux
      - this low-level API should be coming in the next few days.
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    clintandrewhall and kibanamachine committed May 2, 2023
    Configuration menu
    Copy the full SHA
    b217dbf View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    bf0920d View commit details
    Browse the repository at this point in the history
  16. [Infrastructure UI] Adopt new saved views API (elastic#155827)

    ## 📓 Summary
    
    Part of elastic#152617
    Closes elastic#106650
    Closes elastic#154725
    
    This PR replace the existing client React logic for handling saved views
    on the `infra` plugin with a new state management implementation that
    interacts with the newly created API.
    It brings the following changes:
    - Implement `useInventoryViews` and `useMetricsExplorerViews` custom
    hooks.
    - Adopt `@tanstack/react-query` for the above hooks implementation as it
    was already used across the plugin and simplifies the server state
    management. Extract the provider for the react query cache.
    - Update server services to fix an issue while updating views, which was
    preventing the unset of properties from the view.
    - Update Saved Views components to integrate the new hooks.
    - The `Load views` option has been removed accordingly to the decision
    made with the UX team, since it wasn't adding any value that wasn't
    already present in the `Manage views` option.
    
    Even if we are duplicating similar logic to handle the Inventory and
    Metrics Explorer views, we decided to keep them separated to easily
    control their behaviour and avoid coupled logic that can be painful to
    split in future.
    
    ## 🐞 Bug fixes
    
    This implementation also fixed some existing bugs in production:
    - As reported in [this
    comment](elastic#155174 (review)),
    when the current view is deleted, the selector doesn't fallback on
    another view and keeps showing the same view title.
    It has been fixed and the selected view fallbacks to the default view.
    - When refreshing the page after a view was selected, the view was not
    correctly recovered and shown. The implemented changes fix this
    behaviour.
    - The "include time" option for creating/updating a saved view was not
    working and never removed the time property if disabled.
    - Minor visual adjustments such as action button type and alignment.
    
    ## 👨‍💻 Review hints
    
    The best way to verify all the interactions and loadings work correctly
    as a user expects, running the branch locally with an oblt cluster is
    recommended.
    In both the inventory and metrics explorer pages, the user should be
    able to:
    - Access and manage the saved views, select and load a view, delete a
    view, and set a view as default.
    - Save a new view.
    - Update the currently used view, except for the static **Default
    view**.
    - Show an error when trying to create/update a view with a name already
    held by another view.
    - Restore the view with the following priority order
      - Use from the URL the stored view id to restore the view
    - Use the default view id stored in the source configuration as a user
    preference
      - Use the static **Default view**
    
    ## 👣 Following steps
    
    - [ ] elastic#155117
    
    ---------
    
    Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    Co-authored-by: jennypavlova <jennypavlova94@gmail.com>
    4 people committed May 2, 2023
    Configuration menu
    Copy the full SHA
    74c9814 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    dbedd53 View commit details
    Browse the repository at this point in the history
  18. [ResponseOps] [Event Log] Remove event log HTTP APIs if no longer used (

    elastic#155913)
    
    Resolves elastic#90486
    
    ## Summary
    
    Removes the event log HTTP apis since they are not used, and adds them
    to the functional tests
    
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    doakalexi and kibanamachine committed May 2, 2023
    Configuration menu
    Copy the full SHA
    5e1055c View commit details
    Browse the repository at this point in the history
  19. [Security Solution] [Fix] Alert Page Controls do not take Alert Table…

    … "Additional Filters" into account. (elastic#155861)
    
    ## Summary
    
    This PR handles : [Security Solution] New alert filters are not taking
    into consideration alert table filters elastic#155173 and elastic#156252
    
    Currently, Alert Page Controls do not take Alert Table Checkboxes (
    Building block + Threat indicator alerts only ) into account. This PR
    enables the effect of Alert Table Checkboxes on Alert Page controls
    
    | Before | After |
    |--|--|
    | <video
    src="https://user-images.githubusercontent.com/7485038/234568673-b05ffc32-09bc-4378-aecb-bb64dbc5cbb6.mov"
    /> | <video
    src="https://user-images.githubusercontent.com/7485038/234562759-6309d6a0-f7db-48fd-bd9e-62788a1c89fe.mov"/>
    |
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios.
    logeekal committed May 2, 2023
    Configuration menu
    Copy the full SHA
    aeded80 View commit details
    Browse the repository at this point in the history
  20. [RAM] Apply maintenance windows privilege to UI (elastic#156191)

    ## Summary
    
    We will have three scenarios with kibana privileges
    
    ### NONE
    Kibana privileges form maintenance window:
    <img width="680" alt="image"
    src="https://user-images.githubusercontent.com/189600/235188523-acaff7de-54d4-4991-a014-05c0f449738c.png">
    
    `The expected result is to not see maintenance window at all`
    
    <img width="1481" alt="image"
    src="https://user-images.githubusercontent.com/189600/235188658-6a53b463-4856-42c7-916e-aa8e6d7e326b.png">
    
    ### READ
    Kibana privileges form maintenance window:
    <img width="677" alt="image"
    src="https://user-images.githubusercontent.com/189600/235188908-623d32ac-39a7-484e-bd5c-f858e04d16b2.png">
    
    `The expected result is to only see the table with window maintenance
    and you can not edit them`
    
    <img width="1487" alt="image"
    src="https://user-images.githubusercontent.com/189600/235189169-f71422bf-6394-4574-87fb-14c653ca1e79.png">
    <img width="1484" alt="image"
    src="https://user-images.githubusercontent.com/189600/235192048-149519ba-0505-46e3-b737-2703560eb3d6.png">
    
    
    ### ALL
    Kibana privileges form maintenance window:
    <img width="668" alt="image"
    src="https://user-images.githubusercontent.com/189600/235189384-e71d9138-221c-4024-91bb-2ae32da1bd3b.png">
    
    `The expected result is to be able to create/edit/etc on any maintenance
    windows`
    
    <img width="1484" alt="image"
    src="https://user-images.githubusercontent.com/189600/235189974-e36c1e65-0586-4840-ace5-32caf06455c6.png">
    <img width="1481" alt="image"
    src="https://user-images.githubusercontent.com/189600/235192269-0f8d1922-d48f-494c-9979-2288bf142286.png">
    
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    XavierM and kibanamachine committed May 2, 2023
    Configuration menu
    Copy the full SHA
    3c9da2c View commit details
    Browse the repository at this point in the history
  21. Fix throughput chart on APM alert details page (elastic#156348)

    Fixes elastic#154802
    
    ## Summary
    
    Fix the Y-axis label and tooltip:
    
    <img
    src="https://user-images.githubusercontent.com/12370520/235647500-5efb80c4-5c93-47b3-bd69-6518ae330a4b.png"
    width="500" />
    
    ## 🧪 How to test
    - Create an APM Latency threshold alert
    - Go to the alert details page and check the throughput chart for the
    correct label and tooltip
    maryam-saeidi committed May 2, 2023
    Configuration menu
    Copy the full SHA
    c271cbb View commit details
    Browse the repository at this point in the history
  22. [Infrastructure UI] Fix Lens charts for APM hosts (elastic#156372)

    ## Summary
    
    After the implementation of the new API and host limit, all charts now
    load only after the table is loaded. This PR changes the filters the
    page currently passes to Lens, to pass only a list of host names, the
    same way Alerts and Logs tabs do it.
    
    This also fixes a problem where filters remove documents containing
    metrics data.
    
    
    <img width="772" alt="image"
    src="https://user-images.githubusercontent.com/2767137/235683301-35709698-49c2-4871-a724-2d2ca662f3f2.png">
    
    <img width="772" alt="image"
    src="https://user-images.githubusercontent.com/2767137/235683956-f7170213-afbd-400d-a190-a02087831af1.png">
    
    
    
    
    ### How to test
    
    - Connect your local kibana to an oblt cluster
    - Go to Hosts view
    - Filter by `service.name: "opbeans-java"`
    crespocarlos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    e980427 View commit details
    Browse the repository at this point in the history
  23. [AO] Fix APM latency expected value (elastic#156269)

    Fixes elastic#154801
    
    ## 📝 Summary 
    This PR fixes the expected value of the APM latency rule both in the
    flyout and alert details page.
    
    |Before|After 1|After 2|
    |---|---|---|
    
    |![image](https://user-images.githubusercontent.com/12370520/235477575-bc1891b7-0067-4bdf-9576-f0dce41d4b4c.png)|![image](https://user-images.githubusercontent.com/12370520/235477607-ab37d990-3536-409a-980d-370473a8c918.png)|![image](https://user-images.githubusercontent.com/12370520/235477667-438ebd69-3e4d-4e95-88f1-5fc8febf9125.png)|
    
    
    ## 🧪 How to test
    - Create an APM Latency alert
    - Click on the reason to open the flyout and check the expected value
    there
    - From the action menu of that alert, go to alert details page and check
    the expected value
    maryam-saeidi committed May 2, 2023
    Configuration menu
    Copy the full SHA
    b5914f4 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    8da8f89 View commit details
    Browse the repository at this point in the history
  25. [Fleet] Removes messageSigningService api definition from openApi spec (

    elastic#156376)
    
    ## Summary
    
    - Removes message signing service api definition from openAPI spec.
    - Updates warning message when `acknowledge` param is missing or set to
    false.
    dasansol92 committed May 2, 2023
    Configuration menu
    Copy the full SHA
    b961399 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    30eb413 View commit details
    Browse the repository at this point in the history
  27. [Fleet] Fix package install with older version (elastic#156257)

    ## Summary
    
    This PR fixes a bug where an older version of a package cannot be
    installed when creating a new agent policy.
    
    Closes elastic#152095
    
    ### Reproducing the bug
    
    1. Run Kibana off the `main` branch.
    2. Install a package of your choice for the first time (it should not
    already be installed) on a version lower than the latest (cf. screenshot
    1). In the configuration page under `Where to add this integration?`,
    leave `New hosts` selected to ensure a new agent policy is created (cf.
    screenshot 2).
    3. After the package is installed, go to the package settings: notice
    that the installed version is actually the latest (cf. screenshot 3).
    4. Note: if you go to the `Integration policies` tab of the package, you
    will notice that the integration policy has the version number you
    intended to install (cf. screenshot 4).
    
    ### Cause of the bug
    
    The `onSubmit` hook used by the package install form [makes use the of
    the `epm/packages/_bulk`
    endpoint](https://github.com/elastic/kibana/blob/e62581f8bf6098f2813768af2f31647c592645a2/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/single_page_layout/hooks/form.tsx#L272)
    to bulk install multiple packages if a new agent policy is to be
    created. The `epm/packages/_bulk` endpoint accepts an array of packages
    which are either specified by a package name (string) or name and
    version (object). In the current implementation, this hook only provides
    the package names, which resolves to the latest version of the package
    being installed.
    
    ### How this PR fixes the bug
    
    This PR make the following changes:
    * Make the `BulkInstallPackagesFromRegistryRequestSchema` validation
    accepts an array of either strings or objects of shape `{ name: string,
    version: string }` for packages.
    * Modify the `sendBulkInstallPackages` request hook to do the same.
    * Make the `onSubmit` hook used by the package install form pass the
    package name and version to the `epm/packages/_bulk` endpoint.
    
    ### Additional changes
    
    * Add API integration test for bulk package install
    * Amend OpenAPI definition: [Swagger
    link](https://petstore.swagger.io/?url=https://raw.githubusercontent.com/elastic/kibana/a4a3209905a5cf099fa22779e889a57acb124fb2/x-pack/plugins/fleet/common/openapi/bundled.json#/Elastic%20Package%20Manager%20(EPM)/bulk-install-packages)
    (cf. screenshot 7)
    
    ### Testing steps
    
    1. (Optional) Test that the `epm/packages/_bulk` endpoint accepts
    package name as strings or package name and version as objects, or even
    a mix of both (cf. screenshot 6).
    2. Same steps as `Reproducing the bug` above on this branch. The correct
    version of the package should be installed (cf screenshot 5).
    
    ### Screenshots
    
    Screenshot 1: preparing to install an older version of a package:
    <img width="1917" alt="Screenshot 2023-05-02 at 11 21 12"
    src="https://user-images.githubusercontent.com/23701614/235631501-aa03d2b0-6fe8-4e9a-8e0c-5547f8fccea0.png">
    
    
    Screenshot 2: creating a new agent policy when installing the package:
    <img width="1917" alt="Screenshot 2023-05-02 at 11 21 33"
    src="https://user-images.githubusercontent.com/23701614/235631650-3d9bfc19-ace3-4488-a7c7-48078aae3e7c.png">
    
    Screenshot 3: integration settings after installing an older version
    onto a new agent policy, showing that the installed version is actually
    the latest version:
    <img width="1917" alt="Screenshot 2023-05-02 at 11 29 07"
    src="https://user-images.githubusercontent.com/23701614/235631920-3ca8f606-d225-464e-8094-46aeee4869df.png">
    
    
    Screenshot 4: `Integration policies` tab, showing that the integration
    policy has the older version:
    <img width="1917" alt="Screenshot 2023-05-02 at 11 28 43"
    src="https://user-images.githubusercontent.com/23701614/235632212-c82a3ddd-cb33-4179-a4ab-b57e33e7490d.png">
    
    
    Screenshot 5: integration settings after installing an older version
    onto a new agent policy **with the bug fix**, showing that the correct
    version was installed:
    <img width="1917" alt="Screenshot 2023-05-02 at 11 23 09"
    src="https://user-images.githubusercontent.com/23701614/235632590-bb26183d-ce60-439c-9bee-eadb9fdb9654.png">
    
    
    Screenshot 6: API call showing the two ways of specifying a package
    using the `epm/packages/_bulk` endpoint (package name only, or name and
    version):
    <img width="1917" alt="Screenshot 2023-05-02 at 11 59 11"
    src="https://user-images.githubusercontent.com/23701614/235637532-ae32072b-ca84-48bb-9760-120a2149f0e5.png">
    
    
    Screenshot 7: `epm/packages/_bulk` endpoint reference on Swagger:
    <img width="1429" alt="Screenshot 2023-05-02 at 15 13 14"
    src="https://user-images.githubusercontent.com/23701614/235677504-e8ba1329-1a70-44f8-92c5-0f32e5da7e46.png">
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    jillguyonnet and kibanamachine committed May 2, 2023
    Configuration menu
    Copy the full SHA
    d71f6f3 View commit details
    Browse the repository at this point in the history
  28. Add dev docs for other bucket generation (elastic#156335)

    ## Summary
    
    This PR adds dev docs for generating `_other` bucket running APM Server
    locally
    achyutjhunjhunwala committed May 2, 2023
    Configuration menu
    Copy the full SHA
    3ccf499 View commit details
    Browse the repository at this point in the history
  29. [Security Solution] [Fix] Alert Table re-render + column width reset …

    …+ TopN Not rendering (elastic#155478)
    
    ## Summary
    
    This PR handles : 
    -  Column width is reset when alert table re-renders elastic#154796 
    - [Response Ops] Triggers Actions Alert table un-mounts / remounts
    complete row when clicking on checkbox. elastic#155229
    - [Security Solution] TopN does not work on Alert Table in Event
    Rendered View elastic#155152
    
    
    |Before | After |
    |---|---|
    | <video
    src="https://user-images.githubusercontent.com/7485038/233974827-548c7e61-0737-436c-8384-0faa923ab5d7.mov"
    /> | <video
    src="https://user-images.githubusercontent.com/7485038/234316670-4cd318bd-8fde-45ed-999d-a6a78bbf0432.mov"
    />
    
     |
    logeekal committed May 2, 2023
    Configuration menu
    Copy the full SHA
    eba1001 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    d41da82 View commit details
    Browse the repository at this point in the history
  31. [Response Ops][Alerting] Exposing background worker utilization load …

    …metric (elastic#153600)
    
    Resolves elastic#155762,
    elastic#155761
    ## Summary
    
    This PR exposes a metric that represents the background task worker
    utilization load at the end of each polling cycle. This is calculated as
    `(# of workers already busy + claimed tasks) / max workers`, which comes
    out to the number of workers in use at the end of each claim cycle. This
    metric is then averaged over the previous 15 seconds (or 5 polling
    cycles). This window size is configurable using
    `xpack.task_manager.worker_utilization_running_average_window`
    
    This PR exposes this metric in the existing
    `/internal/task_manager/_background_task_utilization` API but also adds
    a public version of this API
    (`/api/task_manager/_background_task_utilization`) that only exposes
    this metric. We need the public API for serverless but I thought we
    could keep the private route as well to expose experimental metrics
    without the overhead of supporting them long term.
    
    ## To Verify
    
    1. Run ES and Kibana with this branch
    2. Navigate to `/internal/task_manager/_background_task_utilization` and
    see the new metric exposed as `stats.value.load` along with the existing
    `adhoc` and `recurring` metrics
    3. Navigate to `/api/task_manager/_background_task_utilization` and see
    only the load metric returned from the public API
    4. You can also create some rules to see the load metric increase.
    
    ---------
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    ymao1 and kibanamachine committed May 2, 2023
    Configuration menu
    Copy the full SHA
    17487b8 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    0324cdc View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    ee9d782 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    3cd3549 View commit details
    Browse the repository at this point in the history
  35. [Serverless/Side Nav] Light mode for side nav background (elastic#156293

    )
    
    ## Summary
    
    This removes the dark background of the side nav for serverless
    projects.
    
    Pulled from elastic#153508
    
    Context from @MichaelMarcialis 
    > current plans for the next revision is to ditch the high contrast nav
    and header in favor of one that honors the current theme mode (light for
    light and dark for dark).
    
    ## Screenshots
    **Before**
    <img width="1912" alt="light mode before"
    src="https://user-images.githubusercontent.com/908371/235507715-5a094c83-b644-4cfa-946e-bc7183d393f5.png">
    
    **After**
    <img width="1912" alt="light mode after"
    src="https://user-images.githubusercontent.com/908371/235507752-fa4e6548-f587-4bc2-93f4-f900aef542a1.png">
    tsullivan committed May 2, 2023
    Configuration menu
    Copy the full SHA
    0bf005a View commit details
    Browse the repository at this point in the history
  36. [Security Solution] [Fix] Cypress test flakyness in Alert page Contro…

    …ls (elastic#155988)
    
    ## Summary
    
    Handles :  elastic#153685 and elastic#153686
    
    This PR tries to fix the flakyness of cypress tests. Although, this
    issue in cypress is very difficult to reproduce, I noticed that it is
    coming mainly when adding extra control.
    
    And it looks like during the course of dev one of the API of adding a
    control called `addOptionsListControl` was changed to be a promise,
    therefore, mainly the change is to await the promise before adding a new
    control.
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    logeekal committed May 2, 2023
    Configuration menu
    Copy the full SHA
    6203acb View commit details
    Browse the repository at this point in the history
  37. [Synthetics] Fix step number column on monitor detail page (elastic#1…

    …56222)
    
    ## Summary
    
    Resolves elastic#155921.
    
    Adds `nowrap` to the step number column.
    
    <img width="115" alt="image"
    src="https://user-images.githubusercontent.com/18429259/235238832-95589bea-83ce-4571-8fc9-c508e5c6e6f7.png">
    
    
    ## Testing
    
    On the detail page, look at the list. If the step number is not wrapping
    like the image shown in the linked issue, the problem is fixed.
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [ ] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [ ] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [ ] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [ ] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [ ] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    
    ### Risk Matrix
    
    Delete this section if it is not applicable to this PR.
    
    Before closing this PR, invite QA, stakeholders, and other developers to
    identify risks that should be tested prior to the change/feature
    release.
    
    When forming the risk matrix, consider some of the following examples
    and how they may potentially impact the change:
    
    | Risk | Probability | Severity | Mitigation/Notes |
    
    |---------------------------|-------------|----------|-------------------------|
    | Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
    | Low | High | Integration tests will verify that all features are still
    supported in non-default Kibana Space and when user switches between
    spaces. |
    | Multiple nodes&mdash;Elasticsearch polling might have race conditions
    when multiple Kibana nodes are polling for the same tasks. | High | Low
    | Tasks are idempotent, so executing them multiple times will not result
    in logical error, but will degrade performance. To test for this case we
    add plenty of unit tests around this logic and document manual testing
    procedure. |
    | Code should gracefully handle cases when feature X or plugin Y are
    disabled. | Medium | High | Unit tests will verify that any feature flag
    or plugin combination still results in our service operational. |
    | [See more potential risk
    examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    justinkambic committed May 2, 2023
    Configuration menu
    Copy the full SHA
    9816a6f View commit details
    Browse the repository at this point in the history
  38. [Synthetics] Support hideInterval when using rule edit form (elasti…

    …c#156187)
    
    ## Summary
    
    Fixes elastic#152430.
    
    As
    [noted](elastic#152430 (comment)),
    the previous fix for this does not work in all cases. We need to support
    this flag in both `add` and `edit` modes, so this patch adds support for
    the `hideInterval` flag for the rule edit form as well.
    
    ## Testing
    
    Open Synthetics and attempt to modify the Monitor Status alert, and
    observe that the interval edit field doesn't show up anymore.
    
    <img width="593" alt="image"
    src="https://user-images.githubusercontent.com/18429259/235187611-9e84b14e-180c-4ce2-b020-4cdd56ceb09f.png">
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [ ] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [ ] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [ ] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [ ] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [ ] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    
    ### Risk Matrix
    
    Delete this section if it is not applicable to this PR.
    
    Before closing this PR, invite QA, stakeholders, and other developers to
    identify risks that should be tested prior to the change/feature
    release.
    
    When forming the risk matrix, consider some of the following examples
    and how they may potentially impact the change:
    
    | Risk | Probability | Severity | Mitigation/Notes |
    
    |---------------------------|-------------|----------|-------------------------|
    | Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
    | Low | High | Integration tests will verify that all features are still
    supported in non-default Kibana Space and when user switches between
    spaces. |
    | Multiple nodes&mdash;Elasticsearch polling might have race conditions
    when multiple Kibana nodes are polling for the same tasks. | High | Low
    | Tasks are idempotent, so executing them multiple times will not result
    in logical error, but will degrade performance. To test for this case we
    add plenty of unit tests around this logic and document manual testing
    procedure. |
    | Code should gracefully handle cases when feature X or plugin Y are
    disabled. | Medium | High | Unit tests will verify that any feature flag
    or plugin combination still results in our service operational. |
    | [See more potential risk
    examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    justinkambic committed May 2, 2023
    Configuration menu
    Copy the full SHA
    41f0b75 View commit details
    Browse the repository at this point in the history
  39. [Chrome] Expose api to to set custom component for project left nav (e…

    …lastic#156205)
    
    In this PR I've exposed a new api from the Chrome service to set a
    custom React component for the side navigation.
    Calling this API does not have any effect if Kibana is not started in
    "project" ChromeStyle.
    
    ## Api
    
    ```ts
    chrome.project.setSideNavComponent(/* component */);
    ```
    
    ## Example
    
    ```ts
    // my_nav.tsx
    import React, { type FC } from 'react';
    import type { SideNavComponent } from '@kbn/core-chrome-browser';
    
    // SideNavComponent will receive in its props Chrome service state (the current active route, the navTree...) 
    export const MyNav: SideNavComponent = (props) => {
      return <div>Custom navigation...</div>;
    };
    
    -------------------
    
    // serverless plugin.ts (public)
    import { MyNav } from './my_nav';
    ...
    
    public start(core: CoreStart) {
      core.chrome.project.setSideNavComponent(MyNav);
      return {};
    }
    ```
    sebelga committed May 2, 2023
    Configuration menu
    Copy the full SHA
    06054cd View commit details
    Browse the repository at this point in the history
  40. Profiling: symbolization created on user opt-in (elastic#156089)

    Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
    
    ## Summary
    
    Include the creation of symbolizer package policy in the setup initiated
    by users when they opt-in Universal Profiling.
    
    ### Checklist
    
    - [X]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [X] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    
    ### Related issues or PRs
    * elastic#155642
    * elastic#150885
    
    ---------
    
    Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    Co-authored-by: Jen Huang <its.jenetic@gmail.com>
    3 people committed May 2, 2023
    Configuration menu
    Copy the full SHA
    d4f6cf7 View commit details
    Browse the repository at this point in the history
  41. [Response Ops][Alerting] Updating alerting README for FAAD (elastic#1…

    …55899)
    
    Updated alerting README to describe assets installed for framework
    alerts-as-data
    ymao1 committed May 2, 2023
    Configuration menu
    Copy the full SHA
    1a485ec View commit details
    Browse the repository at this point in the history
  42. Fix search issue with Alert search bar (elastic#155796)

    Fixes elastic#155655
    
    Added `onQuerySubmit` ~as optional~ parameter to `AlertsSearchBar` and
    made `onQueryChange` as optional parameter as this is not needed for
    Observability Alerts.
    
    ### [Observability] Alerts page:
    
    
    https://user-images.githubusercontent.com/69037875/234622864-c18e338c-2ea3-4c79-9340-30c5e8fa470e.mov
    
    ### [Security] Alerts filter in action:
    
    
    https://user-images.githubusercontent.com/69037875/234623243-c882a866-83fa-4d09-a1fb-d36588922f30.mov
    benakansara committed May 2, 2023
    Configuration menu
    Copy the full SHA
    44c40a3 View commit details
    Browse the repository at this point in the history
  43. [SLO] Improve optimistic updating when cloning or deleting (elastic#1…

    …56385)
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    CoenWarmer and kibanamachine committed May 2, 2023
    Configuration menu
    Copy the full SHA
    df279dc View commit details
    Browse the repository at this point in the history
  44. chore(NA): update versions after v8.7.2 bump (elastic#156368)

    This PR is a simple update of our versions file after the recent bumps
    mistic committed May 2, 2023
    Configuration menu
    Copy the full SHA
    594e53a View commit details
    Browse the repository at this point in the history
  45. chore(NA): update versions after v7.17.11 bump (elastic#156371)

    This PR is a simple update of our versions file after the recent bumps
    mistic committed May 2, 2023
    Configuration menu
    Copy the full SHA
    5299873 View commit details
    Browse the repository at this point in the history
  46. [Enterprise Search] Bug fix: Show correct index doc counts when viewi…

    …ng search applications (elastic#156431)
    
    ## Summary
    
    Fixes a bug where replicas would be counted when reporting the total
    document count in indices associated with a search application.
    
    Thanks to @efegurkan for the help!
    kderusso committed May 2, 2023
    Configuration menu
    Copy the full SHA
    296b05a View commit details
    Browse the repository at this point in the history
  47. Fix unable to create roles under Stack Management (elastic#156381)

    Resolves elastic#156249
    
    ---------
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    thomheymann and kibanamachine committed May 2, 2023
    Configuration menu
    Copy the full SHA
    de0498d View commit details
    Browse the repository at this point in the history
  48. [Cases] Renaming user action type (elastic#156113)

    This PR creates a proper `UserAction` type and various attributes types
    to be used in the service layer of the backend.
    
    There shouldn't be any functionality changes here just type name
    changes.
    jonathan-buttner committed May 2, 2023
    Configuration menu
    Copy the full SHA
    f0b75b3 View commit details
    Browse the repository at this point in the history
  49. [Enterprise Search] Remove BA CTA from search application API page (e…

    …lastic#156378)
    
    ## Summary
    
    Removes a call to action to connect search applications to behavioral
    analytics. This will not be supported for 8.8.0.
    
    <img width="1278" alt="image"
    src="https://user-images.githubusercontent.com/63422879/235670262-c537f790-6d75-40c1-96a8-d7a21473b30b.png">
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    kderusso and kibanamachine committed May 2, 2023
    Configuration menu
    Copy the full SHA
    291cdb6 View commit details
    Browse the repository at this point in the history
  50. [Enterprise Search] Show error panel on API call errors (elastic#156273)

    ## Summary
    
    This PR adds generic error handling for API calls that manage the ELSER
    model: creation (download), fetching and starting the deployment. If an
    error occurs, the ELSER panel is replaced with the error panel. The user
    can navigate to the ML Notifications page with a link, which might
    contain diagnostic information about the error.
    
    
    ![ELSER_error_handling](https://user-images.githubusercontent.com/14224983/235535266-93e8e822-0603-4a10-8aab-ec77cd167bf6.gif)
    
    
    ### Checklist
    
    - [x] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [x] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [x] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    
    ---------
    
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    demjened and kibanamachine committed May 2, 2023
    Configuration menu
    Copy the full SHA
    5263339 View commit details
    Browse the repository at this point in the history
  51. [Synthetics] Adjust content (elastic#156029)

    ## Summary
    
    Resolves elastic#155936
    Relates to elastic#152915
    Resolves elastic#150944
    Resolves elastic#156166
    
    Copy fixes:
    
    - Alerting config: Address Typo
    (elastic#152915 (comment))
    - Alerting config: Address success toast wording
    - Getting started ("Create your first monitor") locations: Repeated text
    between placeholder and hint text. To address this, I changed the
    helptext to give more detail
    - Private locations -> "Monitors" column: replaced `Running` with
    `configured`
    - Overview page: Search bar placeholder: `url` is now uppercase `URL`
    - Monitor status alert - Updates text for viewer user to be consistent
    with other tooltips
    - Run once errors - Remove extra error toast 
    - Run once errors - Remove excess phrase from error
    - Sync errors - Made content more user friendly
    - Synthetics App - replace references to Monitor Management with
    Synthetics App
    - Enable/disable - clarify when actions apply to all monitors
    - Project monitors - add reference to enabling/disabling alerting on
    project monitor page
    - Enablement - Adjust content for less privileged users
    
    Some screenshots of the fixes are below. These are not exhaustive
    <img width="1417" alt="Screen Shot 2023-04-25 at 12 12 38 PM"
    src="https://user-images.githubusercontent.com/11356435/234906460-529d48d4-f682-4d45-b439-7bd7189c37ea.png">
    <img width="772" alt="Screen Shot 2023-04-25 at 12 12 31 PM"
    src="https://user-images.githubusercontent.com/11356435/234906462-b85d6fe0-2d32-42f0-81fb-2f528c5c0d87.png">
    <img width="909" alt="Screen Shot 2023-04-25 at 12 12 10 PM"
    src="https://user-images.githubusercontent.com/11356435/234906466-49286af9-29c4-4bcb-9d10-dc84bcddd66f.png">
    <img width="1414" alt="Screen Shot 2023-04-25 at 11 59 57 AM"
    src="https://user-images.githubusercontent.com/11356435/234906468-48b27002-5771-42df-9ee5-5852dabeaaeb.png">
    <img width="623" alt="Screen Shot 2023-04-25 at 11 57 53 AM"
    src="https://user-images.githubusercontent.com/11356435/234906470-4ea5acf7-bff2-41af-a679-7e4b9f43c377.png">
    <img width="735" alt="Screen Shot 2023-04-27 at 4 16 17 PM"
    src="https://user-images.githubusercontent.com/11356435/234982914-128af18e-204a-4df6-a791-ac3155d8b5b9.png">
    <img width="1240" alt="Screen Shot 2023-04-28 at 2 09 29 PM"
    src="https://user-images.githubusercontent.com/11356435/235223171-f2177983-f8cc-45a3-8ff8-76850508e63e.png">
    <img width="602" alt="Screen Shot 2023-04-28 at 11 12 49 AM"
    src="https://user-images.githubusercontent.com/11356435/235223288-7b01dd85-2311-4b42-bb91-92e4a4f454e3.png">
    <img width="552" alt="Screen Shot 2023-04-28 at 11 12 25 AM"
    src="https://user-images.githubusercontent.com/11356435/235223290-00cc6a8c-7f9c-46f1-b8ae-5c98eaeaa35d.png">
    <img width="1448" alt="Screen Shot 2023-04-28 at 2 56 58 PM"
    src="https://user-images.githubusercontent.com/11356435/235230906-093d720c-9ac9-4cf1-b04a-34a1409d7379.png">
    
    ---------
    
    Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    3 people committed May 2, 2023
    Configuration menu
    Copy the full SHA
    589ea3a View commit details
    Browse the repository at this point in the history
  52. [SecuritySolution] Restore lens table columns when Reset group by fie…

    …ld clicked. (elastic#156393)
    
    ## Summary
    
    issue: elastic#155859
    Steps to reproduce: Please find the issue above.
    
    `Reset group by field` action should:
    1. Revert `Group by` and `Group by top` to default fields
    `kibana.alert.rule.name` and `host.name`
    2. Unhide all the columns in the table.
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    angorayc committed May 2, 2023
    Configuration menu
    Copy the full SHA
    db02784 View commit details
    Browse the repository at this point in the history
  53. [SecuritySolution] Align no indices state with Kibana dashboard (elas…

    …tic#155990)
    
    ## Summary
    
    Steps to reproduce:
    1. Make sure you have some data in Security Data View. Create a
    dashboard that consumes Security Data View, save it and add a `Security
    Solution` tag.
    2. Delete the non-empty indices in Security Data View
    3. Back to SecuritySolution > Dashboards, select the dashboard you
    added.
    4. This is the current indices not found UI you'd see:
    <img width="2546" alt="dashboard_view_indices_notfound"
    src="https://user-images.githubusercontent.com/6295984/234829440-842442e1-f09a-464e-a6c0-8761a3124791.png">
    
    
    Expected:
    - We should align the behaviour with Kibana dashboard when indices not
    found:
    
    <img width="2555" alt="Screenshot 2023-04-27 at 10 48 26"
    src="https://user-images.githubusercontent.com/6295984/234829379-251fb621-e7cd-4788-a682-8a2bce25312a.png">
    
    After:
    <img width="2542" alt="Screenshot 2023-04-27 at 11 10 16"
    src="https://user-images.githubusercontent.com/6295984/234832003-95f5c7e5-57d9-4424-b591-f512f365cda2.png">
    angorayc committed May 2, 2023
    Configuration menu
    Copy the full SHA
    12277ac View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Update APM links (elastic#156460)

    This PR updates three APM links. For the failing links in
    elastic/apm-server#10560.
    bmorelli25 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    72c5d52 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8a2a4bb View commit details
    Browse the repository at this point in the history
  3. [ML] Package @kbn/ml-anomaly-utils (elastic#155697)

    Creates Package `@kbn/ml-anomaly-utils`.
    
    - This moves some of the utility functions, constants and types related
    to Anomaly Detection we previously exposed from the `ml` plugin itself
    to a package `@kbn/ml-anomaly-utils`, resulting in ~5.9KB reduction of
    the plugin's page load bundle size.
    - To reduce increases in async bundle size for consuming plugins the
    utils have been refactored into individual files to allow deep imports
    and get some optimization through that. Some previously duplicated code
    in consuming plugins has been deleted and replaced with deep imports of
    the corresponding original code in the package.
    - Types have been prefixed with `Ml`.
    - Constants have been prefixed with `ML_`.
    
    Created package via `node scripts/generate package @kbn/ml-anomaly-utils
    --web --dir ./x-pack/packages/ml/anomaly_utils`.
    walterra committed May 3, 2023
    Configuration menu
    Copy the full SHA
    385d0dc View commit details
    Browse the repository at this point in the history
  4. [functional tests] split security and spaces ftr configs (elastic#156350

    )
    
    ## Summary
    
    Splitting ftr configs to speed up ftr tests run on CI 
    
    ```
    The following "Functional Tests" configs have durations that exceed the maximum amount of time desired for a single CI job. 
    This is not an error, and if you don't own any of these configs then you can ignore this warning.If you own any of these
    configs please split them up ASAP and ask Operations if you have questions about how to do that.
    
    x-pack/test/spaces_api_integration/security_and_spaces/config_basic.ts: 38.2 minutes
    x-pack/test/spaces_api_integration/security_and_spaces/config_trial.ts: 38.2 minutes
    ```
    
    After split:
    x-pack/test/spaces_api_integration/security_and_spaces/config_basic.ts
    20m 29s
    
    x-pack/test/spaces_api_integration/security_and_spaces/copy_to_space_config_basic.ts
    20m 52s
    x-pack/test/spaces_api_integration/security_and_spaces/config_trial.ts
    19m 57s
    
    x-pack/test/spaces_api_integration/security_and_spaces/copy_to_space_config_trial.ts
    21m 5s
    
    Rebalancing it with other configs should speedup CI by at least few
    minutes
    dmlemeshko committed May 3, 2023
    Configuration menu
    Copy the full SHA
    424eae3 View commit details
    Browse the repository at this point in the history
  5. [Fleet] Fix missing await in test making test flaky (elastic#156402)

    Closes elastic#150607
    
    ## Summary
    
    Flaky test was re-enabled last month but was failing again. An "await"
    was missing and was likely causing the flakiness.
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    criamico and kibanamachine committed May 3, 2023
    Configuration menu
    Copy the full SHA
    b6fe8e1 View commit details
    Browse the repository at this point in the history
  6. [Unified search] Fixes the bar suggestions method selection (elastic#…

    …156329)
    
    ## Summary
    
    Closes elastic#155801
    
    Fixes the bug described here
    elastic#155801
    
    The bug was introduced by
    https://github.com/elastic/kibana/pull/154522/files
    
    If the filtersForSuggestions prop is there, we want to default to
    terms_agg, otherwise we want to keep it as undefined to use the advanced
    settings method.
    stratoula committed May 3, 2023
    Configuration menu
    Copy the full SHA
    63c1f20 View commit details
    Browse the repository at this point in the history
  7. [ML] Functional tests - stabilize and re-enable export jobs tests (el…

    …astic#152334)
    
    This PR re-enables the export job tests and the reporting download tests
    after the underlying issues has been fixed by switching to the new
    headless browser mode.
    pheyos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    a90f4c2 View commit details
    Browse the repository at this point in the history
  8. [ML] Anomaly Detection Settings: Fix key attribute for filter list ta…

    …ble (elastic#156392)
    
    Fixes the React dev mode warning "Warning: Each child in a list should
    have a unique "key" prop." by adding a key attribute to the
    `DeleteFilterListModal` component.
    walterra committed May 3, 2023
    Configuration menu
    Copy the full SHA
    7a4ae72 View commit details
    Browse the repository at this point in the history
  9. [ML] Fixing space checks for recently changed trained model apis (ela…

    …stic#156238)
    
    Fixes issues raised in
    elastic#155375 (comment)
    Kibana trained model endpoints for `_stop`, `_update` and `infer` now
    require the model ID was well as the deployment ID to be passed to them.
    
    
    Also fixes the stop trained model api when stopping more than one model.
    It's very likely the elasticsearch `_stop` api will not support a comma
    separated list of deployment IDs for this release, and so this change
    calls `_stop` in a loop for each deployment. It also allows for better
    reporting if any of the deployments fail to stop.
    jgowdyelastic committed May 3, 2023
    Configuration menu
    Copy the full SHA
    9559bee View commit details
    Browse the repository at this point in the history
  10. [Lens] Enabled tsdb counter fields for last_value (elastic#156183)

    ## Summary
    
    Fixes elastic#156168 
    
    Enables the `last_value` operation for TSDB `counter` field types.
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [ ] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [ ] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [ ] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [ ] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [ ] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    
    ### Risk Matrix
    
    Delete this section if it is not applicable to this PR.
    
    Before closing this PR, invite QA, stakeholders, and other developers to
    identify risks that should be tested prior to the change/feature
    release.
    
    When forming the risk matrix, consider some of the following examples
    and how they may potentially impact the change:
    
    | Risk | Probability | Severity | Mitigation/Notes |
    
    |---------------------------|-------------|----------|-------------------------|
    | Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
    | Low | High | Integration tests will verify that all features are still
    supported in non-default Kibana Space and when user switches between
    spaces. |
    | Multiple nodes&mdash;Elasticsearch polling might have race conditions
    when multiple Kibana nodes are polling for the same tasks. | High | Low
    | Tasks are idempotent, so executing them multiple times will not result
    in logical error, but will degrade performance. To test for this case we
    add plenty of unit tests around this logic and document manual testing
    procedure. |
    | Code should gracefully handle cases when feature X or plugin Y are
    disabled. | Medium | High | Unit tests will verify that any feature flag
    or plugin combination still results in our service operational. |
    | [See more potential risk
    examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    dej611 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    36c31f5 View commit details
    Browse the repository at this point in the history
  11. [ML] Transforms/DFA: Render EuiDataGrad for more than 0 rows. (elasti…

    …c#156403)
    
    Fixes the React dev mode warning "Warning: Can't perform a React state
    update on an unmounted component." by only rendering `EuiDataGrid` if
    there's more than 0 rows.
    walterra committed May 3, 2023
    Configuration menu
    Copy the full SHA
    3f52ff6 View commit details
    Browse the repository at this point in the history
  12. [Defend Workflows][Bug] Case flyout z-index (elastic#153219)

    Fixes elastic/security-team#6228
    
    5000 `z-index` set in `create-case-flyout-mask-overlay` is being
    overwritten by `euiOverlayMask-belowHeader` with a value of 1000. This
    causes **Case flyout** to be under the already opened **Osquery flyout**
    
    This PR includes cleanup in flyouts renders - we removed unnecessary
    `maskProps` as well as z-indexes that were explicitly set even though
    flyout component manages them itself.
    
    
    ![test](https://user-images.githubusercontent.com/29123534/225292177-a08d3fb8-aad3-487b-a054-6cde6aec94d7.gif)
    
    ---------
    
    Co-authored-by: Tomasz Ciecierski <ciecierskitomek@gmail.com>
    Co-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co>
    Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    5 people committed May 3, 2023
    Configuration menu
    Copy the full SHA
    d8fe39c View commit details
    Browse the repository at this point in the history
  13. [Security Solution] Fix color coding of severities is different at En…

    …tity analytics (elastic#156383)
    
    issue: elastic#143043
    
    ## Summary
    
    Fix color coding of severities is different at Entity Analytics by using
    the same colors of alert severity.
    
    **Before:**
    
    ![195068297-4893ff3e-184a-4deb-b551-28d55f4994fd](https://user-images.githubusercontent.com/1490444/235682183-272d0739-7a65-42d4-b1ef-83751cf57ab0.jpg)
    
    
    
    
    **After:**
    
    ![Screenshot 2023-05-02 at 14 40
    23](https://user-images.githubusercontent.com/1490444/235678297-f4a05f1c-95f6-4895-a7b1-fd6645e55f7b.png)
    ![Screenshot 2023-05-02 at 14 40
    03](https://user-images.githubusercontent.com/1490444/235678383-0eefe697-5669-496d-b0b8-44433f519754.png)
    ![Screenshot 2023-05-02 at 14 37
    45](https://user-images.githubusercontent.com/1490444/235678609-257b8eb1-8b86-4064-8fbf-0c0b188174ae.png)
    
    ![Screenshot 2023-05-02 at 15 32
    22](https://user-images.githubusercontent.com/1490444/235681736-609b484c-bd08-4379-b76b-6a47c3a016ba.png)
    machadoum committed May 3, 2023
    Configuration menu
    Copy the full SHA
    7f68428 View commit details
    Browse the repository at this point in the history
  14. [visulizations] adding schema to saved object mapping (elastic#154514)

    ## Summary
    
    Removes remaining properties that are not searched on from the mapping
    for the visualizations saved object and adds a schema definition to it.
    
    part of elastic#153070
    ppisljar committed May 3, 2023
    Configuration menu
    Copy the full SHA
    b3aa580 View commit details
    Browse the repository at this point in the history
  15. [DataView] Style improvements for CreateDataView and CreateDataViewFi…

    …eld flyouts (elastic#156341)
    
    ## Summary
    
    This PR adds eui styles to scrollbars and shows "Discard changes" button
    in red.
    
    Before:
    <img width="500" alt="Screenshot 2023-05-02 at 11 16 42"
    src="https://user-images.githubusercontent.com/1415710/235631712-70fe2c39-d8ab-4304-9f59-8802cac278f1.png">
    
    After:
    <img width="500" alt="Screenshot 2023-05-02 at 11 22 59"
    src="https://user-images.githubusercontent.com/1415710/235631763-be30207c-f870-476e-a0e0-16050ea56750.png">
    <img width="500" alt="Screenshot 2023-05-02 at 11 26 42"
    src="https://user-images.githubusercontent.com/1415710/235631771-5f982918-2810-4cda-879b-7ad535299cd3.png">
    jughosta committed May 3, 2023
    Configuration menu
    Copy the full SHA
    93256a7 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    2c491b5 View commit details
    Browse the repository at this point in the history
  17. [Synthetics] enable api key when devUrl is set (elastic#156059)

    Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
    devcorpio and kibanamachine committed May 3, 2023
    Configuration menu
    Copy the full SHA
    c11dc28 View commit details
    Browse the repository at this point in the history
  18. [Enterprise Search] Remove low memory banner (elastic#156509)

    ## Summary
    
    Removes the low memory banner that would block cloud connectors on 2GB
    deployments, as memory issues have been resolved.
    sphilipse committed May 3, 2023
    Configuration menu
    Copy the full SHA
    b37224d View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    d0761f3 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    d96c5a6 View commit details
    Browse the repository at this point in the history
  21. Fix task manager polling flow controls (elastic#153491)

    Fixes elastic#151938
    
    In this PR, I'm re-writing the Task Manager poller so it doesn't run
    concurrently when timeouts occur while also fixing the issue where
    polling requests would pile up when polling takes time. To support this,
    I've also made the following changes:
    - Removed the observable monitor and the
    `xpack.task_manager.max_poll_inactivity_cycles` setting
    - Make the task store `search` and `updateByQuery` functions have no
    retries. This prevents the request from retrying 5x whenever a timeout
    occurs, causing each call taking up to 2 1/2 minutes before Kibana sees
    the error (now down to 30s each). We have polling to manage retries in
    these situations.
    - Switch the task poller tests to use `sinon` for faking timers
    - Removing the `assertStillInSetup` checks on plugin setup. Felt like a
    maintenance burden that wasn't necessary to fix with my code changes.
    
    The main code changes are within these files (to review thoroughly so
    the polling cycle doesn't suddenly stop):
    - x-pack/plugins/task_manager/server/polling/task_poller.ts
    - x-pack/plugins/task_manager/server/polling_lifecycle.ts (easier to
    review if you disregard whitespace `?w=1`)
    
    ## To verify
    1. Tasks run normally (create a rule or something that goes through task
    manager regularly).
    2. When the update by query takes a while, the request is cancelled
    after 30s or the time manually configured.
    4. When the search for claimed tasks query takes a while, the request is
    cancelled after 30s or the time manually configured.
    
    **Tips:**
    <details><summary>how to slowdown search for claimed task
    queries</summary>
    
    ```
    diff --git a/x-pack/plugins/task_manager/server/queries/task_claiming.ts b/x-pack/plugins/task_manager/server/queries/task_claiming.ts
    index 07042650a37..2caefd63672 100644
    --- a/x-pack/plugins/task_manager/server/queries/task_claiming.ts
    +++ b/x-pack/plugins/task_manager/server/queries/task_claiming.ts
    @@ -247,7 +247,7 @@ export class TaskClaiming {
             taskTypes,
           });
    
    -    const docs = tasksUpdated > 0 ? await this.sweepForClaimedTasks(taskTypes, size) : [];
    +    const docs = await this.sweepForClaimedTasks(taskTypes, size);
    
         this.emitEvents(docs.map((doc) => asTaskClaimEvent(doc.id, asOk(doc))));
    
    @@ -346,6 +346,13 @@ export class TaskClaiming {
           size,
           sort: SortByRunAtAndRetryAt,
           seq_no_primary_term: true,
    +      aggs: {
    +        delay: {
    +          shard_delay: {
    +            value: '40s',
    +          },
    +        },
    +      },
         });
    
         return docs;
    ```
    </details>
    
    <details><summary>how to slow down update by queries</summary>
    Not the cleanest way but you'll see occasional request timeouts from the
    updateByQuery calls. I had more luck creating rules running every 1s.
    
    ```
    diff --git a/x-pack/plugins/task_manager/server/task_store.ts b/x-pack/plugins/task_manager/server/task_store.ts
    index a06ee7b918a..07aa81e5388 100644
    --- a/x-pack/plugins/task_manager/server/task_store.ts
    +++ b/x-pack/plugins/task_manager/server/task_store.ts
    @@ -126,6 +126,7 @@ export class TaskStore {
           // Timeouts are retried and make requests timeout after (requestTimeout * (1 + maxRetries))
           // The poller doesn't need retry logic because it will try again at the next polling cycle
           maxRetries: 0,
    +      requestTimeout: 900,
         });
       }
    
    @@ -458,6 +459,7 @@ export class TaskStore {
               ignore_unavailable: true,
               refresh: true,
               conflicts: 'proceed',
    +          requests_per_second: 1,
               body: {
                 ...opts,
                 max_docs,
    ```
    </details>
    
    ---------
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    mikecote and kibanamachine committed May 3, 2023
    Configuration menu
    Copy the full SHA
    cb2e28d View commit details
    Browse the repository at this point in the history
  22. [Synthetics] adjust monitor status rule location logic (elastic#156432)

    ## Summary
    
    Resolves elastic#156223
    
    In previous stack versions, the label was not saved to the saved object.
    
    This ensures that alerting works both for those early versions as well
    current versions, by adjusting the logic to consider both the
    location.label and location.id in alerting logic.
    
    ### Testing
    
    1. Create a new oblt-cli cluster and connect to the synthetics service,
    locally or via the dev environment
    2. Checkout v8.5.3
    3. Create a monitor. Make sure it's down and wait for the first down
    check
    4. Check out this branch
    5. Navigate to Observabillity alerts. Ensure that an alert is generated
    for the monitor. You may have to wait a few minutes.
    
    ---------
    
    Co-authored-by: Shahzad <shahzad31comp@gmail.com>
    dominiqueclarke and shahzad31 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    77cebee View commit details
    Browse the repository at this point in the history
  23. [Enterprise Search] Fix custom connector not selectable (elastic#156523)

    ## Summary
    
    Custom connector has empty string "" as service type and it is nullish
    in JS/TS. Selection is fixed and Continue button is now selectable for
    custom connectors by checking value to be null instead.
    
    Before:
    
    
    https://user-images.githubusercontent.com/1410658/235914298-c8230681-3520-4e08-b364-e65237661aec.mov
    
    
    After:
    
    
    https://user-images.githubusercontent.com/1410658/235914179-3f655131-b5bf-454e-b3ab-384863a21607.mov
    efegurkan committed May 3, 2023
    Configuration menu
    Copy the full SHA
    605e9ca View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    b6ea07a View commit details
    Browse the repository at this point in the history
  25. [Guided onboarding] Fix the missing help link (elastic#156399)

    ## Summary
    
    This PR fixes a bug introduced in
    elastic#155065 that I noticed when
    testing guided onboarding for v8.9.0: the help link was missing from the
    help menu. I added a functional test for the help link but we also need
    a test that the link is hidden when the user doesn't have access to
    guided onboarding (opened an issue for that
    [here](elastic#156410)).
    
    ### How to test
    1. Add xpack.cloud.id: 'testID' to /config/kibana.dev.yml
    2. Start ES with yarn es snapshot and Kibana with `yarn start``
    3. Check that the help link "Setup guides" is displayed in the help menu
    
    ### Screenshot 
    <img width="336" alt="Screenshot 2023-05-02 at 17 27 20"
    src="https://user-images.githubusercontent.com/6585477/235712599-812b422d-3092-45b3-a726-37f6b90e81c1.png">
    yuliacech committed May 3, 2023
    Configuration menu
    Copy the full SHA
    d00e2a3 View commit details
    Browse the repository at this point in the history
  26. [Tech Debt] Remove deprecated EuiLoadingContent (elastic#156316)

    ## Summary
    
    This PR removes the deprecated `EuiLoadingContent` in favour of the new
    `EuiSkeletonText` + `EuiSkeletonRectangle` components in all
    Presentation-owned files.
    
    cc @elastic/eui-team 
    
    
    ### Checklist
    
    - [x] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [x] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    Heenawter committed May 3, 2023
    Configuration menu
    Copy the full SHA
    9163599 View commit details
    Browse the repository at this point in the history
  27. [Enterprise Search] Simplify doc links on configuration page. (elasti…

    …c#156530)
    
    ## Summary
    
    Simplified the list of documents on Index configuration page
    
    ![Screenshot 2023-05-03 at 14 44
    04](https://user-images.githubusercontent.com/1410658/235919505-508eeceb-d35f-49c1-a40e-3efae71324f5.png)
    efegurkan committed May 3, 2023
    Configuration menu
    Copy the full SHA
    cb0d0b9 View commit details
    Browse the repository at this point in the history
  28. [Security Solution][Fix] Set doc count to 0 when empty aggregated data (

    elastic#156497)
    
    ## Summary
    
    bug: elastic#155228
    
    Despite the hit count may be greater than 0 in the aggregation response,
    it is possible it won't contain any data, this happens when the
    aggregated field is empty in all documents, such as the
    `kibana.alert.rule.name` field.
    
    In this situation, we should display `0 events` in the visualization
    subtitle.
    
    
    ![screenshot](https://user-images.githubusercontent.com/17747913/235885604-4caf99e8-6826-45a1-967e-32168a88adab.png)
    semd committed May 3, 2023
    Configuration menu
    Copy the full SHA
    93e75de View commit details
    Browse the repository at this point in the history
  29. [Lens] Fix field formatters functional tests (elastic#156190)

    ## Summary
    
    Fixes elastic#155884 , elastic#156463, elastic#156463
    
    This PR make sure the field editor panel is closed after save before
    proceeding with other steps.
    The main problem here was that the tests were not failing if the
    execution was too fast and the panel was still open on test end, so the
    cleanup process will fail as would expect the panel to be closed, and
    cannot find the right elements to click.
    
    
    Flaky runner 50 (✅ ):
    https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2213
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [ ] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [ ] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [ ] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [ ] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [ ] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    
    ### Risk Matrix
    
    Delete this section if it is not applicable to this PR.
    
    Before closing this PR, invite QA, stakeholders, and other developers to
    identify risks that should be tested prior to the change/feature
    release.
    
    When forming the risk matrix, consider some of the following examples
    and how they may potentially impact the change:
    
    | Risk | Probability | Severity | Mitigation/Notes |
    
    |---------------------------|-------------|----------|-------------------------|
    | Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
    | Low | High | Integration tests will verify that all features are still
    supported in non-default Kibana Space and when user switches between
    spaces. |
    | Multiple nodes&mdash;Elasticsearch polling might have race conditions
    when multiple Kibana nodes are polling for the same tasks. | High | Low
    | Tasks are idempotent, so executing them multiple times will not result
    in logical error, but will degrade performance. To test for this case we
    add plenty of unit tests around this logic and document manual testing
    procedure. |
    | Code should gracefully handle cases when feature X or plugin Y are
    disabled. | Medium | High | Unit tests will verify that any feature flag
    or plugin combination still results in our service operational. |
    | [See more potential risk
    examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    dej611 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    91c1ff1 View commit details
    Browse the repository at this point in the history
  30. [functional tests] split fleet_api_integration config into smaller on…

    …es (elastic#156407)
    
    ## Summary
    
    Runtime for `fleet_api_integration/config` crossed the 38 min limit.
    Ideally config runtime should be <10 min so that pipeline can quickly
    retry failed configs (we do 1 retry on CI)
    
    <img width="1600" alt="image"
    src="https://user-images.githubusercontent.com/10977896/235707744-3120e1e9-4882-493f-9ee0-86016a765401.png">
    
    
    This PR splits the existing config into few smaller ones:
    
    ```
    x-pack/test/fleet_api_integration/config.agent.ts 15m 15s
    x-pack/test/fleet_api_integration/config.agent_policy.ts 4m 10s
    x-pack/test/fleet_api_integration/config.epm.ts 8m 12s
    x-pack/test/fleet_api_integration/config.package_policy.ts 10m 54s
    // combines multiple test files
    x-pack/test/fleet_api_integration/config.fleet.ts 5m 2s
    ```
    dmlemeshko committed May 3, 2023
    Configuration menu
    Copy the full SHA
    1c777a2 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    b7bd376 View commit details
    Browse the repository at this point in the history
  32. [Enterprise Search] Fix incorrect gating of Enterprise Seach (elastic…

    …#156537)
    
    ## Summary
    
    This fixes an issue where we were incorrectly telling the user they
    didn't have access to Enterprise Search, because we weren't passing the
    correct product access settings to the Overview component.
    sphilipse committed May 3, 2023
    Configuration menu
    Copy the full SHA
    e243c32 View commit details
    Browse the repository at this point in the history
  33. [Enterprise Search] Promote Postgresql and MSSQL connectors to native (

    …elastic#156277)
    
    ## Summary
    
    This adds PostgreSQL and MSSQL as native connectors.
    sphilipse committed May 3, 2023
    Configuration menu
    Copy the full SHA
    875f3f3 View commit details
    Browse the repository at this point in the history
  34. [Security Solution] [Fix] Alert Page Controls do not recover from inv…

    …alid query. (elastic#156542)
    
    ## Summary
    
    This PR handles elastic#156016 .
    
    Previously, if user supplied an invalid kql or lucene query, Alert Page
    controls will go in error state and not recover until user reloaded the
    page or navigated away and back to the Alert Page.
    
    This PR prevents Alert Page Controls going in that error state.
    
    | Before | After |
    |--|--|
    | <video
    src="https://user-images.githubusercontent.com/7485038/235931286-6da23567-4ae8-454a-92b8-a595a20f5655.mov"
    /> | <video
    src="https://user-images.githubusercontent.com/7485038/235930584-485df881-d22c-44f3-9d53-f673820eb673.mov"
    /> |
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    logeekal committed May 3, 2023
    Configuration menu
    Copy the full SHA
    ff65ca4 View commit details
    Browse the repository at this point in the history
  35. [SecuritySolution] Fix minimize amd maximize panel actions (elastic#1…

    …56518)
    
    ## Summary
    
    Issues: elastic#155857 |
    elastic#156253
    
    This PR fixed minimize amd maximize panel actions in Security Dashboard
    view.
    
    
    https://user-images.githubusercontent.com/6295984/235910244-1cca8dda-cd4c-40b7-977a-69fa00021f81.mov
    
    
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
    angorayc and machadoum committed May 3, 2023
    Configuration menu
    Copy the full SHA
    c278f4e View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    7f192bb View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    4171c9b View commit details
    Browse the repository at this point in the history
  38. [RAM][Maintenance Window][8.8] Remove Extra Commas and Disable Fetch …

    …If No License (elastic#156296)
    
    ## Summary
    
    Remove some extra commas for the maintenance window no license prompt 
    
    
    ![image](https://user-images.githubusercontent.com/74562234/235515841-1ea1da44-db5c-42c0-9e34-97ad017be474.png)
    
    Also, disable fetch if the user does not have the correct license type,
    this gets rid of the unnecessary error popover since the find
    maintenance window API will reject these requests.
    
    ### Checklist
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    JiaweiWu committed May 3, 2023
    Configuration menu
    Copy the full SHA
    f7881f6 View commit details
    Browse the repository at this point in the history
  39. [Enterprise Search] Add beta badge to sync rules (elastic#156555)

    ## Summary
    
    This adds a beta badge and callout to the sync rules page for connec
    <img width="1009" alt="Screenshot 2023-05-03 at 16 08 58"
    src="https://user-images.githubusercontent.com/94373878/235943197-fecf2e11-daab-4c6a-a99e-cbf8b865f461.png">
    tors.
    <img width="1193" alt="Screenshot 2023-05-03 at 16 15 02"
    src="https://user-images.githubusercontent.com/94373878/235943190-e6d86a36-3e08-415c-8a29-bc886e1a9951.png">
    sphilipse committed May 3, 2023
    Configuration menu
    Copy the full SHA
    30836a8 View commit details
    Browse the repository at this point in the history
  40. [Enterprise Search] Switch to production ELSER model (elastic#156565)

    ## Summary
    
    This PR switches the ELSER model to the production one `.elser_model_1`.
    
    This has been manually tested with the Elasticsearch [8.8.0-SNAPSHOT
    Docker image from May
    2](https://artifacts-snapshot.elastic.co/elasticsearch/8.8.0-6ba23699/summary-8.8.0-SNAPSHOT.html).
    
    
    ![ELSER_prod_model](https://user-images.githubusercontent.com/14224983/235962097-9b7c15b5-2249-4900-b358-9f2906e3d10e.gif)
    demjened committed May 3, 2023
    Configuration menu
    Copy the full SHA
    8f0103c View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    4301d80 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    a3fad62 View commit details
    Browse the repository at this point in the history
  43. [Cases] Renaming comment type (elastic#156086)

    This PR:
    
    - Renames `CommentResponseRt` to `CommentRt`
    - Create `CommentUI` for the UI based on the snake to camel case version
    of `Comment`
    - Introduces a `AttachmentTransformedAttributes` type that should be
    used when returning `CommentAttributes` from the service layer
    jonathan-buttner committed May 3, 2023
    Configuration menu
    Copy the full SHA
    b80b4c2 View commit details
    Browse the repository at this point in the history
  44. adjusts timeout, only report 1 issue (elastic#156287)

    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    TinaHeiligers and kibanamachine committed May 3, 2023
    Configuration menu
    Copy the full SHA
    264b0f6 View commit details
    Browse the repository at this point in the history
  45. [SecuritySolution] Update timeline actions (elastic#155692)

    ## Summary
    
    issue: elastic#155034 |
    elastic#155586
    
    Please find expected behaviours here:
    elastic#155034 (comment)
    angorayc committed May 3, 2023
    Configuration menu
    Copy the full SHA
    5be0f40 View commit details
    Browse the repository at this point in the history
  46. [ML] Data Frame Analytics creation wizard: ensure preview datagrid di…

    …splays expected fields (elastic#156435)
    
    ## Summary
    
    Fixes elastic#154009
    
    This PR ensures the column field check for the data grid preview in DFA
    uses the Data view fields.
    
    BEFORE:
    
    <img width="1214" alt="image"
    src="https://user-images.githubusercontent.com/6446462/228678497-ffe65bf9-1b4c-4f56-bb3d-fe69ac941e62.png">
    
    AFTER: 
    
    <img width="1178" alt="image"
    src="https://user-images.githubusercontent.com/6446462/235797816-34425648-a470-4631-b6c2-ba453f62752d.png">
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [ ] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [ ] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [ ] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [ ] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [ ] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    alvarezmelissa87 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    22f01bf View commit details
    Browse the repository at this point in the history
  47. [ML] Add functional testing for continuous transforms (creation, star…

    …t, stop, reset) (elastic#156128)
    
    ## Summary
    
    Part of elastic#152009. This PR adds
    functional test for continuous transforms related actions including
    creation, start, stop, and reset. It also stablizes tests skipped in
    elastic#151889.
    
    Started [flaky test suite runner for continuous
    transform](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2185)...
    
    Started [flaky test suite runner for creation index pattern (previously
    skipped)](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2187)...
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [ ] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [ ] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [ ] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [ ] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    
    ### Risk Matrix
    
    Delete this section if it is not applicable to this PR.
    
    Before closing this PR, invite QA, stakeholders, and other developers to
    identify risks that should be tested prior to the change/feature
    release.
    
    When forming the risk matrix, consider some of the following examples
    and how they may potentially impact the change:
    
    | Risk | Probability | Severity | Mitigation/Notes |
    
    |---------------------------|-------------|----------|-------------------------|
    | Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
    | Low | High | Integration tests will verify that all features are still
    supported in non-default Kibana Space and when user switches between
    spaces. |
    | Multiple nodes&mdash;Elasticsearch polling might have race conditions
    when multiple Kibana nodes are polling for the same tasks. | High | Low
    | Tasks are idempotent, so executing them multiple times will not result
    in logical error, but will degrade performance. To test for this case we
    add plenty of unit tests around this logic and document manual testing
    procedure. |
    | Code should gracefully handle cases when feature X or plugin Y are
    disabled. | Medium | High | Unit tests will verify that any feature flag
    or plugin combination still results in our service operational. |
    | [See more potential risk
    examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    
    ---------
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    qn895 and kibanamachine committed May 3, 2023
    Configuration menu
    Copy the full SHA
    f615466 View commit details
    Browse the repository at this point in the history
  48. [Canvas] Update function reference docs (elastic#156409)

    ## Summary
    
    Closes elastic#141526.
    
    This updates the function reference docs for Canvas expressions. The
    main update here is the deprecation message added to `filters` function.
    I'm also removing an expression example that doesn't work.
    
    <img width="866" alt="Screenshot 2023-05-02 at 9 26 54 AM"
    src="https://user-images.githubusercontent.com/1697105/235727031-8ece820e-3db5-42c7-ba11-e94d647a8b84.png">
    
    
    @KOTungseth These changes impact as early as v8.4. Should I backport all
    the way back through 8.4?
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [ ] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [ ] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [ ] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [ ] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [ ] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    
    ### Risk Matrix
    
    Delete this section if it is not applicable to this PR.
    
    Before closing this PR, invite QA, stakeholders, and other developers to
    identify risks that should be tested prior to the change/feature
    release.
    
    When forming the risk matrix, consider some of the following examples
    and how they may potentially impact the change:
    
    | Risk | Probability | Severity | Mitigation/Notes |
    
    |---------------------------|-------------|----------|-------------------------|
    | Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
    | Low | High | Integration tests will verify that all features are still
    supported in non-default Kibana Space and when user switches between
    spaces. |
    | Multiple nodes&mdash;Elasticsearch polling might have race conditions
    when multiple Kibana nodes are polling for the same tasks. | High | Low
    | Tasks are idempotent, so executing them multiple times will not result
    in logical error, but will degrade performance. To test for this case we
    add plenty of unit tests around this logic and document manual testing
    procedure. |
    | Code should gracefully handle cases when feature X or plugin Y are
    disabled. | Medium | High | Unit tests will verify that any feature flag
    or plugin combination still results in our service operational. |
    | [See more potential risk
    examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    
    ---------
    
    Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
    cqliu1 and KOTungseth committed May 3, 2023
    Configuration menu
    Copy the full SHA
    b5e8ab7 View commit details
    Browse the repository at this point in the history
  49. [Enterprise Search] Make EntSearch app inputs explicit (elastic#156562)

    ## Summary
    
    This moves the Enterprise Search inputs for the bootstrap `<App>` to be
    explicit, rather than implicitly derived from what is and isn't excluded
    from a destructured object. Hopefully this will avoid us accidentally
    breaking the app because we changed the destructure or removed a
    variable somewhere.
    sphilipse committed May 3, 2023
    Configuration menu
    Copy the full SHA
    bceeec0 View commit details
    Browse the repository at this point in the history
  50. [APM] Fix comparison option showing in individual transaction page (e…

    …lastic#155915)
    
    ## Summary
    
    This PR fixes `Expected bounds` showing as a comparison option in the
    individual transaction page. Currently, it will show the bounds of the
    overall job, and not of the individual transaction, which is incorrect.
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [ ] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [ ] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [ ] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [ ] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [ ] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    
    ### Risk Matrix
    
    Delete this section if it is not applicable to this PR.
    
    Before closing this PR, invite QA, stakeholders, and other developers to
    identify risks that should be tested prior to the change/feature
    release.
    
    When forming the risk matrix, consider some of the following examples
    and how they may potentially impact the change:
    
    | Risk | Probability | Severity | Mitigation/Notes |
    
    |---------------------------|-------------|----------|-------------------------|
    | Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
    | Low | High | Integration tests will verify that all features are still
    supported in non-default Kibana Space and when user switches between
    spaces. |
    | Multiple nodes&mdash;Elasticsearch polling might have race conditions
    when multiple Kibana nodes are polling for the same tasks. | High | Low
    | Tasks are idempotent, so executing them multiple times will not result
    in logical error, but will degrade performance. To test for this case we
    add plenty of unit tests around this logic and document manual testing
    procedure. |
    | Code should gracefully handle cases when feature X or plugin Y are
    disabled. | Medium | High | Unit tests will verify that any feature flag
    or plugin combination still results in our service operational. |
    | [See more potential risk
    examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
    
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    
    ---------
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    qn895 and kibanamachine committed May 3, 2023
    Configuration menu
    Copy the full SHA
    5778f31 View commit details
    Browse the repository at this point in the history
  51. Don't trigger summary actions when there are no alerts to report (ela…

    …stic#156421)
    
    Resolves: elastic#155708
    
    Currently we always trigger summary actions on custom interval even if
    there are no alerts to report.
    This PR changes this behaviour to skip summary actions when there are no
    alerts.
    
    ## To verify
    Create a Security Rule with a summary action that is on custom interval
    (`Summary of alerts` -> `Custom Frequency`)
    Add an alerts filter to filter out all the alerts (e.g. by using host
    name that doesn't exist)
    Expect the summary action not to be triggered.
    ersin-erdal committed May 3, 2023
    Configuration menu
    Copy the full SHA
    506806f View commit details
    Browse the repository at this point in the history
  52. [Enterprise Search] Search Apps. - fetch indices one-by-one (elastic#…

    …156571)
    
    ## Summary
    
    fetches a search application's indices' stats one at a time.
    
    if even one index is not available the stats api returns an error[^1].
    while fetching them all together is probably more efficient we have to
    get them one-by-one just in case one isn't available.
    
    ### Checklist
    
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    [^1]: <details><summary>stats errors response</summary>
        <pre>
        {
          "error": {
            "root_cause": [
              {
                "type": "index_not_found_exception",
                "reason": "no such index [sloane-books-001]",
                "resource.type": "index_or_alias",
                "resource.id": "sloane-books-001",
                "index_uuid": "_na_",
                "index": "sloane-books-001"
              }
            ],
            "type": "index_not_found_exception",
            "reason": "no such index [sloane-books-001]",
            "resource.type": "index_or_alias",
            "resource.id": "sloane-books-001",
            "index_uuid": "_na_",
            "index": "sloane-books-001"
          },
          "status": 404
        }
        </pre>
    </details>
    Sloane Perrault committed May 3, 2023
    Configuration menu
    Copy the full SHA
    23a45bd View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Configuration menu
    Copy the full SHA
    0ace8ba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f5c12dc View commit details
    Browse the repository at this point in the history
  3. [Security Solution] Maintenance Window callout: Update tests to match…

    … the test plan (elastic#156532)
    
    ## Summary
    
    This PR updates Maintenance Window callout tests to match the test plan.
    
    Maintenance Window callout is shown on the Rules Management page when
    there's a Maintenance Window running.
    
    <img width="1260" alt="233624339-9c9b6e3e-9e5e-424d-9d19-9cd7d4e92259"
    src="https://user-images.githubusercontent.com/15949146/235923634-53113720-d58a-4a15-b66b-b2008f80f035.png">
    
    [**Test plan**
    (internal)](https://docs.google.com/document/d/1NTTbV7FemZR8LVwWBbDW3Jji58Wy2-n-YGycD698RR8/edit?usp=sharing
    )
    
    [**Maintenance Window Callout
    issue**](elastic#155099) with more info
    about the feature
    nikitaindik committed May 4, 2023
    Configuration menu
    Copy the full SHA
    508ab65 View commit details
    Browse the repository at this point in the history
  4. Fix Alerts table inspect modal incomplete title (elastic#156488)

    issue: elastic#156267
    
    ## Summary
    
    Add a title to "Alerts Table inspect modal".
    
    **BEFORE**
    
    <img width="751" alt="Screenshot 2023-05-03 at 15 55 58"
    src="https://user-images.githubusercontent.com/1490444/235937998-caedf8f5-6645-440f-af1d-8618e8012d8b.png">
    
    **AFTER**
    
    <img width="769" alt="Screenshot 2023-05-03 at 15 58 30"
    src="https://user-images.githubusercontent.com/1490444/235938006-6c303f9d-8b81-43d0-b536-ae23f1f5bfd1.png">
    machadoum committed May 4, 2023
    Configuration menu
    Copy the full SHA
    c1d76f8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0974e59 View commit details
    Browse the repository at this point in the history
  6. [Security Solution] Fix a broken header on small screens (elastic#156525

    )
    
    **Resolves:** elastic#155596
    
    ## Summary
    
    It fixes a broken header on small screen after adding rule snooze badge component.  
    
    *Before:*
    
    ![image](https://user-images.githubusercontent.com/3775283/235914975-d30c75c4-f4fe-4887-86d1-417787e16521.png)
    ![image](https://user-images.githubusercontent.com/3775283/235915062-b079fac0-0fef-447a-b2e5-d571f6862441.png)
    ![image](https://user-images.githubusercontent.com/3775283/235915165-d34cb157-ecf1-4074-9a08-48c4dfa3605d.png)
    
    *After:*
    
    ![image](https://user-images.githubusercontent.com/3775283/235915333-ca658f3a-8dfe-47d4-90ec-8bc629566d5c.png)
    ![image](https://user-images.githubusercontent.com/3775283/235915401-31a7ff25-933e-4c8e-938d-323433e85d66.png)
    ![image](https://user-images.githubusercontent.com/3775283/235915479-fc56dd64-e113-4535-b268-f3dacdd6f4a4.png)
    
    
    ### Checklist
    
    - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
    - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    maximpn committed May 4, 2023
    Configuration menu
    Copy the full SHA
    0a9bbe7 View commit details
    Browse the repository at this point in the history
  7. [Discover] Switch from "at" to "charAt" for better browser support (e…

    …lastic#156474)
    
    From the community forum: users can't access Discover on older browsers.
    
    ```
    TypeError: t.at is not a function
    at http://xxx:5601/61109/bundles/plugin/data/kibana/data.plugin.js:1:312992
    at Array.forEach ()
    at n (http://xxx:5601/61109/bundles/plugin/data/kibana/data.plugin.js:1:312956)
    at s (http://xxx:5601/61109/bundles/plugin/discover/kibana/discover.chunk.0.js:1:10138)
    at http://xxx:5601/61109/bundles/plugin/discover/kibana/discover.chunk.0.js:1:10215
    at Array.map ()
    at a (http://xxx:5601/61109/bundles/plugin/discover/kibana/discover.chunk.0.js:1:10207)
    at http://xxx:5601/61109/bundles/plugin/discover/kibana/discover.chunk.0.js:1:8442
    at http://xxx:5601/61109/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:334:27724
    at t.s._next (http://xxx:5601/61109/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:6:33456)
    ```
    
    - https://discuss.elastic.co/t/update-to-8-7-0/329525
    -
    https://discuss.elastic.co/t/elastic-8-7-0-error-in-discover-tab/332329/2
    
    ## Summary
    
    This PR replaces `String` `.at` usage with `.charAt` so it does not
    require a polyfill for older browsers.
    jughosta committed May 4, 2023
    Configuration menu
    Copy the full SHA
    396a2b6 View commit details
    Browse the repository at this point in the history
  8. [TSVB] Remove flakiness on resetPage (elastic#156484)

    ## Summary
    
    Closes elastic#156457
    Closes elastic#156452
    Closes elastic#156439
    Closes elastic#156400
    Closes elastic#156599
    Closes elastic#156502
    Closes elastic#156501
    
    the resetPage function is creating this flakiness. I cant figure out why
    but is on the navigateToUrl function. Sometimes it reports #create and
    sometimes without the hash. The navigateToUrl is not needed as it is
    already done on another function. The only thing that is needed is the
    setTimePicker function.
    
    Flaky runer (100 times)
    https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2210
    stratoula committed May 4, 2023
    Configuration menu
    Copy the full SHA
    e5f6f96 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    fffe57d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5a65112 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4c5663f View commit details
    Browse the repository at this point in the history
  12. Addressing PR comments

    yngrdyn committed May 4, 2023
    Configuration menu
    Copy the full SHA
    2826d0f View commit details
    Browse the repository at this point in the history